From 200e5f3373925ae6578ec44e6cf5e9ba8000e7ee Mon Sep 17 00:00:00 2001 From: Rodrigo Damazio Date: Fri, 3 Jun 2011 11:19:24 -0300 Subject: [PATCH] Addressing review suggestion. --- .../apps/mytracks/ExportAllTracks.java | 24 +++++++++---------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/MyTracks/src/com/google/android/apps/mytracks/ExportAllTracks.java b/MyTracks/src/com/google/android/apps/mytracks/ExportAllTracks.java index b40caf3a6..de33fb381 100644 --- a/MyTracks/src/com/google/android/apps/mytracks/ExportAllTracks.java +++ b/MyTracks/src/com/google/android/apps/mytracks/ExportAllTracks.java @@ -133,12 +133,7 @@ public class ExportAllTracks { Log.i(Constants.TAG, "ExportAllTracks: Releasing wake lock."); } Log.i(Constants.TAG, "ExportAllTracks: Done"); - activity.runOnUiThread(new Runnable() { - @Override - public void run() { - Toast.makeText(activity, R.string.export_done, Toast.LENGTH_SHORT).show(); - } - }); + showToast(R.string.export_done, Toast.LENGTH_SHORT); } private void makeProgressDialog(final int trackCount) { @@ -198,13 +193,7 @@ public class ExportAllTracks { if (!writer.wasSuccess()) { // Abort the whole export on the first error. - final int error = writer.getErrorMessage(); - activity.runOnUiThread(new Runnable() { - @Override - public void run() { - Toast.makeText(activity, error, Toast.LENGTH_LONG).show(); - } - }); + showToast(writer.getErrorMessage(), Toast.LENGTH_LONG); return; } } @@ -220,4 +209,13 @@ public class ExportAllTracks { } } } + + private void showToast(final int messageId, final int length) { + activity.runOnUiThread(new Runnable() { + @Override + public void run() { + Toast.makeText(activity, messageId, length).show(); + } + }); + } }