From 3384ef67a6d672a1221a6c26beb24184d815026c Mon Sep 17 00:00:00 2001
From: Sandor Dornbush <Sandor Dornbush@localhost>
Date: Tue, 28 Dec 2010 14:39:26 -0800
Subject: [PATCH] Addressed comments.

---
 MyTracks/res/values/colors.xml                |  7 ++++--
 .../apps/mytracks/ChartValueSeries.java       | 23 -------------------
 .../android/apps/mytracks/ChartView.java      |  4 ++--
 .../apps/mytracks/ChartValueSeriesTest.java   | 11 +++------
 4 files changed, 10 insertions(+), 35 deletions(-)

diff --git a/MyTracks/res/values/colors.xml b/MyTracks/res/values/colors.xml
index 51f287256..1801e61b8 100644
--- a/MyTracks/res/values/colors.xml
+++ b/MyTracks/res/values/colors.xml
@@ -21,7 +21,6 @@ limitations under the License.
   <color name="darkgray">#FF444444</color>
   <color name="gold">#FFffd700</color>
   <color name="gray">#FFAAAAAA</color>
-  <color name="green">#FF00AA00</color>
   <color name="lightblue">#FF00FFFF</color>
   <color name="opaque_shadow">#70000000</color>
   <color name="red">#FFFF0000</color>
@@ -30,6 +29,10 @@ limitations under the License.
   <color name="white">#FFFFFFFF</color>
 
   <!-- Chart colors by series. -->
+  <!-- Green and a transparent green -->
+  <color name="elevation_border">#FF00AA00</color>
+  <color name="elevation_fill">#8000AA00</color>
+
   <!-- Purple and a transparent purple -->
   <color name="heartrate_border">#FF401465</color>
   <color name="heartrate_fill">#40401465</color>
@@ -38,7 +41,7 @@ limitations under the License.
   <color name="cadence_border">#FFF128F3</color>
   <color name="cadence_fill">#40F128F3</color>
 
-  <!-- red and a transparent red -->
+  <!-- Red and a transparent red -->
   <color name="power_border">#FFFF0000</color>
   <color name="power_fill">#40FF0000</color>
 </resources>
diff --git a/MyTracks/src/com/google/android/apps/mytracks/ChartValueSeries.java b/MyTracks/src/com/google/android/apps/mytracks/ChartValueSeries.java
index 36bcdd4e0..31a196bee 100644
--- a/MyTracks/src/com/google/android/apps/mytracks/ChartValueSeries.java
+++ b/MyTracks/src/com/google/android/apps/mytracks/ChartValueSeries.java
@@ -85,29 +85,6 @@ public class ChartValueSeries {
     this.title = context.getString(titleId);
   }
 
-  /**
-   * Constructs a new chart value series.
-   *
-   * @param context The context for the chart
-   * @param formatString The format of the decimal format for this series
-   * @param fill The paint for filling the chart
-   * @param stroke The paint for stroking the outside the chart, optional
-   * @param rounding The factor to round the values by
-   */
-  public ChartValueSeries(Context context,
-                          String formatString,
-                          Paint fill,
-                          Paint stroke,
-                          int rounding,
-                          int titleId) {
-    this.format = new DecimalFormat(formatString);
-    this.fillPaint = fill;
-    this.labelPaint = fill;
-    this.strokePaint = stroke;
-    this.rounding = rounding;
-    this.title = context.getString(titleId);
-  }
-
   /**
    * Draws the path of the chart
    */
diff --git a/MyTracks/src/com/google/android/apps/mytracks/ChartView.java b/MyTracks/src/com/google/android/apps/mytracks/ChartView.java
index 24888536a..f72a521fd 100644
--- a/MyTracks/src/com/google/android/apps/mytracks/ChartView.java
+++ b/MyTracks/src/com/google/android/apps/mytracks/ChartView.java
@@ -197,8 +197,8 @@ public class ChartView extends View {
     series[ELEVATION_SERIES] =
         new ChartValueSeries(context,
                              "###,###",
-                             R.color.green,
-                             -1,
+                             R.color.elevation_fill,
+                             R.color.elevation_border,
                              100,
                              R.string.elevation);
 
diff --git a/MyTracksTest/src/com/google/android/apps/mytracks/ChartValueSeriesTest.java b/MyTracksTest/src/com/google/android/apps/mytracks/ChartValueSeriesTest.java
index afefd4910..775fd7971 100644
--- a/MyTracksTest/src/com/google/android/apps/mytracks/ChartValueSeriesTest.java
+++ b/MyTracksTest/src/com/google/android/apps/mytracks/ChartValueSeriesTest.java
@@ -26,18 +26,13 @@ import android.test.AndroidTestCase;
  */
 public class ChartValueSeriesTest extends AndroidTestCase {
   private ChartValueSeries series;
-  private Paint fillPaint1;
  
   @Override
   protected void setUp() throws Exception {
-    fillPaint1 = new Paint();
-    fillPaint1.setStyle(Style.FILL);
-    fillPaint1.setColor(getContext().getResources().getColor(R.color.green));
-    fillPaint1.setAntiAlias(true);
     series = new ChartValueSeries(getContext(),
         "###,###",
-        fillPaint1,
-        null,
+        R.color.elevation_fill,
+        R.color.elevation_border,
         100,
         R.string.elevation);
   }
@@ -48,7 +43,7 @@ public class ChartValueSeriesTest extends AndroidTestCase {
     assertEquals(0, series.getMin());
     assertEquals(0, series.getMax());
     assertEquals(0.0, series.getSpread());
-    assertEquals(fillPaint1, series.getPaint());
+    assertEquals(Style.STROKE, series.getPaint().getStyle());
     assertEquals(getContext().getString(R.string.elevation),
         series.getTitle());
     assertTrue(series.isEnabled());