From 401e07d7e789fefef53baf883cf19bb8e80dc76b Mon Sep 17 00:00:00 2001
From: Dennis Guse <dennis.guse@alumni.tu-berlin.de>
Date: Fri, 9 Jul 2021 23:17:18 +0200
Subject: [PATCH] Cleanup.

---
 .../de/dennisguse/opentracks/adapters/SensorsAdapter.java | 8 ++++----
 .../de/dennisguse/opentracks/content/TrackDataHub.java    | 7 -------
 .../java/de/dennisguse/opentracks/content/data/Speed.java | 4 ----
 .../opentracks/content/provider/ShareContentProvider.java | 4 ----
 .../opentracks/services/sensors/AltitudeSumManager.java   | 4 ----
 .../opentracks/stats/TrackStatisticsUpdater.java          | 1 -
 .../de/dennisguse/opentracks/util/UnitConversions.java    | 2 --
 7 files changed, 4 insertions(+), 26 deletions(-)

diff --git a/src/main/java/de/dennisguse/opentracks/adapters/SensorsAdapter.java b/src/main/java/de/dennisguse/opentracks/adapters/SensorsAdapter.java
index d5b5a439f..07e4f6aff 100644
--- a/src/main/java/de/dennisguse/opentracks/adapters/SensorsAdapter.java
+++ b/src/main/java/de/dennisguse/opentracks/adapters/SensorsAdapter.java
@@ -61,10 +61,10 @@ public class SensorsAdapter extends RecyclerView.Adapter<RecyclerView.ViewHolder
     }
 
     private class ViewHolder extends RecyclerView.ViewHolder {
-        final TextView label;
-        final TextView sensorValue;
-        final TextView value;
-        final TextView unit;
+        private final TextView label;
+        private final TextView sensorValue;
+        private final TextView value;
+        private final TextView unit;
 
         public ViewHolder(@NonNull View itemView) {
             super(itemView);
diff --git a/src/main/java/de/dennisguse/opentracks/content/TrackDataHub.java b/src/main/java/de/dennisguse/opentracks/content/TrackDataHub.java
index 8f4578e64..08e27f437 100644
--- a/src/main/java/de/dennisguse/opentracks/content/TrackDataHub.java
+++ b/src/main/java/de/dennisguse/opentracks/content/TrackDataHub.java
@@ -209,13 +209,6 @@ public class TrackDataHub {
         return selectedTrackId != null && selectedTrackId.equals(recordingStatus.getTrackId());
     }
 
-    /**
-     * Returns true if the selected track is paused.
-     */
-    public boolean isSelectedTrackPaused() {
-        return selectedTrackId != null && selectedTrackId.equals(recordingStatus.getTrackId()) && recordingStatus.isPaused();
-    }
-
     /**
      * Loads data for all listeners. To be run in the {@link #handler} thread.
      */
diff --git a/src/main/java/de/dennisguse/opentracks/content/data/Speed.java b/src/main/java/de/dennisguse/opentracks/content/data/Speed.java
index 629c9d2d1..c483a6d0f 100644
--- a/src/main/java/de/dennisguse/opentracks/content/data/Speed.java
+++ b/src/main/java/de/dennisguse/opentracks/content/data/Speed.java
@@ -23,10 +23,6 @@ public class Speed {
         return of(Float.parseFloat(speed_mps));
     }
 
-    public static Speed invalid() {
-        return of(Double.NaN);
-    }
-
     public static Speed zero() {
         return of(0.0);
     }
diff --git a/src/main/java/de/dennisguse/opentracks/content/provider/ShareContentProvider.java b/src/main/java/de/dennisguse/opentracks/content/provider/ShareContentProvider.java
index 5d7cf220f..bf3a6bb66 100644
--- a/src/main/java/de/dennisguse/opentracks/content/provider/ShareContentProvider.java
+++ b/src/main/java/de/dennisguse/opentracks/content/provider/ShareContentProvider.java
@@ -49,12 +49,8 @@ public class ShareContentProvider extends CustomContentProvider {
     private static final String TAG = ShareContentProvider.class.getSimpleName();
 
     private static final int URI_GPX = 0;
-    private static final int URI_KML_ONLY = 1;
-    private static final int URI_KML_WITH_TRACKDETAIL = 2;
     private static final int URI_KML_WITH_TRACKDETAIL_SENSORDATA = 3;
 
-    private static final int URI_KMZ_ONLY_TRACK = 4;
-    private static final int URI_KMZ_WITH_TRACKDETAIL = 5;
     private static final int URI_KMZ_WITH_TRACKDETAIL_AND_SENSORDATA = 6;
     private static final int URI_KMZ_WITH_TRACKDETAIL_SENSORDATA_AND_PICTURES = 7;
 
diff --git a/src/main/java/de/dennisguse/opentracks/services/sensors/AltitudeSumManager.java b/src/main/java/de/dennisguse/opentracks/services/sensors/AltitudeSumManager.java
index 09b8b8087..15c4089a1 100644
--- a/src/main/java/de/dennisguse/opentracks/services/sensors/AltitudeSumManager.java
+++ b/src/main/java/de/dennisguse/opentracks/services/sensors/AltitudeSumManager.java
@@ -55,10 +55,6 @@ public class AltitudeSumManager implements SensorEventListener {
         reset();
     }
 
-    public boolean isConnected() {
-        return isConnected;
-    }
-
     @VisibleForTesting
     public void setConnected(boolean isConnected) {
         this.isConnected = isConnected;
diff --git a/src/main/java/de/dennisguse/opentracks/stats/TrackStatisticsUpdater.java b/src/main/java/de/dennisguse/opentracks/stats/TrackStatisticsUpdater.java
index 7b6febbe5..9014bf75e 100644
--- a/src/main/java/de/dennisguse/opentracks/stats/TrackStatisticsUpdater.java
+++ b/src/main/java/de/dennisguse/opentracks/stats/TrackStatisticsUpdater.java
@@ -236,7 +236,6 @@ public class TrackStatisticsUpdater {
 
     private void updateAbsoluteAltitude(double altitude) {
         // Update altitude using the smoothed average
-        double oldAverage = altitudeBuffer_m.getAverage();
         altitudeBuffer_m.setNext(altitude);
         double newAverage = altitudeBuffer_m.getAverage();
 
diff --git a/src/main/java/de/dennisguse/opentracks/util/UnitConversions.java b/src/main/java/de/dennisguse/opentracks/util/UnitConversions.java
index 0b479a242..8fa1ea048 100644
--- a/src/main/java/de/dennisguse/opentracks/util/UnitConversions.java
+++ b/src/main/java/de/dennisguse/opentracks/util/UnitConversions.java
@@ -47,8 +47,6 @@ public class UnitConversions {
     // Distance //TODO Make private to Distance class!
     // multiplication factor to convert miles to feet
     private static final double MI_TO_FT = 5280.0;
-    // multiplication factor to convert feet to miles
-    public static final double FT_TO_MI = 1 / MI_TO_FT;
     // multiplication factor to covert kilometers to meters
     public static final double KM_TO_M = 1000.0;
     // multiplication factor to convert meters to kilometers