From 66fe8e694f52e16001602c6a9cb51dcde72d83ff Mon Sep 17 00:00:00 2001
From: Rodrigo Damazio <Rodrigo Damazio@localhost>
Date: Wed, 29 Jun 2011 18:07:00 -0300
Subject: [PATCH] Addressing review suggestions.

---
 .../com/google/android/apps/mytracks/ChartActivity.java    | 7 ++++---
 .../com/google/android/apps/mytracks/io/SendToMyMaps.java  | 1 -
 .../google/android/apps/mytracks/io/file/SaveActivity.java | 3 ++-
 .../apps/mytracks/io/sendtogoogle/SendActivity.java        | 3 ++-
 4 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/MyTracks/src/com/google/android/apps/mytracks/ChartActivity.java b/MyTracks/src/com/google/android/apps/mytracks/ChartActivity.java
index 5b7a9346d..ed32dcea3 100644
--- a/MyTracks/src/com/google/android/apps/mytracks/ChartActivity.java
+++ b/MyTracks/src/com/google/android/apps/mytracks/ChartActivity.java
@@ -218,11 +218,12 @@ public class ChartActivity extends Activity implements TrackDataListener {
       settingsDialog.setOnClickListener(new OnClickListener() {
         @Override
         public void onClick(DialogInterface arg0, int which) {
-          if (which != DialogInterface.BUTTON_POSITIVE) return;
+          if (which != DialogInterface.BUTTON_POSITIVE) {
+            return;
+          }
 
           for (int i = 0; i < ChartView.NUM_SERIES; i++) {
-            boolean seriesEnabled = settingsDialog.isSeriesEnabled(i);
-            chartView.getChartValueSeries(i).setEnabled(seriesEnabled);
+            chartView.getChartValueSeries(i).setEnabled(settingsDialog.isSeriesEnabled(i));
           }
           setMode(settingsDialog.getMode());
           chartView.postInvalidate();
diff --git a/MyTracks/src/com/google/android/apps/mytracks/io/SendToMyMaps.java b/MyTracks/src/com/google/android/apps/mytracks/io/SendToMyMaps.java
index d5f0d293e..a7190e8a9 100644
--- a/MyTracks/src/com/google/android/apps/mytracks/io/SendToMyMaps.java
+++ b/MyTracks/src/com/google/android/apps/mytracks/io/SendToMyMaps.java
@@ -456,7 +456,6 @@ public class SendToMyMaps implements Runnable {
         (totalLocationsRead + totalLocationsPrepared + totalLocationsUploaded) * 100
         / (totalLocations * 3);
     totalPercentage = Math.min(99, totalPercentage);
-    Log.d(TAG, "Percentage: read=" + totalLocationsRead + "; prep=" + totalLocationsPrepared + "; up=" + totalLocationsUploaded + "; total=" + totalLocations + "; percentage=" + totalPercentage);
     progressIndicator.setProgressValue(totalPercentage);
   }
 }
diff --git a/MyTracks/src/com/google/android/apps/mytracks/io/file/SaveActivity.java b/MyTracks/src/com/google/android/apps/mytracks/io/file/SaveActivity.java
index 429d2d772..de89fcc38 100644
--- a/MyTracks/src/com/google/android/apps/mytracks/io/file/SaveActivity.java
+++ b/MyTracks/src/com/google/android/apps/mytracks/io/file/SaveActivity.java
@@ -49,7 +49,8 @@ public class SaveActivity extends Activity {
   public static final String EXTRA_SHARE_FILE = "share_file";
   public static final String EXTRA_FILE_FORMAT = "file_format";
   private static final int RESULT_DIALOG = 1;
-  /* VisibleForTesting */ static final int PROGRESS_DIALOG = 2;
+  /* VisibleForTesting */
+  static final int PROGRESS_DIALOG = 2;
 
   private MyTracksProviderUtils providerUtils;
   private long trackId;
diff --git a/MyTracks/src/com/google/android/apps/mytracks/io/sendtogoogle/SendActivity.java b/MyTracks/src/com/google/android/apps/mytracks/io/sendtogoogle/SendActivity.java
index 05ae0105d..1f865c16e 100644
--- a/MyTracks/src/com/google/android/apps/mytracks/io/sendtogoogle/SendActivity.java
+++ b/MyTracks/src/com/google/android/apps/mytracks/io/sendtogoogle/SendActivity.java
@@ -68,7 +68,8 @@ public class SendActivity extends Activity implements ProgressIndicator {
 
   private static final int SEND_DIALOG = 1;
   private static final int PROGRESS_DIALOG = 2;
-  /* @VisibleForTesting */ static final int DONE_DIALOG = 3;
+  /* @VisibleForTesting */
+  static final int DONE_DIALOG = 3;
 
   // Services
   private MyTracksProviderUtils providerUtils;