diff --git a/src/androidTest/java/de/dennisguse/opentracks/EspressoUITest.java b/src/androidTest/java/de/dennisguse/opentracks/EspressoUITest.java index 0589cb0cd..a2b6d70d7 100644 --- a/src/androidTest/java/de/dennisguse/opentracks/EspressoUITest.java +++ b/src/androidTest/java/de/dennisguse/opentracks/EspressoUITest.java @@ -5,10 +5,11 @@ import static androidx.test.espresso.assertion.ViewAssertions.matches; import static androidx.test.espresso.matcher.ViewMatchers.isDisplayed; import static androidx.test.espresso.matcher.ViewMatchers.withId; import static androidx.test.espresso.matcher.ViewMatchers.withText; +import static org.hamcrest.Matchers.allOf; import static de.dennisguse.opentracks.util.EspressoUtils.performLongClickOnAncestor; import static de.dennisguse.opentracks.util.EspressoUtils.selectTabAtIndex; -import static de.dennisguse.opentracks.util.EspressoUtils.waitUntilDisplayed; import static de.dennisguse.opentracks.util.EspressoUtils.waitForResumedViewCondition; +import static de.dennisguse.opentracks.util.EspressoUtils.waitUntilDisplayed; import static de.dennisguse.opentracks.util.EspressoUtils.withSelectedTab; import static de.dennisguse.opentracks.util.EspressoUtils.withViewPagerCurrentItem; import static de.dennisguse.opentracks.util.TestEnvironmentUtils.resetTrackRecordingServiceAndDeleteTracks; @@ -16,7 +17,6 @@ import static de.dennisguse.opentracks.util.TrackUiTestUtils.finishStoppedTrack; import static de.dennisguse.opentracks.util.TrackUiTestUtils.resumeStoppedTrack; import static de.dennisguse.opentracks.util.TrackUiTestUtils.startRecordingFromTrackList; import static de.dennisguse.opentracks.util.TrackUiTestUtils.stopRecordingToTrackStopped; -import static org.hamcrest.Matchers.allOf; import android.util.Pair; @@ -27,7 +27,6 @@ import androidx.test.ext.junit.runners.AndroidJUnit4; import androidx.test.filters.LargeTest; import androidx.test.rule.GrantPermissionRule; -import org.hamcrest.Matcher; import org.junit.Before; import org.junit.Rule; import org.junit.Test; diff --git a/src/androidTest/java/de/dennisguse/opentracks/ui/customRecordingLayout/RecordingLayoutTest.java b/src/androidTest/java/de/dennisguse/opentracks/ui/customRecordingLayout/RecordingLayoutTest.java index 1ab0a2338..729cb080e 100644 --- a/src/androidTest/java/de/dennisguse/opentracks/ui/customRecordingLayout/RecordingLayoutTest.java +++ b/src/androidTest/java/de/dennisguse/opentracks/ui/customRecordingLayout/RecordingLayoutTest.java @@ -63,8 +63,8 @@ public class RecordingLayoutTest extends TestCase { RecordingLayout recordingLayout = RecordingLayoutIO.fromCsvLine(csv1, resources); // then layout and data fields are built correctly - assertEquals(recordingLayout.getName(), "Default Layout"); - assertEquals(recordingLayout.getColumnsPerRow(), 2); + assertEquals("Default Layout", recordingLayout.getName()); + assertEquals(2, recordingLayout.getColumnsPerRow()); assertEquals(PreferencesUtils.getDefaultLayout().getFields(), recordingLayout.getFields()); } @@ -78,8 +78,8 @@ public class RecordingLayoutTest extends TestCase { List dataFieldList = recordingLayout.getFields(); // then layout and data fields are built correctly - assertEquals(recordingLayout.getName(), "Default Layout"); - assertEquals(recordingLayout.getColumnsPerRow(), 2); + assertEquals("Default Layout", recordingLayout.getName()); + assertEquals(2, recordingLayout.getColumnsPerRow()); assertEquals(PreferencesUtils.getDefaultLayout().getFields(), recordingLayout.getFields()); } @@ -144,6 +144,6 @@ public class RecordingLayoutTest extends TestCase { String csv = recordingLayout.toCsv(); // then csv is well built - assertEquals(csv, "Test Layout;2;key1,0,0,0;key2,0,1,0;key3,1,0,0;key4,1,1,0;key5,1,1,1;"); + assertEquals("Test Layout;2;key1,0,0,0;key2,0,1,0;key3,1,0,0;key4,1,1,0;key5,1,1,1;", csv); } } \ No newline at end of file diff --git a/src/main/java/de/dennisguse/opentracks/io/file/exporter/GPXTrackExporter.java b/src/main/java/de/dennisguse/opentracks/io/file/exporter/GPXTrackExporter.java index f4ba3f978..e45e17509 100644 --- a/src/main/java/de/dennisguse/opentracks/io/file/exporter/GPXTrackExporter.java +++ b/src/main/java/de/dennisguse/opentracks/io/file/exporter/GPXTrackExporter.java @@ -384,10 +384,7 @@ public class GPXTrackExporter implements TrackExporter { printWriter.println(""); - if (cumulativeDistance != null) { - return cumulativeDistance; - } - return Distance.ZERO; + return Objects.requireNonNullElse(cumulativeDistance, Distance.ZERO); } private Double cumulateSensorData(TrackPoint trackPoint, List sensorPoints, Function map) { diff --git a/src/main/java/de/dennisguse/opentracks/sensors/driver/BoschEbikeParser.java b/src/main/java/de/dennisguse/opentracks/sensors/driver/BoschEbikeParser.java index d7398c823..fe9e95543 100644 --- a/src/main/java/de/dennisguse/opentracks/sensors/driver/BoschEbikeParser.java +++ b/src/main/java/de/dennisguse/opentracks/sensors/driver/BoschEbikeParser.java @@ -7,6 +7,7 @@ import androidx.annotation.Nullable; import java.util.ArrayList; import java.util.Arrays; import java.util.List; +import java.util.Objects; import java.util.UUID; import de.dennisguse.opentracks.data.models.Cadence; @@ -98,7 +99,7 @@ public final class BoschEbikeParser { .filter(BoschEbikeParser::isValidFrame) .filter(BoschEbikeParser::isSupportedFrame) .map(BoschEbikeParser::decodeFrame) - .filter(decodedFrame -> decodedFrame != null) + .filter(Objects::nonNull) .reduce(null, BoschEbikeParser::processMessage, (left, right) -> right); diff --git a/src/main/java/de/dennisguse/opentracks/settings/ImportExportSettingsFragment.java b/src/main/java/de/dennisguse/opentracks/settings/ImportExportSettingsFragment.java index 9b97b0286..ebfc6dc80 100644 --- a/src/main/java/de/dennisguse/opentracks/settings/ImportExportSettingsFragment.java +++ b/src/main/java/de/dennisguse/opentracks/settings/ImportExportSettingsFragment.java @@ -58,7 +58,6 @@ public class ImportExportSettingsFragment extends PreferenceFragmentCompat { if (!healthConnectAvailable) { findPreference(getString(R.string.post_workout_export_health_connect_enabled_key)) .setSummary(R.string.health_connect_not_available); - return; } } diff --git a/src/main/java/de/dennisguse/opentracks/util/FileUtils.java b/src/main/java/de/dennisguse/opentracks/util/FileUtils.java index b0e82e63d..40f9e966d 100644 --- a/src/main/java/de/dennisguse/opentracks/util/FileUtils.java +++ b/src/main/java/de/dennisguse/opentracks/util/FileUtils.java @@ -27,7 +27,6 @@ import java.io.File; import java.io.FileDescriptor; import java.io.FileInputStream; import java.io.FileOutputStream; -import java.nio.channels.FileChannel; import java.util.ArrayList; import java.util.List;