diff --git a/src/main/java/de/dennisguse/opentracks/MarkerDetailActivity.java b/src/main/java/de/dennisguse/opentracks/MarkerDetailActivity.java index cf4cce204..155aab707 100644 --- a/src/main/java/de/dennisguse/opentracks/MarkerDetailActivity.java +++ b/src/main/java/de/dennisguse/opentracks/MarkerDetailActivity.java @@ -109,12 +109,7 @@ public class MarkerDetailActivity extends AbstractActivity implements DeleteMark @Override public void onDeleteMarkerDone() { - runOnUiThread(new Runnable() { - @Override - public void run() { - finish(); - } - }); + runOnUiThread(this::finish); } /** diff --git a/src/main/java/de/dennisguse/opentracks/MarkerListActivity.java b/src/main/java/de/dennisguse/opentracks/MarkerListActivity.java index 0785ec74a..b585e5fc5 100644 --- a/src/main/java/de/dennisguse/opentracks/MarkerListActivity.java +++ b/src/main/java/de/dennisguse/opentracks/MarkerListActivity.java @@ -82,12 +82,7 @@ public class MarkerListActivity extends AbstractActivity implements DeleteMarker recordingTrackPaused = PreferencesUtils.isRecordingTrackPaused(MarkerListActivity.this); } if (key != null) { - runOnUiThread(new Runnable() { - @Override - public void run() { - MarkerListActivity.this.invalidateOptionsMenu(); - } - }); + runOnUiThread(() -> MarkerListActivity.this.invalidateOptionsMenu()); } } }; diff --git a/src/main/java/de/dennisguse/opentracks/SearchListActivity.java b/src/main/java/de/dennisguse/opentracks/SearchListActivity.java index 71679be72..6b0b8a2c9 100644 --- a/src/main/java/de/dennisguse/opentracks/SearchListActivity.java +++ b/src/main/java/de/dennisguse/opentracks/SearchListActivity.java @@ -153,12 +153,7 @@ public class SearchListActivity extends AbstractListActivity implements DeleteMa recordingTrackPaused = PreferencesUtils.isRecordingTrackPaused(SearchListActivity.this); } if (key != null) { - runOnUiThread(new Runnable() { - @Override - public void run() { - arrayAdapter.notifyDataSetChanged(); - } - }); + runOnUiThread(() -> arrayAdapter.notifyDataSetChanged()); } } }; @@ -346,12 +341,9 @@ public class SearchListActivity extends AbstractListActivity implements DeleteMa final List> displayResults = prepareResultsforDisplay(scoredResults); // Use the UI thread to display the results - runOnUiThread(new Runnable() { - @Override - public void run() { - arrayAdapter.clear(); - arrayAdapter.addAll(displayResults); - } + runOnUiThread(() -> { + arrayAdapter.clear(); + arrayAdapter.addAll(displayResults); }); } @@ -448,12 +440,7 @@ public class SearchListActivity extends AbstractListActivity implements DeleteMa @Override public void onDeleteMarkerDone() { - runOnUiThread(new Runnable() { - @Override - public void run() { - handleIntent(getIntent()); - } - }); + runOnUiThread(() -> handleIntent(getIntent())); } @Override @@ -463,11 +450,6 @@ public class SearchListActivity extends AbstractListActivity implements DeleteMa @Override protected void onDeleted() { - runOnUiThread(new Runnable() { - @Override - public void run() { - handleIntent(getIntent()); - } - }); + runOnUiThread(() -> handleIntent(getIntent())); } } diff --git a/src/main/java/de/dennisguse/opentracks/TrackListActivity.java b/src/main/java/de/dennisguse/opentracks/TrackListActivity.java index 30a1bfb9d..acdc786f7 100644 --- a/src/main/java/de/dennisguse/opentracks/TrackListActivity.java +++ b/src/main/java/de/dennisguse/opentracks/TrackListActivity.java @@ -143,14 +143,11 @@ public class TrackListActivity extends AbstractListActivity implements ConfirmDe recordingTrackPaused = PreferencesUtils.isRecordingTrackPaused(TrackListActivity.this); } if (key != null) { - runOnUiThread(new Runnable() { - @Override - public void run() { - TrackListActivity.this.invalidateOptionsMenu(); - LoaderManager.getInstance(TrackListActivity.this).restartLoader(0, null, loaderCallbacks); - boolean isRecording = PreferencesUtils.isRecording(recordingTrackId); - trackController.update(isRecording, recordingTrackPaused); - } + runOnUiThread(() -> { + TrackListActivity.this.invalidateOptionsMenu(); + LoaderManager.getInstance(TrackListActivity.this).restartLoader(0, null, loaderCallbacks); + boolean isRecording = PreferencesUtils.isRecording(recordingTrackId); + trackController.update(isRecording, recordingTrackPaused); }); } } @@ -177,12 +174,7 @@ public class TrackListActivity extends AbstractListActivity implements ConfirmDe /* * After binding changes (e.g., becomes available), update the total time in trackController. */ - runOnUiThread(new Runnable() { - @Override - public void run() { - trackController.update(PreferencesUtils.isRecording(recordingTrackId), recordingTrackPaused); - } - }); + runOnUiThread(() -> trackController.update(PreferencesUtils.isRecording(recordingTrackId), recordingTrackPaused)); if (!startGps) { return; diff --git a/src/main/java/de/dennisguse/opentracks/TrackRecordedActivity.java b/src/main/java/de/dennisguse/opentracks/TrackRecordedActivity.java index 901a8981a..07983584a 100644 --- a/src/main/java/de/dennisguse/opentracks/TrackRecordedActivity.java +++ b/src/main/java/de/dennisguse/opentracks/TrackRecordedActivity.java @@ -16,7 +16,6 @@ package de.dennisguse.opentracks; -import android.app.ActivityOptions; import android.content.Intent; import android.os.Bundle; import android.util.Log; @@ -226,12 +225,7 @@ public class TrackRecordedActivity extends AbstractListActivity implements Choos @Override protected void onDeleted() { - runOnUiThread(new Runnable() { - @Override - public void run() { - finish(); - } - }); + runOnUiThread(this::finish); } /** @@ -259,7 +253,6 @@ public class TrackRecordedActivity extends AbstractListActivity implements Choos if (trackId == -1L) { Log.e(TAG, "TrackDetailActivity needs EXTRA_TRACK_ID."); finish(); - return; } } diff --git a/src/main/java/de/dennisguse/opentracks/TrackRecordingActivity.java b/src/main/java/de/dennisguse/opentracks/TrackRecordingActivity.java index 8df8041f2..08397b623 100644 --- a/src/main/java/de/dennisguse/opentracks/TrackRecordingActivity.java +++ b/src/main/java/de/dennisguse/opentracks/TrackRecordingActivity.java @@ -1,6 +1,5 @@ package de.dennisguse.opentracks; -import android.app.ActivityOptions; import android.content.Intent; import android.content.SharedPreferences; import android.content.SharedPreferences.OnSharedPreferenceChangeListener; @@ -68,12 +67,7 @@ public class TrackRecordingActivity extends AbstractActivity implements ChooseAc @Override public void run() { // After binding changes (is available), update the total time in trackController. - runOnUiThread(new Runnable() { - @Override - public void run() { - trackController.update(true, recordingTrackPaused); - } - }); + runOnUiThread(() -> trackController.update(true, recordingTrackPaused)); if (recordingTrackId == -1L) { TrackRecordingServiceInterface service = trackRecordingServiceConnection.getServiceIfBound(); @@ -130,12 +124,9 @@ public class TrackRecordingActivity extends AbstractActivity implements ChooseAc if (key == null) return; - runOnUiThread(new Runnable() { - @Override - public void run() { - TrackRecordingActivity.this.invalidateOptionsMenu(); - trackController.update(true, recordingTrackPaused); - } + runOnUiThread(() -> { + TrackRecordingActivity.this.invalidateOptionsMenu(); + trackController.update(true, recordingTrackPaused); }); } }; diff --git a/src/main/java/de/dennisguse/opentracks/content/TrackDataHub.java b/src/main/java/de/dennisguse/opentracks/content/TrackDataHub.java index 053123039..ca6f676d9 100644 --- a/src/main/java/de/dennisguse/opentracks/content/TrackDataHub.java +++ b/src/main/java/de/dennisguse/opentracks/content/TrackDataHub.java @@ -144,12 +144,9 @@ public class TrackDataHub implements SharedPreferences.OnSharedPreferenceChangeL PreferencesUtils.register(context, this); onSharedPreferenceChanged(null, null); - runInHandlerThread(new Runnable() { - @Override - public void run() { - if (started) { - loadDataForAll(); - } + runInHandlerThread(() -> { + if (started) { + loadDataForAll(); } }); } @@ -178,16 +175,13 @@ public class TrackDataHub implements SharedPreferences.OnSharedPreferenceChangeL } public void loadTrack(final long trackId) { - runInHandlerThread(new Runnable() { - @Override - public void run() { - if (trackId == selectedTrackId) { - Log.i(TAG, "Not reloading track " + trackId); - return; - } - selectedTrackId = trackId; - loadDataForAll(); + runInHandlerThread(() -> { + if (trackId == selectedTrackId) { + Log.i(TAG, "Not reloading track " + trackId); + return; } + selectedTrackId = trackId; + loadDataForAll(); }); } @@ -197,13 +191,10 @@ public class TrackDataHub implements SharedPreferences.OnSharedPreferenceChangeL * @param trackDataListener the track data listener */ public void registerTrackDataListener(final TrackDataListener trackDataListener, final boolean tracksTable, final boolean waypointsTable, final boolean trackPointsTable_SampleIn, final boolean trackPointsTable_SampleOut) { - runInHandlerThread(new Runnable() { - @Override - public void run() { - trackDataManager.registerTrackDataListener(trackDataListener, tracksTable, waypointsTable, trackPointsTable_SampleIn, trackPointsTable_SampleOut); - if (started) { - loadDataForListener(trackDataListener); - } + runInHandlerThread(() -> { + trackDataManager.registerTrackDataListener(trackDataListener, tracksTable, waypointsTable, trackPointsTable_SampleIn, trackPointsTable_SampleOut); + if (started) { + loadDataForListener(trackDataListener); } }); } @@ -214,12 +205,7 @@ public class TrackDataHub implements SharedPreferences.OnSharedPreferenceChangeL * @param trackDataListener the track data listener */ public void unregisterTrackDataListener(final TrackDataListener trackDataListener) { - runInHandlerThread(new Runnable() { - @Override - public void run() { - trackDataManager.unregisterTrackDataListener(trackDataListener); - } - }); + runInHandlerThread(() -> trackDataManager.unregisterTrackDataListener(trackDataListener)); } /** @@ -238,15 +224,12 @@ public class TrackDataHub implements SharedPreferences.OnSharedPreferenceChangeL @Override public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, final String key) { - runInHandlerThread(new Runnable() { - @Override - public void run() { - if (PreferencesUtils.isKey(context, R.string.recording_track_id_key, key)) { - recordingTrackId = PreferencesUtils.getRecordingTrackId(context); - } - if (PreferencesUtils.isKey(context, R.string.recording_track_paused_key, key)) { - recordingTrackPaused = PreferencesUtils.isRecordingTrackPaused(context); - } + runInHandlerThread(() -> { + if (PreferencesUtils.isKey(context, R.string.recording_track_id_key, key)) { + recordingTrackId = PreferencesUtils.getRecordingTrackId(context); + } + if (PreferencesUtils.isKey(context, R.string.recording_track_paused_key, key)) { + recordingTrackPaused = PreferencesUtils.isRecordingTrackPaused(context); } }); } @@ -289,7 +272,7 @@ public class TrackDataHub implements SharedPreferences.OnSharedPreferenceChangeL if (isOnlyListener) { resetSamplingState(); } - Set sampledOutListeners = hasSampledOut ? trackDataListeners : Collections.emptySet(); + Set sampledOutListeners = hasSampledOut ? trackDataListeners : Collections.emptySet(); notifyTrackPointsTableUpdate(isOnlyListener, trackDataListeners, sampledOutListeners); } diff --git a/src/main/java/de/dennisguse/opentracks/fragments/ChartFragment.java b/src/main/java/de/dennisguse/opentracks/fragments/ChartFragment.java index 03af17e78..cedd9f674 100644 --- a/src/main/java/de/dennisguse/opentracks/fragments/ChartFragment.java +++ b/src/main/java/de/dennisguse/opentracks/fragments/ChartFragment.java @@ -90,12 +90,9 @@ public class ChartFragment extends Fragment implements TrackDataListener { boolean metricUnits = PreferencesUtils.isMetricUnits(getContext()); if (metricUnits != chartView.getMetricUnits()) { chartView.setMetricUnits(metricUnits); - runOnUiThread(new Runnable() { - @Override - public void run() { - if (isResumed()) { - chartView.requestLayout(); - } + runOnUiThread(() -> { + if (isResumed()) { + chartView.requestLayout(); } }); } @@ -106,12 +103,9 @@ public class ChartFragment extends Fragment implements TrackDataListener { chartView.setReportSpeed(reportSpeed); chartView.applyReportSpeed(); - runOnUiThread(new Runnable() { - @Override - public void run() { - if (isResumed()) { - chartView.requestLayout(); - } + runOnUiThread(() -> { + if (isResumed()) { + chartView.requestLayout(); } }); } @@ -214,12 +208,9 @@ public class ChartFragment extends Fragment implements TrackDataListener { trackStatisticsUpdater = startTime != -1L ? new TrackStatisticsUpdater(startTime) : null; pendingPoints.clear(); chartView.reset(); - runOnUiThread(new Runnable() { - @Override - public void run() { - if (isResumed()) { - chartView.resetScroll(); - } + runOnUiThread(() -> { + if (isResumed()) { + chartView.resetScroll(); } }); } diff --git a/src/main/java/de/dennisguse/opentracks/fragments/DeleteMarkerDialogFragment.java b/src/main/java/de/dennisguse/opentracks/fragments/DeleteMarkerDialogFragment.java index 3de0ec2c2..f0e19dad7 100644 --- a/src/main/java/de/dennisguse/opentracks/fragments/DeleteMarkerDialogFragment.java +++ b/src/main/java/de/dennisguse/opentracks/fragments/DeleteMarkerDialogFragment.java @@ -80,15 +80,12 @@ public class DeleteMarkerDialogFragment extends DialogFragment { fragmentActivity, titleId, getString(messageId), new DialogInterface.OnClickListener() { @Override public void onClick(DialogInterface dialog, int which) { - new Thread(new Runnable() { - @Override - public void run() { - ContentProviderUtils contentProviderUtils = new ContentProviderUtils(fragmentActivity); - for (long markerId : markerIds) { - contentProviderUtils.deleteWaypoint(getContext(), markerId); - } - caller.onDeleteMarkerDone(); + new Thread(() -> { + ContentProviderUtils contentProviderUtils = new ContentProviderUtils(fragmentActivity); + for (long markerId : markerIds) { + contentProviderUtils.deleteWaypoint(getContext(), markerId); } + caller.onDeleteMarkerDone(); }).start(); } }); diff --git a/src/main/java/de/dennisguse/opentracks/fragments/StatisticsRecordedFragment.java b/src/main/java/de/dennisguse/opentracks/fragments/StatisticsRecordedFragment.java index 0f50feed0..4d11df999 100644 --- a/src/main/java/de/dennisguse/opentracks/fragments/StatisticsRecordedFragment.java +++ b/src/main/java/de/dennisguse/opentracks/fragments/StatisticsRecordedFragment.java @@ -59,12 +59,9 @@ public class StatisticsRecordedFragment extends Fragment implements TrackDataLis public void onSharedPreferenceChanged(SharedPreferences preferences, String key) { if (PreferencesUtils.isKey(getContext(), R.string.stats_units_key, key) || PreferencesUtils.isKey(getContext(), R.string.stats_rate_key, key)) { if (isResumed()) { - getActivity().runOnUiThread(new Runnable() { - @Override - public void run() { - if (isResumed()) { - updateUI(); - } + getActivity().runOnUiThread(() -> { + if (isResumed()) { + updateUI(); } }); } @@ -195,14 +192,11 @@ public class StatisticsRecordedFragment extends Fragment implements TrackDataLis @Override public void onTrackUpdated(final Track track) { if (isResumed()) { - getActivity().runOnUiThread(new Runnable() { - @Override - public void run() { - if (isResumed()) { - trackStatistics = track != null ? track.getTrackStatistics() : null; - category = track != null ? track.getCategory() : ""; - updateUI(); - } + getActivity().runOnUiThread(() -> { + if (isResumed()) { + trackStatistics = track != null ? track.getTrackStatistics() : null; + category = track != null ? track.getCategory() : ""; + updateUI(); } }); } diff --git a/src/main/java/de/dennisguse/opentracks/fragments/StatisticsRecordingFragment.java b/src/main/java/de/dennisguse/opentracks/fragments/StatisticsRecordingFragment.java index 2a1170d39..5cdcc55b7 100644 --- a/src/main/java/de/dennisguse/opentracks/fragments/StatisticsRecordingFragment.java +++ b/src/main/java/de/dennisguse/opentracks/fragments/StatisticsRecordingFragment.java @@ -68,12 +68,9 @@ public class StatisticsRecordingFragment extends Fragment implements TrackDataLi public void onSharedPreferenceChanged(SharedPreferences preferences, String key) { if (PreferencesUtils.isKey(getContext(), R.string.stats_units_key, key) || PreferencesUtils.isKey(getContext(), R.string.stats_rate_key, key)) { if (isResumed()) { - getActivity().runOnUiThread(new Runnable() { - @Override - public void run() { - if (isResumed()) { - updateUI(); - } + getActivity().runOnUiThread(() -> { + if (isResumed()) { + updateUI(); } }); } @@ -308,14 +305,11 @@ public class StatisticsRecordingFragment extends Fragment implements TrackDataLi @Override public void onTrackUpdated(final Track track) { if (isResumed()) { - getActivity().runOnUiThread(new Runnable() { - @Override - public void run() { - if (isResumed()) { - lastTrackStatistics = track != null ? track.getTrackStatistics() : null; - category = track != null ? track.getCategory() : ""; - updateUI(); - } + getActivity().runOnUiThread(() -> { + if (isResumed()) { + lastTrackStatistics = track != null ? track.getTrackStatistics() : null; + category = track != null ? track.getCategory() : ""; + updateUI(); } }); } @@ -339,24 +333,21 @@ public class StatisticsRecordingFragment extends Fragment implements TrackDataLi @Override public void onNewTrackPointsDone() { if (isResumed()) { - getActivity().runOnUiThread(new Runnable() { - @Override - public void run() { - if (isResumed()) { - if (!isSelectedTrackRecording() || isSelectedTrackPaused()) { + getActivity().runOnUiThread(() -> { + if (isResumed()) { + if (!isSelectedTrackRecording() || isSelectedTrackPaused()) { + lastTrackPoint = null; + } + + if (lastTrackPoint != null) { + boolean hasFix = !LocationUtils.isLocationOld(lastTrackPoint.getLocation()); + boolean hasGoodFix = TrackPointUtils.fulfillsAccuracy(lastTrackPoint, recordingGpsAccuracy); + + if (!hasFix || !hasGoodFix) { lastTrackPoint = null; } - - if (lastTrackPoint != null) { - boolean hasFix = !LocationUtils.isLocationOld(lastTrackPoint.getLocation()); - boolean hasGoodFix = TrackPointUtils.fulfillsAccuracy(lastTrackPoint, recordingGpsAccuracy); - - if (!hasFix || !hasGoodFix) { - lastTrackPoint = null; - } - } - setLocationValues(); } + setLocationValues(); } }); } diff --git a/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java b/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java index 1c1d3d0bd..80f58c82d 100644 --- a/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java +++ b/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java @@ -150,12 +150,7 @@ public class TrackRecordingService extends Service { if (locationExecutorService == null || locationExecutorService.isShutdown() || locationExecutorService.isTerminated()) { return; } - locationExecutorService.submit(new Runnable() { - @Override - public void run() { - onLocationChangedAsync(location); - } - }); + locationExecutorService.submit(() -> onLocationChangedAsync(location)); } @Override diff --git a/src/main/java/de/dennisguse/opentracks/settings/SettingsActivity.java b/src/main/java/de/dennisguse/opentracks/settings/SettingsActivity.java index 5017e2d97..d17245e22 100644 --- a/src/main/java/de/dennisguse/opentracks/settings/SettingsActivity.java +++ b/src/main/java/de/dennisguse/opentracks/settings/SettingsActivity.java @@ -60,20 +60,10 @@ public class SettingsActivity extends AppCompatActivity implements ChooseActivit @Override public void onSharedPreferenceChanged(SharedPreferences preferences, String key) { if (PreferencesUtils.isKey(getActivity(), R.string.recording_track_id_key, key)) { - getActivity().runOnUiThread(new Runnable() { - @Override - public void run() { - updateReset(); - } - }); + getActivity().runOnUiThread(() -> updateReset()); } if (PreferencesUtils.isKey(getActivity(), R.string.stats_units_key, key)) { - getActivity().runOnUiThread(new Runnable() { - @Override - public void run() { - updateUnits(); - } - }); + getActivity().runOnUiThread(() -> updateUnits()); } } }; diff --git a/src/main/java/de/dennisguse/opentracks/util/BluetoothUtils.java b/src/main/java/de/dennisguse/opentracks/util/BluetoothUtils.java index ed32d1c9f..26928de70 100644 --- a/src/main/java/de/dennisguse/opentracks/util/BluetoothUtils.java +++ b/src/main/java/de/dennisguse/opentracks/util/BluetoothUtils.java @@ -61,13 +61,10 @@ public class BluetoothUtils { final Object mutex = new Object(); Handler handler = new Handler(Looper.getMainLooper()); - handler.post(new Runnable() { - @Override - public void run() { - adapters.add(BluetoothAdapter.getDefaultAdapter()); - synchronized (mutex) { - mutex.notify(); - } + handler.post(() -> { + adapters.add(BluetoothAdapter.getDefaultAdapter()); + synchronized (mutex) { + mutex.notify(); } });