diff --git a/MyTracks/res/layout/about.xml b/MyTracks/res/layout/about.xml index e98c5982f..88a026d4a 100644 --- a/MyTracks/res/layout/about.xml +++ b/MyTracks/res/layout/about.xml @@ -18,7 +18,7 @@ limitations under the License. style="@style/ScrollView" > diff --git a/MyTracks/res/layout/chart.xml b/MyTracks/res/layout/chart.xml index b5d169658..3e5906f07 100644 --- a/MyTracks/res/layout/chart.xml +++ b/MyTracks/res/layout/chart.xml @@ -15,14 +15,14 @@ See the License for the specific language governing permissions and limitations under the License. --> \ No newline at end of file diff --git a/MyTracks/res/layout/choose_activity_list_item.xml b/MyTracks/res/layout/choose_activity_list_item.xml index 60b4758c9..a7a18609d 100644 --- a/MyTracks/res/layout/choose_activity_list_item.xml +++ b/MyTracks/res/layout/choose_activity_list_item.xml @@ -17,7 +17,7 @@ limitations under the License. + android:layout_height="match_parent" + android:layout_width="match_parent" > + android:layout_height="match_parent" + android:layout_width="match_parent" /> diff --git a/MyTracks/res/layout/choose_map_item.xml b/MyTracks/res/layout/choose_map_item.xml index 20da468ef..6332033b8 100644 --- a/MyTracks/res/layout/choose_map_item.xml +++ b/MyTracks/res/layout/choose_map_item.xml @@ -17,7 +17,7 @@ limitations under the License. diff --git a/MyTracks/res/layout/choose_upload_service.xml b/MyTracks/res/layout/choose_upload_service.xml index 2e20d0cbe..6e36c969e 100644 --- a/MyTracks/res/layout/choose_upload_service.xml +++ b/MyTracks/res/layout/choose_upload_service.xml @@ -18,7 +18,7 @@ limitations under the License. style="@style/ScrollView" > diff --git a/MyTracks/res/layout/confirm_sharing.xml b/MyTracks/res/layout/confirm_sharing.xml index d13425cfa..5c738ca54 100644 --- a/MyTracks/res/layout/confirm_sharing.xml +++ b/MyTracks/res/layout/confirm_sharing.xml @@ -18,7 +18,7 @@ limitations under the License. style="@style/ScrollView" > diff --git a/MyTracks/res/layout/help.xml b/MyTracks/res/layout/help.xml index 930e7bbbc..16341955c 100644 --- a/MyTracks/res/layout/help.xml +++ b/MyTracks/res/layout/help.xml @@ -15,13 +15,13 @@ See the License for the specific language governing permissions and limitations under the License. --> @@ -29,11 +29,11 @@ limitations under the License. + android:layout_height="match_parent" + android:layout_width="match_parent" > diff --git a/MyTracks/res/layout/marker_edit.xml b/MyTracks/res/layout/marker_edit.xml index 5175394ae..90cd620c3 100644 --- a/MyTracks/res/layout/marker_edit.xml +++ b/MyTracks/res/layout/marker_edit.xml @@ -15,13 +15,13 @@ See the License for the specific language governing permissions and limitations under the License. --> + android:layout_height="match_parent" + android:layout_width="match_parent" > + android:layout_height="match_parent" + android:layout_width="match_parent" /> + android:layout_height="match_parent" + android:layout_width="match_parent" > + android:layout_height="match_parent" + android:layout_width="match_parent" /> diff --git a/MyTracks/res/layout/track_controller.xml b/MyTracks/res/layout/track_controller.xml index 923a638e4..5206a5a86 100644 --- a/MyTracks/res/layout/track_controller.xml +++ b/MyTracks/res/layout/track_controller.xml @@ -18,12 +18,12 @@ limitations under the License. + android:layout_width="match_parent" /> \ No newline at end of file diff --git a/MyTracks/res/layout/track_detail.xml b/MyTracks/res/layout/track_detail.xml index 2284175c0..6e15644f0 100644 --- a/MyTracks/res/layout/track_detail.xml +++ b/MyTracks/res/layout/track_detail.xml @@ -15,23 +15,23 @@ See the License for the specific language governing permissions and limitations under the License. --> + android:layout_width="match_parent" > + android:layout_width="match_parent" /> + android:layout_width="match_parent" /> diff --git a/MyTracks/res/layout/track_widget_4x1.xml b/MyTracks/res/layout/track_widget_4x1.xml index 4263b1cdc..046e633fb 100644 --- a/MyTracks/res/layout/track_widget_4x1.xml +++ b/MyTracks/res/layout/track_widget_4x1.xml @@ -30,7 +30,7 @@ limitations under the License. style="@style/TrackWidgetButtonRecord" /> diff --git a/MyTracks/res/values/styles.xml b/MyTracks/res/values/styles.xml index e160ce22b..2be5ec6ca 100644 --- a/MyTracks/res/values/styles.xml +++ b/MyTracks/res/values/styles.xml @@ -29,7 +29,7 @@ limitations under the License. @@ -48,25 +48,25 @@ limitations under the License. @@ -113,8 +113,8 @@ limitations under the License. @@ -126,7 +126,7 @@ limitations under the License. @@ -137,7 +137,7 @@ limitations under the License. @@ -191,14 +191,14 @@ limitations under the License. @@ -212,7 +212,7 @@ limitations under the License. center_vertical 0dp 1 - fill_parent + match_parent horizontal 4dp 4dp @@ -234,13 +234,13 @@ limitations under the License. center_horizontal wrap_content 8dp - fill_parent + match_parent @@ -257,7 +257,7 @@ limitations under the License. @@ -319,7 +319,7 @@ limitations under the License. @@ -328,7 +328,7 @@ limitations under the License. center_vertical 0dp 1 - fill_parent + match_parent horizontal @@ -390,7 +390,7 @@ limitations under the License. diff --git a/MyTracks/src/com/google/android/apps/mytracks/fragments/ChartFragment.java b/MyTracks/src/com/google/android/apps/mytracks/fragments/ChartFragment.java index edc036f32..bb19e0e74 100644 --- a/MyTracks/src/com/google/android/apps/mytracks/fragments/ChartFragment.java +++ b/MyTracks/src/com/google/android/apps/mytracks/fragments/ChartFragment.java @@ -125,13 +125,12 @@ public class ChartFragment extends Fragment implements TrackDataListener { return view; } - @SuppressWarnings("deprecation") @Override public void onStart() { super.onStart(); ViewGroup layout = (ViewGroup) getActivity().findViewById(R.id.chart_view_layout); LayoutParams layoutParams = new LayoutParams( - LayoutParams.FILL_PARENT, LayoutParams.FILL_PARENT); + LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT); layout.addView(chartView, layoutParams); } diff --git a/MyTracks/src/com/google/android/apps/mytracks/services/ControlRecordingService.java b/MyTracks/src/com/google/android/apps/mytracks/services/ControlRecordingService.java index 3fb94f757..342147931 100644 --- a/MyTracks/src/com/google/android/apps/mytracks/services/ControlRecordingService.java +++ b/MyTracks/src/com/google/android/apps/mytracks/services/ControlRecordingService.java @@ -103,21 +103,21 @@ public class ControlRecordingService extends IntentService implements ServiceCon * Handles the intent to start or stop a recording. * * @param intent to be handled - * @param trackRecordingService the trackRecordingService + * @param service the trackRecordingService */ @VisibleForTesting - void onHandleIntent(Intent intent, @SuppressWarnings("hiding") ITrackRecordingService trackRecordingService) { + void onHandleIntent(Intent intent, ITrackRecordingService service) { String action = intent.getAction(); if (action != null) { try { if (action.equals(getString(R.string.track_action_start))) { - trackRecordingService.startNewTrack(); + service.startNewTrack(); } else if (action.equals(getString(R.string.track_action_end))) { - trackRecordingService.endCurrentTrack(); + service.endCurrentTrack(); } else if (action.equals(getString(R.string.track_action_pause))) { - trackRecordingService.pauseCurrentTrack(); + service.pauseCurrentTrack(); } else if (action.equals(getString(R.string.track_action_resume))) { - trackRecordingService.resumeCurrentTrack(); + service.resumeCurrentTrack(); } } catch (RemoteException e) { Log.d(TAG, "ControlRecordingService onHandleIntent RemoteException", e); diff --git a/MyTracksTest/src/com/google/android/apps/mytracks/content/MyTracksProviderUtilsImplTest.java b/MyTracksTest/src/com/google/android/apps/mytracks/content/MyTracksProviderUtilsImplTest.java index ee5cadd22..315dcf01f 100644 --- a/MyTracksTest/src/com/google/android/apps/mytracks/content/MyTracksProviderUtilsImplTest.java +++ b/MyTracksTest/src/com/google/android/apps/mytracks/content/MyTracksProviderUtilsImplTest.java @@ -453,9 +453,8 @@ public class MyTracksProviderUtilsImplTest extends AndroidTestCase { return MyTracksProviderUtilsImplTest.MOCK_DESC; } - @SuppressWarnings("hiding") @Override - public String generateTrackDescription(Track track, Vector distances, + public String generateTrackDescription(Track aTrack, Vector distances, Vector elevations, boolean html) { return null; } @@ -509,9 +508,8 @@ public class MyTracksProviderUtilsImplTest extends AndroidTestCase { return MyTracksProviderUtilsImplTest.MOCK_DESC; } - @SuppressWarnings("hiding") @Override - public String generateTrackDescription(Track track, Vector distances, + public String generateTrackDescription(Track aTrack, Vector distances, Vector elevations, boolean html) { return null; } @@ -653,14 +651,8 @@ public class MyTracksProviderUtilsImplTest extends AndroidTestCase { } /** - * Tests the method {@link MyTracksProviderUtilsImpl#createLocation(Cursor)}. - * This test also covers the method - * {@link MyTracksProviderUtilsImpl#fillLocation(Cursor, Location)} and - * {@link MyTracksProviderUtilsImpl#fillLocation(Cursor, MyTracksProviderUtilsImpl.CachedTrackPointsIndexes, Location)} - * and the inner class - * {@link MyTracksProviderUtilsImpl.CachedTrackPointsIndexes}. + * Tests the method {@link MyTracksProviderUtilsImpl#createTrackPoint(Cursor)}. */ - @SuppressWarnings("javadoc") @UsesMocks(Cursor.class) public void testCreateTrackPoint() { Cursor cursorMock = AndroidMock.createNiceMock(Cursor.class);