From d49e7749f387a08b85f7b6e2b0f9a3c1a83509cc Mon Sep 17 00:00:00 2001 From: Dennis Guse Date: Thu, 26 Feb 2026 20:35:55 +0100 Subject: [PATCH] Cleanup: removed unnecessary interface from ContentProviderUtils. --- .../dennisguse/opentracks/data/ContentProviderUtils.java | 7 +------ .../java/de/dennisguse/opentracks/data/TrackSelection.java | 3 +-- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/main/java/de/dennisguse/opentracks/data/ContentProviderUtils.java b/src/main/java/de/dennisguse/opentracks/data/ContentProviderUtils.java index 699fe57da..09d8cd350 100644 --- a/src/main/java/de/dennisguse/opentracks/data/ContentProviderUtils.java +++ b/src/main/java/de/dennisguse/opentracks/data/ContentProviderUtils.java @@ -72,11 +72,6 @@ public class ContentProviderUtils { private final ContentResolver contentResolver; - //TODO Check if this can be used in more than one place. If not remove. - public interface ContentProviderSelectionInterface { - SelectionData buildSelection(); - } - public ContentProviderUtils(Context context) { contentResolver = context.getContentResolver(); } @@ -746,7 +741,7 @@ public class ContentProviderUtils { } @NonNull - public List getAggregatedStatisticsForTracks(ContentProviderSelectionInterface selection) { + public List getAggregatedStatisticsForTracks(TrackSelection selection) { SelectionData data = selection.buildSelection(); try (Cursor cursor = contentResolver.query(TracksColumns.CONTENT_URI_AGGREGATED_STATISTICS, null, data.selection(), data.getSelectionArgs(), null)) { ArrayList aggregatedStatistics = new ArrayList<>(cursor.getCount()); diff --git a/src/main/java/de/dennisguse/opentracks/data/TrackSelection.java b/src/main/java/de/dennisguse/opentracks/data/TrackSelection.java index 53dfca5d1..f364c7e32 100644 --- a/src/main/java/de/dennisguse/opentracks/data/TrackSelection.java +++ b/src/main/java/de/dennisguse/opentracks/data/TrackSelection.java @@ -10,7 +10,7 @@ import java.util.List; import de.dennisguse.opentracks.data.models.Track; import de.dennisguse.opentracks.data.tables.TracksColumns; -public class TrackSelection implements ContentProviderUtils.ContentProviderSelectionInterface { +public class TrackSelection { private final List trackIds = new ArrayList<>(); private final List categories = new ArrayList<>(); private Instant from; @@ -40,7 +40,6 @@ public class TrackSelection implements ContentProviderUtils.ContentProviderSelec return trackIds.isEmpty() && categories.isEmpty() && from == null && to == null; } - @Override public ContentProviderUtils.SelectionData buildSelection() { String selection = ""; List selectionArgs = new ArrayList<>();