From f984339b1361295ebbd48ba42dd0647ac9503407 Mon Sep 17 00:00:00 2001
From: Matthew Simmons <simmonmt@google.com>
Date: Wed, 6 Apr 2011 18:46:14 -0400
Subject: [PATCH] code review comments

---
 .../mytracks/WriteProgressController.java     | 34 +++++++++----------
 .../mytracks/WriteProgressControllerTest.java |  3 ++
 .../mytracks/io/file/MockTrackWriter.java     |  1 +
 3 files changed, 21 insertions(+), 17 deletions(-)

diff --git a/MyTracks/src/com/google/android/apps/mytracks/WriteProgressController.java b/MyTracks/src/com/google/android/apps/mytracks/WriteProgressController.java
index f5e0dcb28..514f2fc02 100644
--- a/MyTracks/src/com/google/android/apps/mytracks/WriteProgressController.java
+++ b/MyTracks/src/com/google/android/apps/mytracks/WriteProgressController.java
@@ -88,26 +88,26 @@ class WriteProgressController {
   }
 
   private final TrackWriter.OnCompletionListener writerCompleteListener =
-    new TrackWriter.OnCompletionListener() {
-      @Override
-      public void onComplete() {
-        DialogManager.dismissDialogSafely(activity, dialog);
+      new TrackWriter.OnCompletionListener() {
+        @Override
+        public void onComplete() {
+          DialogManager.dismissDialogSafely(activity, dialog);
 
-        if (onCompletionListener != null) {
-          onCompletionListener.onComplete(writer);
+          if (onCompletionListener != null) {
+            onCompletionListener.onComplete(writer);
+          }
         }
-      }
-    };
+      };
 
   private final TrackWriter.OnWriteListener writerWriteListener =
-    new TrackWriter.OnWriteListener() {
-      @Override
-      public void onWrite(int number, int max) {
-        if (number % 500 == 0) {
-          dialog.setIndeterminate(false);
-          dialog.setMax(max);
-          dialog.setProgress(Math.min(number, max));
+      new TrackWriter.OnWriteListener() {
+        @Override
+        public void onWrite(int number, int max) {
+          if (number % 500 == 0) {
+            dialog.setIndeterminate(false);
+            dialog.setMax(max);
+            dialog.setProgress(Math.min(number, max));
+          }
         }
-      }
-    };
+      };
 }
diff --git a/MyTracksTest/src/com/google/android/apps/mytracks/WriteProgressControllerTest.java b/MyTracksTest/src/com/google/android/apps/mytracks/WriteProgressControllerTest.java
index 17e348eeb..baab083d0 100644
--- a/MyTracksTest/src/com/google/android/apps/mytracks/WriteProgressControllerTest.java
+++ b/MyTracksTest/src/com/google/android/apps/mytracks/WriteProgressControllerTest.java
@@ -24,6 +24,9 @@ import android.test.ActivityInstrumentationTestCase2;
 import java.util.concurrent.Semaphore;
 import java.util.concurrent.atomic.AtomicReference;
 
+/**
+ * @author Matthew Simmons
+ */
 public class WriteProgressControllerTest extends ActivityInstrumentationTestCase2<MyTracks> {
   public WriteProgressControllerTest() {
     super(MyTracks.class);
diff --git a/MyTracksTest/src/com/google/android/apps/mytracks/io/file/MockTrackWriter.java b/MyTracksTest/src/com/google/android/apps/mytracks/io/file/MockTrackWriter.java
index 686a5a5c6..8de892d93 100644
--- a/MyTracksTest/src/com/google/android/apps/mytracks/io/file/MockTrackWriter.java
+++ b/MyTracksTest/src/com/google/android/apps/mytracks/io/file/MockTrackWriter.java
@@ -41,6 +41,7 @@ public class MockTrackWriter implements TrackWriter {
 
   @Override
   public void setDirectory(File directory) {
+    throw new RuntimeException("not implemented");
   }
 
   @Override