Cleanup using AndroidStudio code analyzer.

Moved to iterator for loops for ChartView and ChartFragment.

src/main/java/de/dennisguse/opentracks/content/TrackDataHub.java

@@ -222,18 +222,6 @@ public class TrackDataHub implements SharedPreferences.OnSharedPreferenceChangeL
         });
     }
 
-    /**
-     * Reloads data for a {@link TrackDataListener}.
-     */
-    public void reloadDataForListener(final TrackDataListener trackDataListener) {
-        runInHandlerThread(new Runnable() {
-            @Override
-            public void run() {
-                loadDataForListener(trackDataListener);
-            }
-        });
-    }
-
     /**
      * Returns true if the selected track is recording.
      */

src/main/java/de/dennisguse/opentracks/content/provider/ContentProviderUtils.java

@@ -69,7 +69,7 @@ public class ContentProviderUtils {
      * Maximum number of waypoints that will be loaded at one time.
      */
     public static final int MAX_LOADED_WAYPOINTS_POINTS = 10000;
-    public static final String ID_SEPARATOR = ",";
+    private static final String ID_SEPARATOR = ",";
 
     private final IContentResolver contentResolver;
     private int defaultCursorBatchSize = 2000;

src/main/java/de/dennisguse/opentracks/content/provider/CustomSQLiteOpenHelper.java

@@ -15,14 +15,14 @@ import de.dennisguse.opentracks.content.data.WaypointsColumns;
  * Database helper for creating and upgrading the database.
  */
 @VisibleForTesting
-public class CustomSQLiteOpenHelper extends SQLiteOpenHelper {
+class CustomSQLiteOpenHelper extends SQLiteOpenHelper {
 
     @VisibleForTesting
-    static final int DATABASE_VERSION = 25;
+    private static final int DATABASE_VERSION = 25;
     private static final String TAG = CustomSQLiteOpenHelper.class.getSimpleName();
 
     @VisibleForTesting
-    static final String DATABASE_NAME = "database.db";
+    private static final String DATABASE_NAME = "database.db";
 
 
     public CustomSQLiteOpenHelper(Context context) {

src/main/java/de/dennisguse/opentracks/content/provider/ShareContentProvider.java

@@ -43,7 +43,7 @@ public class ShareContentProvider extends CustomContentProvider implements ICont
 
     private static final String[] COLUMNS = {OpenableColumns.DISPLAY_NAME, OpenableColumns.SIZE};
 
-    public static final String TAG = ShareContentProvider.class.getSimpleName();
+    private static final String TAG = ShareContentProvider.class.getSimpleName();
 
     private static final int URI_GPX = 0;
     private static final int URI_KML_ONLY = 1;
@@ -90,7 +90,7 @@ public class ShareContentProvider extends CustomContentProvider implements ICont
         return new Pair<>(uri, mime);
     }
 
-    protected static long[] parseURI(Uri uri) {
+    static long[] parseURI(Uri uri) {
         List<String> uriPaths = uri.getPathSegments();
         if (uriPaths == null || uriPaths.size() < 2) {
             Log.d(TAG, "URI does not contain any trackIds.");
@@ -151,7 +151,7 @@ public class ShareContentProvider extends CustomContentProvider implements ICont
     }
 
     @Nullable
-    public static String getTypeMime(@NonNull Uri uri) {
+    private static String getTypeMime(@NonNull Uri uri) {
         return getTrackFileFormat(uri).getMimeType();
     }