Commit Graph

45 Commits

Author SHA1 Message Date
Sandor Dornbush a0d42c8b59 Add basic tests to the DialogManager. 2010-11-08 11:28:39 -08:00
Bartlomiej Niechwiej a21663da61 Fix a NPE (replace MyTracks.getInstance() with the parent activity). 2010-11-06 23:37:14 -07:00
Bartlomiej Niechwiej 67a0382942 Fixed another bug reported by users (division by zero).
The issue was most likely related to a race condition (selectedTrackId can change in the UI thread, while the track is being processed in the handler thread).

Simulated slow drawing by adding 50ms, works pretty cool :)
2010-11-06 00:31:52 -07:00
Bartlomiej Niechwiej f5c2467d01 Fix StringIndexOutOfBoundsException in ChartsExtendedEncoder.getEncodedValue().
Found in user error reports (3rd top issue):
java.lang.StringIndexOutOfBoundsException
at com.google.android.apps.mytracks.util.ChartsExtendedEncoder.getEncodedValue(ChartsExtendedEncoder.java:45)
at com.google.android.apps.mytracks.util.ChartURLGenerator.getChartUrl(ChartURLGenerator.java:162)
at com.google.android.apps.mytracks.util.ChartURLGenerator.getChartUrl(ChartURLGenerator.java:60)
at com.google.android.apps.mytracks.util.StringUtils.generateTrackDescription(StringUtils.java:366)
at com.google.android.apps.mytracks.io.SendToMyMaps.doUpload(SendToMyMaps.java:581)
at com.google.android.apps.mytracks.io.SendToMyMaps.access$10(SendToMyMaps.java:538)
at com.google.android.apps.mytracks.io.SendToMyMaps$5.run(SendToMyMaps.java:517)
at android.os.Handler.handleCallback(Handler.java:587)
at android.os.Handler.dispatchMessage(Handler.java:92)
at android.os.Looper.loop(Looper.java:123)
at android.os.HandlerThread.run(HandlerThread.java:60)
2010-11-05 22:52:42 -07:00
Sandor Dornbush edf439f301 Merge Bart's bug fixes and tests. 2010-11-05 15:37:20 -07:00
Sandor Dornbush 2245563250 Fix broken build. 2010-11-05 14:51:06 -07:00
Bartlomiej Niechwiej 89cae2e7c9 Fix a regression related refactoring recordingTrackId management.
In particular:
1) Add a workaround to {start/end}Recording to update recordingTrackId to trigger a notification
2) Add a bunch of unit tests for MyTracks
3) Clear minor style issues in a few classes
2010-11-04 23:32:31 -07:00
Sandor Dornbush 26c381a4c4 Address Bart's comments and more dialog clean up. 2010-11-04 17:44:08 -07:00
Sandor Dornbush 4bc5aa050c Add tests for the TempFileCleaner. 2010-11-04 17:07:59 -07:00
Rodrigo Damazio cd44b0d180 Merging Sandor's changes. 2010-11-03 21:08:50 -02:00
Rodrigo Damazio 59ee91ca5d Merging my own changes. 2010-11-03 20:59:32 -02:00
Rodrigo Damazio 93d242c05f Merging Matthew's first head. 2010-11-03 20:42:35 -02:00
Rodrigo Damazio 4bbb6591e3 Merging Bart's changes. 2010-11-03 19:59:35 -02:00
Sandor Dornbush 7df8025f6a Merge with head and address comments. 2010-11-03 12:53:12 -07:00
Bartlomiej Niechwiej f19c52f40e Addressed Sandor's comments. 2010-11-02 08:31:21 -07:00
Rodrigo Damazio 28042a8cc9 Adding tests to voice announcements.
If anyone asks, I didn't write this code.
2010-11-02 02:19:43 -02:00
Matthew Simmons b2907226bf Code review comments 2010-11-01 15:21:33 -04:00
Matthew Simmons a2f46821f5 Fix author line 2010-11-01 14:32:19 -04:00
Matthew Simmons b7385cd4cc Combine b2f2f9e9e9 and 8774b3663c
Allow users to choose the default track name policy.  By default, we'll switch
to a new, timestamp-based name.  If they change the pref, they'll get the
old-style 'track n' style.
2010-11-01 13:48:33 -04:00
Rodrigo Damazio 3c4a921f9a Addressing review suggestions 2010-11-01 05:27:04 -02:00
Rodrigo Damazio d04b333126 Merging 2010-11-01 02:05:42 -02:00
Bartlomiej Niechwiej a0f090a83a Bug fixing and refactoring:
1) Make sure no one but service changes recordingTrackId (which is owned by it)
2) Cache sharedPreferences
3) Clear recordingTrackId if it doesn't correspond to a valid track or the service is not recording
4) More unit tests
2010-10-28 22:49:01 -07:00
Bartlomiej Niechwiej dc8ee5943c Merge with c10bc69662325f00bf166b783cc3ab1b78ccfed9 2010-10-28 20:48:01 -07:00
Sandor Dornbush 224c0d759f Minor fixes noticed on first review. 2010-10-28 17:13:59 -07:00
Sandor Dornbush ffcaca2db1 Refactor a few 100 lines of code out of the main Activity. 2010-10-28 17:08:59 -07:00
Sandor Dornbush 53b6b6deca Add tests to ChartValueSeries.
Also other minor fixes.
2010-10-28 14:43:31 -07:00
Rodrigo Damazio 26f47a50d0 Fixing issue 34: Not making voice announcements during a phone call 2010-10-27 03:07:17 -02:00
Bartlomiej Niechwiej 54d517363d Merge with e34329d612571554d6424d5941dfad57e35612a0 2010-10-26 19:39:46 -07:00
Matthew Simmons f84877a4fc Issue 86: Remove - from the list of disallowed characters for filenames. 2010-10-25 14:59:20 -04:00
Matthew Simmons 261fb62e24 Changed the default new track name from "track %d" to "date time", where "date"
is a short, locale-aware version of the track's start date, and "time" is the
track's start time.
2010-10-25 14:15:16 -04:00
Rodrigo Damazio 9030917c14 Merging Bart's changes. 2010-10-22 15:34:24 -02:00
Bartlomiej Niechwiej 9905def352 Terminate tracker update thread on destroy. 2010-10-22 10:14:36 -07:00
Bartlomiej Niechwiej a3793aa92b Minor updates. 2010-10-22 10:00:15 -07:00
Rodrigo Damazio 352fc26f7e Fixing tests 2010-10-14 23:25:42 -03:00
Rodrigo Damazio 44afa1623e Making locations be reused when writing tracks. 2010-10-14 21:06:59 -03:00
Rodrigo Damazio 14acafabfc Getting rid of TrackBuffer. 2010-10-14 20:42:02 -03:00
Rodrigo Damazio 773af58d03 Fixing issue 190 (third step: reordering methods in execution order - no other changes) 2010-10-14 18:44:55 -03:00
Rodrigo Damazio 352b851e9c Fixing issue 190 (second step: refactoring mymaps uploading) 2010-10-14 18:35:51 -03:00
Bartlomiej Niechwiej b70e001206 Addressed Rodrigo's comments. 2010-10-13 21:58:26 -07:00
Rodrigo Damazio a741bb4d55 Fixing issue 190 (first step: dirty hack) 2010-10-13 22:03:31 -03:00
Rodrigo Damazio 24adee3d54 Addressing review suggestions and adding tests. 2010-10-13 21:53:16 -03:00
Bartlomiej Niechwiej 09203ffb95 Improved test coverage and minor refactoring/improvements. 2010-10-13 12:29:00 -07:00
Bartlomiej Niechwiej e94338f4c6 Fix a drawing lag during track recording.
For a track with ~2,500 points, the average drawign would take ~30-50ms, now it takes about 20ms (21ms if software clipping is enabled).

Removed all possible congestion points by introducing a blocking queue.

This change includes many fixes, including:
1) Major refactoring and clean up of the overlay, sped up drawing by a factor of 2x
2) Disable software clipping as it was slower by about 5% than w/o clipping and would trigger a bug related to map view spanning
3) Add waypoints synchronization  and fixed a bug related to skipping the first wpt
4) Add a simple unit test
2010-10-11 21:55:12 -07:00
Rodrigo Damazio dd9dd8ee81 Refactoring API level detection. 2010-10-11 22:28:02 -03:00
Rodrigo Damazio 50fcd67085 Releasing version 1.0.19 (bugfix release) 2010-10-07 21:21:23 -03:00