From 51a0576ce0dc2afa20865f84426e85ae5e96f1c4 Mon Sep 17 00:00:00 2001 From: gavine99 Date: Wed, 12 Feb 2025 14:35:17 +1100 Subject: [PATCH 1/3] new setting to show/hide new stt button - defaults to 'show' to enable discovery by user. move compose stt feature from double-tap compose entry box to new button on compose activity --- .../java/com/moez/QKSMS/util/Preferences.kt | 1 + .../QKSMS/feature/compose/ComposeActivity.kt | 92 ++++++++----------- .../moez/QKSMS/feature/compose/ComposeView.kt | 5 +- .../QKSMS/feature/compose/ComposeViewModel.kt | 5 + .../feature/settings/SettingsController.kt | 2 + .../feature/settings/SettingsPresenter.kt | 7 +- .../QKSMS/feature/settings/SettingsState.kt | 1 + .../res/drawable/ic_speech_to_text_black.xml | 11 +++ .../src/main/res/layout/compose_activity.xml | 38 +++++++- .../main/res/layout/settings_controller.xml | 8 ++ presentation/src/main/res/values/strings.xml | 1 + 11 files changed, 112 insertions(+), 59 deletions(-) create mode 100644 presentation/src/main/res/drawable/ic_speech_to_text_black.xml diff --git a/domain/src/main/java/com/moez/QKSMS/util/Preferences.kt b/domain/src/main/java/com/moez/QKSMS/util/Preferences.kt index ce10166d..eb102d3b 100644 --- a/domain/src/main/java/com/moez/QKSMS/util/Preferences.kt +++ b/domain/src/main/java/com/moez/QKSMS/util/Preferences.kt @@ -108,6 +108,7 @@ class Preferences @Inject constructor( val black = rxPrefs.getBoolean("black", false) val autoColor = rxPrefs.getBoolean("autoColor", true) val systemFont = rxPrefs.getBoolean("systemFont", false) + val showStt = rxPrefs.getBoolean("showStt", true) val textSize = rxPrefs.getInteger("textSize", TEXT_SIZE_NORMAL) val blockingManager = rxPrefs.getInteger("blockingManager", BLOCKING_MANAGER_QKSMS) val drop = rxPrefs.getBoolean("drop", false) diff --git a/presentation/src/main/java/com/moez/QKSMS/feature/compose/ComposeActivity.kt b/presentation/src/main/java/com/moez/QKSMS/feature/compose/ComposeActivity.kt index 7179d255..ba82b7dd 100644 --- a/presentation/src/main/java/com/moez/QKSMS/feature/compose/ComposeActivity.kt +++ b/presentation/src/main/java/com/moez/QKSMS/feature/compose/ComposeActivity.kt @@ -108,6 +108,9 @@ import kotlinx.android.synthetic.main.compose_activity.sendAsGroupBackground import kotlinx.android.synthetic.main.compose_activity.sendAsGroupSwitch import kotlinx.android.synthetic.main.compose_activity.sim import kotlinx.android.synthetic.main.compose_activity.simIndex +import kotlinx.android.synthetic.main.compose_activity.speechToTextFrame +import kotlinx.android.synthetic.main.compose_activity.speechToTextIcon +import kotlinx.android.synthetic.main.compose_activity.speechToTextIconBorder import kotlinx.android.synthetic.main.compose_activity.toolbarSubtitle import kotlinx.android.synthetic.main.compose_activity.toolbarTitle import kotlinx.android.synthetic.main.main_activity.toolbar @@ -160,31 +163,12 @@ class ComposeActivity : QkThemedActivity(), ComposeView { override val backPressedIntent: Subject = PublishSubject.create() override val confirmDeleteIntent: Subject> = PublishSubject.create() override val messageLinkAskIntent: Subject by lazy { messageAdapter.messageLinkClicks } + override val speechRecogniserIntent by lazy { speechToTextIconBorder.clicks() } private val viewModel by lazy { ViewModelProviders.of(this, viewModelFactory)[ComposeViewModel::class.java] } private var cameraDestination: Uri? = null - private val speechResultLauncher = registerForActivityResult(ActivityResultContracts.StartActivityForResult()) { result -> - if (result.resultCode != Activity.RESULT_OK) - return@registerForActivityResult - - // check returned results are good - val match = result.data?.getStringArrayListExtra(RecognizerIntent.EXTRA_RESULTS) - if ((match === null) || (match.size < 1) || (match[0].isNullOrEmpty())) - return@registerForActivityResult - - // get the edit text view - val message = findViewById(R.id.message) - if (message === null) - return@registerForActivityResult - - // populate message box with data returned by STT, set cursor to end, and focus - message.append(match[0]) - message.setSelection(message.text.length) - message.requestFocus() - } - override fun onCreate(savedInstanceState: Bundle?) { AndroidInjection.inject(this) super.onCreate(savedInstanceState) @@ -215,46 +199,13 @@ class ComposeActivity : QkThemedActivity(), ComposeView { .doOnNext { loading.setTint(it.theme) } .doOnNext { attach.setBackgroundTint(it.theme) } .doOnNext { attach.setTint(it.textPrimary) } + .doOnNext { speechToTextIconBorder.setBackgroundTint(it.theme) } + .doOnNext { speechToTextIcon.setBackgroundTint(it.textPrimary) } + .doOnNext { speechToTextIcon.setTint(it.theme) } .doOnNext { messageAdapter.theme = it } .autoDisposable(scope()) .subscribe() - message.setOnTouchListener(object : OnTouchListener { - private val gestureDetector = - GestureDetector(this@ComposeActivity, object : SimpleOnGestureListener() { - private var lastUpEvent: MotionEvent? = null - - override fun onDoubleTap(e: MotionEvent): Boolean { - val speechRecognizerIntent = Intent(RecognizerIntent.ACTION_RECOGNIZE_SPEECH) - .putExtra( - RecognizerIntent.EXTRA_LANGUAGE_MODEL, - RecognizerIntent.LANGUAGE_MODEL_FREE_FORM - ) - // include if want a custom message that the STT can (optionally) display .putExtra(RecognizerIntent.EXTRA_PROMPT, "Speak your message") - speechResultLauncher.launch(speechRecognizerIntent) - return true - } - - override fun onSingleTapConfirmed(e: MotionEvent): Boolean { - if (lastUpEvent !== null) { - message.onTouchEvent(lastUpEvent) - lastUpEvent?.recycle() - lastUpEvent = null - } - return true - } - - override fun onSingleTapUp(e: MotionEvent): Boolean { - lastUpEvent = MotionEvent.obtain(e) - return true // don't show soft keyboard on this event - } - }) - - override fun onTouch(v: View, e: MotionEvent): Boolean { - return gestureDetector.onTouchEvent(e) - } - }) - // context menu registration for message parts messagePartContextMenuRegistrar .mapNotNull { it } @@ -375,6 +326,8 @@ class ComposeActivity : QkThemedActivity(), ComposeView { // if scheduling mode is set, show schedule dialog if (state.scheduling) scheduleAction.onNext(true) + + speechToTextFrame.isVisible = (prefs.showStt.get()) } override fun clearSelection() = messageAdapter.clearSelection() @@ -460,6 +413,18 @@ class ComposeActivity : QkThemedActivity(), ComposeView { startActivityForResult(intent, ComposeView.SelectContactRequestCode) } + override fun startSpeechRecognition() { + startActivityForResult( + Intent(RecognizerIntent.ACTION_RECOGNIZE_SPEECH).putExtra( + RecognizerIntent.EXTRA_LANGUAGE_MODEL, + RecognizerIntent.LANGUAGE_MODEL_FREE_FORM + ), + // include below if want a custom message that the STT can (optionally) display + // .putExtra(RecognizerIntent.EXTRA_PROMPT, "Speak your message") + ComposeView.SpeechRecognitionRequestCode + ) + } + override fun themeChanged() { messageList.scrapViews() } @@ -576,6 +541,21 @@ class ComposeActivity : QkThemedActivity(), ComposeView { data?.data?.let(contactSelectedIntent::onNext) } + ComposeView.SpeechRecognitionRequestCode -> { + // check returned results are good + val match = data?.getStringArrayListExtra(RecognizerIntent.EXTRA_RESULTS) + if ((match !== null) && (match.size > 0) && (!match[0].isNullOrEmpty())) { + // get the edit text view + val messageEditBox = findViewById(R.id.message) + if (messageEditBox !== null) { + // populate message box with data returned by STT, set cursor to end, and focus + messageEditBox.append(match[0]) + messageEditBox.setSelection(messageEditBox.text.length) + messageEditBox.requestFocus() + } + } + } + else -> super.onActivityResult(requestCode, resultCode, data) } } diff --git a/presentation/src/main/java/com/moez/QKSMS/feature/compose/ComposeView.kt b/presentation/src/main/java/com/moez/QKSMS/feature/compose/ComposeView.kt index 64f5669c..ef537990 100644 --- a/presentation/src/main/java/com/moez/QKSMS/feature/compose/ComposeView.kt +++ b/presentation/src/main/java/com/moez/QKSMS/feature/compose/ComposeView.kt @@ -34,8 +34,9 @@ interface ComposeView : QkView { companion object { const val SelectContactRequestCode = 0 const val TakePhotoRequestCode = 1 - const val AttachAFileRequestCode = 4 const val AttachContactRequestCode = 3 + const val AttachAFileRequestCode = 4 + const val SpeechRecognitionRequestCode = 5 const val CameraDestinationKey = "camera_destination" } @@ -73,6 +74,7 @@ interface ComposeView : QkView { val backPressedIntent: Observable val confirmDeleteIntent: Observable> val messageLinkAskIntent: Observable + val speechRecogniserIntent: Observable<*> fun clearSelection() fun toggleSelectAll() @@ -93,5 +95,6 @@ interface ComposeView : QkView { fun scrollToMessage(id: Long) fun showQksmsPlusSnackbar(@StringRes message: Int) fun showDeleteDialog( messages: List) + fun startSpeechRecognition() } \ No newline at end of file diff --git a/presentation/src/main/java/com/moez/QKSMS/feature/compose/ComposeViewModel.kt b/presentation/src/main/java/com/moez/QKSMS/feature/compose/ComposeViewModel.kt index 6763f183..9b594ec7 100644 --- a/presentation/src/main/java/com/moez/QKSMS/feature/compose/ComposeViewModel.kt +++ b/presentation/src/main/java/com/moez/QKSMS/feature/compose/ComposeViewModel.kt @@ -763,6 +763,11 @@ class ComposeViewModel @Inject constructor( .autoDisposable(view.scope()) .subscribe() + // speech recognition button clicked + view.speechRecogniserIntent + .autoDisposable(view.scope()) + .subscribe { view.startSpeechRecognition() } + // Send a message when the send button is clicked, and disable editing mode if it's enabled view.sendIntent .withLatestFrom(view.textChangedIntent) { _, body -> body.toString() } diff --git a/presentation/src/main/java/com/moez/QKSMS/feature/settings/SettingsController.kt b/presentation/src/main/java/com/moez/QKSMS/feature/settings/SettingsController.kt index 4c302dfe..54defd2d 100644 --- a/presentation/src/main/java/com/moez/QKSMS/feature/settings/SettingsController.kt +++ b/presentation/src/main/java/com/moez/QKSMS/feature/settings/SettingsController.kt @@ -184,6 +184,8 @@ class SettingsController : QkController newState { copy(autoColor = autoColor) } } disposables += prefs.systemFont.asObservable() - .subscribe { enabled -> newState { copy(systemFontEnabled = enabled) } } + .subscribe { enabled -> newState { copy(systemFontEnabled = enabled) } } + + disposables += prefs.showStt.asObservable() + .subscribe { enabled -> newState { copy(showStt = enabled) } } disposables += prefs.unicode.asObservable() .subscribe { enabled -> newState { copy(stripUnicodeEnabled = enabled) } } @@ -207,6 +210,8 @@ class SettingsPresenter @Inject constructor( R.id.systemFont -> prefs.systemFont.set(!prefs.systemFont.get()) + R.id.showStt -> prefs.showStt.set(!prefs.showStt.get()) + R.id.unicode -> prefs.unicode.set(!prefs.unicode.get()) R.id.mobileOnly -> prefs.mobileOnly.set(!prefs.mobileOnly.get()) diff --git a/presentation/src/main/java/com/moez/QKSMS/feature/settings/SettingsState.kt b/presentation/src/main/java/com/moez/QKSMS/feature/settings/SettingsState.kt index c87522bc..7e766ca0 100644 --- a/presentation/src/main/java/com/moez/QKSMS/feature/settings/SettingsState.kt +++ b/presentation/src/main/java/com/moez/QKSMS/feature/settings/SettingsState.kt @@ -39,6 +39,7 @@ data class SettingsState( val textSizeSummary: String = "", val textSizeId: Int = Preferences.TEXT_SIZE_NORMAL, val systemFontEnabled: Boolean = false, + val showStt: Boolean = true, val splitSmsEnabled: Boolean = false, val stripUnicodeEnabled: Boolean = false, val mobileOnly: Boolean = false, diff --git a/presentation/src/main/res/drawable/ic_speech_to_text_black.xml b/presentation/src/main/res/drawable/ic_speech_to_text_black.xml new file mode 100644 index 00000000..48de1c61 --- /dev/null +++ b/presentation/src/main/res/drawable/ic_speech_to_text_black.xml @@ -0,0 +1,11 @@ + + + + + + \ No newline at end of file diff --git a/presentation/src/main/res/layout/compose_activity.xml b/presentation/src/main/res/layout/compose_activity.xml index 95f8b1e4..ff30a5d3 100644 --- a/presentation/src/main/res/layout/compose_activity.xml +++ b/presentation/src/main/res/layout/compose_activity.xml @@ -27,6 +27,41 @@ android:orientation="vertical" tools:context="dev.octoshrimpy.quik.feature.compose.ComposeActivity"> + + + + + + + + + tools:listitem="@layout/message_list_item_in" + tools:visibility="invisible" /> + + Automatic contact colors Font size Use system font + Show the speech to text button Automatic emoji Notifications Tap to customize From 3e9d7804353b55eb4590692dc4e11ef3e8f62551 Mon Sep 17 00:00:00 2001 From: gavine99 Date: Wed, 12 Feb 2025 14:36:05 +1100 Subject: [PATCH 2/3] change tools view to 'on' for messageList --- presentation/src/main/res/layout/compose_activity.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/presentation/src/main/res/layout/compose_activity.xml b/presentation/src/main/res/layout/compose_activity.xml index ff30a5d3..fb19ed9a 100644 --- a/presentation/src/main/res/layout/compose_activity.xml +++ b/presentation/src/main/res/layout/compose_activity.xml @@ -74,8 +74,7 @@ app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toBottomOf="@id/sendAsGroupBackground" app:stackFromEnd="true" - tools:listitem="@layout/message_list_item_in" - tools:visibility="invisible" /> + tools:listitem="@layout/message_list_item_in" /> Date: Sat, 15 Feb 2025 11:01:47 +1100 Subject: [PATCH 3/3] changes to make the speed-to-text button drag-and-dropable --- .../java/com/moez/QKSMS/util/Preferences.kt | 2 + .../QKSMS/feature/compose/ComposeActivity.kt | 59 ++++++++++++++++--- .../feature/settings/SettingsPresenter.kt | 6 +- .../QKSMS/feature/settings/SettingsState.kt | 2 + presentation/src/main/res/values/strings.xml | 4 +- 5 files changed, 64 insertions(+), 9 deletions(-) diff --git a/domain/src/main/java/com/moez/QKSMS/util/Preferences.kt b/domain/src/main/java/com/moez/QKSMS/util/Preferences.kt index eb102d3b..df81490f 100644 --- a/domain/src/main/java/com/moez/QKSMS/util/Preferences.kt +++ b/domain/src/main/java/com/moez/QKSMS/util/Preferences.kt @@ -109,6 +109,8 @@ class Preferences @Inject constructor( val autoColor = rxPrefs.getBoolean("autoColor", true) val systemFont = rxPrefs.getBoolean("systemFont", false) val showStt = rxPrefs.getBoolean("showStt", true) + val showSttOffsetX = rxPrefs.getFloat("showSttOffsetX", Float.MIN_VALUE) + val showSttOffsetY = rxPrefs.getFloat("showSttOffsetY", Float.MIN_VALUE) val textSize = rxPrefs.getInteger("textSize", TEXT_SIZE_NORMAL) val blockingManager = rxPrefs.getInteger("blockingManager", BLOCKING_MANAGER_QKSMS) val drop = rxPrefs.getBoolean("drop", false) diff --git a/presentation/src/main/java/com/moez/QKSMS/feature/compose/ComposeActivity.kt b/presentation/src/main/java/com/moez/QKSMS/feature/compose/ComposeActivity.kt index ba82b7dd..5790e473 100644 --- a/presentation/src/main/java/com/moez/QKSMS/feature/compose/ComposeActivity.kt +++ b/presentation/src/main/java/com/moez/QKSMS/feature/compose/ComposeActivity.kt @@ -32,14 +32,13 @@ import android.provider.MediaStore import android.speech.RecognizerIntent import android.text.format.DateFormat import android.view.ContextMenu -import android.view.GestureDetector -import android.view.GestureDetector.SimpleOnGestureListener +import android.view.DragEvent.ACTION_DRAG_ENDED +import android.view.DragEvent.ACTION_DRAG_EXITED +import android.view.DragEvent.ACTION_DROP import android.view.Menu import android.view.MenuItem -import android.view.MotionEvent import android.view.View -import android.view.View.OnTouchListener -import androidx.activity.result.contract.ActivityResultContracts +import android.widget.Toast import androidx.appcompat.app.AlertDialog import androidx.constraintlayout.widget.ConstraintLayout import androidx.constraintlayout.widget.ConstraintSet @@ -62,6 +61,7 @@ import dev.octoshrimpy.quik.common.base.QkThemedActivity import dev.octoshrimpy.quik.common.util.DateFormatter import dev.octoshrimpy.quik.common.util.extensions.autoScrollToStart import dev.octoshrimpy.quik.common.util.extensions.hideKeyboard +import dev.octoshrimpy.quik.common.util.extensions.makeToast import dev.octoshrimpy.quik.common.util.extensions.scrapViews import dev.octoshrimpy.quik.common.util.extensions.setBackgroundTint import dev.octoshrimpy.quik.common.util.extensions.setTint @@ -163,7 +163,7 @@ class ComposeActivity : QkThemedActivity(), ComposeView { override val backPressedIntent: Subject = PublishSubject.create() override val confirmDeleteIntent: Subject> = PublishSubject.create() override val messageLinkAskIntent: Subject by lazy { messageAdapter.messageLinkClicks } - override val speechRecogniserIntent by lazy { speechToTextIconBorder.clicks() } + override val speechRecogniserIntent by lazy { speechToTextIcon.clicks() } private val viewModel by lazy { ViewModelProviders.of(this, viewModelFactory)[ComposeViewModel::class.java] } @@ -212,12 +212,46 @@ class ComposeActivity : QkThemedActivity(), ComposeView { .autoDisposable(scope()) .subscribe { registerForContextMenu(it) } + // drag drop handlers for speech-to-text icon + speechToTextIcon.setOnLongClickListener { + it.startDragAndDrop(null, View.DragShadowBuilder(speechToTextFrame), null, 0) + speechToTextFrame.isVisible = false + + contentView.setOnDragListener { _, event -> + when (event.action) { + ACTION_DROP -> { + speechToTextFrame.x = (event.x - (speechToTextFrame.width / 2)) + speechToTextFrame.y =(event.y - (speechToTextFrame.height / 2)) + + // get offset from root view as a percentage of root view for saving + prefs.showSttOffsetX.set((speechToTextFrame.x - contentView.x) / contentView.width) + prefs.showSttOffsetY.set((speechToTextFrame.y - contentView.y) / contentView.height) + } + ACTION_DRAG_ENDED, ACTION_DRAG_EXITED -> { + speechToTextFrame.isVisible = true + } + } + true + } + true + } + window.callback = ComposeWindowCallback(window.callback, this) } override fun onStart() { super.onStart() activityVisibleIntent.onNext(true) + + // if first time stt icon is shown (since setting reset), pop up an instruction toast + if (prefs.showStt.get() && + (prefs.showSttOffsetX.get() == Float.MIN_VALUE) && + (prefs.showSttOffsetX.get() == Float.MIN_VALUE)) { + makeToast(R.string.compose_toast_drag_stt, Toast.LENGTH_LONG) + // reset to new flag value that indicates 'not first time through, but not customised' + prefs.showSttOffsetX.set(Float.MAX_VALUE) + prefs.showSttOffsetY.set(Float.MAX_VALUE) + } } override fun onPause() { @@ -327,7 +361,18 @@ class ComposeActivity : QkThemedActivity(), ComposeView { if (state.scheduling) scheduleAction.onNext(true) - speechToTextFrame.isVisible = (prefs.showStt.get()) + if (prefs.showStt.get()) { + speechToTextFrame.isVisible = true + + var xPercent = prefs.showSttOffsetX.get() + var yPercent = prefs.showSttOffsetY.get() + + // if the stt icon has a custom position, move it + if ((xPercent != Float.MAX_VALUE) && (yPercent != Float.MAX_VALUE)) { + speechToTextFrame.x = (contentView.x + (xPercent * contentView.width)) + speechToTextFrame.y = (contentView.y + (yPercent * contentView.height)) + } + } } override fun clearSelection() = messageAdapter.clearSelection() diff --git a/presentation/src/main/java/com/moez/QKSMS/feature/settings/SettingsPresenter.kt b/presentation/src/main/java/com/moez/QKSMS/feature/settings/SettingsPresenter.kt index daf8a8b7..15e0f580 100644 --- a/presentation/src/main/java/com/moez/QKSMS/feature/settings/SettingsPresenter.kt +++ b/presentation/src/main/java/com/moez/QKSMS/feature/settings/SettingsPresenter.kt @@ -210,7 +210,11 @@ class SettingsPresenter @Inject constructor( R.id.systemFont -> prefs.systemFont.set(!prefs.systemFont.get()) - R.id.showStt -> prefs.showStt.set(!prefs.showStt.get()) + R.id.showStt -> { + prefs.showStt.set(!prefs.showStt.get()) + prefs.showSttOffsetX.set(Float.MIN_VALUE) + prefs.showSttOffsetY.set(Float.MIN_VALUE) + } R.id.unicode -> prefs.unicode.set(!prefs.unicode.get()) diff --git a/presentation/src/main/java/com/moez/QKSMS/feature/settings/SettingsState.kt b/presentation/src/main/java/com/moez/QKSMS/feature/settings/SettingsState.kt index 7e766ca0..0b8b270d 100644 --- a/presentation/src/main/java/com/moez/QKSMS/feature/settings/SettingsState.kt +++ b/presentation/src/main/java/com/moez/QKSMS/feature/settings/SettingsState.kt @@ -40,6 +40,8 @@ data class SettingsState( val textSizeId: Int = Preferences.TEXT_SIZE_NORMAL, val systemFontEnabled: Boolean = false, val showStt: Boolean = true, + val showSttOffsetX: Float = Float.MIN_VALUE, + val showSttOffsetY: Float = Float.MAX_VALUE, val splitSmsEnabled: Boolean = false, val stripUnicodeEnabled: Boolean = false, val mobileOnly: Boolean = false, diff --git a/presentation/src/main/res/values/strings.xml b/presentation/src/main/res/values/strings.xml index a482146e..d7371aaa 100644 --- a/presentation/src/main/res/values/strings.xml +++ b/presentation/src/main/res/values/strings.xml @@ -161,6 +161,8 @@ Message item Attachment + Move the speech-to-text button anywhere you like + Sending… Delivered %s Failed to send. Tap to try again @@ -240,7 +242,7 @@ Automatic contact colors Font size Use system font - Show the speech to text button + Show the speech-to-text button Automatic emoji Notifications Tap to customize