From cb6a83eacc6e6e8c9f2ba8fe15d800a2a0e72c01 Mon Sep 17 00:00:00 2001 From: gavine99 Date: Fri, 21 Feb 2025 11:47:46 +1100 Subject: [PATCH 1/3] improve attachment icon fetch from other apps. make compose box attachment text background a little less tranparent so icon 'pops' a bit more. make same icon text always black so it can be seen properly. --- domain/src/main/AndroidManifest.xml | 7 ++++ .../moez/QKSMS/extensions/UriExtensions.kt | 40 ++++++++++--------- .../res/layout/attachment_file_list_item.xml | 4 +- 3 files changed, 31 insertions(+), 20 deletions(-) diff --git a/domain/src/main/AndroidManifest.xml b/domain/src/main/AndroidManifest.xml index d70e29d4..71502bba 100644 --- a/domain/src/main/AndroidManifest.xml +++ b/domain/src/main/AndroidManifest.xml @@ -26,4 +26,11 @@ android:grantUriPermissions="true"> + + + + + + + diff --git a/domain/src/main/java/com/moez/QKSMS/extensions/UriExtensions.kt b/domain/src/main/java/com/moez/QKSMS/extensions/UriExtensions.kt index ba525a53..8a5c14d5 100644 --- a/domain/src/main/java/com/moez/QKSMS/extensions/UriExtensions.kt +++ b/domain/src/main/java/com/moez/QKSMS/extensions/UriExtensions.kt @@ -136,21 +136,25 @@ fun Uri.contactToVCard(context: Context): Uri = } fun Uri.getDefaultActivityIconForMimeType(context: Context): Drawable? = - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) { - context.packageManager - .queryIntentActivities( - Intent(Intent.ACTION_VIEW).setDataAndType(this, getType(context)), - PackageManager.ResolveInfoFlags.of( - PackageManager.MATCH_DEFAULT_ONLY.toLong() - ) - ).let { - if (it.size > 0) it[0].loadIcon(context.packageManager) - else null - } - } else { - context.packageManager - .resolveActivity( - Intent(Intent.ACTION_VIEW).setDataAndType(this, getType(context)), - PackageManager.MATCH_DEFAULT_ONLY) - ?.loadIcon(context.packageManager) - } + if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) { + context.packageManager + .queryIntentActivities( + Intent(Intent.ACTION_VIEW).setDataAndType(this, getType(context)), + PackageManager.ResolveInfoFlags.of( + PackageManager.MATCH_DEFAULT_ONLY.toLong() + ) + ).let { + if (it.size > 0) it[0].loadIcon(context.packageManager) + else null + } + } else { + // else, pre-tiramisu versions + context.packageManager + .queryIntentActivities( + Intent(Intent.ACTION_VIEW).setDataAndType(this, getType(context)), + PackageManager.MATCH_DEFAULT_ONLY + ).let { + if (it.size > 0) it[0].loadIcon(context.packageManager) + else null + } + } diff --git a/presentation/src/main/res/layout/attachment_file_list_item.xml b/presentation/src/main/res/layout/attachment_file_list_item.xml index b14e7827..0934d642 100644 --- a/presentation/src/main/res/layout/attachment_file_list_item.xml +++ b/presentation/src/main/res/layout/attachment_file_list_item.xml @@ -41,11 +41,11 @@ From f5da8cc5223f72e7e9fda474c2f4f32c077f967e Mon Sep 17 00:00:00 2001 From: gavine99 Date: Fri, 21 Feb 2025 12:00:23 +1100 Subject: [PATCH 2/3] use app:tint rather than android:tint in attachment_file_list_item layout --- presentation/src/main/res/layout/attachment_file_list_item.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/presentation/src/main/res/layout/attachment_file_list_item.xml b/presentation/src/main/res/layout/attachment_file_list_item.xml index 0934d642..1c5b4946 100644 --- a/presentation/src/main/res/layout/attachment_file_list_item.xml +++ b/presentation/src/main/res/layout/attachment_file_list_item.xml @@ -21,6 +21,7 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="wrap_content" android:layout_height="wrap_content" + xmlns:app="http://schemas.android.com/apk/res-auto" tools:background="?attr/bubbleColor"> + app:tint="?android:attr/textColorSecondary" /> \ No newline at end of file From d8ffcc52c5ce1ce9aa316c720aa03090860c4b12 Mon Sep 17 00:00:00 2001 From: gavine99 Date: Fri, 21 Feb 2025 12:21:08 +1100 Subject: [PATCH 3/3] same changes as last commits to icons on scheduled messages activity --- .../src/main/res/layout/scheduled_message_image_list_item.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/presentation/src/main/res/layout/scheduled_message_image_list_item.xml b/presentation/src/main/res/layout/scheduled_message_image_list_item.xml index 0f85dc04..55d6f4e7 100644 --- a/presentation/src/main/res/layout/scheduled_message_image_list_item.xml +++ b/presentation/src/main/res/layout/scheduled_message_image_list_item.xml @@ -34,11 +34,11 @@