changes to fix a bug that appeared to be a race condition between deleting mms parts (attachments) and removing the message data from the realm db when deleting a message. there could be attempts to access part data that no longer exists. protected where the access was being attempted.

This commit is contained in:
gavine99
2025-02-18 21:49:58 +11:00
parent ee71010a57
commit 31b38ec70e
@@ -35,6 +35,7 @@ import dev.octoshrimpy.quik.common.util.extensions.setBackgroundTint
import dev.octoshrimpy.quik.common.util.extensions.setTint import dev.octoshrimpy.quik.common.util.extensions.setTint
import dev.octoshrimpy.quik.common.widget.BubbleImageView import dev.octoshrimpy.quik.common.widget.BubbleImageView
import dev.octoshrimpy.quik.extensions.isAudio import dev.octoshrimpy.quik.extensions.isAudio
import dev.octoshrimpy.quik.extensions.resourceExists
import dev.octoshrimpy.quik.feature.compose.MessagesAdapter import dev.octoshrimpy.quik.feature.compose.MessagesAdapter
import dev.octoshrimpy.quik.model.Message import dev.octoshrimpy.quik.model.Message
import dev.octoshrimpy.quik.model.MmsPart import dev.octoshrimpy.quik.model.MmsPart
@@ -134,6 +135,7 @@ class AudioBinder @Inject constructor(colors: Colors, private val context: Conte
} }
} }
else -> { else -> {
if (part.getUri().resourceExists(context)) {
QkMediaPlayer.reset() // make sure reset before trying to (re-)use QkMediaPlayer.reset() // make sure reset before trying to (re-)use
QkMediaPlayer.setOnPreparedListener { QkMediaPlayer.setOnPreparedListener {
@@ -179,6 +181,7 @@ class AudioBinder @Inject constructor(colors: Colors, private val context: Conte
} }
} }
} }
}
// if this item is the active active audio item update the active view holder // if this item is the active active audio item update the active view holder
if (audioState.partId == part.id) if (audioState.partId == part.id)
@@ -234,6 +237,7 @@ class AudioBinder @Inject constructor(colors: Colors, private val context: Conte
} }
MediaMetadataRetriever().use { MediaMetadataRetriever().use {
if (part.getUri().resourceExists(context))
it.setDataSource(context, part.getUri()) it.setDataSource(context, part.getUri())
// metadata title // metadata title