From 3b74913269a16fd9530a57a5517ef0e7bbd7b2c0 Mon Sep 17 00:00:00 2001 From: Moez Bhatti Date: Tue, 9 Jan 2018 12:22:01 -0500 Subject: [PATCH] Improve layout for MMS images --- .../presentation/feature/compose/MessagesAdapter.kt | 4 ++++ qksms/src/main/res/layout/message_list_item_in.xml | 12 ++++++------ qksms/src/main/res/layout/message_list_item_out.xml | 12 ++++++------ 3 files changed, 16 insertions(+), 12 deletions(-) diff --git a/qksms/src/main/java/presentation/feature/compose/MessagesAdapter.kt b/qksms/src/main/java/presentation/feature/compose/MessagesAdapter.kt index f6e6b91c..ece568ee 100644 --- a/qksms/src/main/java/presentation/feature/compose/MessagesAdapter.kt +++ b/qksms/src/main/java/presentation/feature/compose/MessagesAdapter.kt @@ -83,6 +83,8 @@ class MessagesAdapter @Inject constructor( } } + view.messageBackground.clipToOutline = true + if (viewType != VIEWTYPE_ME) { view.avatar.contact = Contact().apply { numbers.add(PhoneNumber().apply { address = people[viewType] }) @@ -119,6 +121,8 @@ class MessagesAdapter @Inject constructor( bindGrouping(view, position) view.body.text = message.getText() + view.body.setVisible(message.isSms() || view.body.text.isNotBlank()) + view.timestamp.text = dateFormatter.getMessageTimestamp(message.date) } diff --git a/qksms/src/main/res/layout/message_list_item_in.xml b/qksms/src/main/res/layout/message_list_item_in.xml index 6570a27c..d11f4a95 100644 --- a/qksms/src/main/res/layout/message_list_item_in.xml +++ b/qksms/src/main/res/layout/message_list_item_in.xml @@ -58,16 +58,12 @@ android:background="@drawable/message_only" android:minHeight="36dp" android:orientation="vertical" - android:paddingBottom="8dp" - android:paddingEnd="12dp" - android:paddingStart="12dp" - android:paddingTop="8dp" tools:backgroundTint="@color/tools_theme"> + android:layout_width="256dp" + android:layout_height="wrap_content" /> diff --git a/qksms/src/main/res/layout/message_list_item_out.xml b/qksms/src/main/res/layout/message_list_item_out.xml index a7ca0b80..289eabb6 100644 --- a/qksms/src/main/res/layout/message_list_item_out.xml +++ b/qksms/src/main/res/layout/message_list_item_out.xml @@ -52,16 +52,12 @@ android:gravity="start" android:minHeight="36dp" android:orientation="vertical" - android:paddingBottom="8dp" - android:paddingEnd="12dp" - android:paddingStart="12dp" - android:paddingTop="8dp" tools:backgroundTint="@color/white"> + android:layout_width="256dp" + android:layout_height="wrap_content" />