From 950426a9bad4775b797de041b322dd688d5ed528 Mon Sep 17 00:00:00 2001 From: George Kankava Date: Thu, 10 Mar 2016 10:53:38 +0400 Subject: [PATCH] squid:UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding --- .../java/com/moez/QKSMS/common/google/PduLoaderManager.java | 6 +++--- .../java/com/moez/QKSMS/common/google/ThumbnailManager.java | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/QKSMS/src/main/java/com/moez/QKSMS/common/google/PduLoaderManager.java b/QKSMS/src/main/java/com/moez/QKSMS/common/google/PduLoaderManager.java index b6bcd0cd..f66bb588 100644 --- a/QKSMS/src/main/java/com/moez/QKSMS/common/google/PduLoaderManager.java +++ b/QKSMS/src/main/java/com/moez/QKSMS/common/google/PduLoaderManager.java @@ -87,11 +87,11 @@ public class PduLoaderManager extends BackgroundLoaderManager { final SlideshowModel slideshow = (requestSlideshow && !DEBUG_DISABLE_CACHE) ? mSlideshowCache.get(uri) : null; - final boolean slideshowExists = (!requestSlideshow || slideshow != null); - final boolean pduExists = (cacheEntry != null && cacheEntry.getPdu() != null); + final boolean slideshowExists = !requestSlideshow || slideshow != null; + final boolean pduExists = cacheEntry != null && cacheEntry.getPdu() != null; final boolean taskExists = mPendingTaskUris.contains(uri); final boolean newTaskRequired = (!pduExists || !slideshowExists) && !taskExists; - final boolean callbackRequired = (callback != null); + final boolean callbackRequired = callback != null; if (pduExists && slideshowExists) { if (callbackRequired) { diff --git a/QKSMS/src/main/java/com/moez/QKSMS/common/google/ThumbnailManager.java b/QKSMS/src/main/java/com/moez/QKSMS/common/google/ThumbnailManager.java index 6060131b..4b6254ca 100644 --- a/QKSMS/src/main/java/com/moez/QKSMS/common/google/ThumbnailManager.java +++ b/QKSMS/src/main/java/com/moez/QKSMS/common/google/ThumbnailManager.java @@ -122,10 +122,10 @@ public class ThumbnailManager extends BackgroundLoaderManager { final Bitmap thumbnail = DEBUG_DISABLE_CACHE ? null : mThumbnailCache.get(uri); - final boolean thumbnailExists = (thumbnail != null); + final boolean thumbnailExists = thumbnail != null; final boolean taskExists = mPendingTaskUris.contains(uri); final boolean newTaskRequired = !thumbnailExists && !taskExists; - final boolean callbackRequired = (callback != null); + final boolean callbackRequired = callback != null; if (Log.isLoggable(LogTag.THUMBNAIL_CACHE, Log.DEBUG)) { Log.v(TAG, "getThumbnail mThumbnailCache.get for uri: " + uri + " thumbnail: " +