From e134516b3cd94ef5c7f6f7e366fb71bed44332cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phane=20BAUSSERON?= Date: Wed, 10 Aug 2016 19:35:52 +0200 Subject: [PATCH 1/3] Fill mColumnsMap and mMessageItemCache before than spread cursor change event --- .../com/moez/QKSMS/ui/messagelist/MessageListAdapter.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/QKSMS/src/main/java/com/moez/QKSMS/ui/messagelist/MessageListAdapter.java b/QKSMS/src/main/java/com/moez/QKSMS/ui/messagelist/MessageListAdapter.java index 6730b902..09b6bb13 100644 --- a/QKSMS/src/main/java/com/moez/QKSMS/ui/messagelist/MessageListAdapter.java +++ b/QKSMS/src/main/java/com/moez/QKSMS/ui/messagelist/MessageListAdapter.java @@ -589,12 +589,12 @@ public class MessageListAdapter extends RecyclerCursorAdapter Date: Wed, 10 Aug 2016 17:53:56 +0200 Subject: [PATCH 2/3] Does not scroll to bottom of current conversation if no new SMS are received in this conversation --- .../QKSMS/ui/messagelist/MessageListFragment.java | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/QKSMS/src/main/java/com/moez/QKSMS/ui/messagelist/MessageListFragment.java b/QKSMS/src/main/java/com/moez/QKSMS/ui/messagelist/MessageListFragment.java index 9f19186b..2c727984 100644 --- a/QKSMS/src/main/java/com/moez/QKSMS/ui/messagelist/MessageListFragment.java +++ b/QKSMS/src/main/java/com/moez/QKSMS/ui/messagelist/MessageListFragment.java @@ -208,6 +208,7 @@ public class MessageListFragment extends QKFragment implements ActivityLauncher, mAdapter.setItemClickListener(this); mAdapter.setMultiSelectListener(this); mAdapter.registerAdapterDataObserver(new RecyclerView.AdapterDataObserver() { + private long mLastMessageId = -1; @Override public void onChanged() { LinearLayoutManager manager = (LinearLayoutManager) mRecyclerView.getLayoutManager(); @@ -225,8 +226,15 @@ public class MessageListFragment extends QKFragment implements ActivityLauncher, position = mAdapter.getItemCount() - 1; } - if (position != -1) { - manager.smoothScrollToPosition(mRecyclerView, null, position); + if(mAdapter.getCount() > 0) { + MessageItem lastMessage = mAdapter.getItem(mAdapter.getCount() - 1); + if (mLastMessageId >= 0 && mLastMessageId != lastMessage.getMessageId()) { + // Scroll to bottom only if a new message was inserted in this conversation + if (position != -1) { + manager.smoothScrollToPosition(mRecyclerView, null, position); + } + } + mLastMessageId = lastMessage.getMessageId(); } } }); From abd578587b4129d32014a49541503a6354046d44 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phane=20BAUSSERON?= Date: Mon, 29 Aug 2016 12:02:57 +0200 Subject: [PATCH 3/3] Remove unused variable MessageListFragment.mLastMessageId to prevent from confusing with mLastMessageId of the observer --- .../com/moez/QKSMS/ui/messagelist/MessageListFragment.java | 5 ----- 1 file changed, 5 deletions(-) diff --git a/QKSMS/src/main/java/com/moez/QKSMS/ui/messagelist/MessageListFragment.java b/QKSMS/src/main/java/com/moez/QKSMS/ui/messagelist/MessageListFragment.java index 2c727984..1d71cf4c 100644 --- a/QKSMS/src/main/java/com/moez/QKSMS/ui/messagelist/MessageListFragment.java +++ b/QKSMS/src/main/java/com/moez/QKSMS/ui/messagelist/MessageListFragment.java @@ -134,7 +134,6 @@ public class MessageListFragment extends QKFragment implements ActivityLauncher, // If the value >= 0, then we jump to that line. If the // value is maxint, then we jump to the end. - private long mLastMessageId; private BackgroundQueryHandler mBackgroundQueryHandler; private long mThreadId; @@ -949,10 +948,6 @@ public class MessageListFragment extends QKFragment implements ActivityLauncher, mConversation.setMessageCount(0); // fall through case DELETE_MESSAGE_TOKEN: - if (cookie instanceof Boolean && ((Boolean) cookie).booleanValue()) { - // If we just deleted the last message, reset the saved id. - mLastMessageId = 0; - } // Update the notification for new messages since they may be deleted. NotificationManager.update(mContext);