Don't animate for initial view setup in settings screens

This commit is contained in:
Moez Bhatti
2018-06-07 23:55:37 -04:00
parent f410ae939c
commit 8777722df4
7 changed files with 20 additions and 3 deletions
@@ -18,6 +18,7 @@
*/ */
package common.util.extensions package common.util.extensions
import android.animation.LayoutTransition
import android.content.Context import android.content.Context
import android.content.res.ColorStateList import android.content.res.ColorStateList
import android.graphics.PorterDuff import android.graphics.PorterDuff
@@ -25,11 +26,19 @@ import android.os.Build
import android.support.v7.widget.RecyclerView import android.support.v7.widget.RecyclerView
import android.view.MotionEvent import android.view.MotionEvent
import android.view.View import android.view.View
import android.view.ViewGroup
import android.view.inputmethod.InputMethodManager import android.view.inputmethod.InputMethodManager
import android.widget.EditText import android.widget.EditText
import android.widget.ImageView import android.widget.ImageView
import android.widget.ProgressBar import android.widget.ProgressBar
var ViewGroup.animateLayoutChanges: Boolean
get() = layoutTransition != null
set(value) {
layoutTransition = if (value) LayoutTransition() else null
}
fun EditText.showKeyboard() { fun EditText.showKeyboard() {
requestFocus() requestFocus()
val imm = context.getSystemService(Context.INPUT_METHOD_SERVICE) as InputMethodManager val imm = context.getSystemService(Context.INPUT_METHOD_SERVICE) as InputMethodManager
@@ -28,6 +28,7 @@ import com.uber.autodispose.android.lifecycle.scope
import com.uber.autodispose.kotlin.autoDisposable import com.uber.autodispose.kotlin.autoDisposable
import common.Navigator import common.Navigator
import common.base.QkThemedActivity import common.base.QkThemedActivity
import common.util.extensions.animateLayoutChanges
import common.util.extensions.scrapViews import common.util.extensions.scrapViews
import common.util.extensions.setVisible import common.util.extensions.setVisible
import dagger.android.AndroidInjection import dagger.android.AndroidInjection
@@ -60,6 +61,8 @@ class ConversationInfoActivity : QkThemedActivity(), ConversationInfoView {
viewModel.bindView(this) viewModel.bindView(this)
setTitle(R.string.info_title) setTitle(R.string.info_title)
items.postDelayed({ items.animateLayoutChanges = true }, 100)
mediaAdapter.thumbnailClicks mediaAdapter.thumbnailClicks
.autoDisposable(scope()) .autoDisposable(scope())
.subscribe { view -> navigator.showImageAnimated(this, view) } .subscribe { view -> navigator.showImageAnimated(this, view) }
@@ -30,6 +30,7 @@ import com.jakewharton.rxbinding2.view.clicks
import com.moez.QKSMS.R import com.moez.QKSMS.R
import common.QkDialog import common.QkDialog
import common.base.QkThemedActivity import common.base.QkThemedActivity
import common.util.extensions.animateLayoutChanges
import common.util.extensions.setVisible import common.util.extensions.setVisible
import common.widget.PreferenceView import common.widget.PreferenceView
import dagger.android.AndroidInjection import dagger.android.AndroidInjection
@@ -58,6 +59,8 @@ class NotificationPrefsActivity : QkThemedActivity(), NotificationPrefsView {
showBackButton(true) showBackButton(true)
viewModel.bindView(this) viewModel.bindView(this)
preferences.postDelayed({ preferences.animateLayoutChanges = true }, 100)
val hasOreo = Build.VERSION.SDK_INT >= Build.VERSION_CODES.O val hasOreo = Build.VERSION.SDK_INT >= Build.VERSION_CODES.O
notificationsO.setVisible(hasOreo) notificationsO.setVisible(hasOreo)
@@ -18,6 +18,7 @@
*/ */
package feature.settings package feature.settings
import android.animation.LayoutTransition
import android.app.ProgressDialog import android.app.ProgressDialog
import android.app.TimePickerDialog import android.app.TimePickerDialog
import android.arch.lifecycle.ViewModelProvider import android.arch.lifecycle.ViewModelProvider
@@ -33,6 +34,7 @@ import com.uber.autodispose.android.lifecycle.scope
import com.uber.autodispose.kotlin.autoDisposable import com.uber.autodispose.kotlin.autoDisposable
import common.QkDialog import common.QkDialog
import common.base.QkThemedActivity import common.base.QkThemedActivity
import common.util.extensions.animateLayoutChanges
import common.util.extensions.setBackgroundTint import common.util.extensions.setBackgroundTint
import common.util.extensions.setVisible import common.util.extensions.setVisible
import common.widget.PreferenceView import common.widget.PreferenceView
@@ -81,6 +83,8 @@ class SettingsActivity : QkThemedActivity(), SettingsView {
showBackButton(true) showBackButton(true)
viewModel.bindView(this) viewModel.bindView(this)
preferences.postDelayed({ preferences.animateLayoutChanges = true }, 100)
nightModeDialog.adapter.setData(R.array.night_modes) nightModeDialog.adapter.setData(R.array.night_modes)
textSizeDialog.adapter.setData(R.array.text_sizes) textSizeDialog.adapter.setData(R.array.text_sizes)
sendDelayDialog.adapter.setData(R.array.delayed_sending_labels) sendDelayDialog.adapter.setData(R.array.delayed_sending_labels)
@@ -40,9 +40,9 @@
app:layout_constraintTop_toBottomOf="@id/toolbar"> app:layout_constraintTop_toBottomOf="@id/toolbar">
<LinearLayout <LinearLayout
android:id="@+id/items"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="match_parent" android:layout_height="match_parent"
android:animateLayoutChanges="true"
android:orientation="vertical"> android:orientation="vertical">
<android.support.v7.widget.RecyclerView <android.support.v7.widget.RecyclerView
@@ -45,7 +45,6 @@
android:id="@+id/preferences" android:id="@+id/preferences"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:animateLayoutChanges="true"
android:orientation="vertical" android:orientation="vertical"
android:paddingBottom="8dp" android:paddingBottom="8dp"
android:paddingTop="8dp"> android:paddingTop="8dp">
@@ -50,7 +50,6 @@
android:id="@+id/preferences" android:id="@+id/preferences"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:animateLayoutChanges="true"
android:orientation="vertical" android:orientation="vertical"
android:paddingBottom="8dp" android:paddingBottom="8dp"
android:paddingTop="8dp"> android:paddingTop="8dp">