From 06e3037f32c75e7546b674b21da23d65105ec4f6 Mon Sep 17 00:00:00 2001 From: l3d00m Date: Thu, 10 Sep 2015 17:57:34 +0200 Subject: [PATCH 1/3] add a non intrusive rate snackbar --- QKSMS/build.gradle | 2 ++ .../java/com/moez/QKSMS/common/QksmsRateSnack.java | 14 ++++++++++++++ .../main/java/com/moez/QKSMS/ui/MainActivity.java | 9 +++++++++ 3 files changed, 25 insertions(+) create mode 100644 QKSMS/src/main/java/com/moez/QKSMS/common/QksmsRateSnack.java diff --git a/QKSMS/build.gradle b/QKSMS/build.gradle index 8e7b8df4..9863ba37 100644 --- a/QKSMS/build.gradle +++ b/QKSMS/build.gradle @@ -2,6 +2,7 @@ apply plugin: 'com.android.application' repositories { mavenCentral() + jcenter() } android { @@ -74,6 +75,7 @@ dependencies { compile 'com.googlecode.ez-vcard:ez-vcard:0.9.6' compile 'com.google.code.gson:gson:2.3' compile 'com.koushikdutta.ion:ion:1.1.7' + compile 'org.ligi:snackengage:0.4' // Google libraries compile 'com.android.support:appcompat-v7:22.2.1' diff --git a/QKSMS/src/main/java/com/moez/QKSMS/common/QksmsRateSnack.java b/QKSMS/src/main/java/com/moez/QKSMS/common/QksmsRateSnack.java new file mode 100644 index 00000000..c4c8a9ad --- /dev/null +++ b/QKSMS/src/main/java/com/moez/QKSMS/common/QksmsRateSnack.java @@ -0,0 +1,14 @@ +package com.moez.QKSMS.common; + +import org.ligi.snackengage.conditions.AfterNumberOfOpportunities; +import org.ligi.snackengage.conditions.NeverAgainWhenClickedOnce; +import org.ligi.snackengage.snacks.RateSnack; + +/* https://github.com/ligi/SnackEngage +* "This shows a snackbar after app was started *20* times and never again when once clicked on Rate" */ + +public class QksmsRateSnack extends RateSnack { + public QksmsRateSnack() { + this.withConditions(new NeverAgainWhenClickedOnce(), new AfterNumberOfOpportunities(20)); + } +} \ No newline at end of file diff --git a/QKSMS/src/main/java/com/moez/QKSMS/ui/MainActivity.java b/QKSMS/src/main/java/com/moez/QKSMS/ui/MainActivity.java index 66ca389a..71721df2 100644 --- a/QKSMS/src/main/java/com/moez/QKSMS/ui/MainActivity.java +++ b/QKSMS/src/main/java/com/moez/QKSMS/ui/MainActivity.java @@ -26,10 +26,12 @@ import android.view.MenuInflater; import android.view.MenuItem; import android.view.View; import android.widget.ImageView; + import com.google.android.mms.pdu_alt.PduHeaders; import com.moez.QKSMS.R; import com.moez.QKSMS.common.ConversationPrefsHelper; import com.moez.QKSMS.common.DonationManager; +import com.moez.QKSMS.common.QksmsRateSnack; import com.moez.QKSMS.common.google.DraftCache; import com.moez.QKSMS.common.utils.KeyboardUtils; import com.moez.QKSMS.common.utils.MessageUtils; @@ -56,6 +58,9 @@ import com.moez.QKSMS.ui.welcome.WelcomeActivity; import com.nispok.snackbar.Snackbar; import com.nispok.snackbar.listeners.ActionClickListener; +import org.ligi.snackengage.SnackEngage; +import org.ligi.snackengage.snacks.BaseSnack; + import java.net.URLDecoder; import java.util.Collection; @@ -121,6 +126,10 @@ public class MainActivity extends QKActivity implements SlidingMenu.OnOpenListen onNewIntent(getIntent()); showDialogIfNeeded(savedInstanceState); + + //Adds a small/non intrusive snackbar that asks the user to rate the app + SnackEngage.from(MainActivity.this).withSnack( + new QksmsRateSnack().withDuration(BaseSnack.DURATION_LONG)).build().engageWhenAppropriate(); } /** From c747b3273dbec95bcdc3324ac316475dc7a886b0 Mon Sep 17 00:00:00 2001 From: l3d00m Date: Thu, 10 Sep 2015 18:02:53 +0200 Subject: [PATCH 2/3] Add snackengage to thank you screen --- QKSMS/src/main/res/values/donottranslate.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/QKSMS/src/main/res/values/donottranslate.xml b/QKSMS/src/main/res/values/donottranslate.xml index 31a40183..5af07d85 100644 --- a/QKSMS/src/main/res/values/donottranslate.xml +++ b/QKSMS/src/main/res/values/donottranslate.xml @@ -30,6 +30,7 @@ Jacob Klinker Jeff Gilfelt Melnykov Oleksandr + ligi @@ -39,6 +40,7 @@ github.com/klinker41 github.com/jgilfelt github.com/makovkastar + github.com/ligi @@ -48,6 +50,7 @@ android-smsmms\nandroid-chips SystemBarTint FloatingActionButton + SnackEngage From 2b265d4221716ae2bfba9d7d30f9562d159e7247 Mon Sep 17 00:00:00 2001 From: l3d00m Date: Tue, 15 Sep 2015 15:19:01 +0200 Subject: [PATCH 3/3] improve rate snackbar --- .../com/moez/QKSMS/common/QKRateSnack.java | 24 +++++++++++++++++++ .../com/moez/QKSMS/common/QksmsRateSnack.java | 14 ----------- .../java/com/moez/QKSMS/ui/MainActivity.java | 6 ++--- QKSMS/src/main/res/values-de/strings.xml | 2 ++ QKSMS/src/main/res/values/strings.xml | 4 ++++ 5 files changed, 33 insertions(+), 17 deletions(-) create mode 100644 QKSMS/src/main/java/com/moez/QKSMS/common/QKRateSnack.java delete mode 100644 QKSMS/src/main/java/com/moez/QKSMS/common/QksmsRateSnack.java diff --git a/QKSMS/src/main/java/com/moez/QKSMS/common/QKRateSnack.java b/QKSMS/src/main/java/com/moez/QKSMS/common/QKRateSnack.java new file mode 100644 index 00000000..714e42f1 --- /dev/null +++ b/QKSMS/src/main/java/com/moez/QKSMS/common/QKRateSnack.java @@ -0,0 +1,24 @@ +package com.moez.QKSMS.common; + +import com.moez.QKSMS.R; + +import org.ligi.snackengage.conditions.AfterNumberOfOpportunities; +import org.ligi.snackengage.conditions.NeverAgainWhenClickedOnce; +import org.ligi.snackengage.snacks.RateSnack; + +/* https://github.com/ligi/SnackEngage +* "This shows a snackbar after MainActivity was created *10* times and never again when once clicked on Rate" */ + +public class QKRateSnack extends RateSnack { + public QKRateSnack() { + withConditions(new NeverAgainWhenClickedOnce(), new AfterNumberOfOpportunities(10)); + } + + @Override public String getText(){ + return getString(R.string.rate_title); + } + + @Override public String getActionText(){ + return getString(R.string.rate_action); + } +} \ No newline at end of file diff --git a/QKSMS/src/main/java/com/moez/QKSMS/common/QksmsRateSnack.java b/QKSMS/src/main/java/com/moez/QKSMS/common/QksmsRateSnack.java deleted file mode 100644 index c4c8a9ad..00000000 --- a/QKSMS/src/main/java/com/moez/QKSMS/common/QksmsRateSnack.java +++ /dev/null @@ -1,14 +0,0 @@ -package com.moez.QKSMS.common; - -import org.ligi.snackengage.conditions.AfterNumberOfOpportunities; -import org.ligi.snackengage.conditions.NeverAgainWhenClickedOnce; -import org.ligi.snackengage.snacks.RateSnack; - -/* https://github.com/ligi/SnackEngage -* "This shows a snackbar after app was started *20* times and never again when once clicked on Rate" */ - -public class QksmsRateSnack extends RateSnack { - public QksmsRateSnack() { - this.withConditions(new NeverAgainWhenClickedOnce(), new AfterNumberOfOpportunities(20)); - } -} \ No newline at end of file diff --git a/QKSMS/src/main/java/com/moez/QKSMS/ui/MainActivity.java b/QKSMS/src/main/java/com/moez/QKSMS/ui/MainActivity.java index 71721df2..81a258c8 100644 --- a/QKSMS/src/main/java/com/moez/QKSMS/ui/MainActivity.java +++ b/QKSMS/src/main/java/com/moez/QKSMS/ui/MainActivity.java @@ -31,7 +31,7 @@ import com.google.android.mms.pdu_alt.PduHeaders; import com.moez.QKSMS.R; import com.moez.QKSMS.common.ConversationPrefsHelper; import com.moez.QKSMS.common.DonationManager; -import com.moez.QKSMS.common.QksmsRateSnack; +import com.moez.QKSMS.common.QKRateSnack; import com.moez.QKSMS.common.google.DraftCache; import com.moez.QKSMS.common.utils.KeyboardUtils; import com.moez.QKSMS.common.utils.MessageUtils; @@ -128,8 +128,8 @@ public class MainActivity extends QKActivity implements SlidingMenu.OnOpenListen showDialogIfNeeded(savedInstanceState); //Adds a small/non intrusive snackbar that asks the user to rate the app - SnackEngage.from(MainActivity.this).withSnack( - new QksmsRateSnack().withDuration(BaseSnack.DURATION_LONG)).build().engageWhenAppropriate(); + SnackEngage.from(this).withSnack(new QKRateSnack().withDuration(BaseSnack.DURATION_LONG)) + .build().engageWhenAppropriate(); } /** diff --git a/QKSMS/src/main/res/values-de/strings.xml b/QKSMS/src/main/res/values-de/strings.xml index e071e360..d9dd1ca9 100755 --- a/QKSMS/src/main/res/values-de/strings.xml +++ b/QKSMS/src/main/res/values-de/strings.xml @@ -49,6 +49,8 @@ Inhalt Gesendet Empfangen + Gefällt dir QKSMS? + Bewerten Erscheinungsbild Themen, Schriften, Farben, Avatare und mehr Allgemein diff --git a/QKSMS/src/main/res/values/strings.xml b/QKSMS/src/main/res/values/strings.xml index 927af657..00aaa045 100644 --- a/QKSMS/src/main/res/values/strings.xml +++ b/QKSMS/src/main/res/values/strings.xml @@ -101,6 +101,10 @@ Date sent Date received + + Like QKSMS? + + Rate Appearance Themes, fonts, colors, avatars, and more