Removed unused permissions as TrackRecordingService is now only reachable from within the app.

src/main/AndroidManifest.xml

@@ -36,36 +36,11 @@ limitations under the License.
   <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
   <!-- Permissions to access My Tracks data -->
   <uses-permission android:name="com.google.android.apps.mytracks.MYTRACKS_NOTIFICATIONS" />
-  <uses-permission android:name="com.google.android.apps.mytracks.READ_TRACK_DATA" />
-  <uses-permission android:name="com.google.android.apps.mytracks.WRITE_TRACK_DATA" />
   <!-- Permission to receive My Tracks internal broadcasts -->
   <permission
-    android:description="@string/permission_notification_label"
-    android:label="@string/permission_notification_label"
     android:name="com.google.android.apps.mytracks.MYTRACKS_NOTIFICATIONS"
     android:permissionGroup="android.permission-group.LOCATION"
     android:protectionLevel="signature" />
-  <!-- Permission to read track data -->
-  <permission
-    android:description="@string/permission_read_description"
-    android:label="@string/permission_read_label"
-    android:name="com.google.android.apps.mytracks.READ_TRACK_DATA"
-    android:permissionGroup="android.permission-group.LOCATION"
-    android:protectionLevel="dangerous" />
-  <!-- Permission to receive track start/end broadcasts -->
-  <permission
-    android:description="@string/permission_notification_description"
-    android:label="@string/permission_notification_label"
-    android:name="com.google.android.apps.mytracks.TRACK_NOTIFICATIONS"
-    android:permissionGroup="android.permission-group.LOCATION"
-    android:protectionLevel="dangerous" />
-  <!-- Permission to write track data, either directly or through service calls -->
-  <permission
-    android:description="@string/permission_write_description"
-    android:label="@string/permission_write_label"
-    android:name="com.google.android.apps.mytracks.WRITE_TRACK_DATA"
-    android:permissionGroup="android.permission-group.LOCATION"
-    android:protectionLevel="dangerous" />
   <!-- Required features -->
   <uses-feature
     android:name="android.hardware.location.gps"
@@ -184,8 +159,7 @@ limitations under the License.
       android:exported="false"
       android:icon="@drawable/ic_arrow_320"
       android:label="@string/recording_service"
-      android:name="com.google.android.apps.mytracks.services.TrackRecordingService"
+      android:name="com.google.android.apps.mytracks.services.TrackRecordingService" />
-      android:permission="com.google.android.apps.mytracks.WRITE_TRACK_DATA" />
     <!-- Receivers -->
     <receiver android:name="com.google.android.apps.mytracks.BootReceiver" >
       <intent-filter>
@@ -206,14 +180,12 @@ limitations under the License.
         android:resource="@xml/track_widget_info" />
     </receiver>
     <!-- Providers -->
-    <!-- My Tracks data provider -->
     <provider
       android:authorities="com.google.android.maps.mytracks"
       android:exported="false"
       android:grantUriPermissions="true"
       android:name="com.google.android.apps.mytracks.content.CustomContentProvider"
-      android:readPermission="com.google.android.apps.mytracks.READ_TRACK_DATA"
+    />
-      android:writePermission="com.google.android.apps.mytracks.WRITE_TRACK_DATA" />
     <!-- Search suggestion provider -->
     <provider
       android:authorities="com.google.android.maps.mytracks.search"

src/main/java/com/google/android/apps/mytracks/services/TrackRecordingService.java

@@ -1037,9 +1037,6 @@ public class TrackRecordingService extends Service {
         Intent intent = new Intent().setAction(getString(actionId))
                 .putExtra(getString(R.string.track_id_broadcast_extra), trackId);
         sendBroadcast(intent, getString(R.string.permission_notification_value));
-        if (PreferencesUtils.getBoolean(this, R.string.allow_access_key, PreferencesUtils.ALLOW_ACCESS_DEFAULT)) {
-            sendBroadcast(intent, getString(R.string.broadcast_notifications_permission));
-        }
     }
 
     /**

src/main/java/com/google/android/apps/mytracks/util/PreferencesUtils.java

@@ -35,8 +35,6 @@ public class PreferencesUtils {
    * Preferences values. The defaults need to match the defaults in the xml
    * files.
    */
-  @Deprecated //TODO: to be removed.
-  public static final boolean ALLOW_ACCESS_DEFAULT = false;
   public static final int AUTO_RESUME_TRACK_CURRENT_RETRY_DEFAULT = 0;
 
   // Values for auto_resume_track_timeout_key

src/main/res/values/keys.xml

@@ -16,44 +16,43 @@ limitations under the License.
 -->
 <resources>
   <!-- Keys for persisted preferences. Sorted alphabetically. DO NOT TRANSLATE. -->
-  <string name="allow_access_key">allowAccess</string>
+  <string name="auto_resume_track_timeout_key" translatable="false">autoResumeTrackTimeout</string>
-  <string name="auto_resume_track_timeout_key">autoResumeTrackTimeout</string>
+  <string name="chart_show_cadence_key" translatable="false">chartShowCadence</string>
-  <string name="chart_show_cadence_key">chartShowCadence</string>
+  <string name="chart_show_elevation_key" translatable="false">chartShowElevation</string>
-  <string name="chart_show_elevation_key">chartShowElevation</string>
+  <string name="chart_show_heart_rate_key" translatable="false">chartShowHeartRate</string>
-  <string name="chart_show_heart_rate_key">chartShowHeartRate</string>
+  <string name="chart_show_power_key" translatable="false">chartShowPower</string>
-  <string name="chart_show_power_key">chartShowPower</string>
+  <string name="chart_show_speed_key" translatable="false">chartShowSpeed</string>
-  <string name="chart_show_speed_key">chartShowSpeed</string>
+  <string name="chart_x_axis_key" translatable="false">chartXAxis</string>
-  <string name="chart_x_axis_key">chartXAxis</string>
+  <string name="default_activity_key" translatable="false">defaultActivity</string>
-  <string name="default_activity_key">defaultActivity</string>
+  <string name="max_recording_distance_key" translatable="false">maxRecordingDistance</string>
-  <string name="max_recording_distance_key">maxRecordingDistance</string>
+  <string name="min_recording_interval_key" translatable="false">minRecordingInterval</string>
-  <string name="min_recording_interval_key">minRecordingInterval</string>
+  <string name="photo_size_key" translatable="false">photoSize</string>
-  <string name="photo_size_key">photoSize</string>
+  <string name="recording_distance_interval_key" translatable="false">recordingDistanceInterval</string>
-  <string name="recording_distance_interval_key">recordingDistanceInterval</string>
+  <string name="recording_gps_accuracy_key" translatable="false">recordingGpsAccuracy</string>
-  <string name="recording_gps_accuracy_key">recordingGpsAccuracy</string>
+  <string name="split_frequency_key" translatable="false">splitFrequency</string>
-  <string name="split_frequency_key">splitFrequency</string>
+  <string name="stats_rate_key" translatable="false">statsRate</string>
-  <string name="stats_rate_key">statsRate</string>
+  <string name="stats_show_coordinate_key" translatable="false">statsShowCoordinate</string>
-  <string name="stats_show_coordinate_key">statsShowCoordinate</string>
+  <string name="stats_show_grade_elevation_key" translatable="false">statsShowGradeElevation</string>
-  <string name="stats_show_grade_elevation_key">statsShowGradeElevation</string>
+  <string name="stats_units_key" translatable="false">statsUnits</string>
-  <string name="stats_units_key">statsUnits</string>
+  <string name="track_name_key" translatable="false">trackName</string>
-  <string name="track_name_key">trackName</string>
+  <string name="track_widget_item1" translatable="false">trackWidgetItem1</string>
-  <string name="track_widget_item1">trackWidgetItem1</string>
+  <string name="track_widget_item2" translatable="false">trackWidgetItem2</string>
-  <string name="track_widget_item2">trackWidgetItem2</string>
+  <string name="track_widget_item3" translatable="false">trackWidgetItem3</string>
-  <string name="track_widget_item3">trackWidgetItem3</string>
+  <string name="track_widget_item4" translatable="false">trackWidgetItem4</string>
-  <string name="track_widget_item4">trackWidgetItem4</string>
+  <string name="voice_frequency_key" translatable="false">voiceFrequency</string>
-  <string name="voice_frequency_key">voiceFrequency</string>
   <!-- Keys for persistend preferences. But they should not get backed up or restored. -->
-  <string name="auto_resume_track_current_retry_key">autoResumeTrackCurrentRetry</string>
+  <string name="auto_resume_track_current_retry_key" translatable="false">autoResumeTrackCurrentRetry</string>
-  <string name="bluetooth_sensor_key">bluetoothSensor</string>
+  <string name="bluetooth_sensor_key" translatable="false">bluetoothSensor</string>
-  <string name="recording_track_id_key">recordingTrackId</string>
+  <string name="recording_track_id_key" translatable="false">recordingTrackId</string>
-  <string name="recording_track_paused_key">recordingTrackPaused</string>
+  <string name="recording_track_paused_key" translatable="false">recordingTrackPaused</string>
   <!-- Keys for non-persisted preferences. Sorted alphabetically. DO NOT TRANSLATE. -->
-  <string name="settings_advanced_key">settingsAdvanced</string>
+  <string name="settings_advanced_key" translatable="false">settingsAdvanced</string>
-  <string name="settings_chart_key">settingsChart</string>
+  <string name="settings_chart_key" translatable="false">settingsChart</string>
-  <string name="settings_recording_key">settingsRecording</string>
+  <string name="settings_recording_key" translatable="false">settingsRecording</string>
-  <string name="settings_reset_key">settingsReset</string>
+  <string name="settings_reset_key" translatable="false">settingsReset</string>
-  <string name="settings_sensor_key">settingsSensor</string>
+  <string name="settings_sensor_key" translatable="false">settingsSensor</string>
-  <string name="settings_sensor_bluetooth_key">settingsSensorBluetooth</string>
+  <string name="settings_sensor_bluetooth_key" translatable="false">settingsSensorBluetooth</string>
-  <string name="settings_sensor_bluetooth_pairing_key">settingsSensorBluetoothPairing</string>
+  <string name="settings_sensor_bluetooth_pairing_key" translatable="false">settingsSensorBluetoothPairing</string>
-  <string name="settings_sensor_root_key">settingsSensorRoot</string>
+  <string name="settings_sensor_root_key" translatable="false">settingsSensorRoot</string>
-  <string name="settings_stats_key">settingsStats</string>
+  <string name="settings_stats_key" translatable="false">settingsStats</string>
 </resources>

src/main/res/values/strings.xml

@@ -1156,47 +1156,6 @@ limitations under the License.
   <string name="permission_gps_failed">
     My Tracks requires permission to use GPS.
   </string>
-  <string name="permission_notification_description"
-    translation_description="The permission description the Google Play Store shows during app
-      installation when the app wants to receive Google My Tracks notifications.">
-    Allows the application to receive notifications when Google My Tracks starts or stops a
-    recording.
-  </string>
-  <string name="permission_notification_label"
-    translation_description="The permission label the Google Play Store shows during app
-      installation when the app wants to receive Google My Tracks notifications.">
-    receive Google My Tracks notifications
-  </string>
-  <string name="permission_read_description"
-    translation_description="The permission description the Google Play Store shows during app
-      installation when the app wants to read Google My Tracks data.">
-    Allows the application to read Google My Tracks data.
-  </string>
-  <string name="permission_read_label"
-    translation_description="The permission label the Google Play Store shows during app
-      installation when the app wants to read My Tracks data.">
-    read Google My Tracks data
-  </string>
-  <string name="permission_request_message"
-    translation_description="The message when requesting permission.
-      %1$s account name. E.g., 'foo@foo.com'.">
-    for account %1$s
-  </string>
-  <string name="permission_request_title"
-    translation_description="The title when the 'My Tracks' app is requesting permission.">
-    My Tracks requesting permission
-  </string>
-  <string name="permission_write_description"
-    translation_description="The permission description the Google Play Store shows during app
-      installation when the app wants to write data to My Tracks.">
-    Allows the application to write data to Google My Tracks and start/stop Google My Tracks
-    recording.
-  </string>
-  <string name="permission_write_label"
-    translation_description="The permission label the Google Play Store shows during app
-      installation when the app wants to write data to My Tracks.">
-    write data to Google My Tracks and start/stop Google My Tracks recording
-  </string>
 
   <!-- Search -->
   <string name="search_global_description"