Commit Graph

5 Commits

Author SHA1 Message Date
Dominik R?ttsches 9281e0adf3 Revision comments for rev 5bcaab17e76f addressed. 2011-08-27 14:32:37 +03:00
Dominik R?ttsches ace10fc511 Review comments for revision fd70af575b77 addressed. 2011-08-26 18:03:57 +03:00
Dominik R?ttsches acf5c0931f Addressing review comments for StrideReadings class and related test cases:
- removing inner class, and recording of heartbeat timestamps
- fixing issue with rollover by replacing % operator with modulo operation
- comparing problematic firmware id against byte[] instead of String
- removing zephyr packet debug loggin
- not reassigning protobuffers Builders
- moving decision to use workaround into setCadence function
- license and javadoc author for testcase class
- proposal: using introspection to access private fields in testcase in order to determine expected availablity of values from getCadence, alternatively modify access to protected.
- modifying rollover test, hopefully more clear now.
- adding asserts during the loop in this test case.
2011-08-25 15:12:33 +03:00
Dominik R?ttsches b5a1cf1b10 Adding tests for new StrideReadings class. 2011-08-21 14:11:35 +03:00
Sandor Dornbush 1b595ee7fe Pick up new Chinese translations 2011-08-13 08:24:12 -07:00