Commit Graph

122 Commits

Author SHA1 Message Date
Bartlomiej Niechwiej f5c2467d01 Fix StringIndexOutOfBoundsException in ChartsExtendedEncoder.getEncodedValue().
Found in user error reports (3rd top issue):
java.lang.StringIndexOutOfBoundsException
at com.google.android.apps.mytracks.util.ChartsExtendedEncoder.getEncodedValue(ChartsExtendedEncoder.java:45)
at com.google.android.apps.mytracks.util.ChartURLGenerator.getChartUrl(ChartURLGenerator.java:162)
at com.google.android.apps.mytracks.util.ChartURLGenerator.getChartUrl(ChartURLGenerator.java:60)
at com.google.android.apps.mytracks.util.StringUtils.generateTrackDescription(StringUtils.java:366)
at com.google.android.apps.mytracks.io.SendToMyMaps.doUpload(SendToMyMaps.java:581)
at com.google.android.apps.mytracks.io.SendToMyMaps.access$10(SendToMyMaps.java:538)
at com.google.android.apps.mytracks.io.SendToMyMaps$5.run(SendToMyMaps.java:517)
at android.os.Handler.handleCallback(Handler.java:587)
at android.os.Handler.dispatchMessage(Handler.java:92)
at android.os.Looper.loop(Looper.java:123)
at android.os.HandlerThread.run(HandlerThread.java:60)
2010-11-05 22:52:42 -07:00
Bartlomiej Niechwiej a3abcc8094 Provide a workaround for binding to the service once it has been started. It fixes the failing tests (4). 2010-11-05 20:45:06 -07:00
Sandor Dornbush edf439f301 Merge Bart's bug fixes and tests. 2010-11-05 15:37:20 -07:00
Sandor Dornbush 2245563250 Fix broken build. 2010-11-05 14:51:06 -07:00
Bartlomiej Niechwiej bca21d5515 Addressed Rodrigo's comments. 2010-11-05 10:11:55 -07:00
Bartlomiej Niechwiej 89cae2e7c9 Fix a regression related refactoring recordingTrackId management.
In particular:
1) Add a workaround to {start/end}Recording to update recordingTrackId to trigger a notification
2) Add a bunch of unit tests for MyTracks
3) Clear minor style issues in a few classes
2010-11-04 23:32:31 -07:00
Sandor Dornbush 26c381a4c4 Address Bart's comments and more dialog clean up. 2010-11-04 17:44:08 -07:00
Sandor Dornbush 4bc5aa050c Add tests for the TempFileCleaner. 2010-11-04 17:07:59 -07:00
Rodrigo Damazio cd44b0d180 Merging Sandor's changes. 2010-11-03 21:08:50 -02:00
Rodrigo Damazio 59ee91ca5d Merging my own changes. 2010-11-03 20:59:32 -02:00
Rodrigo Damazio 59165a7033 Ignoring Matthew's second head by no-op merging it. 2010-11-03 20:53:50 -02:00
Rodrigo Damazio 93d242c05f Merging Matthew's first head. 2010-11-03 20:42:35 -02:00
Rodrigo Damazio 4bbb6591e3 Merging Bart's changes. 2010-11-03 19:59:35 -02:00
Sandor Dornbush 7df8025f6a Merge with head and address comments. 2010-11-03 12:53:12 -07:00
Bartlomiej Niechwiej f19c52f40e Addressed Sandor's comments. 2010-11-02 08:31:21 -07:00
Bartlomiej Niechwiej b7840779fe Revert API Key Change. 2010-11-02 08:26:31 -07:00
Rodrigo Damazio 28042a8cc9 Adding tests to voice announcements.
If anyone asks, I didn't write this code.
2010-11-02 02:19:43 -02:00
Matthew Simmons b2907226bf Code review comments 2010-11-01 15:21:33 -04:00
Matthew Simmons a2f46821f5 Fix author line 2010-11-01 14:32:19 -04:00
Matthew Simmons b7385cd4cc Combine b2f2f9e9e9 and 8774b3663c
Allow users to choose the default track name policy.  By default, we'll switch
to a new, timestamp-based name.  If they change the pref, they'll get the
old-style 'track n' style.
2010-11-01 13:48:33 -04:00
Matthew Simmons 718c65818c Allow users to choose the track name policy. 2010-11-01 12:59:56 -04:00
Rodrigo Damazio 91e2293606 Adding proper AndroidMock configuration - requires setting eclipse variables 2010-11-01 05:30:16 -02:00
Rodrigo Damazio 3c4a921f9a Addressing review suggestions 2010-11-01 05:27:04 -02:00
Rodrigo Damazio d04b333126 Merging 2010-11-01 02:05:42 -02:00
Rodrigo Damazio 0a4bef4d9a Fixing concurrent access to the content provider by making it have a single instance in the same process as the service. 2010-10-29 17:35:54 -02:00
Bartlomiej Niechwiej a0f090a83a Bug fixing and refactoring:
1) Make sure no one but service changes recordingTrackId (which is owned by it)
2) Cache sharedPreferences
3) Clear recordingTrackId if it doesn't correspond to a valid track or the service is not recording
4) More unit tests
2010-10-28 22:49:01 -07:00
Bartlomiej Niechwiej dc8ee5943c Merge with c10bc69662325f00bf166b783cc3ab1b78ccfed9 2010-10-28 20:48:01 -07:00
Bartlomiej Niechwiej 9132c36aa7 Use a test android:apiKey instead of the official one. 2010-10-28 20:47:42 -07:00
Sandor Dornbush 224c0d759f Minor fixes noticed on first review. 2010-10-28 17:13:59 -07:00
Sandor Dornbush ffcaca2db1 Refactor a few 100 lines of code out of the main Activity. 2010-10-28 17:08:59 -07:00
Sandor Dornbush 409fc4a43b Address Bart's comments. 2010-10-28 15:07:01 -07:00
Sandor Dornbush 16968f3f2b Fix copyright notice. 2010-10-28 14:50:03 -07:00
Sandor Dornbush e3fd0dce21 Undo changes to the eclipse prefs. 2010-10-28 14:47:00 -07:00
Sandor Dornbush 53b6b6deca Add tests to ChartValueSeries.
Also other minor fixes.
2010-10-28 14:43:31 -07:00
Rodrigo Damazio 26f47a50d0 Fixing issue 34: Not making voice announcements during a phone call 2010-10-27 03:07:17 -02:00
Bartlomiej Niechwiej 3cf77374c4 Fix merge. 2010-10-26 20:19:54 -07:00
Bartlomiej Niechwiej a1129c3f0f Merge with c58e4b8519d3ed6959a96192286b83aa1b77f6f3 2010-10-26 20:17:15 -07:00
Bartlomiej Niechwiej 2fe74603a3 Merge with 96ee47b2d8639a0cf62a387f3360640643fbeb0a 2010-10-26 20:14:41 -07:00
Bartlomiej Niechwiej 54d517363d Merge with e34329d612571554d6424d5941dfad57e35612a0 2010-10-26 19:39:46 -07:00
Bartlomiej Niechwiej 948fe0c0e6 Merge with 68eb8dff3a87698ace057447dff40a07cf673f2e 2010-10-26 19:39:20 -07:00
Bartlomiej Niechwiej dbd8e6c0e9 Merge with 5ed61c63ba59f4748231ea14bbbc222423d0b08a 2010-10-26 19:38:51 -07:00
Bartlomiej Niechwiej 02b5601933 Remove unnecessary log. 2010-10-26 19:32:24 -07:00
Sandor Dornbush 3ed40608a2 Merging from head. 2010-10-26 14:44:31 -07:00
Bartlomiej Niechwiej 36d7c2dd91 Allow to move the app to SD card (by default goes to internal storage). This is a frequently requested feature (based on market feedback). 2010-10-26 00:33:38 -07:00
Bartlomiej Niechwiej fa7ef68851 Addressed Sandor's comments. 2010-10-25 22:35:38 -07:00
Matthew Simmons f84877a4fc Issue 86: Remove - from the list of disallowed characters for filenames. 2010-10-25 14:59:20 -04:00
Matthew Simmons 261fb62e24 Changed the default new track name from "track %d" to "date time", where "date"
is a short, locale-aware version of the track's start date, and "time" is the
track's start time.
2010-10-25 14:15:16 -04:00
Bartlomiej Niechwiej 48d8aa4cd8 Introduce an interface to decouple platform specific API from the classes that require it. Also:
1) Put the service into foreground to prevent from being killed by the system
2) Fix a bug the prevented MyTracks from running on pre-Eclair devices
2010-10-24 21:24:11 -07:00
Bartlomiej Niechwiej 95ff0d3db6 Fix a typo in shared preferences and minor cleanup. 2010-10-24 18:55:35 -07:00
Bartlomiej Niechwiej 2dc1d914c0 Several fixes to the service and more test coverage.
Notably:
1) Fixed isRecording to not return false if service is down (for instance, it may be being restarted)
2) Added more checks to prevent from invalid starting/stopping (if in already in progress/not started).
2010-10-24 14:16:43 -07:00