Release: v4.0.3

Part of #1003.

.github/ISSUE_TEMPLATE/data_not_recorded.md

@@ -0,0 +1,24 @@
+---
+name: Data not recorded 
+about: Somehow OpenTracks did not record GPS data 
+title: ''
+labels: potential bug 
+assignees: ''
+
+---
+
+**Please describe the problem and how to reproduce it:**
+
+...
+
+**Checklist**
+
+- [ ] Consulted [https://dontkillmyapp.com/]
+- [ ] Power management: battery optimization is disabled for OpenTracks
+
+**Technical information**
+
+- Device: [e.g. Nexus 7 (2013)]
+- OS: [e.g. LineageOS 15.1]
+- OpenTracks version: [e.g. v3.2.4]
+- OpenTracks commit id (only for nightly builds): [e.g. 4b333bb]

build.gradle

@@ -59,8 +59,8 @@ android {
 
     defaultConfig {
         applicationId "de.dennisguse.opentracks"
-        versionCode 4938
-        versionName "v4.0.2"
+        versionCode 4951
+        versionName "v4.0.3"
 
         buildConfigField "String", "VERSION_NAME_FULL", "\"${getVersionName()}\""
 
@@ -117,7 +117,7 @@ android {
 }
 
 dependencies {
-    coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:1.1.5'
+    coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:1.1.6'
 
     implementation 'androidx.appcompat:appcompat:1.4.2'
     implementation 'androidx.preference:preference:1.2.0'

fastlane/metadata/android/en-US/changelogs/4951.txt

@@ -0,0 +1,8 @@
+v4.0.3: OpenTracks
+
+Changes:
+- Max. speed as reported by sensor (GPS or BLE)
+
+Bugfix:
+- Prevent crash if OSM Dashboard is not installed
+- GPX track export: do not export empty track segments

src/androidTest/java/de/dennisguse/opentracks/data/ShareContentProviderTest.java

@@ -7,7 +7,6 @@ import android.util.Pair;
 
 import org.junit.Test;
 
-import java.util.HashSet;
 import java.util.Set;
 
 import de.dennisguse.opentracks.data.models.Track;
@@ -24,10 +23,7 @@ public class ShareContentProviderTest {
 
     @Test
     public void testCreateAndParseURI_valid() {
-        Set<Track.Id> trackIds = new HashSet<>();
-        trackIds.add(new Track.Id(1));
-        trackIds.add(new Track.Id(3));
-        trackIds.add(new Track.Id(5));
+        Set<Track.Id> trackIds = Set.of(new Track.Id(1), new Track.Id(3), new Track.Id(5));
 
         Pair<Uri, String> shareURIandMIME = ShareContentProvider.createURI(trackIds, "filename.suffix", TrackFileFormat.KML_WITH_TRACKDETAIL_AND_SENSORDATA);
 
@@ -36,9 +32,7 @@ public class ShareContentProviderTest {
 
     @Test
     public void testCreateURIescapeFilename() {
-        Set<Track.Id> trackIds = new HashSet<>();
-        trackIds.add(new Track.Id(1));
-        Pair<Uri, String> shareURIandMIME = ShareContentProvider.createURI(trackIds, "../../&1=1", TrackFileFormat.KML_WITH_TRACKDETAIL_AND_SENSORDATA);
+        Pair<Uri, String> shareURIandMIME = ShareContentProvider.createURI(Set.of(new Track.Id(1)), "../../&1=1", TrackFileFormat.KML_WITH_TRACKDETAIL_AND_SENSORDATA);
 
         assertEquals(Uri.parse("content://de.dennisguse.opentracks.debug.content/tracks/KML_WITH_TRACKDETAIL_AND_SENSORDATA/1/..%2F..%2F%261%3D1"), shareURIandMIME.first);
     }

src/androidTest/java/de/dennisguse/opentracks/io/file/importer/GPXTrackImporterTest.java

@@ -181,7 +181,7 @@ public class GPXTrackImporterTest {
 
         // 3. trackstatistics
         TrackStatistics trackStatistics = importedTrack.getTrackStatistics();
-        assertEquals(4, trackStatistics.getMaxSpeed().toMPS(), 0.01);
+        assertEquals(4.0, trackStatistics.getMaxSpeed().toMPS(), 0.01);
         assertEquals(Duration.ofSeconds(101), trackStatistics.getMovingTime());
 
         // 4. trackpoints

src/androidTest/java/de/dennisguse/opentracks/stats/TrackStatisticsUpdaterTest.java

@@ -11,6 +11,7 @@ import org.junit.runner.RunWith;
 
 import java.time.Duration;
 import java.time.Instant;
+import java.util.List;
 
 import de.dennisguse.opentracks.content.data.TestDataUtil;
 import de.dennisguse.opentracks.data.models.Altitude;
@@ -245,6 +246,70 @@ public class TrackStatisticsUpdaterTest {
     public void addTrackPoint_speed_from_GPS_moving_and_sensor_speed() {
     }
 
+    @Test
+    public void addTrackPoint_maxSpeed_ignore_above_acceleration() {
+        TrackStatisticsUpdater subject = new TrackStatisticsUpdater();
+        assertEquals(Speed.of(0f), subject.getTrackStatistics().getMaxSpeed());
+
+        subject.addTrackPoint(new TrackPoint(TrackPoint.Type.SEGMENT_START_MANUAL, Instant.ofEpochSecond(0)));
+        assertEquals(Speed.of(0f), subject.getTrackStatistics().getMaxSpeed());
+
+        // Ignore as we set max speed if two consecutive trackpoints were considered moving
+        subject.addTrackPoint(new TrackPoint(0, 0, Altitude.WGS84.of(0), Instant.ofEpochSecond(1))
+                .setSpeed(Speed.of(1f)));
+        assertEquals(Speed.of(0f), subject.getTrackStatistics().getMaxSpeed());
+
+        // Update max speed
+        subject.addTrackPoint(new TrackPoint(0, 0, Altitude.WGS84.of(0), Instant.ofEpochSecond(2))
+                .setSpeed(Speed.of(1f)));
+        assertEquals(Speed.of(1f), subject.getTrackStatistics().getMaxSpeed());
+
+        // Update max speed
+        subject.addTrackPoint(new TrackPoint(0, 0, Altitude.WGS84.of(0), Instant.ofEpochSecond(12))
+                .setSpeed(Speed.of(50f)));
+        assertEquals(Speed.of(50f), subject.getTrackStatistics().getMaxSpeed());
+
+        // Ignore; we were getting slower
+        subject.addTrackPoint(new TrackPoint(0, 0, Altitude.WGS84.of(0), Instant.ofEpochSecond(13))
+                .setSpeed(Speed.of(5f)));
+        assertEquals(Speed.of(50f), subject.getTrackStatistics().getMaxSpeed());
+
+        // Ignore acceleration above 2g
+        subject.addTrackPoint(new TrackPoint(0, 0, Altitude.WGS84.of(0), Instant.ofEpochSecond(14))
+                .setSpeed(Speed.of(500f)));
+        assertEquals(Speed.of(50f), subject.getTrackStatistics().getMaxSpeed());
+
+    }
+
+    @Test
+    public void addTrackPoint_maxSpeed_multiple_segments() {
+        TrackStatisticsUpdater subject = new TrackStatisticsUpdater();
+        assertEquals(Speed.of(0f), subject.getTrackStatistics().getMaxSpeed());
+
+        subject.addTrackPoints(List.of(
+                new TrackPoint(TrackPoint.Type.SEGMENT_START_MANUAL, Instant.ofEpochSecond(0)),
+                new TrackPoint(0, 0, Altitude.WGS84.of(0), Instant.ofEpochSecond(1))
+                        .setSpeed(Speed.of(2f)),
+                new TrackPoint(0, 0, Altitude.WGS84.of(0), Instant.ofEpochSecond(2))
+                        .setSpeed(Speed.of(2f)),
+                new TrackPoint(TrackPoint.Type.SEGMENT_END_MANUAL, Instant.ofEpochSecond(4))
+        ));
+        assertEquals(Speed.of(2f), subject.getTrackStatistics().getMaxSpeed());
+
+        // when
+        subject.addTrackPoints(List.of(
+                new TrackPoint(TrackPoint.Type.SEGMENT_START_MANUAL, Instant.ofEpochSecond(5)),
+                new TrackPoint(0, 0, Altitude.WGS84.of(0), Instant.ofEpochSecond(6))
+                        .setSpeed(Speed.of(1f)),
+                new TrackPoint(0, 0, Altitude.WGS84.of(0), Instant.ofEpochSecond(7))
+                        .setSpeed(Speed.of(1f)),
+                new TrackPoint(TrackPoint.Type.SEGMENT_END_MANUAL, Instant.ofEpochSecond(8))
+        ));
+
+        // then
+        assertEquals(Speed.of(2f), subject.getTrackStatistics().getMaxSpeed());
+    }
+
     @Test
     public void copy_constructor() {
         // given

src/androidTest/java/de/dennisguse/opentracks/util/StringUtilsTest.java

@@ -41,12 +41,12 @@ import java.time.format.TextStyle;
 import java.time.temporal.ChronoUnit;
 import java.util.ArrayList;
 import java.util.Arrays;
-import java.util.GregorianCalendar;
 import java.util.Locale;
 import java.util.TimeZone;
 import java.util.stream.Collectors;
 
 import de.dennisguse.opentracks.LocaleRule;
+import de.dennisguse.opentracks.TimezoneRule;
 
 /**
  * Tests for {@link StringUtils}.
@@ -59,6 +59,9 @@ public class StringUtilsTest {
     @Rule
     public final LocaleRule mLocaleRule = new LocaleRule(Locale.ENGLISH);
 
+    @Rule
+    public TimezoneRule timezoneRule = new TimezoneRule(TimeZone.getTimeZone("Europe/Berlin"));
+
     private final Context context = ApplicationProvider.getApplicationContext();
 
     /**
@@ -99,51 +102,13 @@ public class StringUtilsTest {
     }
 
     @Test
-    public void testGetTime_fractional() {
-        assertGetTime("2010-05-04T03:02:01.352Z", 2010, 5, 4, 3, 2, 1, 352);
-        assertGetTime("2010-05-04T03:02:01.3529Z", 2010, 5, 4, 3, 2, 1, 352);
-    }
+    public void testParseTime() {
+        assertEquals(Instant.ofEpochMilli(352), StringUtils.parseTime("1970-01-01T00:00:00.352").toInstant());
+        assertEquals(Instant.ofEpochMilli(352), StringUtils.parseTime("1970-01-01T00:00:00.352Z").toInstant());
+        assertEquals(Instant.ofEpochMilli(352), StringUtils.parseTime("1970-01-01T00:00:00.352+00:00").toInstant());
 
-    @Test
-    public void testGetTime_timezone() {
-        assertGetTime("2010-05-04T03:02:01", 2010, 5, 4, 3, 2, 1, 0);
-        assertGetTime("2010-05-04T03:02:01Z", 2010, 5, 4, 3, 2, 1, 0);
-        assertGetTime("2010-05-04T03:02:01+00:00", 2010, 5, 4, 3, 2, 1, 0);
-        assertGetTime("2010-05-04T03:02:01-00:00", 2010, 5, 4, 3, 2, 1, 0);
-        assertGetTime("2010-05-04T03:02:01+01:00", 2010, 5, 4, 2, 2, 1, 0);
-        assertGetTime("2010-05-04T03:02:01+10:30", 2010, 5, 3, 16, 32, 1, 0);
-        assertGetTime("2010-05-04T03:02:01-09:30", 2010, 5, 4, 12, 32, 1, 0);
-        assertGetTime("2010-05-04T03:02:01-05:00", 2010, 5, 4, 8, 2, 1, 0);
-    }
-
-    @Test
-    public void testGetTime_fractionalAndTimezone() {
-        assertGetTime("2010-05-04T03:02:01.352Z", 2010, 5, 4, 3, 2, 1, 352);
-        assertGetTime("2010-05-04T03:02:01.47+00:00", 2010, 5, 4, 3, 2, 1, 470);
-        assertGetTime("2010-05-04T03:02:01.5791+03:00", 2010, 5, 4, 0, 2, 1, 579);
-        assertGetTime("2010-05-04T03:02:01.8-05:30", 2010, 5, 4, 8, 32, 1, 800);
-    }
-
-    /**
-     * Asserts the {@link StringUtils#parseTime(String)} returns the expected values.
-     *
-     * @param xmlDateTime the xml date time string
-     * @param year        the expected year
-     * @param month       the expected month
-     * @param day         the expected day
-     * @param hour        the expected hour
-     * @param minute      the expected minute
-     * @param second      the expected second
-     * @param millisecond the expected milliseconds
-     */
-    private void assertGetTime(String xmlDateTime, int year, int month, int day, int hour, int minute, int second, int millisecond) {
-        GregorianCalendar calendar = new GregorianCalendar(TimeZone.getTimeZone("UTC"));
-        calendar.set(year, month - 1, day, hour, minute, second);
-        calendar.set(GregorianCalendar.MILLISECOND, millisecond);
-
-        // This comparision tends to be flaky (difference of 1ms)
-        // Assert.assertEquals(calendar.getTimeInMillis(), StringUtils.parseTime(xmlDateTime));
-        assertTrue(calendar.getTimeInMillis() + " vs. " + StringUtils.parseTime(xmlDateTime), Math.abs(calendar.getTimeInMillis() - StringUtils.parseTime(xmlDateTime).toInstant().toEpochMilli()) <= 1);
+        assertEquals(Instant.ofEpochMilli(352), StringUtils.parseTime("1970-01-01T01:00:00.352+01:00").toInstant());
+        assertEquals(Instant.ofEpochMilli(352).plus(Duration.ofHours(1)), StringUtils.parseTime("1970-01-01T00:00:00.352-01:00").toInstant());
     }
 
     @Test

src/main/java/de/dennisguse/opentracks/chart/ChartFragment.java

@@ -188,9 +188,9 @@ public class ChartFragment extends Fragment implements TrackDataHub.Listener {
         }
     }
 
-    public void onSampledInTrackPoint(@NonNull TrackPoint trackPoint, @NonNull TrackStatistics trackStatistics, Speed smoothedSpeed) {
+    public void onSampledInTrackPoint(@NonNull TrackPoint trackPoint, @NonNull TrackStatistics trackStatistics) {
         if (isResumed()) {
-            ChartPoint point = new ChartPoint(trackStatistics, trackPoint, smoothedSpeed, chartByDistance, viewBinding.chartView.getUnitSystem());
+            ChartPoint point = new ChartPoint(trackStatistics, trackPoint, trackPoint.getSpeed(), chartByDistance, viewBinding.chartView.getUnitSystem());
             pendingPoints.add(point);
         }
     }

src/main/java/de/dennisguse/opentracks/data/ShareContentProvider.java

@@ -24,6 +24,7 @@ import java.util.Collections;
 import java.util.HashSet;
 import java.util.List;
 import java.util.Set;
+import java.util.stream.Collectors;
 
 import de.dennisguse.opentracks.data.models.Track;
 import de.dennisguse.opentracks.data.tables.TracksColumns;
@@ -72,9 +73,7 @@ public class ShareContentProvider extends CustomContentProvider {
      * @return An URI for one file containing this tracks.
      */
     public static Pair<Uri, String> createURI(Track.Id trackId, String trackName, @NonNull TrackFileFormat trackFileFormat) {
-        Set<Track.Id> trackIds = new HashSet<>(1);
-        trackIds.add(trackId);
-        return createURI(trackIds, trackName, trackFileFormat);
+        return createURI(Set.of(trackId), trackName, trackFileFormat);
     }
 
     /**
@@ -108,11 +107,7 @@ public class ShareContentProvider extends CustomContentProvider {
 
         String[] uriTrackIds = uriPaths.get(2).split(TRACKID_DELIMITER);
 
-        Set<Track.Id> trackIds = new HashSet<>();
-        for (String uriTrackId : uriTrackIds) {
-            trackIds.add(new Track.Id(Long.parseLong(uriTrackId)));
-        }
-        return trackIds;
+        return Arrays.stream(uriTrackIds).map(uriTrackId -> new Track.Id(Long.parseLong(uriTrackId))).collect(Collectors.toSet());
     }
 
     /**

src/main/java/de/dennisguse/opentracks/data/TrackDataHub.java

@@ -25,14 +25,12 @@ import android.os.HandlerThread;
 import android.util.Log;
 
 import androidx.annotation.NonNull;
-import androidx.annotation.Nullable;
 import androidx.annotation.VisibleForTesting;
 
 import java.util.Collections;
 import java.util.HashSet;
 import java.util.Set;
 
-import de.dennisguse.opentracks.data.models.Altitude;
 import de.dennisguse.opentracks.data.models.Marker;
 import de.dennisguse.opentracks.data.models.Speed;
 import de.dennisguse.opentracks.data.models.Track;
@@ -367,7 +365,7 @@ public class TrackDataHub {
                 // Also include the last point if the selected track is not recording.
                 if ((localNumLoadedTrackPoints % samplingFrequency == 0) || (trackPointId == lastTrackPointId && !isSelectedTrackRecording())) {
                     for (Listener trackDataListener : listeners) {
-                        trackDataListener.onSampledInTrackPoint(trackPoint, currentUpdater.getTrackStatistics(), currentUpdater.getSmoothedSpeed());
+                        trackDataListener.onSampledInTrackPoint(trackPoint, currentUpdater.getTrackStatistics());
                     }
                 } else {
                     for (Listener trackDataListener : listeners) {
@@ -432,7 +430,7 @@ public class TrackDataHub {
          *
          * @param trackPoint the trackPoint
          */
-        default void onSampledInTrackPoint(@NonNull TrackPoint trackPoint, @NonNull TrackStatistics trackStatistics, Speed smoothedSpeed) {
+        default void onSampledInTrackPoint(@NonNull TrackPoint trackPoint, @NonNull TrackStatistics trackStatistics) {
         }
 
         /**

src/main/java/de/dennisguse/opentracks/data/models/UnitConversions.java

@@ -24,6 +24,7 @@ public class UnitConversions {
 
     // Time //TODO Use Duration
     // multiplication factor to convert seconds to milliseconds
+    @Deprecated
     public static final long S_TO_MS = 1000;
 
     // multiplication factor to convert milliseconds to seconds

src/main/java/de/dennisguse/opentracks/io/file/exporter/GPXTrackExporter.java

@@ -146,13 +146,10 @@ public class GPXTrackExporter implements TrackExporter {
 
                 switch (trackPoint.getType()) {
                     case SEGMENT_START_MANUAL:
-                        if (wroteSegment) writeCloseSegment();
-                        writeOpenSegment();
-                        wroteSegment = true;
                         Log.i(TAG, "Exporting " + TrackPoint.Type.SEGMENT_START_MANUAL.name() + " is not supported.");
                         break;
                     case SEGMENT_END_MANUAL:
-                        writeCloseSegment();
+                        if (wroteSegment) writeCloseSegment();
                         wroteSegment = false;
                         Log.i(TAG, "Exporting " + TrackPoint.Type.SEGMENT_END_MANUAL.name() + " is not supported.");
                         break;

src/main/java/de/dennisguse/opentracks/stats/RingBuffer.java

@@ -1,138 +0,0 @@
-/*
- * Copyright 2009 Google Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the "License"); you may not
- * use this file except in compliance with the License. You may obtain a copy of
- * the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations under
- * the License.
- */
-
-package de.dennisguse.opentracks.stats;
-
-import androidx.annotation.NonNull;
-import androidx.annotation.Nullable;
-
-import java.util.ArrayList;
-
-/**
- * This class maintains a ring buffer of doubles.
- * This buffer is a convenient class for storing a series of doubles and calculating information about them.
- * This is a FIFO buffer.
- *
- * @author Sandor Dornbush
- */
-abstract class RingBuffer<T> {
-
-    private final ArrayList<T> buffer;
-
-    // The location that the next write will occur at.
-    private int index;
-
-    // True if the buffer is full
-    private boolean isFull;
-
-    /**
-     * Creates a buffer with a certain size.
-     *
-     * @param size the size
-     */
-    RingBuffer(int size) {
-        if (size < 1) {
-            throw new IllegalArgumentException("The buffer size must be greater than 1.");
-        }
-
-        buffer = new ArrayList<T>(size);
-        reset();
-    }
-
-    RingBuffer(RingBuffer<T> toCopy) {
-        this.buffer = new ArrayList<>(toCopy.buffer);
-        this.index = toCopy.index;
-        this.isFull = toCopy.isFull;
-    }
-
-    /**
-     * Resets the buffer.
-     */
-    public void reset() {
-        index = 0;
-        isFull = false;
-    }
-
-    /**
-     * Returns true if the buffer is full.
-     */
-    boolean isFull() {
-        return isFull;
-    }
-
-    /**
-     * Gets the average of the buffer.
-     */
-    public T getAverage() {
-        int numberOfEntries = isFull ? buffer.size() : index;
-        if (numberOfEntries == 0) {
-            return null;
-        }
-        Double sum = null;
-        int numberOfUsedEntries = 0;
-        for (int i = 0; i < numberOfEntries; i++) {
-            Number value = from(buffer.get(i));
-            if (value != null) {
-                if (sum == null) {
-                    sum = 0.0;
-                }
-                sum += value.doubleValue();
-                numberOfUsedEntries++;
-            }
-        }
-        if (sum == null) {
-            return null;
-        } else {
-            return to(sum / numberOfUsedEntries);
-        }
-    }
-
-    @Nullable
-    protected abstract Number from(T object);
-
-    protected abstract T to(double object);
-
-    /**
-     * Adds a double to the buffer.
-     * If the buffer is full the oldest element is overwritten.
-     *
-     * @param value the double to add
-     */
-    public void setNext(T value) {
-        if (index == buffer.size()) {
-            index = 0;
-        }
-        buffer.add(index, value);
-        index++;
-        if (index == buffer.size()) {
-            isFull = true;
-        }
-    }
-
-    @NonNull
-    @Override
-    public String toString() {
-        StringBuilder builder = new StringBuilder("Full: ");
-        builder.append(isFull);
-        builder.append("\n");
-        for (int i = 0; i < buffer.size(); i++) {
-            builder.append((i == index) ? "<<" : "[");
-            builder.append(buffer.get(i));
-            builder.append((i == index) ? ">> " : "] ");
-        }
-        return builder.toString();
-    }
-}

src/main/java/de/dennisguse/opentracks/stats/SpeedRingBuffer.java

@@ -1,27 +0,0 @@
-package de.dennisguse.opentracks.stats;
-
-import androidx.annotation.Nullable;
-
-import de.dennisguse.opentracks.data.models.Speed;
-
-public class SpeedRingBuffer extends RingBuffer<Speed> {
-
-    SpeedRingBuffer(int size) {
-        super(size);
-    }
-
-    SpeedRingBuffer(RingBuffer<Speed> toCopy) {
-        super(toCopy);
-    }
-
-    @Nullable
-    @Override
-    protected Number from(Speed object) {
-        return object.toMPS();
-    }
-
-    @Override
-    protected Speed to(double object) {
-        return Speed.of(object);
-    }
-}

src/main/java/de/dennisguse/opentracks/stats/TrackStatisticsUpdater.java

@@ -19,16 +19,15 @@ package de.dennisguse.opentracks.stats;
 import android.util.Log;
 
 import androidx.annotation.NonNull;
-import androidx.annotation.VisibleForTesting;
 
 import java.time.Duration;
 import java.util.List;
 
-import de.dennisguse.opentracks.data.models.Altitude;
 import de.dennisguse.opentracks.data.models.Distance;
 import de.dennisguse.opentracks.data.models.HeartRate;
 import de.dennisguse.opentracks.data.models.Speed;
 import de.dennisguse.opentracks.data.models.TrackPoint;
+import de.dennisguse.opentracks.data.models.UnitConversions;
 
 /**
  * Updater for {@link TrackStatistics}.
@@ -41,23 +40,15 @@ import de.dennisguse.opentracks.data.models.TrackPoint;
  */
 public class TrackStatisticsUpdater {
 
-    /**
-     * The number of speed reading to smooth to get a somewhat accurate signal.
-     */
-    @VisibleForTesting
-    private static final int SPEED_SMOOTHING_FACTOR = 25;
-
     private static final String TAG = TrackStatisticsUpdater.class.getSimpleName();
     /**
      * Ignore any acceleration faster than this.
      * Will ignore any speeds that imply acceleration greater than 2g's
-     * 2g = 19.6 m/s^2 = 0.0002 m/ms^2 = 0.02 m/(m*ms)
      */
-    private static final double MAX_ACCELERATION = 0.02;
+    private static final double SPEED_MAX_ACCELERATION = 2 * 9.81;
 
     private final TrackStatistics trackStatistics;
 
-    private final SpeedRingBuffer speedBuffer;
     private float averageHeartRateBPM;
     private Duration totalHeartRateDuration = Duration.ZERO;
 
@@ -79,7 +70,6 @@ public class TrackStatisticsUpdater {
         this.trackStatistics = trackStatistics;
         this.currentSegment = new TrackStatistics();
 
-        speedBuffer = new SpeedRingBuffer(SPEED_SMOOTHING_FACTOR);
         resetAverageHeartRate();
     }
 
@@ -87,8 +77,6 @@ public class TrackStatisticsUpdater {
         this.currentSegment = new TrackStatistics(toCopy.currentSegment);
         this.trackStatistics = new TrackStatistics(toCopy.trackStatistics);
 
-        this.speedBuffer = new SpeedRingBuffer(toCopy.speedBuffer);
-
         this.lastTrackPoint = toCopy.lastTrackPoint;
         resetAverageHeartRate();
     }
@@ -165,11 +153,8 @@ public class TrackStatisticsUpdater {
 
             // Update max speed
             updateSpeed(trackPoint, lastTrackPoint);
-        } else {
-            speedBuffer.reset();
         }
 
-
         if (trackPoint.isSegmentEnd()) {
             reset(trackPoint);
             return;
@@ -185,7 +170,6 @@ public class TrackStatisticsUpdater {
         currentSegment.reset(trackPoint.getTime());
 
         lastTrackPoint = null;
-        speedBuffer.reset();
         resetAverageHeartRate();
     }
 
@@ -194,22 +178,14 @@ public class TrackStatisticsUpdater {
         totalHeartRateDuration = Duration.ZERO;
     }
 
-    public Speed getSmoothedSpeed() {
-        return speedBuffer.getAverage();
-    }
-
     /**
      * Updates a speed reading while assuming the user is moving.
      */
-    @VisibleForTesting
     private void updateSpeed(@NonNull TrackPoint trackPoint, @NonNull TrackPoint lastTrackPoint) {
-        if (!trackPoint.isMoving()) {
-            speedBuffer.reset();
-        } else if (isValidSpeed(trackPoint, lastTrackPoint)) {
-            speedBuffer.setNext(trackPoint.getSpeed());
-            Speed average = speedBuffer.getAverage();
-            if (average.greaterThan(currentSegment.getMaxSpeed())) {
-                currentSegment.setMaxSpeed(average);
+        if (isValidSpeed(trackPoint, lastTrackPoint)) {
+            Speed currentSpeed = trackPoint.getSpeed();
+            if (currentSpeed.greaterThan(currentSegment.getMaxSpeed())) {
+                currentSegment.setMaxSpeed(currentSpeed);
             }
         } else {
             Log.d(TAG, "Invalid speed. speed: " + trackPoint.getSpeed() + " lastLocationSpeed: " + lastTrackPoint.getSpeed());
@@ -217,30 +193,13 @@ public class TrackStatisticsUpdater {
     }
 
     private boolean isValidSpeed(@NonNull TrackPoint trackPoint, @NonNull TrackPoint lastTrackPoint) {
-        // There are a lot of noisy speed readings. Do the cheapest checks first, most expensive last.
-        if (trackPoint.getSpeed().isZero()) {
-            return false;
-        }
-
+        // See if the speed seems physically likely. Ignore any speeds that imply acceleration greater than 2g.
         Duration timeDifference = Duration.between(lastTrackPoint.getTime(), trackPoint.getTime());
-        Speed maxAcceleration = Speed.of(MAX_ACCELERATION * timeDifference.toMillis());
-        {
-            // See if the speed seems physically likely. Ignore any speeds that imply acceleration greater than 2g.
-            Speed speedDifference = Speed.absDiff(lastTrackPoint.getSpeed(), trackPoint.getSpeed());
-            if (speedDifference.greaterThan(maxAcceleration)) {
-                return false;
-            }
-        }
+        Speed maxSpeedDifference = Speed.of(Distance.of(SPEED_MAX_ACCELERATION), Duration.ofMillis(1000))
+                .mul(timeDifference.toMillis() / UnitConversions.S_TO_MS);
 
-        // Only check if the speed buffer is full. Check that the speed is less than 10X the smoothed average and the speed difference doesn't imply 2g acceleration.
-        if (speedBuffer.isFull()) {
-            Speed average = speedBuffer.getAverage();
-            Speed speedDifference = Speed.absDiff(average, trackPoint.getSpeed());
-
-            return trackPoint.getSpeed().lessThan(average.mul(10)) && speedDifference.lessThan(maxAcceleration);
-        }
-
-        return true;
+        Speed speedDifference = Speed.absDiff(lastTrackPoint.getSpeed(), trackPoint.getSpeed());
+        return speedDifference.lessThan(maxSpeedDifference);
     }
 
     @NonNull

src/main/java/de/dennisguse/opentracks/util/IntentDashboardUtils.java

@@ -1,11 +1,13 @@
 package de.dennisguse.opentracks.util;
 
+import android.content.ActivityNotFoundException;
 import android.content.ClipData;
 import android.content.Context;
 import android.content.Intent;
 import android.net.Uri;
 import android.util.Log;
 import android.util.Pair;
+import android.widget.Toast;
 
 import androidx.appcompat.app.AlertDialog;
 
@@ -173,7 +175,12 @@ public class IntentDashboardUtils {
             Log.i(TAG, "Starting dashboard activity with generic intent (package=" + targetPackage + ", class=" + targetClass + ")");
         }
 
-        context.startActivity(intent);
+        try {
+            context.startActivity(intent);
+        } catch (ActivityNotFoundException e) {
+            Log.e(TAG, "Dashboard not installed; cannot start it.");
+            Toast.makeText(context, R.string.show_on_dashboard_not_installed, Toast.LENGTH_SHORT).show();
+        }
     }
 
     /**

src/main/res/values-cs/strings.xml

@@ -15,14 +15,14 @@ See the License for the specific language governing permissions and
 limitations under the License.
 --><resources>
     <string name="about_preference_title">O OpenTracks</string>
-    <string name="about_description"><i> OpenTracks </i> je sportovní sledovací aplikace, která zcela respektuje vaše soukromí.</string>
+    <string name="about_description"><i> OpenTracks </i> je aplikace pro záznam vašich sportů, která zcela respektuje vaše soukromí.</string>
     <string name="about_url">Webová stránka projektu: <a href="%1$s">%1$s</a></string>
     <string name="about_version_name">Název verze: %1$s</string>
     <string name="about_version_code">Kód verze: %1$d</string>
-    <string name="about_history">OpenTracks je fork aplikace <a href="https://code.google.com/archive/p/mytracks/"> <i> MyTracks Google </i> </a> (v roce 2016 ukončena).</string>
+    <string name="about_history">OpenTracks je fork aplikace <a href="https://code.google.com/archive/p/mytracks/"> <i> MyTracks Google </i> </a> (ukončena v roce 2016).</string>
     <string name="about_libraries">Knihovny</string>
     <!-- Help -->
-    <string name="help_feature_title">OpenTracks má následující funkce:</string>
+    <string name="help_feature_title">OpenTracks dokáže:</string>
     <string name="help_feature_content">* vytvářet GPS stopy
 \n* použít snímač srdeční frekvence (pouze Bluetooth LE)
 \n* hlasová oznámení (podle času nebo vzdálenosti)
@@ -34,14 +34,14 @@ limitations under the License.
 \n a) (živé aktualizace) Nainstalujte <a href="https://github.com/OpenTracksApp/OSMDashboard">OSMDashboard</a>. Poskytuje online nebo offline mapy prostřednictvím <a href="https://www.openstreetmap.org">OpenStreetMap</a>.
 \n Ve skutečnosti je OSMDashboard samostatná aplikace, která má přístup (dočasně) pouze k datům stop, které se budou zobrazovat.
 \n b) Prostřednictvím „normální“ mapové aplikace (např. <a href="http://osmand.net/">OsmAnd</a> a <a href="https://maps.me/">MAPS.ME</a>). Tyto aplikace musí podporovat formát souboru KMZ (pouze umístění a časová razítka). Ve skutečnosti musí aplikace podporovat <i>ACTION_VIEW</i> pomocí MIME <i>application/vnd.google-earth.kmz</i>. </string>
-    <string name="help_storage_pictures_title">Jak ukládá OpenTracks obrázky pořízené jako značky?</string>
+    <string name="help_storage_pictures_title">Jak ukládá OpenTracks obrázky pořízené jako značky na cestě\?</string>
     <string name="help_storage_pictures_content">Jsou uloženy v interním úložišti aplikace (tj. přístupné pouze v rámci OpenTracks).</string>
     <string name="help_track_export_title">Jak mohu exportovat/sdílet zaznamenané stopy\?</string>
-    <string name="help_track_export_content"> Trasy lze exportovat z Nastavení jako KMZ, KML nebo GPX. KMZ a KML obsahuje všechna data, GPX pouze umístění. Trasy sdílené pomocí <i>ikony sdílení</i> jsou sdíleny jako KMZ. </string>
+    <string name="help_track_export_content"> Trasy lze exportovat z Nastavení jako KMZ, KML nebo GPX. KMZ a KML obsahuje všechna data, GPX pouze polohu. Trasy sdílené pomocí <i>ikony sdílení</i> jsou sdíleny jako KMZ. </string>
     <string name="help_data_google_play_services_title">Vyžaduje/používá OpenTracks službu Google Play\?</string>
     <string name="help_recording_title">Jak OpenTracks zaznamenává data?</string>
     <string name="help_recording_content">OpenTracks používá GPS senzor zařízení k nepřetržitému zaznamenávání polohy. Pokud zařízení GPS hlásí nepřesná data (např. polohu, rychlost, nadmořskou výšku), OpenTracks s tím nemůže nic udělat.</string>
-    <string name="help_data_storage_title">Jak OpenTracks ukládá data senzorů?</string>
+    <string name="help_data_storage_title">Jak OpenTracks ukládá data ze senzorů\?</string>
     <string name="help_data_storage_content"> Data senzoru se ukládají na zaznamenané místo. Pokud jde o snímač srdeční frekvence, znamená to, že na každé místo je uloženo pouze <i> jedno </i> měření srdeční frekvence. Pokud stojíte v klidu nebo jste uvnitř, nebudou zaznamenána žádná data ze senzorů (ale budou zobrazena). </string>
     <string name="help_gps_troubleshooting_title">OpenTracks nezaznamenává místa?</string>
     <string name="help_gps_troubleshooting_content"> Co můžete udělat:

src/main/res/values-nb/strings.xml

@@ -206,10 +206,10 @@ limitations under the License.
 \n%1$s</string>
     <string name="share_track_subject">Jeg vil dele et spor med deg</string>
     <!-- Stats -->
-    <string name="stats_average_moving_pace">Gjennomsnittlig forflytningstempo</string>
-    <string name="stats_average_moving_speed">Gjennomsnittlig forflytningshastighet</string>
-    <string name="stats_average_pace">Gjennomsnittlig tempo</string>
-    <string name="stats_average_speed">Gjennomsnittlig hastighet</string>
+    <string name="stats_average_moving_pace">Gj. forflytningstempo</string>
+    <string name="stats_average_moving_speed">Gj. forflytningshastighet</string>
+    <string name="stats_average_pace">Gj. tempo</string>
+    <string name="stats_average_speed">Gj. hastighet</string>
     <string name="stats_altitude">Høyde</string>
     <string name="stats_fastest_pace">Raskeste tempo</string>
     <string name="stats_gain">Total stigning</string>
@@ -449,11 +449,11 @@ limitations under the License.
     <string name="generic_open_track">Åpne spor</string>
     <string name="import_progress_summary_exists_msg">Finnes allerede</string>
     <string name="import_progress_summary_errors_msg">Feil</string>
-    <string name="sensor_state_cadence_avg">Gjennomsnittlig kadens</string>
+    <string name="sensor_state_cadence_avg">Gj. kadens</string>
     <string name="sensor_state_cadence_max">Maks kadens</string>
-    <string name="sensor_state_heart_rate_avg">Gjennomsnittlig puls</string>
+    <string name="sensor_state_heart_rate_avg">Gj. puls</string>
     <string name="sensor_state_heart_rate_max">Maks puls</string>
-    <string name="sensor_state_power_avg">Gjennomsnittlig kraft</string>
+    <string name="sensor_state_power_avg">Gj. kraft</string>
     <string name="settings_sensor_wheel_circumference">Hjulomkrets (mm)</string>
     <string name="track_distance_notification">Distanse: %1$s</string>
     <string name="track_speed_notification">Hastighet: %1$s</string>
@@ -575,4 +575,28 @@ limitations under the License.
     <string name="show_on_map_format_ask">Spør</string>
     <string name="show_on_dashboard">OpenTracks Dashboard API</string>
     <string name="always">Alltid</string>
+    <string name="settings_announcements_average_heart_rate">Gjennomsnittlig puls</string>
+    <string name="settings_announcements_lap_heart_rate">Runde-puls</string>
+    <string name="settings_announcements_average_speed_pace">Gjennomsnittlig hastighet/tempo</string>
+    <string name="image_discard">Forkast</string>
+    <string name="settings_announcements_lap_speed_pace">Runde-hastighet/tempo</string>
+    <string name="description_pace_nautical">Tempo (min/NM)</string>
+    <string name="description_speed_nautical">Hastighet (knop)</string>
+    <string name="settings_stats_units_nautical">Nautisk (NM, ft)</string>
+    <string name="track_discarding">Forkaster spor</string>
+    <string name="unit_nautical_mile">NM</string>
+    <string name="unit_knots">kn</string>
+    <string name="unit_minute_per_nautical_mile">min/NM</string>
+    <string name="value_integer_knots">%1$d knop</string>
+    <string name="value_float_knots">%1$.1f knop</string>
+    <string name="value_float_knots_recommended">%1$.1f knop (anbefales)</string>
+    <string name="voice_per_nautical_mile">per nautisk mil</string>
+    <plurals name="voiceSpeedMKnots">
+        <item quantity="one">1 knop</item>
+        <item quantity="other">%1$.1f knop</item>
+    </plurals>
+    <plurals name="voiceDistanceNauticalMiles">
+        <item quantity="one">1 nautisk mil</item>
+        <item quantity="other">%1$.2f nautiske mil</item>
+    </plurals>
 </resources>

src/main/res/values-tr/strings.xml

@@ -462,7 +462,7 @@ limitations under the License.
     <string name="permission_gps_failed">OpenTracks GPS kullanmak için izin gerektirir.</string>
     <string name="import_progress_summary_ok_msg">Dosyalar içe aktarıldı</string>
     <string name="settings_defaults_title">Varsayılan Birimler ve Etkinlik</string>
-    <string name="settings_ui_title">Kullanıcı arayüzü</string>
+    <string name="settings_ui_title">Kullanıcı Arayüzü</string>
     <string name="settings_default_trackfileformat">Dosya biçimini dışa aktarma/paylaşma</string>
     <string name="settings_export_filename_title">Dosya adının biçimi</string>
     <string name="settings_import_export_title">İçe/Dışa Aktar</string>
@@ -477,7 +477,7 @@ limitations under the License.
     <string name="settings_recording_keep_screen_on_while_recording_summary">Kayıt esnasında ekranı açık tutar.</string>
     <string name="settings_recording_fullscreen_on_while_recording_summary">Kayıt esnasında tam ekranda sunar.</string>
     <string name="settings_recording_idle_speed_title">Boşta hız eşiği</string>
-    <string name="settings_night_mode_title">Kullanıcı Arayüzü Teması</string>
+    <string name="settings_night_mode_title">Kullanıcı arayüzü teması</string>
     <string name="settings_night_mode_option_system">Sistem</string>
     <string name="settings_night_mode_option_night">Gece</string>
     <string name="custom_layout_select_layout">Dizilim seçin</string>
@@ -487,8 +487,8 @@ limitations under the License.
     <string name="settings_layout_reset_done">Tüm dizilim ayarları varsayılan değerlere döndürüldü</string>
     <string name="settings_public_api_enabled_title">Genel API</string>
     <string name="settings_public_api_enabled_summary_on">Diğer yüklü uygulamalar kayıtları başlatabilir veya durdurabilir.</string>
-    <string name="settings_import_section">İçe aktar</string>
-    <string name="settings_export_section">Dışa aktar</string>
+    <string name="settings_import_section">İçe Aktarma</string>
+    <string name="settings_export_section">Dışa Aktarma</string>
     <string name="settings_prevent_reimport_tracks_title">Parçaların yeniden içe aktarılmasını önleme</string>
     <string name="stats_coordinates">Enlem/Boylam</string>
     <string name="stats_sensors_power">Güç</string>
@@ -571,4 +571,23 @@ limitations under the License.
     <string name="report_bug">Hata bildir</string>
     <string name="error_crash_title">%1$s çöktü</string>
     <string name="select_show_on_map_behavior">\"Haritada göster\" eylemini seçin</string>
+    <string name="settings_announcements_average_heart_rate">Ortalama kalp atış hızı</string>
+    <string name="description_pace_nautical">Tempo (dk/NM)</string>
+    <string name="description_speed_nautical">Hız (düğüm)</string>
+    <string name="settings_announcements_average_speed_pace">Ortalama hız/tempo</string>
+    <string name="settings_announcements_lap_speed_pace">Tur hızı/temposu</string>
+    <string name="settings_stats_units_nautical">Deniz (NM, ft)</string>
+    <string name="unit_minute_per_nautical_mile">dk/NM</string>
+    <string name="value_integer_knots">%1$d düğüm</string>
+    <string name="value_float_knots">%1$.1f düğüm</string>
+    <string name="value_float_knots_recommended">%1$.1f düğüm (önerilen)</string>
+    <plurals name="voiceSpeedMKnots">
+        <item quantity="one">1 düğüm</item>
+        <item quantity="other">%1$.1f düğüm</item>
+    </plurals>
+    <string name="voice_per_nautical_mile">deniz mili başına</string>
+    <plurals name="voiceDistanceNauticalMiles">
+        <item quantity="one">1 deniz mili</item>
+        <item quantity="other">%1$.2f deniz mili</item>
+    </plurals>
 </resources>

src/main/res/values/strings.xml

@@ -666,5 +666,6 @@ limitations under the License.
     <string name="select_show_on_map_behavior">Select \"show on map\" behavior</string>
     <string name="show_on_map_format_ask">Ask</string>
     <string name="show_on_dashboard">OpenTracks Dashboard API</string>
+    <string name="show_on_dashboard_not_installed">No application supporting OpenTracks Dashboard API installed.</string>
     <string name="always">Always</string>
 </resources>