WIP

Fixes #2093.

.github/workflows/test.yml

@@ -27,7 +27,7 @@ jobs:
           sudo udevadm trigger --name-match=kvm
 
       - name: run tests
-        uses: reactivecircus/android-emulator-runner@v2.33.0
+        uses: reactivecircus/android-emulator-runner@v2.34.0
         with:
           arch: x86_64
           api-level: 34

README.md

@@ -135,6 +135,7 @@ The Public API is disabled by default to protect the user's privacy, but it can
 | [FitTrackee](https://github.com/SamR1/FitTrackee)         | yes                                                                            | n/a                                                                  | n/a                                                                  |
 | [SportsTracker](https://github.com/ssaring/sportstracker) | yes, [single tracks only](https://github.com/ssaring/sportstracker/issues/260) | no                                                                   | no                                                                   |
 | [ExifTool](https://exiftool.org)                          | [yes](https://exiftool.org/forum/index.php?topic=15972.0)                      | no                                                                   | no                                                                   |
+| [Wanderer](https://wanderer.to/)                          | yes                      | yes                                                                   | yes                                                                   |
 
 
 ## Dashboard API (incl. map)

build.gradle

@@ -6,7 +6,7 @@ buildscript {
         mavenCentral()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:8.9.0'
+        classpath 'com.android.tools.build:gradle:8.9.1'
     }
 }
 
@@ -33,7 +33,7 @@ android {
         targetCompatibility JavaVersion.VERSION_17
     }
 
-    compileSdk = 35
+    compileSdk = 36
 
     buildFeatures {
         viewBinding = true
@@ -52,7 +52,7 @@ android {
         buildConfigField "String", "VERSION_NAME_FULL", "\"${getVersionName()}\""
 
         minSdk = 26
-        targetSdk = 35
+        targetSdk = 36
 
         testInstrumentationRunner 'de.dennisguse.opentracks.TestRunner'
         testInstrumentationRunnerArguments clearPackageData: 'true'
@@ -145,10 +145,10 @@ dependencies {
     implementation 'androidx.appcompat:appcompat:1.7.0'
     implementation 'androidx.preference:preference:1.2.1'
     implementation 'androidx.documentfile:documentfile:1.0.1'
-    implementation 'androidx.gridlayout:gridlayout:1.0.0'
+    implementation 'androidx.gridlayout:gridlayout:1.1.0'
     implementation 'com.google.android.material:material:1.12.0'
     implementation 'androidx.constraintlayout:constraintlayout:2.2.1'
-    implementation 'androidx.core:core:1.15.0'
+    implementation 'androidx.core:core:1.16.0'
     implementation 'androidx.core:core-splashscreen:1.0.1'
     implementation 'androidx.mediarouter:mediarouter:1.7.0'
     implementation 'androidx.core:core-location-altitude:1.0.0-alpha03'
@@ -158,7 +158,7 @@ dependencies {
     androidTestImplementation 'androidx.test:rules:1.6.1'
     androidTestImplementation 'androidx.test:runner:1.6.2'
     androidTestImplementation 'androidx.test.espresso:espresso-core:3.6.1'
-    androidTestImplementation 'org.mockito:mockito-android:5.16.0'
+    androidTestImplementation 'org.mockito:mockito-android:5.17.0'
 
     androidTestUtil 'androidx.test:orchestrator:1.5.1'
 }

fastlane/metadata/android/cs-CZ/changelogs/6095.txt

@@ -0,0 +1,11 @@
+v4.18.0: OpenTracks
+
+Změny:
+- Varování o zakázané poloze lze vypnout
+
+Oprava chyby:
+- BottomAppBar překrýval obsah
+
+Vývojář:
+- Použití zaznamenané pozice namísto polohy systému Android
+- Předělány agregátory senzorů

fastlane/metadata/android/ga/changelogs/6095.txt

@@ -0,0 +1,11 @@
+v4.18.0: OpenTracks
+
+Athruithe:
+- Is féidir rabhadh faoi mhíchumas GPS a dhíchumasú
+
+Ceartúchán Bug:
+- Ábhar forluiteach BottomAppBar
+
+Forbróir:
+- Úsáid taifead Seasamh in ionad Android suíomh
+- Comhbhailitheoirí braite athfhachtóirithe

fastlane/metadata/android/nl-NL/changelogs/6095.txt

@@ -0,0 +1,11 @@
+v4.18.0: OpenTracks
+
+Wijzigingen:
+- GPS uitgeschakeld waarschuwing kan worden uitgeschakeld
+
+Bugfix:
+- BottomAppBar overlapte inhoud
+
+Ontwikkelaar:
+- Gebruik recordpositie in plaats van Android-locatie
+- Gerefactoreerde sensor-aggregators

fastlane/metadata/android/zh-CN/changelogs/6095.txt

@@ -0,0 +1,11 @@
+v4.18.0: OpenTracks
+
+更改：
+- GPS 禁用警告可被禁用
+
+错误修复：
+- BottomAppBar 重叠内容
+
+开发相关：
+- 使用记录位置代替 Android 位置
+- 重构了传感器聚合器

src/androidTest/java/de/dennisguse/opentracks/io/file/exporter/FITv2TrackExporterTest.java

@@ -0,0 +1,44 @@
+package de.dennisguse.opentracks.io.file.exporter;
+
+import org.junit.Test;
+
+import java.nio.ByteBuffer;
+import java.nio.ByteOrder;
+
+public class FITv2TrackExporterTest {
+
+    private final byte FIT_PROTOCOL_VERSION = 2 << 4 + 0;
+    private final short FIT_PROFILE_VERSION = 21 * 1000 + 158;
+
+    private long checksum;
+    private final byte FILE_HEADER_SIZE = 14;
+
+    @Test
+    public void run() {
+        ByteBuffer littleEndian = ByteBuffer
+                .allocate(FILE_HEADER_SIZE)
+                .order(ByteOrder.LITTLE_ENDIAN);
+
+        littleEndian.put(0, FILE_HEADER_SIZE);
+        littleEndian.put(1, FIT_PROTOCOL_VERSION);
+
+        // Profile version: 1513
+        littleEndian.putShort(2, FIT_PROFILE_VERSION);
+
+        // Data size: 32bit
+        littleEndian.putInt(4, 0); // We do not calculate the data size.
+
+        // .FIT
+        littleEndian.putChar(8, '.');
+        littleEndian.putChar(9, 'F');
+        littleEndian.putChar(10, 'I');
+        littleEndian.putChar(11, 'T');
+
+        // CRC (not implemented)
+        littleEndian.put(12, (byte) 0);
+        littleEndian.put(13, (byte) 0);
+
+        var a = littleEndian.array();
+        littleEndian.array();
+    }
+}

src/androidTest/java/de/dennisguse/opentracks/io/file/importer/ExportImportTest.java

@@ -312,7 +312,7 @@ public class ExportImportTest {
         contentProviderUtils.deleteTrack(context, trackId);
 
         // 2. import
-        KmzTrackImporter importer = new KmzTrackImporter(context, trackImporter);
+        KMZTrackImporter importer = new KMZTrackImporter(context, trackImporter);
         importTrackId = importer.importFile(tmpFileUri).get(0);
 
         // then
@@ -358,7 +358,7 @@ public class ExportImportTest {
 
         // 2. import
         InputStream inputStream = context.getContentResolver().openInputStream(tmpFileUri);
-        XMLImporter importer = new XMLImporter(new KmlTrackImporter(context, trackImporter));
+        XMLImporter importer = new XMLImporter(new KMLTrackImporter(context, trackImporter));
         importTrackId = importer.importFile(inputStream).get(0);
 
         // then
@@ -383,7 +383,7 @@ public class ExportImportTest {
 
         // 2. import
         InputStream inputStream = context.getContentResolver().openInputStream(tmpFileUri);
-        XMLImporter importer = new XMLImporter(new GpxTrackImporter(context, trackImporter));
+        XMLImporter importer = new XMLImporter(new GPXTrackImporter(context, trackImporter));
         importTrackId = importer.importFile(inputStream).get(0);
 
         // then
@@ -503,7 +503,7 @@ public class ExportImportTest {
 
         // 2. import
         InputStream inputStream = context.getContentResolver().openInputStream(tmpFileUri);
-        XMLImporter importer = new XMLImporter(new GpxTrackImporter(context, trackImporter));
+        XMLImporter importer = new XMLImporter(new GPXTrackImporter(context, trackImporter));
         importTrackId = importer.importFile(inputStream).get(0);
 
         // then

src/androidTest/java/de/dennisguse/opentracks/io/file/importer/GPXTrackImporterTest.java

@@ -68,7 +68,7 @@ public class GPXTrackImporterTest {
     @Test
     public void gpx_with_pause_resume() throws IOException {
         // given
-        XMLImporter importer = new XMLImporter(new GpxTrackImporter(context, trackImporter));
+        XMLImporter importer = new XMLImporter(new GPXTrackImporter(context, trackImporter));
         InputStream inputStream = InstrumentationRegistry.getInstrumentation().getContext().getResources().openRawResource(de.dennisguse.opentracks.test.R.raw.legacy_gpx_pause_resume);
 
         // when
@@ -132,7 +132,7 @@ public class GPXTrackImporterTest {
     @Test
     public void gpx_without_speed() throws IOException {
         // given
-        XMLImporter importer = new XMLImporter(new GpxTrackImporter(context, trackImporter));
+        XMLImporter importer = new XMLImporter(new GPXTrackImporter(context, trackImporter));
         InputStream inputStream = InstrumentationRegistry.getInstrumentation().getContext().getResources().openRawResource(de.dennisguse.opentracks.test.R.raw.gpx11_without_speed);
 
         // when
@@ -187,7 +187,7 @@ public class GPXTrackImporterTest {
     @Test
     public void gpx_speed_no_namespace() throws IOException {
         // given
-        XMLImporter importer = new XMLImporter(new GpxTrackImporter(context, trackImporter));
+        XMLImporter importer = new XMLImporter(new GPXTrackImporter(context, trackImporter));
         InputStream inputStream = InstrumentationRegistry.getInstrumentation().getContext().getResources().openRawResource(de.dennisguse.opentracks.test.R.raw.gpx11_with_speed_no_namespace);
 
         // when
@@ -246,7 +246,7 @@ public class GPXTrackImporterTest {
     @Test
     public void gpx_legacy_trackpointextension() throws IOException {
         // given
-        XMLImporter importer = new XMLImporter(new GpxTrackImporter(context, trackImporter));
+        XMLImporter importer = new XMLImporter(new GPXTrackImporter(context, trackImporter));
         InputStream inputStream = InstrumentationRegistry.getInstrumentation().getContext().getResources().openRawResource(de.dennisguse.opentracks.test.R.raw.legacy_gpx_trackpointextensions_incorrect);
 
         // when
@@ -317,7 +317,7 @@ public class GPXTrackImporterTest {
     @Test
     public void importExportTest_timezone() throws IOException {
         // given
-        XMLImporter importer = new XMLImporter(new GpxTrackImporter(context, trackImporter));
+        XMLImporter importer = new XMLImporter(new GPXTrackImporter(context, trackImporter));
         InputStream inputStream = InstrumentationRegistry.getInstrumentation().getContext().getResources().openRawResource(de.dennisguse.opentracks.test.R.raw.gpx_timezone);
         InputStream inputStreamExpected = InstrumentationRegistry.getInstrumentation().getContext().getResources().openRawResource(de.dennisguse.opentracks.test.R.raw.gpx_timezone);
 

src/androidTest/java/de/dennisguse/opentracks/io/file/importer/KMLTrackImporterTest.java

@@ -62,7 +62,7 @@ public class KMLTrackImporterTest {
     @Test
     public void kml22_order_location_and_when() throws IOException {
         // given
-        XMLImporter importer = new XMLImporter(new KmlTrackImporter(context, trackImporter));
+        XMLImporter importer = new XMLImporter(new KMLTrackImporter(context, trackImporter));
         InputStream inputStream = InstrumentationRegistry.getInstrumentation().getContext().getResources().openRawResource(de.dennisguse.opentracks.test.R.raw.kml22_order_location_and_when);
 
         // when
@@ -118,7 +118,7 @@ public class KMLTrackImporterTest {
     @Test
     public void kml22_time_decreases() throws IOException {
         // given
-        XMLImporter importer = new XMLImporter(new KmlTrackImporter(context, trackImporter));
+        XMLImporter importer = new XMLImporter(new KMLTrackImporter(context, trackImporter));
         InputStream inputStream = InstrumentationRegistry.getInstrumentation().getContext().getResources().openRawResource(de.dennisguse.opentracks.test.R.raw.kml22_time_decreases);
 
         // when
@@ -159,7 +159,7 @@ public class KMLTrackImporterTest {
     @Test
     public void kml22_with_statistics_marker() throws IOException {
         // given
-        XMLImporter importer = new XMLImporter(new KmlTrackImporter(context, trackImporter));
+        XMLImporter importer = new XMLImporter(new KMLTrackImporter(context, trackImporter));
         InputStream inputStream = InstrumentationRegistry.getInstrumentation().getContext().getResources().openRawResource(de.dennisguse.opentracks.test.R.raw.legacy_kml22_statistics_marker);
 
         // when
@@ -243,7 +243,7 @@ public class KMLTrackImporterTest {
     @Test(expected = ImportParserException.class)
     public void kml_without_locations() throws IOException {
         // given
-        XMLImporter importer = new XMLImporter(new KmlTrackImporter(context, trackImporter));
+        XMLImporter importer = new XMLImporter(new KMLTrackImporter(context, trackImporter));
         InputStream inputStream = InstrumentationRegistry.getInstrumentation().getContext().getResources().openRawResource(de.dennisguse.opentracks.test.R.raw.kml22_without_locations);
 
         // when
@@ -254,7 +254,7 @@ public class KMLTrackImporterTest {
     @Test(expected = ImportParserException.class)
     public void kml_when_locations_different() throws IOException {
         // given
-        XMLImporter importer = new XMLImporter(new KmlTrackImporter(context, trackImporter));
+        XMLImporter importer = new XMLImporter(new KMLTrackImporter(context, trackImporter));
         InputStream inputStream = InstrumentationRegistry.getInstrumentation().getContext().getResources().openRawResource(de.dennisguse.opentracks.test.R.raw.kml22_when_locations_different);
 
         // when

src/androidTest/res/raw/gpx_timezone.gpx

@@ -10,7 +10,7 @@ xmlns:gpxtpx="http://www.garmin.com/xmlschemas/TrackPointExtension/v2"
 xmlns:gpxtrkx="http://www.garmin.com/xmlschemas/TrackStatsExtension/v1"
 xmlns:cluetrust="http://www.cluetrust.com/Schemas/"
 xmlns:pwr="http://www.garmin.com/xmlschemas/PowerExtension/v1"
-xsi:schemaLocation="http://www.topografix.com/GPX/1/1 http://www.topografix.com/GPX/1/1/gpx.xsd http://www.topografix.com/GPX/Private/TopoGrafix/0/1 http://www.topografix.com/GPX/Private/TopoGrafix/0/1/topografix.xsd http://www.garmin.com/xmlschemas/TrackPointExtension/v2 https://www8.garmin.com/xmlschemas/TrackPointExtensionv2.xsd http://www.garmin.com/xmlschemas/PowerExtension/v1 https://www8.garmin.com/xmlschemas/PowerExtensionv1.xsd http://www.garmin.com/xmlschemas/TrackStatsExtension/v1 http://www.cluetrust.com/Schemas https://www.cluetrust.com/Schemas/gpxdata10.xsd http://opentracksapp.com/xmlschemas/v1 http://opentracksapp.com/xmlschemas/OpenTracks_v1.xsd">
+xsi:schemaLocation="http://www.topografix.com/GPX/1/1 http://www.topografix.com/GPX/1/1/gpx.xsd http://www.topografix.com/GPX/Private/TopoGrafix/0/1 http://www.topografix.com/GPX/Private/TopoGrafix/0/1/topografix.xsd http://www.garmin.com/xmlschemas/TrackPointExtension/v2 https://www8.garmin.com/xmlschemas/TrackPointExtensionv2.xsd http://www.garmin.com/xmlschemas/PowerExtension/v1 https://www8.garmin.com/xmlschemas/PowerExtensionv1.xsd http://www.garmin.com/xmlschemas/TrackStatsExtension/v1 https://www8.garmin.com/xmlschemas/TrackStatsExtension.xsd http://www.cluetrust.com/Schemas https://www.cluetrust.com/Schemas/gpxdata10.xsd http://opentracksapp.com/xmlschemas/v1 http://opentracksapp.com/xmlschemas/OpenTracks_v1.xsd">
 <wpt lat="3" lon="14">
 <ele>10</ele>
 <time>2021-01-07T21:51:59.179+01:15</time>

src/main/java/de/dennisguse/opentracks/io/file/TrackFileFormat.java

@@ -15,7 +15,7 @@ import de.dennisguse.opentracks.data.ContentProviderUtils;
 import de.dennisguse.opentracks.io.file.exporter.CSVTrackExporter;
 import de.dennisguse.opentracks.io.file.exporter.GPXTrackExporter;
 import de.dennisguse.opentracks.io.file.exporter.KMLTrackExporter;
-import de.dennisguse.opentracks.io.file.exporter.KmzTrackExporter;
+import de.dennisguse.opentracks.io.file.exporter.KMZTrackExporter;
 import de.dennisguse.opentracks.io.file.exporter.TrackExporter;
 
 /**
@@ -33,7 +33,7 @@ public enum TrackFileFormat {
 
         @Override
         public String getMimeType() {
-            return MIME_KML;
+            return "application/vnd.google-earth.kml+xml";
         }
 
         public String getExtension() {
@@ -49,12 +49,12 @@ public enum TrackFileFormat {
         @Override
         public TrackExporter createTrackExporter(@NonNull Context context, @NonNull ContentProviderUtils contentProviderUtils) {
             KMLTrackExporter exporter = new KMLTrackExporter(context, contentProviderUtils, exportPhotos);
-            return new KmzTrackExporter(context, contentProviderUtils, exporter, exportPhotos);
+            return new KMZTrackExporter(context, contentProviderUtils, exporter, exportPhotos);
         }
 
         @Override
         public String getMimeType() {
-            return MIME_KMZ;
+            return "application/vnd.google-earth.kmz";
         }
 
         public String getExtension() {
@@ -74,12 +74,12 @@ public enum TrackFileFormat {
         @Override
         public TrackExporter createTrackExporter(@NonNull Context context, @NonNull ContentProviderUtils contentProviderUtils) {
             KMLTrackExporter exporter = new KMLTrackExporter(context, contentProviderUtils, exportPhotos);
-            return new KmzTrackExporter(context, contentProviderUtils, exporter, exportPhotos);
+            return new KMZTrackExporter(context, contentProviderUtils, exporter, exportPhotos);
         }
 
         @Override
         public String getMimeType() {
-            return MIME_KMZ;
+            return KMZ_WITH_TRACKDETAIL_AND_SENSORDATA.getMimeType();
         }
 
         public String getExtension() {
@@ -126,17 +126,13 @@ public enum TrackFileFormat {
         }
     };
 
-    private static final String MIME_KMZ = "application/vnd.google-earth.kmz";
-
-    private static final String MIME_KML = "application/vnd.google-earth.kml+xml";
-
     private final String preferenceId;
 
     TrackFileFormat(String preferenceId) {
         this.preferenceId = preferenceId;
     }
 
-    public static Map<String, String> toPreferenceIdLabelMap(final Resources resources, final TrackFileFormat ... trackFileFormats) {
+    public static Map<String, String> toPreferenceIdLabelMap(final Resources resources, final TrackFileFormat... trackFileFormats) {
         Map<String, String> preferenceIdLabelMap = new LinkedHashMap<>(trackFileFormats.length);
         for (TrackFileFormat trackFileFormat : trackFileFormats) {
             String trackFileFormatUpperCase = trackFileFormat.getExtension().toUpperCase(Locale.US); //ASCII upper case

src/main/java/de/dennisguse/opentracks/io/file/exporter/FITv2TrackExporter.java

@@ -0,0 +1,74 @@
+package de.dennisguse.opentracks.io.file.exporter;
+
+import androidx.annotation.NonNull;
+import androidx.annotation.VisibleForTesting;
+
+import java.io.OutputStream;
+import java.nio.ByteBuffer;
+import java.nio.ByteOrder;
+import java.nio.channels.Channels;
+import java.nio.channels.WritableByteChannel;
+import java.util.List;
+
+import de.dennisguse.opentracks.data.models.Track;
+
+/**
+ * FIT v2.0
+ * https://developer.garmin.com/fit/
+ * <p>
+ * Encoding is little endian.
+ */
+public class FITv2TrackExporter implements TrackExporter {
+
+    private final byte FIT_PROTOCOL_VERSION = 2 << 4 + 0;
+    private final short FIT_PROFILE_VERSION = 21 * 1000 + 158;
+
+    private long checksum;
+    private final byte FILE_HEADER_SIZE = 14;
+
+
+    @Override
+    public boolean writeTrack(List<Track> tracks, @NonNull OutputStream outputStream) {
+        WritableByteChannel channel = Channels.newChannel(outputStream);
+
+        writeFileHeader(channel);
+        // writeFileId(channel);
+        writeFooter(channel);
+        return false;
+    }
+
+    // https://developer.garmin.com/fit/protocol/
+    @VisibleForTesting
+    void writeFileHeader(@NonNull WritableByteChannel channel) {
+        ByteBuffer littleEndian = ByteBuffer
+                .allocate(FILE_HEADER_SIZE)
+                .order(ByteOrder.LITTLE_ENDIAN);
+
+        littleEndian.put(0, FILE_HEADER_SIZE);
+        littleEndian.put(1, FIT_PROTOCOL_VERSION);
+
+        // Profile version
+        littleEndian.putShort(2, FIT_PROFILE_VERSION);
+
+        // Data size: 32bit
+        littleEndian.putInt(4, 0); // We do not calculate the data size.
+
+        // .FIT
+        littleEndian.putChar(8, '.');
+        littleEndian.putChar(9, 'F');
+        littleEndian.putChar(10, 'I');
+        littleEndian.putChar(11, 'T');
+
+        // CRC (not implemented)
+        littleEndian.put(12, (byte) 0);
+        littleEndian.put(13, (byte) 0);
+
+        var a = littleEndian.array();
+        littleEndian.array();
+    }
+
+
+    private void writeFooter(@NonNull WritableByteChannel channel) {
+
+    }
+}

src/main/java/de/dennisguse/opentracks/io/file/exporter/GPXTrackExporter.java

@@ -102,7 +102,6 @@ public class GPXTrackExporter implements TrackExporter {
         try {
             prepare(outputStream);
             writeHeader();
-
             for (Track track : tracks) {
                 writeMarkers(track);
             }
@@ -200,17 +199,17 @@ public class GPXTrackExporter implements TrackExporter {
         }
     }
 
-    public void prepare(OutputStream outputStream) {
+    private void prepare(OutputStream outputStream) {
         this.printWriter = new PrintWriter(outputStream);
     }
 
-    public void close() {
+    private void close() {
         printWriter.flush();
         printWriter = null;
     }
 
 
-    public void writeHeader() {
+    private void writeHeader() {
         printWriter.println("<?xml version=\"1.0\" encoding=\"UTF-8\"?>");
         printWriter.println("<gpx");
         printWriter.println("version=\"1.1\"");
@@ -228,12 +227,12 @@ public class GPXTrackExporter implements TrackExporter {
                 + " http://www.topografix.com/GPX/Private/TopoGrafix/0/1 http://www.topografix.com/GPX/Private/TopoGrafix/0/1/topografix.xsd"
                 + " http://www.garmin.com/xmlschemas/TrackPointExtension/v2 https://www8.garmin.com/xmlschemas/TrackPointExtensionv2.xsd"
                 + " http://www.garmin.com/xmlschemas/PowerExtension/v1 https://www8.garmin.com/xmlschemas/PowerExtensionv1.xsd"
-                + " http://www.garmin.com/xmlschemas/TrackStatsExtension/v1"
+                + " http://www.garmin.com/xmlschemas/TrackStatsExtension/v1 https://www8.garmin.com/xmlschemas/TrackStatsExtension.xsd"
                 + " http://www.cluetrust.com/Schemas https://www.cluetrust.com/Schemas/gpxdata10.xsd"
                 + " http://opentracksapp.com/xmlschemas/v1 http://opentracksapp.com/xmlschemas/OpenTracks_v1.xsd\">");
     }
 
-    public void writeFooter() {
+    private void writeFooter() {
         printWriter.println("</gpx>");
     }
 
@@ -253,7 +252,7 @@ public class GPXTrackExporter implements TrackExporter {
         }
     }
 
-    public void writeMarker(ZoneOffset zoneOffset, Marker marker) {
+    private void writeMarker(ZoneOffset zoneOffset, Marker marker) {
         printWriter.println("<wpt " + formatLocation(marker.getLatitude(), marker.getLongitude()) + ">");
         if (marker.hasAltitude()) {
             printWriter.println("<ele>" + ALTITUDE_FORMAT.format(marker.getAltitude().toM()) + "</ele>");
@@ -265,7 +264,7 @@ public class GPXTrackExporter implements TrackExporter {
         printWriter.println("</wpt>");
     }
 
-    public void writeBeginTrack(Track track) {
+    private void writeBeginTrack(Track track) {
         printWriter.println("<trk>");
         printWriter.println("<name>" + StringUtils.formatCData(track.getName()) + "</name>");
         printWriter.println("<desc>" + StringUtils.formatCData(track.getDescription()) + "</desc>");
@@ -297,19 +296,19 @@ public class GPXTrackExporter implements TrackExporter {
         printWriter.println("</extensions>");
     }
 
-    public void writeEndTrack() {
+    private void writeEndTrack() {
         printWriter.println("</trk>");
     }
 
-    public void writeOpenSegment() {
+    private void writeOpenSegment() {
         printWriter.println("<trkseg>");
     }
 
-    public void writeCloseSegment() {
+    private void writeCloseSegment() {
         printWriter.println("</trkseg>");
     }
 
-    public Distance writeTrackPoint(ZoneOffset zoneOffset, TrackPoint trackPoint, List<TrackPoint> sensorPoints, Distance trackDistance) {
+    private Distance writeTrackPoint(ZoneOffset zoneOffset, TrackPoint trackPoint, List<TrackPoint> sensorPoints, Distance trackDistance) {
         Distance cumulativeDistance;
 
         printWriter.println("<trkpt " + formatLocation(trackPoint.getLatitude(), trackPoint.getLongitude()) + ">");

src/main/java/de/dennisguse/opentracks/io/file/exporter/KMLTrackExporter.java

@@ -107,6 +107,7 @@ public class KMLTrackExporter implements TrackExporter {
         this.contentProviderUtils = contentProviderUtils;
     }
 
+    @Override
     public boolean writeTrack(List<Track> tracks, @NonNull OutputStream outputStream) {
         try {
             prepare(outputStream);
@@ -444,7 +445,7 @@ public class KMLTrackExporter implements TrackExporter {
         writeTypeLocalized(marker.getCategory());
 
         if (exportPhotos) {
-            printWriter.println("<Icon><href>" + KmzTrackExporter.buildKmzImageFilePath(marker) + "</href></Icon>");
+            printWriter.println("<Icon><href>" + KMZTrackExporter.buildKmzImageFilePath(marker) + "</href></Icon>");
         }
 
         printWriter.print("<ViewVolume>");

src/main/java/de/dennisguse/opentracks/io/file/exporter/KMZTrackExporter.java

@@ -43,12 +43,12 @@ import de.dennisguse.opentracks.util.FileUtils;
  *
  * @author Jimmy Shih
  */
-public class KmzTrackExporter implements TrackExporter {
+public class KMZTrackExporter implements TrackExporter {
 
     private static final String KMZ_IMAGES_DIR = "images";
     public static final String KMZ_KML_FILE = "doc.kml";
 
-    private static final String TAG = KmzTrackExporter.class.getSimpleName();
+    private static final String TAG = KMZTrackExporter.class.getSimpleName();
     private static final int BUFFER_SIZE = 4096;
 
     private final ContentProviderUtils contentProviderUtils;
@@ -57,7 +57,7 @@ public class KmzTrackExporter implements TrackExporter {
     private final boolean exportPhotos;
     private final Context context;
 
-    public KmzTrackExporter(Context context, ContentProviderUtils contentProviderUtils, KMLTrackExporter trackExporter, boolean exportPhotos) {
+    public KMZTrackExporter(Context context, ContentProviderUtils contentProviderUtils, KMLTrackExporter trackExporter, boolean exportPhotos) {
         this.context = context;
         this.contentProviderUtils = contentProviderUtils;
         this.fileTrackExporter = trackExporter;

src/main/java/de/dennisguse/opentracks/io/file/importer/GPXTrackImporter.java

@@ -52,9 +52,9 @@ import de.dennisguse.opentracks.util.StringUtils;
  *
  * @author Jimmy Shih
  */
-public class GpxTrackImporter extends DefaultHandler implements XMLImporter.TrackParser {
+public class GPXTrackImporter extends DefaultHandler implements XMLImporter.TrackParser {
 
-    private static final String TAG = GpxTrackImporter.class.getSimpleName();
+    private static final String TAG = GPXTrackImporter.class.getSimpleName();
 
     private static final String TAG_DESCRIPTION = "desc";
     private static final String TAG_ALTITUDE = "ele";
@@ -123,7 +123,7 @@ public class GpxTrackImporter extends DefaultHandler implements XMLImporter.Trac
 
     private final TrackImporter trackImporter;
 
-    public GpxTrackImporter(Context context, TrackImporter trackImporter) {
+    public GPXTrackImporter(Context context, TrackImporter trackImporter) {
         this.context = context;
         this.trackImporter = trackImporter;
     }

src/main/java/de/dennisguse/opentracks/io/file/importer/ImportService.java

@@ -54,17 +54,16 @@ public class ImportService extends JobIntentService {
         String fileExtension = FileUtils.getExtension(file);
         try {
             Distance maxRecordingDistance = PreferencesUtils.getMaxRecordingDistance();
-            Distance recordingDistanceInterval = PreferencesUtils.getRecordingDistanceInterval();
             boolean preventReimport = PreferencesUtils.getPreventReimportTracks();
 
             TrackImporter trackImporter = new TrackImporter(this, new ContentProviderUtils(this), maxRecordingDistance, preventReimport);
 
             if (TrackFileFormat.GPX.getExtension().equals(fileExtension)) {
-                trackIds.addAll(new XMLImporter(new GpxTrackImporter(this, trackImporter)).importFile(this, file.getUri()));
+                trackIds.addAll(new XMLImporter(new GPXTrackImporter(this, trackImporter)).importFile(this, file.getUri()));
             } else if (TrackFileFormat.KML_WITH_TRACKDETAIL_AND_SENSORDATA.getExtension().equals(fileExtension)) {
-                trackIds.addAll(new XMLImporter(new KmlTrackImporter(this, trackImporter)).importFile(this, file.getUri()));
+                trackIds.addAll(new XMLImporter(new KMLTrackImporter(this, trackImporter)).importFile(this, file.getUri()));
             } else if (TrackFileFormat.KMZ_WITH_TRACKDETAIL_AND_SENSORDATA_AND_PICTURES.getExtension().equals(fileExtension)) {
-                trackIds.addAll(new KmzTrackImporter(this, trackImporter).importFile(file.getUri()));
+                trackIds.addAll(new KMZTrackImporter(this, trackImporter).importFile(file.getUri()));
             } else {
                 Log.d(TAG, "Unsupported file format.");
                 sendResult(ImportServiceResultReceiver.RESULT_CODE_ERROR, null, file, getString(R.string.import_unsupported_format));

src/main/java/de/dennisguse/opentracks/io/file/importer/KMLTrackImporter.java

@@ -47,9 +47,9 @@ import de.dennisguse.opentracks.util.StringUtils;
  *
  * @author Jimmy Shih
  */
-public class KmlTrackImporter extends DefaultHandler implements XMLImporter.TrackParser {
+public class KMLTrackImporter extends DefaultHandler implements XMLImporter.TrackParser {
 
-    private static final String TAG = KmlTrackImporter.class.getSimpleName();
+    private static final String TAG = KMLTrackImporter.class.getSimpleName();
 
     private static final String MARKER_STYLE = "#" + KMLTrackExporter.MARKER_STYLE;
 
@@ -128,7 +128,7 @@ public class KmlTrackImporter extends DefaultHandler implements XMLImporter.Trac
 
     private final TrackImporter trackImporter;
 
-    public KmlTrackImporter(Context context, TrackImporter trackImporter) {
+    public KMLTrackImporter(Context context, TrackImporter trackImporter) {
         this.context = context;
         this.trackImporter = trackImporter;
     }

src/main/java/de/dennisguse/opentracks/io/file/importer/KMZTrackImporter.java

@@ -44,9 +44,9 @@ import de.dennisguse.opentracks.util.FileUtils;
  *
  * @author Jimmy Shih
  */
-public class KmzTrackImporter {
+public class KMZTrackImporter {
 
-    private static final String TAG = KmzTrackImporter.class.getSimpleName();
+    private static final String TAG = KMZTrackImporter.class.getSimpleName();
 
     private static final String KML_FILE_EXTENSION = ".kml";
 
@@ -55,7 +55,7 @@ public class KmzTrackImporter {
     private final Context context;
     private final TrackImporter trackImporter;
 
-    public KmzTrackImporter(Context context, TrackImporter trackImporter) {
+    public KMZTrackImporter(Context context, TrackImporter trackImporter) {
         this.context = context;
         this.trackImporter = trackImporter;
     }
@@ -211,7 +211,7 @@ public class KmzTrackImporter {
     }
 
     private List<Track.Id> parseKml(ZipInputStream zipInputStream) throws IOException {
-        XMLImporter kmlFileTrackImporter = new XMLImporter(new KmlTrackImporter(context, trackImporter));
+        XMLImporter kmlFileTrackImporter = new XMLImporter(new KMLTrackImporter(context, trackImporter));
 
         InputStream nonClosableInputStream = new FilterInputStream(zipInputStream) {
             @Override

src/main/java/de/dennisguse/opentracks/io/file/importer/TrackImporter.java

@@ -233,7 +233,7 @@ public class TrackImporter {
      * @param externalPhotoUrl the file name
      */
     private Uri getInternalPhotoUrl(@NonNull Track.Id trackId, @NonNull Uri externalPhotoUrl) {
-        String importFileName = KmzTrackImporter.importNameForFilename(externalPhotoUrl.toString());
+        String importFileName = KMZTrackImporter.importNameForFilename(externalPhotoUrl.toString());
         File file = MarkerUtils.buildInternalPhotoFile(context, trackId, Uri.parse(importFileName));
         if (file != null) {
             return FileUtils.getUriForFile(context, file);

src/main/java/de/dennisguse/opentracks/io/file/importer/XMLImporter.java

@@ -47,7 +47,7 @@ public class XMLImporter {
             return parser.getImportTrackIds();
         } catch (SAXException | ParserConfigurationException | ParsingException e) {
             Log.e(TAG, "Unable to import file", e);
-            if (parser.getImportTrackIds().size() > 0) {
+            if (!parser.getImportTrackIds().isEmpty()) {
                 parser.cleanImport();
             }
             throw new ImportParserException(e);

src/main/res/layout/activity_settings_custom_layout.xml

@@ -3,24 +3,14 @@
 <androidx.coordinatorlayout.widget.CoordinatorLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
     android:layout_width="match_parent"
-    android:layout_height="match_parent">
+    android:layout_height="match_parent"
+    android:fitsSystemWindows="true">
 
-    <com.google.android.material.appbar.AppBarLayout
+    <LinearLayout
         android:layout_width="match_parent"
-        android:layout_height="wrap_content"
-        android:fitsSystemWindows="true">
-
-        <com.google.android.material.appbar.MaterialToolbar
-            android:id="@+id/export_activity_toolbar"
-            android:layout_width="match_parent"
-            android:layout_height="?attr/actionBarSize"
-            app:title="@string/custom_layout_list_title" />
-    </com.google.android.material.appbar.AppBarLayout>
-
-    <LinearLayout android:layout_width="match_parent"
         android:layout_height="match_parent"
         android:orientation="vertical"
-        android:paddingBottom="60dp">
+        android:paddingBottom="?attr/actionBarSize">
 
         <com.google.android.material.textfield.TextInputLayout
             android:id="@+id/rows_options_layout"
@@ -50,16 +40,16 @@
                     android:id="@+id/recycler_view_visible"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
-                    app:layout_constraintTop_toTopOf="parent"
-                    app:layout_constraintBottom_toTopOf="@id/recycler_view_not_visible" />
+                    app:layout_constraintBottom_toTopOf="@id/recycler_view_not_visible"
+                    app:layout_constraintTop_toTopOf="parent" />
 
                 <androidx.recyclerview.widget.RecyclerView
                     android:id="@+id/recycler_view_not_visible"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
                     android:layout_marginTop="24dp"
-                    app:layout_constraintTop_toBottomOf="@id/recycler_view_visible"
-                    app:layout_constraintBottom_toBottomOf="parent" />
+                    app:layout_constraintBottom_toBottomOf="parent"
+                    app:layout_constraintTop_toBottomOf="@id/recycler_view_visible" />
 
             </androidx.constraintlayout.widget.ConstraintLayout>
 

src/main/res/layout/activity_settings_custom_layout_list.xml

@@ -1,16 +1,28 @@
 <?xml version="1.0" encoding="utf-8"?>
 
 <androidx.coordinatorlayout.widget.CoordinatorLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto"
     android:layout_width="match_parent"
     android:layout_height="match_parent">
 
-    <LinearLayout
+    <com.google.android.material.appbar.AppBarLayout
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:fitsSystemWindows="true">
+
+        <com.google.android.material.appbar.MaterialToolbar
+            android:id="@+id/export_activity_toolbar"
+            android:layout_width="match_parent"
+            android:layout_height="?attr/actionBarSize"
+            app:title="@string/custom_layout_list_title" />
+    </com.google.android.material.appbar.AppBarLayout>
+
+    <LinearLayout xmlns:tools="http://schemas.android.com/tools"
+        android:paddingTop="?attr/actionBarSize"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
-        xmlns:tools="http://schemas.android.com/tools"
-        xmlns:app="http://schemas.android.com/apk/res-auto"
-        android:orientation="vertical"
-        android:paddingBottom="60dp">
+        android:fitsSystemWindows="true"
+        android:orientation="vertical">
 
         <LinearLayout
             android:id="@+id/custom_layout_list_add_linear_layout"
@@ -18,25 +30,24 @@
             android:layout_height="wrap_content"
             android:gravity="center_vertical"
             android:orientation="vertical"
-            android:layout_marginBottom="50dp"
             android:visibility="gone"
             tools:visibility="visible">
 
             <com.google.android.material.textfield.TextInputLayout
                 android:id="@+id/custom_layout_list_input_layout"
+                style="@style/Widget.Material3.TextInputLayout.OutlinedBox"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
-                style="@style/Widget.Material3.TextInputLayout.OutlinedBox"
-                app:errorEnabled="true"
-                android:layout_margin="16dp">
+                android:layout_margin="16dp"
+                app:errorEnabled="true">
 
                 <com.google.android.material.textfield.TextInputEditText
                     android:id="@+id/custom_layout_list_edit_name"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
-                    android:inputType="textCapSentences"
+                    android:hint="@string/custom_layout_list_edit_name"
                     android:imeOptions="actionDone"
-                    android:hint="@string/custom_layout_list_edit_name" />
+                    android:inputType="textCapSentences" />
 
             </com.google.android.material.textfield.TextInputLayout>
 
@@ -50,9 +61,9 @@
 
                 <com.google.android.material.button.MaterialButton
                     android:id="@+id/custom_layout_list_cancel_button"
+                    style="@style/Widget.Material3.Button.TextButton"
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
-                    style="@style/Widget.Material3.Button.TextButton"
                     android:text="@android:string/cancel" />
 
                 <com.google.android.material.button.MaterialButton

src/main/res/layout/track_recorded.xml

@@ -21,7 +21,6 @@ limitations under the License.
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         android:orientation="vertical"
-        android:paddingBottom="90dp"
         android:fitsSystemWindows="true">
 
         <com.google.android.material.tabs.TabLayout
@@ -32,6 +31,7 @@ limitations under the License.
         <androidx.viewpager2.widget.ViewPager2
             android:id="@+id/track_detail_activity_view_pager"
             android:layout_width="match_parent"
+            android:paddingBottom="?attr/actionBarSize"
             android:layout_height="0dp"
             android:layout_weight="1" />
 

src/main/res/layout/track_recording.xml

@@ -9,7 +9,6 @@
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         android:orientation="vertical"
-        android:paddingBottom="90dp"
         android:fitsSystemWindows="true">
 
         <com.google.android.material.tabs.TabLayout
@@ -20,6 +19,7 @@
         <androidx.coordinatorlayout.widget.CoordinatorLayout
             android:id="@+id/track_recording_coordinator_layout"
             android:layout_width="match_parent"
+            android:paddingBottom="?attr/actionBarSize"
             android:layout_height="0dp"
             android:layout_weight="1">