Return value instead of variant from Experiment

This commit is contained in:
Moez Bhatti
2018-08-02 17:34:43 -04:00
parent a68997ba69
commit cffebac552
2 changed files with 5 additions and 5 deletions
@@ -38,21 +38,21 @@ abstract class Experiment<T>(val context: Context, val analytics: AnalyticsManag
*/
protected open val qualifies: Boolean = Locale.getDefault().language == "en"
val variant: Variant<T> by lazy {
val variant: T by lazy {
when {
!qualifies -> null // Device doesn't quality for experiment
prefs.contains(prefKey) -> { // Variant already set
variants.firstOrNull { it.key == prefs.getString(prefKey, null) }
variants.firstOrNull { it.key == prefs.getString(prefKey, null) }?.value
}
else -> { // Variant hasn't been set yet
variants[Random().nextInt(variants.size)].also { variant ->
analytics.setUserProperty("Experiment: $key", variant.key)
prefs.edit().putString(prefKey, variant.key).apply()
}
}.value
}
} ?: Variant("default", default)
} ?: default
}
}
@@ -89,7 +89,7 @@ class PlusActivity : QkThemedActivity(), PlusView {
override fun render(state: PlusState) {
description.text = getString(R.string.qksms_plus_description_summary, state.upgradePrice)
upgrade.text = getString(upgradeButtonExperiment.variant.value, state.upgradePrice, state.currency)
upgrade.text = getString(upgradeButtonExperiment.variant, state.upgradePrice, state.currency)
upgradeDonate.text = getString(R.string.qksms_plus_upgrade_donate, state.upgradeDonatePrice, state.currency)
val fdroid = BuildConfig.FLAVOR == "noAnalytics"