Check if emitter is already disposed

This commit is contained in:
moezbhatti
2019-09-11 19:01:10 -04:00
parent cb16921740
commit ded1b7fb99
2 changed files with 14 additions and 6 deletions
@@ -52,13 +52,22 @@ class ChangelogManagerImpl @Inject constructor(
return Single
.create<Response> { emitter ->
call?.enqueue(object : Callback {
override fun onResponse(call: Call, response: Response) {
if (!emitter.isDisposed) {
emitter.onSuccess(response)
}
}
override fun onFailure(call: Call, e: IOException) {
if (!emitter.isDisposed) {
emitter.onError(e)
}
}
})
emitter.setCancellable {
call?.cancel()
}
call?.enqueue(object : Callback {
override fun onResponse(call: Call, response: Response) = emitter.onSuccess(response)
override fun onFailure(call: Call, e: IOException) = emitter.onError(e)
})
}
.map { response -> response.body?.string()?.let(adapter::fromJson) }
.map { response ->
@@ -49,7 +49,6 @@ import io.reactivex.rxkotlin.plusAssign
import io.reactivex.rxkotlin.withLatestFrom
import io.reactivex.schedulers.Schedulers
import io.realm.Realm
import timber.log.Timber
import java.util.*
import java.util.concurrent.TimeUnit
import javax.inject.Inject
@@ -160,7 +159,7 @@ class MainViewModel @Inject constructor(
.subscribe({ changelog ->
changelogManager.markChangelogSeen()
view.showChangelog(changelog)
}, Timber::w)
}, {}) // Ignore error
} else {
changelogManager.markChangelogSeen()
}