Theming: removed all custom modifications to Holo theme.

src/main/java/de/dennisguse/opentracks/fragments/ChooseActivityTypeImageAdapter.java

@@ -22,6 +22,8 @@ import android.view.ViewGroup;
 import android.widget.BaseAdapter;
 import android.widget.ImageView;
 
+import androidx.core.content.ContextCompat;
+
 import java.util.List;
 
 import de.dennisguse.opentracks.R;
@@ -76,7 +78,8 @@ class ChooseActivityTypeImageAdapter extends BaseAdapter {
         }
 
         if (position == selected) {
-            imageView.setBackgroundResource(R.drawable.list_selector_background_transition_holo_dark);
+            //TODO Should use theme!
+            imageView.setBackgroundColor(ContextCompat.getColor(parent.getContext(), R.color.holo_orange_dark));
         } else {
             imageView.setBackgroundColor(Color.TRANSPARENT);
         }

src/main/res/drawable/activated_background_holo_dark.xml

@@ -1,19 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?><!-- Copyright (C) 2008 The Android Open Source Project
-
-     Licensed under the Apache License, Version 2.0 (the "License");
-     you may not use this file except in compliance with the License.
-     You may obtain a copy of the License at
-
-          http://www.apache.org/licenses/LICENSE-2.0
-
-     Unless required by applicable law or agreed to in writing, software
-     distributed under the License is distributed on an "AS IS" BASIS,
-     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-     See the License for the specific language governing permissions and
-     limitations under the License.
--->
-
-<selector xmlns:android="http://schemas.android.com/apk/res/android">
-    <item android:drawable="@drawable/list_activated_holo" android:state_activated="true" />
-    <item android:drawable="@android:color/transparent" />
-</selector>

src/main/res/drawable/btn_check_holo_dark.xml

@@ -1,43 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?><!-- Copyright (C) 2011 The Android Open Source Project
-
-     Licensed under the Apache License, Version 2.0 (the "License");
-     you may not use this file except in compliance with the License.
-     You may obtain a copy of the License at
-
-          http://www.apache.org/licenses/LICENSE-2.0
-
-     Unless required by applicable law or agreed to in writing, software
-     distributed under the License is distributed on an "AS IS" BASIS,
-     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-     See the License for the specific language governing permissions and
-     limitations under the License.
--->
-
-<selector xmlns:android="http://schemas.android.com/apk/res/android">
-
-    <!-- Enabled states -->
-
-    <item android:drawable="@drawable/btn_check_on_holo_dark" android:state_checked="true" android:state_enabled="true" android:state_window_focused="false" />
-    <item android:drawable="@drawable/btn_check_off_holo_dark" android:state_checked="false" android:state_enabled="true" android:state_window_focused="false" />
-
-    <item android:drawable="@drawable/btn_check_on_pressed_holo_dark" android:state_checked="true" android:state_enabled="true" android:state_pressed="true" />
-    <item android:drawable="@drawable/btn_check_off_pressed_holo_dark" android:state_checked="false" android:state_enabled="true" android:state_pressed="true" />
-
-    <item android:drawable="@drawable/btn_check_on_focused_holo_dark" android:state_checked="true" android:state_enabled="true" android:state_focused="true" />
-    <item android:drawable="@drawable/btn_check_off_focused_holo_dark" android:state_checked="false" android:state_enabled="true" android:state_focused="true" />
-
-    <item android:drawable="@drawable/btn_check_off_holo_dark" android:state_checked="false" android:state_enabled="true" />
-    <item android:drawable="@drawable/btn_check_on_holo_dark" android:state_checked="true" android:state_enabled="true" />
-
-    <!-- Disabled states -->
-
-    <item android:drawable="@drawable/btn_check_on_disabled_holo_dark" android:state_checked="true" android:state_window_focused="false" />
-    <item android:drawable="@drawable/btn_check_off_disabled_holo_dark" android:state_checked="false" android:state_window_focused="false" />
-
-    <item android:drawable="@drawable/btn_check_on_disabled_focused_holo_dark" android:state_checked="true" android:state_focused="true" />
-    <item android:drawable="@drawable/btn_check_off_disabled_focused_holo_dark" android:state_checked="false" android:state_focused="true" />
-
-    <item android:drawable="@drawable/btn_check_off_disabled_holo_dark" android:state_checked="false" />
-    <item android:drawable="@drawable/btn_check_on_disabled_holo_dark" android:state_checked="true" />
-
-</selector>

src/main/res/drawable/edit_text_holo_dark.xml

@@ -1,24 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?><!-- Copyright (C) 2010 The Android Open Source Project
-
-     Licensed under the Apache License, Version 2.0 (the "License");
-     you may not use this file except in compliance with the License.
-     You may obtain a copy of the License at
-  
-          http://www.apache.org/licenses/LICENSE-2.0
-  
-     Unless required by applicable law or agreed to in writing, software
-     distributed under the License is distributed on an "AS IS" BASIS,
-     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-     See the License for the specific language governing permissions and
-     limitations under the License.
--->
-
-<selector xmlns:android="http://schemas.android.com/apk/res/android">
-    <item android:drawable="@drawable/textfield_default_holo_dark" android:state_enabled="true" android:state_window_focused="false" />
-    <item android:drawable="@drawable/textfield_disabled_holo_dark" android:state_enabled="false" android:state_window_focused="false" />
-    <item android:drawable="@drawable/textfield_activated_holo_dark" android:state_enabled="true" android:state_focused="true" />
-    <item android:drawable="@drawable/textfield_focused_holo_dark" android:state_activated="true" android:state_enabled="true" />
-    <item android:drawable="@drawable/textfield_default_holo_dark" android:state_enabled="true" />
-    <item android:drawable="@drawable/textfield_disabled_focused_holo_dark" android:state_focused="true" />
-    <item android:drawable="@drawable/textfield_disabled_holo_dark" />
-</selector>

src/main/res/drawable/list_selector_background_transition_holo_dark.xml

@@ -1,19 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?><!-- Copyright (C) 2010 The Android Open Source Project
-
-     Licensed under the Apache License, Version 2.0 (the "License");
-     you may not use this file except in compliance with the License.
-     You may obtain a copy of the License at
-
-          http://www.apache.org/licenses/LICENSE-2.0
-
-     Unless required by applicable law or agreed to in writing, software
-     distributed under the License is distributed on an "AS IS" BASIS,
-     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-     See the License for the specific language governing permissions and
-     limitations under the License.
--->
-
-<transition xmlns:android="http://schemas.android.com/apk/res/android">
-    <item android:drawable="@drawable/list_pressed_holo_dark" />
-    <item android:drawable="@drawable/list_longpressed_holo" />
-</transition>

src/main/res/drawable/list_selector_holo_dark.xml

@@ -1,26 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?><!-- Copyright (C) 2010 The Android Open Source Project
-
-     Licensed under the Apache License, Version 2.0 (the "License");
-     you may not use this file except in compliance with the License.
-     You may obtain a copy of the License at
-
-          http://www.apache.org/licenses/LICENSE-2.0
-
-     Unless required by applicable law or agreed to in writing, software
-     distributed under the License is distributed on an "AS IS" BASIS,
-     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-     See the License for the specific language governing permissions and
-     limitations under the License.
--->
-
-<selector xmlns:android="http://schemas.android.com/apk/res/android">
-
-    <item android:drawable="@android:color/transparent" android:state_window_focused="false" />
-
-    <!-- Even though these two point to the same resource, have two states so the drawable will invalidate itself when coming out of pressed state. -->
-    <item android:drawable="@drawable/list_selector_disabled_holo_dark" android:state_enabled="false" android:state_focused="true" android:state_pressed="true" />
-    <item android:drawable="@drawable/list_selector_disabled_holo_dark" android:state_enabled="false" android:state_focused="true" />
-    <item android:drawable="@drawable/list_selector_background_transition_holo_dark" android:state_focused="true" android:state_pressed="true" />
-    <item android:drawable="@drawable/list_selector_background_transition_holo_dark" android:state_focused="false" android:state_pressed="true" />
-    <item android:drawable="@drawable/list_focused_holo" android:state_focused="true" />
-</selector>

src/main/res/drawable/spinner_background_holo_dark.xml

@@ -1,21 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?><!-- Copyright (C) 2010 The Android Open Source Project
-
-     Licensed under the Apache License, Version 2.0 (the "License");
-     you may not use this file except in compliance with the License.
-     You may obtain a copy of the License at
-
-          http://www.apache.org/licenses/LICENSE-2.0
-
-     Unless required by applicable law or agreed to in writing, software
-     distributed under the License is distributed on an "AS IS" BASIS,
-     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-     See the License for the specific language governing permissions and
-     limitations under the License.
--->
-
-<selector xmlns:android="http://schemas.android.com/apk/res/android">
-    <item android:drawable="@drawable/spinner_disabled_holo_dark" android:state_enabled="false" />
-    <item android:drawable="@drawable/spinner_pressed_holo_dark" android:state_pressed="true" />
-    <item android:drawable="@drawable/spinner_focused_holo_dark" android:state_focused="true" android:state_pressed="false" />
-    <item android:drawable="@drawable/spinner_default_holo_dark" />
-</selector>

src/main/res/layout/interval_list_view.xml

@@ -20,7 +20,6 @@
             android:id="@+id/spinner_intervals"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            style="@style/SpinnerCustomText"
             android:gravity="center" />
 
     </LinearLayout>
@@ -85,7 +84,6 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:gravity="center_horizontal|center_vertical"
-        android:text="@string/interval_list_empty_message"
-        android:textColor="@color/list_empty_text" />
+        android:text="@string/interval_list_empty_message" />
 
 </LinearLayout>

src/main/res/layout/track_edit.xml

@@ -51,7 +51,6 @@ limitations under the License.
                     android:id="@+id/track_edit_activity_type"
                     style="@style/EditCategory"
                     android:layout_width="0dp"
-                    android:layout_height="match_parent"
                     android:layout_weight="1"
                     android:hint="@string/track_edit_activity_type_hint"
                     android:imeOptions="actionNext" />

src/main/res/values/styles_custom.xml

@@ -1,19 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?><!-- Generated with http://android-holo-colors.com -->
-<resources xmlns:android="http://schemas.android.com/apk/res/android">
-    <!-- TODO REMOVE ALL: override only things that are really important. -->
-    <style name="AutoCompleteTextViewCustom" parent="Widget.AppCompat.AutoCompleteTextView">
-        <item name="android:dropDownSelector">@drawable/list_selector_holo_dark</item>
-        <item name="android:background">@drawable/edit_text_holo_dark</item>
-    </style>
-
-    <style name="SpinnerCustom" parent="Widget.AppCompat.Spinner">
-        <item name="android:background">@drawable/spinner_background_holo_dark</item>
-        <item name="android:dropDownSelector">@drawable/list_selector_holo_dark</item>
-    </style>
-
-    <style name="SpinnerCustomText" parent="Widget.AppCompat.Spinner">
-        <item name="android:background">@drawable/spinner_background_holo_dark</item>
-        <item name="android:dropDownSelector">@drawable/list_selector_holo_dark</item>
-        <item name="android:padding">0dp</item>
-    </style>
-</resources>

src/main/res/values/themes_custom.xml

@@ -16,16 +16,6 @@ limitations under the License.
 <resources xmlns:android="http://schemas.android.com/apk/res/android">
 
     <style name="ThemeCustom" parent="Theme.AppCompat.DayNight.NoActionBar">
-        <!-- TODO Cleanup necessary due to change to appcompat -->
-        <!-- Auto generated -->
-        <item name="android:activatedBackgroundIndicator">@drawable/activated_background_holo_dark
-        </item>
-        <item name="android:autoCompleteTextViewStyle">@style/AutoCompleteTextViewCustom</item>
-        <item name="android:dropDownSpinnerStyle">@style/SpinnerCustom</item>
-        <item name="android:editTextBackground">@drawable/edit_text_holo_dark</item>
-        <item name="android:listChoiceBackgroundIndicator">@drawable/list_selector_holo_dark</item>
-        <item name="android:listChoiceIndicatorMultiple">@drawable/btn_check_holo_dark</item>
-
         <!--        <item name="colorPrimary">TODO</item>-->
         <!--        <item name="colorPrimaryDark">TODO</item>-->