Releasing version 1.0.20.

1) Simplify SharedPreferences management
2) Shut down signalManager/splitManager to avoid random crashes
3) Get rid of sharedPreferencesChanged from the service interface

All tests pass.

MyTracks/AndroidManifest.xml

@@ -2,8 +2,8 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
           package="com.google.android.maps.mytracks"
           android:installLocation="auto"
-          android:versionCode="22"
-          android:versionName="1.0.21">
+          android:versionCode="21"
+          android:versionName="1.0.20">
   <application android:icon="@drawable/arrow_icon"
                android:label="@string/app_name"
                android:backupAgent="com.google.android.apps.mytracks.io.backup.MyTracksBackupAgent">

MyTracks/src/com/google/android/apps/mytracks/MyTracks.java

@@ -62,6 +62,7 @@ import android.os.Bundle;
 import android.os.Handler;
 import android.os.HandlerThread;
 import android.os.IBinder;
+import android.os.RemoteException;
 import android.util.Log;
 import android.view.Menu;
 import android.view.MenuItem;
@@ -227,9 +228,7 @@ public class MyTracks extends TabActivity implements OnTouchListener,
     }
     try {
       return trackRecordingService.isRecording();
-      // TODO: We catch Exception, because after eliminating the service process
-      // all exceptions it may throw are no longer wrapped in a RemoteException.
-    } catch (Exception e) {
+    } catch (RemoteException e) {
       Log.e(MyTracksConstants.TAG, "MyTracks: Remote exception.", e);
 
       // Fall back to alternative check method.
@@ -406,11 +405,6 @@ public class MyTracks extends TabActivity implements OnTouchListener,
     return dialogManager.onCreateDialog(id, args);
   }
 
-  @Override
-  protected Dialog onCreateDialog(int id) {
-    return dialogManager.onCreateDialog(id, null);
-  }
-
   @Override
   protected void onPrepareDialog(int id, Dialog dialog) {
     super.onPrepareDialog(id, dialog);
@@ -914,9 +908,7 @@ public class MyTracks extends TabActivity implements OnTouchListener,
           Log.e(MyTracksConstants.TAG, "Cannot insert waypoint marker?");
           return -4;
         }
-        // TODO: We catch Exception, because after eliminating the service process
-        // all exceptions it may throw are no longer wrapped in a RemoteException.
-      } catch (Exception e) {
+      } catch (RemoteException e) {
         Toast.makeText(this, R.string.error_unable_to_insert_marker,
             Toast.LENGTH_LONG).show();
         Log.e(MyTracksConstants.TAG, "Cannot insert waypoint marker.", e);
@@ -956,9 +948,7 @@ public class MyTracks extends TabActivity implements OnTouchListener,
           Log.e(MyTracksConstants.TAG, "Cannot insert statistics marker?");
           return -4;
         }
-        // TODO: We catch Exception, because after eliminating the service process
-        // all exceptions it may throw are no longer wrapped in a RemoteException.
-      } catch (Exception e) {
+      } catch (RemoteException e) {
         Toast.makeText(this, R.string.error_unable_to_insert_marker,
             Toast.LENGTH_LONG).show();
         Log.e(MyTracksConstants.TAG, "Cannot insert statistics marker?", e);
@@ -1026,9 +1016,7 @@ public class MyTracks extends TabActivity implements OnTouchListener,
       setSelectedTrackId(recordingTrackId);
       Toast.makeText(this, getString(R.string.status_now_recording),
           Toast.LENGTH_SHORT).show();
-      // TODO: We catch Exception, because after eliminating the service process
-      // all exceptions it may throw are no longer wrapped in a RemoteException.
-    } catch (Exception e) {
+    } catch (RemoteException e) {
       Toast.makeText(this,
           getString(R.string.error_unable_to_start_recording),
           Toast.LENGTH_SHORT).show();
@@ -1061,9 +1049,7 @@ public class MyTracks extends TabActivity implements OnTouchListener,
       long currentTrackId = recordingTrackId;
       try {
         trackRecordingService.endCurrentTrack();
-        // TODO: We catch Exception, because after eliminating the service process
-        // all exceptions it may throw are no longer wrapped in a RemoteException.
-      } catch (Exception e) {
+      } catch (RemoteException e) {
         Log.e(MyTracksConstants.TAG, "Unable to stop recording.", e);
       }
       Intent intent = new Intent(MyTracks.this, MyTracksDetails.class);

MyTracks/src/com/google/android/apps/mytracks/services/TrackRecordingService.java

@@ -935,33 +935,21 @@ public class TrackRecordingService extends Service implements LocationListener {
     
     @Override
     public boolean isRecording() {
-      if (service == null) {
-        throw new IllegalStateException("The service has been already detached!");
-      }
       return service.isRecording();
     }
 
     @Override
     public long getRecordingTrackId() {
-      if (service == null) {
-        throw new IllegalStateException("The service has been already detached!");
-      }      
       return service.recordingTrackId;
     }
 
     @Override
     public boolean hasRecorded() {
-      if (service == null) {
-        throw new IllegalStateException("The service has been already detached!");
-      }      
       return service.providerUtils.getLastTrackId() >= 0;
     }
 
     @Override
     public long startNewTrack() {
-      if (service == null) {
-        throw new IllegalStateException("The service has been already detached!");
-      }
       return service.startNewTrack();
     }
 
@@ -974,9 +962,6 @@ public class TrackRecordingService extends Service implements LocationListener {
      */
     @Override
     public long insertWaypointMarker(Waypoint waypoint) {
-      if (service == null) {
-        throw new IllegalStateException("The service has been already detached!");
-      }
       return service.insertWaypointMarker(waypoint);
     }
 
@@ -989,36 +974,25 @@ public class TrackRecordingService extends Service implements LocationListener {
      */
     @Override
     public long insertStatisticsMarker(Location location) {
-      if (service == null) {
-        throw new IllegalStateException("The service has been already detached!");
-      }
       return service.insertStatisticsMarker(location);
     }
 
     @Override
     public void endCurrentTrack() {
-      if (service == null) {
-        throw new IllegalStateException("The service has been already detached!");
-      }
       service.endCurrentTrack();
     }
 
     @Override
     public void deleteAllTracks() {
-      if (service == null) {
-        throw new IllegalStateException("The service has been already detached!");
-      }
       if (isRecording()) {
-        throw new IllegalStateException("Cannot delete all tracks while recording!");
+        throw new IllegalStateException(
+            "Cannot delete all tracks while recording!");
       }
       service.providerUtils.deleteAllTracks();
     }
 
     @Override
     public void recordLocation(Location loc) {
-      if (service == null) {
-        throw new IllegalStateException("The service has been already detached!");
-      }      
       service.onLocationChanged(loc);
     }
   }