Bugfix: crash when exporting zero tracks.

Fixes #2285

README_TESTED_SENSORS.md

@@ -112,15 +112,3 @@ Here is a list of the smartphones tested:
 | Google  | Nexus 4            | LineageOS 18.1  | Ok                                                                             |
 | Samsung | S4                 | Android 11      | Ok                                                                             |
 | Sony    | Xperia XZ1 Compact | LineageOS 16.1  | Failure                                                                        |
-
-## Bosch Smart System eBike
-
-OpenTracks also supports Bosch Smart System eBikes via Bosch's custom BLE service `00000010-eaa2-11e9-81b4-2a2ae2dbcce4`.
-
-Tested with:
-
-* Bosch Perfomance Line CX (SW-Version 16.9.0) / Kiox 300 (SW-Version 16.4.0)
-
-Currently supported measurements:
-
-* Human power

build.gradle

@@ -6,7 +6,7 @@ buildscript {
         mavenCentral()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:9.2.1'
+        classpath 'com.android.tools.build:gradle:9.0.1'
     }
 }
 
@@ -18,11 +18,11 @@ allprojects {
 }
 
 def getVersionName = { ->
-    return 'git describe --tags'.execute(null, project.rootDir).text.trim()
+    return 'git describe --tags'.execute().text.trim()
 }
 
 def getVersionCodeNightly = { ->
-    return Integer.valueOf('git rev-list HEAD --count'.execute(null, project.rootDir).text.trim())
+    return Integer.valueOf('git rev-list HEAD --count'.execute().text.trim())
 }
 
 android {
@@ -47,8 +47,8 @@ android {
 
     defaultConfig {
         applicationId 'de.dennisguse.opentracks'
-        versionCode 6653
-        versionName "v4.27.0"
+        versionCode 6603
+        versionName "v4.26.0"
 
         buildConfigField "String", "VERSION_NAME_FULL", "\"${getVersionName()}\""
 
@@ -107,6 +107,7 @@ android {
         nightly {
             dimension 'version'
             applicationId 'de.dennisguse.opentracks.nightly'
+            resValue 'string', 'applicationId', 'de.dennisguse.opentracks.nightly'
 
             versionCode getVersionCodeNightly()
             versionName getVersionName()
@@ -118,6 +119,7 @@ android {
             // Non-reproducible: https://f-droid.org/de/packages/de.dennisguse.opentracks/
             dimension 'version'
             applicationId 'de.dennisguse.opentracks'
+            resValue 'string', 'applicationId', 'de.dennisguse.opentracks'
             versionNameSuffix 'irreproducible'
         }
         reproducible {
@@ -126,6 +128,7 @@ android {
             // PlayStore: https://play.google.com/store/apps/details?id=de.dennisguse.opentracks.playstore
             dimension 'version'
             applicationId 'de.dennisguse.opentracks.playstore'
+            resValue 'string', 'applicationId', 'de.dennisguse.opentracks.playstore'
 
             base.archivesName = "de.dennisguse.opentracks.playstore_${getVersionName()}_${android.defaultConfig.versionCode}"
 
@@ -151,26 +154,18 @@ dependencies {
     implementation 'androidx.gridlayout:gridlayout:1.1.0'
     implementation 'com.google.android.material:material:1.13.0'
     implementation 'androidx.constraintlayout:constraintlayout:2.2.1'
-    implementation 'androidx.core:core:1.18.0'
+    implementation 'androidx.core:core:1.17.0'
     implementation 'androidx.core:core-splashscreen:1.2.0'
     implementation 'androidx.mediarouter:mediarouter:1.8.1'
-    implementation 'androidx.core:core-location-altitude:1.0.0-rc01'
-    implementation 'androidx.work:work-runtime:2.11.2'
+    implementation 'androidx.core:core-location-altitude:1.0.0-beta01'
+    implementation 'androidx.work:work-runtime:2.11.1'
 
     androidTestImplementation 'androidx.test:core:1.7.0'
     androidTestImplementation 'androidx.test.ext:junit:1.3.0'
     androidTestImplementation 'androidx.test:rules:1.7.0'
     androidTestImplementation 'androidx.test:runner:1.7.0'
     androidTestImplementation 'androidx.test.espresso:espresso-core:3.7.0'
+    androidTestImplementation 'org.mockito:mockito-android:5.21.0'
 
     androidTestUtil 'androidx.test:orchestrator:1.6.1'
 }
-
-androidComponents {
-    onVariants(selector().all()) { variant ->
-        variant.resValues.put(
-                new com.android.build.api.variant.impl.ResValueKeyImpl("string", "applicationId"),
-                new com.android.build.api.variant.ResValue(variant.applicationId.get(), null)
-        )
-    }
-}

fastlane/metadata/android/da-DK/changelogs/next_release.txt

@@ -1,10 +0,0 @@
-(versionName): OpenTracks
-
-Ændringer:
--
-
-Fejlrettelser:
--
-
-Udvikler:
--

fastlane/metadata/android/en-US/changelogs/6609.txt

@@ -1,6 +0,0 @@
-v4.26.1: OpenTracks
-
-Bugfix:
-- Crash when deleting a UI layout
-- Crash when heartrate sensor data could not be decoded
-- Crash when exporting zero tracks

fastlane/metadata/android/en-US/changelogs/6627.txt

@@ -1,5 +0,0 @@
-v4.26.2: OpenTracks
-
-Bugfix:
-- GPS via Bluetooth is not (yet) supported
-- Altitude type (EGM2008) wasn't shown

fastlane/metadata/android/en-US/changelogs/6653.txt

@@ -1,14 +0,0 @@
-v4.27.0: OpenTracks
-
-Changes:
-- Sensor: power from Bosch eBike
-- Sensors: include already bonded Bluetooth devices (like Bosch eBike)
-- Barometer: enforce sampling frequency
-
-Bugfix:
-- Dashboard API: did not provide update
-- GPS could not be enabled with Bluetooth disabled
-
-Developer:
-- Removed Mockito
-- UI tests: less flacky

fastlane/metadata/android/gl-ES/changelogs/6627.txt

@@ -1,5 +0,0 @@
-v4.26.2: OpenTracks
-
-Arranxos:
-- (aínda) non hai compatibilidade co GPS vía Bluetooth
-- non se mostraba a altitude tipo (EGM2008)

fastlane/metadata/android/it-IT/full_description.txt

@@ -1,22 +0,0 @@
-Un tracker sportivo che rispetta la tua privacy.
-
-Sport e attività all'aria aperta portano a felicità, allenamento e fiducia
-
-Valorizza la tua salute tenendo traccia dei tuoi progressi.
-Registra quando stai correndo o passeggiando e regalati un monitor più grande quando fai ciclismo.
-Segna con fotografie i posti interessanti incrociati durante il tragitto.
-Tieni traccia delle statistiche in dettaglio per analizzarle.
-Condividi solo i dati che vuoi.
-
-* Annunci vocali.
-* Supporto a sensori Bluetooth LE: battito cardiaco, velocità e distanza (ciclismo), cadenza (ciclismo), rilevamento potenza (ciclismo).
-* Altitudine positiva o negativa tramite sensore barometrico. 
-* Altitudine mostrata in EGM2008 (sopra il livello del mare) ed esportata come WGS84.
-* Esporta tracce come KMZ (con foto incluse), KML o GPX.
-* Non richiede accesso a internet o altri permessi.
-* Temi chiaro e scuro, o seguendo la impostazioni di sistema.
-* Nessuna pubblicità.
-
-Libre software / Free Software / Open Source
-cioè puoi usare, studiare, cambiare e condividere il codice sorgente.
-Licenza: Apache 2.0

gradle/wrapper/gradle-wrapper.properties

@@ -1,6 +1,6 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-9.5.0-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip
 networkTimeout=10000
 validateDistributionUrl=true
 zipStoreBase=GRADLE_USER_HOME

src/androidTest/java/de/dennisguse/opentracks/EspressoDeleteTrackTest.java

@@ -2,117 +2,76 @@ package de.dennisguse.opentracks;
 
 
 import static androidx.test.espresso.Espresso.onView;
-import static androidx.test.espresso.assertion.ViewAssertions.matches;
-import static androidx.test.espresso.matcher.ViewMatchers.isDescendantOfA;
+import static androidx.test.espresso.action.ViewActions.click;
+import static androidx.test.espresso.action.ViewActions.longClick;
+import static androidx.test.espresso.matcher.ViewMatchers.isDisplayed;
 import static androidx.test.espresso.matcher.ViewMatchers.withContentDescription;
 import static androidx.test.espresso.matcher.ViewMatchers.withId;
+import static androidx.test.espresso.matcher.ViewMatchers.withParent;
+import static androidx.test.espresso.matcher.ViewMatchers.withParentIndex;
 import static androidx.test.espresso.matcher.ViewMatchers.withText;
-import static androidx.test.espresso.matcher.RootMatchers.isDialog;
-import static androidx.test.espresso.matcher.RootMatchers.isPlatformPopup;
-import static de.dennisguse.opentracks.util.EspressoUtils.performClick;
-import static de.dennisguse.opentracks.util.EspressoUtils.performClickOnAncestor;
-import static de.dennisguse.opentracks.util.EspressoUtils.performLongClickOnAncestor;
-import static de.dennisguse.opentracks.util.EspressoUtils.waitUntilDisplayed;
-import static de.dennisguse.opentracks.util.EspressoUtils.waitUntilRecyclerViewItemCount;
-import static de.dennisguse.opentracks.util.EspressoUtils.withRecyclerViewItemCount;
-import static de.dennisguse.opentracks.util.TestEnvironmentUtils.resetTrackRecordingServiceAndDeleteTracks;
-import static de.dennisguse.opentracks.util.TrackUiTestUtils.renameStoppedTrack;
-import static de.dennisguse.opentracks.util.TrackUiTestUtils.startRecordingFromTrackList;
-import static de.dennisguse.opentracks.util.TrackUiTestUtils.stopRecordingToTrackStopped;
 import static org.hamcrest.Matchers.allOf;
+import static de.dennisguse.opentracks.util.EspressoUtils.childAtPosition;
+import static de.dennisguse.opentracks.util.EspressoUtils.waitFor;
 
 import androidx.test.ext.junit.rules.ActivityScenarioRule;
 import androidx.test.ext.junit.runners.AndroidJUnit4;
 import androidx.test.filters.LargeTest;
 import androidx.test.rule.GrantPermissionRule;
 
-import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
-import java.time.Duration;
-
 @LargeTest
 @RunWith(AndroidJUnit4.class)
 public class EspressoDeleteTrackTest {
 
-    private static final Duration UI_TIMEOUT = Duration.ofSeconds(10);
-
     @Rule
     public ActivityScenarioRule<TrackListActivity> mActivityTestRule = new ActivityScenarioRule<>(TrackListActivity.class);
 
     @Rule
     public GrantPermissionRule mGrantPermissionRule = TestUtil.createGrantPermissionRule();
 
-    @Before
-    public void setUp() {
-        resetTrackRecordingServiceAndDeleteTracks();
-    }
-
     @Test
-    public void deleteTrackFromTrackStoppedActivity() {
-        recordTrackAndOpenTrackStoppedActivity();
+    public void espressoDeleteTrackTest() {
+        // TrackListActivity: start recording
+        onView(withId(R.id.track_list_fab_action))
+                .perform(click());
 
-        // TrackStoppedActivity: discard the just-recorded track directly
-        onView(withId(R.id.discard_button))
-                .perform(performClick());
-        onView(withText(android.R.string.ok))
-                .inRoot(isDialog())
-                .perform(performClick());
-        waitUntilDisplayed(withId(R.id.track_list), UI_TIMEOUT);
-        waitUntilRecyclerViewItemCount(withId(R.id.track_list), 0, UI_TIMEOUT);
-
-        // the recycler is empty again after discarding the only recorded track
-        onView(withId(R.id.track_list))
-                .check(matches(withRecyclerViewItemCount(0)));
-    }
-
-    @Test
-    public void deleteTrackFromSelectedTrackInTrackList() {
-        String uniqueTrackName = "DeleteFromTrackList-" + System.currentTimeMillis();
-
-        recordTrackAndOpenTrackStoppedActivity();
-        renameStoppedTrack(uniqueTrackName, UI_TIMEOUT);
+        // TrackRecordingActivity
+        onView(withId(R.id.track_recording_fab_action))
+                // wait; stay recording
+                .perform(waitFor(5000))
+                // stop;
+                .perform(longClick());
 
+        // TrackStoppedActivity
         onView(withId(R.id.finish_button))
-                .perform(performClick());
-        waitUntilDisplayed(withId(R.id.track_list), UI_TIMEOUT);
-        waitUntilDisplayed(allOf(withId(R.id.track_list_item_name), withText(uniqueTrackName)), UI_TIMEOUT);
-        waitUntilRecyclerViewItemCount(withId(R.id.track_list), 1, UI_TIMEOUT);
+                .perform(click());
 
-        onView(allOf(withId(R.id.track_list_item_name), withText(uniqueTrackName)))
-                .perform(performLongClickOnAncestor());
+        // select track
+        onView(allOf(withParent(withId(R.id.track_list)), withParentIndex(0)))
+                .perform(longClick());
 
-        clickDeleteSelectedTrackAction();
-        onView(withText(android.R.string.ok))
-                .inRoot(isDialog())
-                .perform(performClick());
-        waitUntilRecyclerViewItemCount(withId(R.id.track_list), 0, UI_TIMEOUT);
+        // open menu and delete selected track
+        onView(
+                allOf(withContentDescription("More options"),
+                        childAtPosition(
+                                childAtPosition(
+                                        withId(androidx.appcompat.R.id.action_mode_bar),
+                                        1),
+                                2),
+                        isDisplayed()))
+                .perform(click());
 
-        onView(withId(R.id.track_list))
-                .check(matches(withRecyclerViewItemCount(0)));
+        onView(withText("Delete"))
+                .perform(click());
+
+        onView(withText("OK"))
+                .perform(click());
+
+        // tracklist is empty now
+        onView(allOf(withText("Start recording your next adventure here"), isDisplayed()));
     }
-
-    private void recordTrackAndOpenTrackStoppedActivity() {
-        startRecordingFromTrackList(UI_TIMEOUT);
-        stopRecordingToTrackStopped(UI_TIMEOUT, R.id.discard_button, R.id.finish_button);
-    }
-
-    private void clickDeleteSelectedTrackAction() {
-        try {
-            waitUntilDisplayed(withId(R.id.list_context_menu_delete), UI_TIMEOUT);
-            onView(withId(R.id.list_context_menu_delete))
-                    .perform(performClick());
-        } catch (AssertionError ignored) {
-            onView(allOf(
-                    withContentDescription(androidx.appcompat.R.string.abc_action_menu_overflow_description),
-                    isDescendantOfA(withId(androidx.appcompat.R.id.action_mode_bar))))
-                    .perform(performClick());
-            onView(withText(R.string.menu_delete))
-                    .inRoot(isPlatformPopup())
-                    .perform(performClickOnAncestor());
-        }
-    }
-
 }

src/androidTest/java/de/dennisguse/opentracks/EspressoEditTrackRecordingTest.java

@@ -2,43 +2,34 @@ package de.dennisguse.opentracks;
 
 
 import static androidx.test.espresso.Espresso.onView;
+import static androidx.test.espresso.Espresso.openContextualActionModeOverflowMenu;
+import static androidx.test.espresso.action.ViewActions.click;
 import static androidx.test.espresso.action.ViewActions.closeSoftKeyboard;
+import static androidx.test.espresso.action.ViewActions.longClick;
 import static androidx.test.espresso.action.ViewActions.replaceText;
 import static androidx.test.espresso.action.ViewActions.scrollTo;
 import static androidx.test.espresso.assertion.ViewAssertions.matches;
-import static androidx.test.espresso.matcher.RootMatchers.isPlatformPopup;
 import static androidx.test.espresso.matcher.ViewMatchers.isDisplayed;
-import static androidx.test.espresso.matcher.ViewMatchers.isDescendantOfA;
-import static androidx.test.espresso.matcher.ViewMatchers.withContentDescription;
 import static androidx.test.espresso.matcher.ViewMatchers.withId;
 import static androidx.test.espresso.matcher.ViewMatchers.withText;
-import static de.dennisguse.opentracks.util.EspressoUtils.performClick;
-import static de.dennisguse.opentracks.util.EspressoUtils.performClickOnAncestor;
-import static de.dennisguse.opentracks.util.EspressoUtils.waitUntilDisplayed;
-import static de.dennisguse.opentracks.util.TestEnvironmentUtils.resetTrackRecordingServiceAndDeleteTracks;
-import static de.dennisguse.opentracks.util.TrackUiTestUtils.startRecordingFromTrackList;
-import static de.dennisguse.opentracks.util.TrackUiTestUtils.stopRecordingToTrackStopped;
 import static org.hamcrest.Matchers.allOf;
+import static de.dennisguse.opentracks.util.EspressoUtils.waitFor;
 
 import androidx.test.ext.junit.rules.ActivityScenarioRule;
 import androidx.test.ext.junit.runners.AndroidJUnit4;
 import androidx.test.filters.LargeTest;
 import androidx.test.rule.GrantPermissionRule;
 
-import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
-import java.time.Duration;
 import java.util.Locale;
 
 @LargeTest
 @RunWith(AndroidJUnit4.class)
 public class EspressoEditTrackRecordingTest {
 
-    private static final Duration UI_TIMEOUT = Duration.ofSeconds(10);
-
     @Rule
     public final LocaleRule mLocaleRule = new LocaleRule(Locale.ENGLISH);
 
@@ -48,27 +39,27 @@ public class EspressoEditTrackRecordingTest {
     @Rule
     public GrantPermissionRule mGrantPermissionRule = TestUtil.createGrantPermissionRule();
 
-    @Before
-    public void setUp() {
-        resetTrackRecordingServiceAndDeleteTracks();
-    }
-
     @LargeTest
     @Test
     public void espressoEditTrackRecordingTest() {
-        startRecordingFromTrackList(UI_TIMEOUT);
+        {
+            // TrackListActivity: start recording
+            onView(withId(R.id.track_list_fab_action))
+                    .perform(click());
+        }
         {
             // TrackRecordingActivity
 
+            // wait; stay recording
+            onView(withId(R.id.track_recording_fab_action))
+                    .perform(waitFor(4000));
+
             // open menu
-            onView(allOf(
-                    withContentDescription(androidx.appcompat.R.string.abc_action_menu_overflow_description),
-                    isDescendantOfA(withId(R.id.bottom_app_bar))))
-                    .perform(performClick());
+            openContextualActionModeOverflowMenu();
+
+            // Click the item.
             onView(withText(R.string.menu_edit))
-                    .inRoot(isPlatformPopup())
-                    .perform(performClickOnAncestor());
-            waitUntilDisplayed(withId(R.id.track_edit_name), UI_TIMEOUT);
+                    .perform(click());
 
             // change name for "New Name"
             onView(withId(R.id.track_edit_name))
@@ -79,11 +70,11 @@ public class EspressoEditTrackRecordingTest {
 
             // save edition
             onView(withId(R.id.track_edit_save))
-                    .perform(performClick());
-            waitUntilDisplayed(withId(R.id.track_recording_fab_action), UI_TIMEOUT);
+                    .perform(click());
 
             // stop;
-            stopRecordingToTrackStopped(UI_TIMEOUT, R.id.resume_button, R.id.finish_button);
+            onView(withId(R.id.track_recording_fab_action))
+                    .perform(longClick());
 
             // it's on track stopped activity and there are two buttons
             onView(withId(R.id.resume_button))

src/androidTest/java/de/dennisguse/opentracks/EspressoUITest.java

@@ -1,142 +1,100 @@
 package de.dennisguse.opentracks;
 
 import static androidx.test.espresso.Espresso.onView;
+import static androidx.test.espresso.action.ViewActions.click;
+import static androidx.test.espresso.action.ViewActions.longClick;
 import static androidx.test.espresso.assertion.ViewAssertions.matches;
+import static androidx.test.espresso.matcher.ViewMatchers.isClickable;
 import static androidx.test.espresso.matcher.ViewMatchers.isDisplayed;
 import static androidx.test.espresso.matcher.ViewMatchers.withId;
-import static androidx.test.espresso.matcher.ViewMatchers.withText;
-import static de.dennisguse.opentracks.util.EspressoUtils.performLongClickOnAncestor;
-import static de.dennisguse.opentracks.util.EspressoUtils.selectTabAtIndex;
-import static de.dennisguse.opentracks.util.EspressoUtils.waitUntilDisplayed;
-import static de.dennisguse.opentracks.util.EspressoUtils.waitForResumedViewCondition;
-import static de.dennisguse.opentracks.util.EspressoUtils.withSelectedTab;
-import static de.dennisguse.opentracks.util.EspressoUtils.withViewPagerCurrentItem;
-import static de.dennisguse.opentracks.util.TestEnvironmentUtils.resetTrackRecordingServiceAndDeleteTracks;
-import static de.dennisguse.opentracks.util.TrackUiTestUtils.finishStoppedTrack;
-import static de.dennisguse.opentracks.util.TrackUiTestUtils.resumeStoppedTrack;
-import static de.dennisguse.opentracks.util.TrackUiTestUtils.startRecordingFromTrackList;
-import static de.dennisguse.opentracks.util.TrackUiTestUtils.stopRecordingToTrackStopped;
+import static androidx.test.espresso.matcher.ViewMatchers.withParent;
+import static androidx.test.espresso.matcher.ViewMatchers.withParentIndex;
 import static org.hamcrest.Matchers.allOf;
+import static de.dennisguse.opentracks.util.EspressoUtils.selectTabAtIndex;
+import static de.dennisguse.opentracks.util.EspressoUtils.waitFor;
 
-import android.util.Pair;
-
-import androidx.test.core.app.ApplicationProvider;
 import androidx.test.espresso.ViewInteraction;
 import androidx.test.ext.junit.rules.ActivityScenarioRule;
 import androidx.test.ext.junit.runners.AndroidJUnit4;
 import androidx.test.filters.LargeTest;
 import androidx.test.rule.GrantPermissionRule;
 
-import org.hamcrest.Matcher;
-import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
-import org.junit.rules.RuleChain;
 import org.junit.runner.RunWith;
 
-import java.time.Duration;
-import java.util.List;
-
-import de.dennisguse.opentracks.content.data.TestDataUtil;
-import de.dennisguse.opentracks.data.ContentProviderUtils;
-import de.dennisguse.opentracks.data.models.Track;
-import de.dennisguse.opentracks.data.models.TrackBuilder;
-import de.dennisguse.opentracks.data.models.TrackPoint;
-
 @LargeTest
 @RunWith(AndroidJUnit4.class)
 public class EspressoUITest {
 
-    private static final Duration UI_TIMEOUT = Duration.ofSeconds(10);
-
-    private final ActivityScenarioRule<TrackListActivity> activityRule = new ActivityScenarioRule<>(TrackListActivity.class);
-    private final GrantPermissionRule grantPermissionRule = TestUtil.createGrantPermissionRule();
+    @Rule
+    public ActivityScenarioRule<TrackListActivity> mActivityTestRule = new ActivityScenarioRule<>(TrackListActivity.class);
 
     @Rule
-    public RuleChain rules = RuleChain.outerRule(grantPermissionRule)
-            .around(activityRule);
-
-    @Before
-    public void setUp() {
-        resetTrackRecordingServiceAndDeleteTracks();
-    }
-
+    public GrantPermissionRule mGrantPermissionRule = TestUtil.createGrantPermissionRule();
     @LargeTest
     @Test
     public void record_stop_resume_stop_finish() {
-        startRecordingFromTrackList(UI_TIMEOUT);
         {
-            stopRecordingToTrackStopped(UI_TIMEOUT, R.id.resume_button);
-            resumeStoppedTrack(UI_TIMEOUT);
-            stopRecordingToTrackStopped(UI_TIMEOUT, R.id.finish_button);
-            finishStoppedTrack(UI_TIMEOUT);
+            // TrackListActivity: start recording
+            onView(withId(R.id.track_list_fab_action))
+                    .perform(click());
+        }
+        {
+            // TrackRecordingActivity: wait to record some time and then stop
+            onView(withId(R.id.track_recording_fab_action))
+                    .perform(waitFor(5000))
+                    .perform(longClick());
 
-            onView(withId(R.id.track_list))
-                    .check(matches(isDisplayed()));
+            // TrackStoppedActivity: resume
+            onView(allOf(withId(R.id.resume_button), isClickable()))
+                    .perform(click());
+
+            // TrackRecordingActivity: wait and then stop
+            onView(withId(R.id.track_recording_fab_action))
+                    .perform(waitFor(5000))
+                    .perform(longClick());
+
+            // TrackStoppedActivity
+            onView(withId(R.id.finish_button))
+                    .perform(click());
         }
     }
 
     @LargeTest
     @Test
     public void record_move_through_tabs() {
-        startRecordingFromTrackList(UI_TIMEOUT);
-        waitUntilDisplayed(withId(R.id.track_detail_activity_tablayout), UI_TIMEOUT);
-        waitUntilDisplayed(withId(R.id.track_detail_activity_view_pager), UI_TIMEOUT);
+        {
+            // TrackListActivity: start recording
+            onView(withId(R.id.track_list_fab_action))
+                    .perform(click());
+        }
         {
             // TrackRecordingActivity
             ViewInteraction tabLayout = onView(withId(R.id.track_detail_activity_tablayout));
 
             tabLayout.perform(selectTabAtIndex(1));
-            waitUntilTabSelectionSettlesAt(1);
+            tabLayout.perform(waitFor(1000));
 
             tabLayout.perform(selectTabAtIndex(2));
-            waitUntilTabSelectionSettlesAt(2);
+            tabLayout.perform(waitFor(1000));
 
             tabLayout.perform(selectTabAtIndex(3));
-            waitUntilTabSelectionSettlesAt(3);
+            tabLayout.perform(waitFor(1000));
 
             tabLayout.perform(selectTabAtIndex(0));
-            waitUntilTabSelectionSettlesAt(0);
+            tabLayout.perform(waitFor(1000));
 
             // stop
-            stopRecordingToTrackStopped(UI_TIMEOUT, R.id.resume_button, R.id.finish_button);
-
-            onView(withId(R.id.resume_button))
-                    .check(matches(isDisplayed()));
-            onView(withId(R.id.finish_button))
-                    .check(matches(isDisplayed()));
+            onView(withId(R.id.track_recording_fab_action)).
+                    perform(longClick());
         }
     }
 
     @LargeTest
     @Test
     public void selectAndDeleteTrack() {
-        Pair<Track, List<TrackPoint>> pair = TestDataUtil.createTrack(new Track.Id(System.currentTimeMillis()), 5);
-        String uniqueTrackName = "SelectAndDeleteTrack-" + System.currentTimeMillis();
-        TrackBuilder trackBuilder = new TrackBuilder(pair.first);
-        trackBuilder.setName(uniqueTrackName);
-        TestDataUtil.insertTrackWithLocations(new ContentProviderUtils(ApplicationProvider.getApplicationContext()), trackBuilder.getTrack(), pair.second);
-        activityRule.getScenario().recreate();
-        waitUntilDisplayed(allOf(withId(R.id.track_list_item_name), withText(uniqueTrackName)), UI_TIMEOUT);
-
         onView(withId(R.id.track_list)).check(matches(isDisplayed()));
-        onView(allOf(withId(R.id.track_list_item_name), withText(uniqueTrackName)))
-                .perform(performLongClickOnAncestor());
-
-        onView(withId(androidx.appcompat.R.id.action_mode_bar))
-                .check(matches(isDisplayed()));
-    }
-
-    private void waitUntilTabSelectionSettlesAt(int index) {
-        waitForResumedViewCondition(
-                withId(R.id.track_detail_activity_tablayout),
-                view -> withSelectedTab(index).matches(view),
-                "selected tab to be " + index,
-                UI_TIMEOUT);
-        waitForResumedViewCondition(
-                withId(R.id.track_detail_activity_view_pager),
-                view -> withViewPagerCurrentItem(index).matches(view),
-                "ViewPager current item to be " + index,
-                UI_TIMEOUT);
+        onView(allOf(withParent(withId(R.id.track_list)), withParentIndex(0))).perform(longClick());
     }
 }

src/androidTest/java/de/dennisguse/opentracks/data/CustomContentProviderUtilsTest.java

@@ -20,19 +20,22 @@ import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.when;
 
 import android.content.ContentResolver;
 import android.content.ContentUris;
 import android.content.ContentValues;
 import android.content.Context;
 import android.database.Cursor;
-import android.database.MatrixCursor;
 import android.util.Pair;
 
 import androidx.test.core.app.ApplicationProvider;
 
 import org.junit.Before;
 import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.junit.MockitoJUnitRunner;
 
 import java.io.File;
 import java.io.IOException;
@@ -75,6 +78,7 @@ import de.dennisguse.opentracks.util.FileUtils;
  * @author Bartlomiej Niechwiej
  * @author Youtao Liu
  */
+@RunWith(MockitoJUnitRunner.class)
 public class CustomContentProviderUtilsTest {
 
     private static final String NAME_PREFIX = "test name";
@@ -86,6 +90,12 @@ public class CustomContentProviderUtilsTest {
     private final Context context = ApplicationProvider.getApplicationContext();
     private ContentProviderUtils contentProviderUtils;
 
+    @Mock
+    private Cursor cursorMock;
+
+    @Mock
+    private ContentResolver contentResolverMock;
+
     @Before
     public void setUp() {
         contentProviderUtils = new ContentProviderUtils(context);
@@ -94,21 +104,21 @@ public class CustomContentProviderUtilsTest {
 
     @Test
     public void testLocationIterator_noPoints() {
-        assertEquals(0, testIterator(new Track.Id(1), 0).size());
+        testIterator(new Track.Id(1), 0);
     }
 
     @Test
     public void testLocationIterator_noAscending() {
-        assertEquals(50, testIterator(new Track.Id(1), 50).size());
-        assertEquals(50, testIterator(new Track.Id(2), 50).size());
+        testIterator(new Track.Id(1), 50);
+        testIterator(new Track.Id(2), 50);
     }
 
     @Test
     public void testLocationIterator_largeTrack() {
-        assertEquals(20000 / 2, testIterator(new Track.Id(1), 20000 / 2).size());
+        testIterator(new Track.Id(1), 20000 / 2);
     }
 
-    private List<TrackPoint> testIterator(Track.Id trackId, int numPoints) {
+    private void testIterator(Track.Id trackId, int numPoints) {
         TrackPoint.Id lastPointId = initializeTrack(trackId, numPoints);
         List<TrackPoint> locations = new ArrayList<>(numPoints);
         try (TrackPointIterator it = contentProviderUtils.getTrackPointIterator(trackId, null)) {
@@ -121,7 +131,6 @@ public class CustomContentProviderUtilsTest {
             }
             assertEquals(numPoints, locations.size());
         }
-        return locations;
     }
 
     private TrackPoint.Id initializeTrack(Track.Id id, int numPoints) {
@@ -178,49 +187,27 @@ public class CustomContentProviderUtilsTest {
     @Test
     public void testCreateTrack() {
         Track.Id trackId = new Track.Id(System.currentTimeMillis());
+
+        int columnIndex = 1;
+        // Id
+        when(cursorMock.getColumnIndexOrThrow(TracksColumns._ID)).thenReturn(columnIndex);
+        when(cursorMock.isNull(columnIndex)).thenReturn(false);
+        when(cursorMock.getLong(columnIndex)).thenReturn(trackId.id());
+
+        //Uuid
+        columnIndex++;
+        when(cursorMock.getColumnIndexOrThrow(TracksColumns.UUID)).thenReturn(columnIndex);
+        when(cursorMock.isNull(columnIndex)).thenReturn(false);
+        when(cursorMock.getBlob(columnIndex)).thenReturn(UUIDUtils.toBytes(UUID.randomUUID()));
+
+        // Name
+        columnIndex++;
         String name = NAME_PREFIX + trackId.id();
+        when(cursorMock.getColumnIndexOrThrow(TracksColumns.NAME)).thenReturn(columnIndex);
+        when(cursorMock.isNull(columnIndex)).thenReturn(false);
+        when(cursorMock.getString(columnIndex)).thenReturn(name);
 
-        MatrixCursor cursor = new MatrixCursor(new String[]{
-                TracksColumns._ID,
-                TracksColumns.UUID,
-                TracksColumns.NAME,
-                TracksColumns.DESCRIPTION,
-                TracksColumns.ACTIVITY_TYPE,
-                TracksColumns.ACTIVITY_TYPE_LOCALIZED,
-                TracksColumns.STARTTIME,
-                TracksColumns.STARTTIME_OFFSET,
-                TracksColumns.STOPTIME,
-                TracksColumns.TOTALDISTANCE,
-                TracksColumns.TOTALTIME,
-                TracksColumns.MOVINGTIME,
-                TracksColumns.MAXSPEED,
-                TracksColumns.MIN_ALTITUDE,
-                TracksColumns.MAX_ALTITUDE,
-                TracksColumns.ALTITUDE_GAIN,
-                TracksColumns.ALTITUDE_LOSS,
-        });
-        cursor.addRow(new Object[]{
-                trackId.id(),
-                UUIDUtils.toBytes(UUID.randomUUID()),
-                name,
-                "",
-                ActivityType.UNKNOWN.getId(),
-                "",
-                1_000L,
-                ZoneOffset.UTC.getTotalSeconds(),
-                2_000L,
-                123.45f,
-                1_000L,
-                500L,
-                12.34f,
-                null,
-                null,
-                null,
-                null,
-        });
-        assertTrue(cursor.moveToFirst());
-
-        Track track = ContentProviderUtils.createTrack(cursor);
+        Track track = ContentProviderUtils.createTrack(cursorMock);
         assertEquals(trackId, track.id());
         assertEquals(name, track.name());
     }
@@ -462,6 +449,8 @@ public class CustomContentProviderUtilsTest {
         marker.setDescription(TEST_DESC);
         contentProviderUtils.insertMarker(marker.getMarker());
 
+        ContentProviderUtils contentProviderUtils = new ContentProviderUtils(contentResolverMock);
+
         Marker.Id markerId = new Marker.Id(System.currentTimeMillis());
         marker.setId(markerId);
         ContentValues contentValues = contentProviderUtils.createContentValues(marker.getMarker(), trackId);
@@ -1195,7 +1184,7 @@ public class CustomContentProviderUtilsTest {
         assertEquals(sensorStatistics.avgPower().getW(), stats.avgPower, 0f);
     }
 
-    private Pair<SensorStatistics, TestSensorDataUtil.SensorDataStats> testGetSensorStats_randomData(int totalPoints, boolean withStartSegments) {
+    private void testGetSensorStats_randomData(int totalPoints, boolean withStartSegments) {
         // given
         Instant start = Instant.now();
         TestSensorDataUtil sensorDataUtil = new TestSensorDataUtil();
@@ -1218,27 +1207,22 @@ public class CustomContentProviderUtilsTest {
         SensorStatistics sensorStatistics = contentProviderUtils.getSensorStats(trackId);
         TestSensorDataUtil.SensorDataStats stats = sensorDataUtil.computeStats();
 
-        return Pair.create(sensorStatistics, stats);
+        // then
+        assertEquals(sensorStatistics.avgHeartRate().getBPM(), stats.avgHr, 0.01f);
+        assertEquals(sensorStatistics.maxHeartRate().getBPM(), stats.maxHr, 0.01f);
+        assertEquals(sensorStatistics.avgCadence().getRPM(), stats.avgCadence, 0.01f);
+        assertEquals(sensorStatistics.maxCadence().getRPM(), stats.maxCadence, 0.01f);
+        assertEquals(sensorStatistics.avgPower().getW(), stats.avgPower, 0.01f);
     }
 
     @Test
     public void testGetSensorStats_veryLongActivity12h() {
-        Pair<SensorStatistics, TestSensorDataUtil.SensorDataStats> result = testGetSensorStats_randomData(43200 / 6, false);
-        assertEquals(result.first.avgHeartRate().getBPM(), result.second.avgHr, 0.01f);
-        assertEquals(result.first.maxHeartRate().getBPM(), result.second.maxHr, 0.01f);
-        assertEquals(result.first.avgCadence().getRPM(), result.second.avgCadence, 0.01f);
-        assertEquals(result.first.maxCadence().getRPM(), result.second.maxCadence, 0.01f);
-        assertEquals(result.first.avgPower().getW(), result.second.avgPower, 0.01f);
+        testGetSensorStats_randomData(43200 / 6, false);
     }
 
     @Test
     public void testGetSensorStats_withSeveralRandomStartSegments() {
-        Pair<SensorStatistics, TestSensorDataUtil.SensorDataStats> result = testGetSensorStats_randomData(5000, true);
-        assertEquals(result.first.avgHeartRate().getBPM(), result.second.avgHr, 0.01f);
-        assertEquals(result.first.maxHeartRate().getBPM(), result.second.maxHr, 0.01f);
-        assertEquals(result.first.avgCadence().getRPM(), result.second.avgCadence, 0.01f);
-        assertEquals(result.first.maxCadence().getRPM(), result.second.maxCadence, 0.01f);
-        assertEquals(result.first.avgPower().getW(), result.second.avgPower, 0.01f);
+        testGetSensorStats_randomData(5000, true);
     }
 
     private TrackPoint getLastValidTrackPoint(Track.Id trackId) {

src/androidTest/java/de/dennisguse/opentracks/io/file/importer/ExportImportTest.java

@@ -199,6 +199,7 @@ public class ExportImportTest {
                 ));
 
         trackPointCreator.setClock("2020-02-02T02:02:18Z");
+        trackPointCreator.getSensorManager().clear();
         service.endCurrentTrack();
 
         trackPointCreator.setClock("2020-02-02T02:03:20Z");
@@ -213,6 +214,7 @@ public class ExportImportTest {
 
         sendLocation(trackPointCreator, "2020-02-02T02:03:50Z", 3.1234567, 16.001, 10, 27, 15, 999.123, 0f);
 
+        trackPointCreator.getSensorManager().clear();
         trackPointCreator.setClock("2020-02-02T02:04:00Z");
         service.endCurrentTrack();
 
@@ -296,22 +298,7 @@ public class ExportImportTest {
                         Power.of(50),
                         new AltitudeGainLoss(0, 0)
                 ),
-                new TrackPoint(
-                        null,
-                        TrackPoint.Type.SEGMENT_END_MANUAL,
-                        new Position(
-                                Instant.parse("2020-02-02T02:02:18Z"),
-                                3.123456, 14.001456, Distance.of(10),
-                                Altitude.WGS84.of(1020.25), null,
-                                null,
-                                Speed.of(5)),
-                        Distance.of(0),
-                        HeartRate.of(69),
-                        null,
-                        Cadence.of(3),
-                        Power.of(50),
-                        new AltitudeGainLoss(0, 0)
-                ),
+                new TrackPoint(TrackPoint.Type.SEGMENT_END_MANUAL, Instant.parse("2020-02-02T02:02:18Z")),
                 new TrackPoint(TrackPoint.Type.SEGMENT_START_MANUAL, Instant.parse("2020-02-02T02:03:20Z")),
                 new TrackPoint(
                         null,
@@ -369,16 +356,7 @@ public class ExportImportTest {
                         null,
                         null,
                         new AltitudeGainLoss(0, 0)),
-                new TrackPoint(
-                        null,
-                        TrackPoint.Type.SEGMENT_END_MANUAL,
-                        Position.of(Instant.parse("2020-02-02T02:04:00Z")),
-                        null,
-                        null,
-                        null,
-                        null,
-                        null,
-                        new AltitudeGainLoss(0, 0))
+                new TrackPoint(TrackPoint.Type.SEGMENT_END_MANUAL, Instant.parse("2020-02-02T02:04:00Z"))
         ), actual);
 
         assertEquals(new Statistics(

src/androidTest/java/de/dennisguse/opentracks/publicapi/DataProviderTest.java

@@ -14,7 +14,7 @@ import androidx.test.ext.junit.runners.AndroidJUnit4;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
-import de.dennisguse.opentracks.data.CustomContentProvider;
+import de.dennisguse.opentracks.data.ContentProviderUtils;
 
 @RunWith(AndroidJUnit4.class)
 public class DataProviderTest {
@@ -24,7 +24,7 @@ public class DataProviderTest {
     @Test
     public void supportsVersion2_tracks() {
         // given
-        Uri uri = Uri.parse(CustomContentProvider.CONTENT_BASE_URI + "/dashboard/tracks/1");
+        Uri uri = Uri.parse(ContentProviderUtils.CONTENT_BASE_URI + "/dashboard/tracks/1");
         String[] expectedTracksColumns = new String[]{
                 "_id",
                 "name",
@@ -64,7 +64,7 @@ public class DataProviderTest {
     @Test
     public void supportsVersion2_trackpoints() {
         // given
-        Uri uri = Uri.parse(CustomContentProvider.CONTENT_BASE_URI + "/dashboard/trackpoints/1");
+        Uri uri = Uri.parse(ContentProviderUtils.CONTENT_BASE_URI + "/dashboard/trackpoints/1");
         String[] expectedTrackpointsColumns = {
                 "_id",
                 "trackid",
@@ -94,7 +94,7 @@ public class DataProviderTest {
     @Test
     public void supportsVersion2_markers() {
         // given
-        Uri uri = Uri.parse(CustomContentProvider.CONTENT_BASE_URI + "/dashboard/markers/1");
+        Uri uri = Uri.parse(ContentProviderUtils.CONTENT_BASE_URI + "/dashboard/markers/1");
         String[] expectedMarkersColumns = {
                 "_id",
                 "name",
@@ -126,7 +126,7 @@ public class DataProviderTest {
     @Test
     public void supportsVersion3_tracks() {
         // given
-        Uri uri = Uri.parse(CustomContentProvider.CONTENT_BASE_URI + "/dashboard/tracks/1");
+        Uri uri = Uri.parse(ContentProviderUtils.CONTENT_BASE_URI + "/dashboard/tracks/1");
         String[] expectedTracksColumns = {
                 "_id",
                 "name",
@@ -164,7 +164,7 @@ public class DataProviderTest {
     @Test
     public void supportsVersion3_trackpoints() {
         //given
-        Uri uri = Uri.parse(CustomContentProvider.CONTENT_BASE_URI + "/dashboard/trackpoints/1");
+        Uri uri = Uri.parse(ContentProviderUtils.CONTENT_BASE_URI + "/dashboard/trackpoints/1");
         String[] expectedTrackpointsColumns = {
                 "_id",
                 "trackid",
@@ -194,7 +194,7 @@ public class DataProviderTest {
     @Test
     public void supportsVersion3_markers() {
         // given
-        Uri uri = Uri.parse(CustomContentProvider.CONTENT_BASE_URI + "/dashboard/markers/1");
+        Uri uri = Uri.parse(ContentProviderUtils.CONTENT_BASE_URI + "/dashboard/markers/1");
         String[] expectedMarkersColumns = {
                 "_id",
                 "name",

src/androidTest/java/de/dennisguse/opentracks/sensors/driver/BoschEbikeParserTest.java

@@ -1,137 +0,0 @@
-package de.dennisguse.opentracks.sensors.driver;
-
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertNull;
-
-import org.junit.Test;
-
-public class BoschEbikeParserTest {
-
-    @Test
-    public void parse_multipleFrames_returnsCombinedMeasurements() {
-        byte[] raw = new byte[] {
-                // Bosch cadence frame
-                0x30, 0x04, (byte) 0x98, 0x5A, 0x08, 0x76,
-                // Bosch human power frame
-                0x30, 0x05, (byte) 0x98, 0x5B, 0x08, (byte) 0x83, 0x01,
-                // Bosch speed frame
-                0x30, 0x07, (byte) 0x98, 0x2D, 0x08, (byte) 0x94, 0x0B, 0x10, 0x01
-        };
-
-        BoschEbikeParser.Data data = BoschEbikeParser.parse(raw);
-
-        assertNotNull(data);
-        assertEquals(59.0f, data.cadence().getRPM(), 0.01f);
-        assertEquals(131.0f, data.humanPower().getW(), 0.01f);
-        assertEquals(14.28 / 3.6, data.speed().toMPS(), 0.0001);
-    }
-
-    @Test
-    public void parse_multiByteVarint_returnsScaledSpeed() {
-        // Bosch speed frame using a multi-byte varint
-        BoschEbikeParser.Data data = BoschEbikeParser.parse(new byte[] {
-                0x30, 0x07, (byte) 0x98, 0x2D, 0x08, (byte) 0xE1, 0x0E, 0x10, 0x01
-        });
-
-        assertNotNull(data);
-        assertEquals(18.89 / 3.6, data.speed().toMPS(), 0.0001);
-    }
-
-    @Test
-    public void parse_zeroValueFrame_returnsZeroCadence() {
-        // Bosch zero-value cadence frame
-        BoschEbikeParser.Data data = BoschEbikeParser.parse(new byte[] {
-                0x30, 0x02, (byte) 0x98, 0x5A
-        });
-
-        assertNotNull(data);
-        assertEquals(0.0f, data.cadence().getRPM(), 0.01f);
-        assertNull(data.speed());
-        assertNull(data.humanPower());
-    }
-
-    @Test
-    public void parse_unsupportedMeasurementsOnly_returnsNull() {
-        // Bosch frame for message 0x9865, which the parser does not map to a measurement.
-        BoschEbikeParser.Data data = BoschEbikeParser.parse(new byte[] {
-                0x30, 0x02, (byte) 0x98, 0x65
-        });
-
-        assertNull(data);
-    }
-
-    @Test
-    public void parse_unimplementedMeasurementsOnly_returnsNull() {
-        // Bosch motor power frame: message 0x985D with value 0x42, currently ignored.
-        BoschEbikeParser.Data data = BoschEbikeParser.parse(new byte[] {
-                0x30, 0x04, (byte) 0x98, 0x5D, 0x08, 0x42
-        });
-
-        assertNull(data);
-    }
-
-    @Test
-    public void parse_malformedVarint_returnsNull() {
-        // Truncated Bosch speed frame: starts like a real 0x982D frame but the varint is incomplete.
-        BoschEbikeParser.Data data = BoschEbikeParser.parse(new byte[] {
-                0x30, 0x04, (byte) 0x98, 0x2D, 0x08, (byte) 0x94
-        });
-
-        assertNull(data);
-    }
-
-    @Test
-    public void parse_varintLargerThan32Bit_returnsNull() {
-        BoschEbikeParser.Data data = BoschEbikeParser.parse(new byte[] {
-                0x30, 0x08, (byte) 0x98, 0x2D, 0x08,
-                (byte) 0x80, (byte) 0x80, (byte) 0x80, (byte) 0x80, (byte) 0x80, 0x01
-        });
-
-        assertNull(data);
-    }
-
-    @Test
-    public void parse_validMeasurementBeforeMalformedFrame_returnsValidMeasurement() {
-        BoschEbikeParser.Data data = BoschEbikeParser.parse(new byte[] {
-                // Bosch cadence frame: message 0x985A with value 0x76
-                0x30, 0x04, (byte) 0x98, 0x5A, 0x08, 0x76,
-                // Truncated Bosch speed frame: malformed trailing frame should not discard the valid cadence above.
-                0x30, 0x04, (byte) 0x98, 0x2D, 0x08, (byte) 0x94
-        });
-
-        assertNotNull(data);
-        assertEquals(59.0f, data.cadence().getRPM(), 0.01f);
-        assertNull(data.speed());
-    }
-
-    @Test
-    public void parse_malformedVarintDoesNotConsumeNextFrameStartByte() {
-        BoschEbikeParser.Data data = BoschEbikeParser.parse(new byte[] {
-                // Truncated Bosch speed frame: the varint continuation bit is set, but the frame ends
-                // before the next varint byte. The following frame start byte must not be consumed.
-                0x30, 0x04, (byte) 0x98, 0x2D, 0x08, (byte) 0x94,
-                // Bosch cadence frame: message 0x985A with value 0x76
-                0x30, 0x04, (byte) 0x98, 0x5A, 0x08, 0x76
-        });
-
-        assertNotNull(data);
-        assertNull(data.speed());
-        assertEquals(59.0f, data.cadence().getRPM(), 0.01f);
-    }
-
-    @Test
-    public void parse_leadingNoise_ignored() {
-        byte[] raw = new byte[] {
-                // Noise bytes to verify the parser resynchronizes on the Bosch frame start byte 0x30.
-                0x01, 0x02, 0x03,
-                // Bosch cadence frame: message 0x985A with value 0x76
-                0x30, 0x04, (byte) 0x98, 0x5A, 0x08, 0x76
-        };
-
-        BoschEbikeParser.Data data = BoschEbikeParser.parse(raw);
-
-        assertNotNull(data);
-        assertEquals(59.0f, data.cadence().getRPM(), 0.01f);
-    }
-}

src/androidTest/java/de/dennisguse/opentracks/sensors/driver/CyclingPowerBluetoothTest.java

@@ -1,7 +1,6 @@
 package de.dennisguse.opentracks.sensors.driver;
 
 import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNull;
 
 import android.bluetooth.BluetoothGattCharacteristic;
 
@@ -36,27 +35,4 @@ public class CyclingPowerBluetoothTest {
         assertEquals(17125, powerCadence.crank().crankRevolutionsTime());
     }
 
-    @Test
-    public void parsePayload_boschPower() {
-        BluetoothGattCharacteristic characteristic = new BluetoothGattCharacteristic(BoschEbikeParser.BOSCH_EBIKE.measurementUUID(), 0, 0);
-        // Bosch human power frame: message 0x985B with value 0x7B => 123 W.
-        characteristic.setValue(new byte[] { 0x30, 0x04, (byte) 0x98, 0x5B, 0x08, 0x7B });
-
-        CyclingPowerBluetooth.Data power = new CyclingPowerBluetooth().parsePayload(BoschEbikeParser.BOSCH_EBIKE, null, characteristic);
-
-        assertEquals(123, power.power().getW(), 0.01);
-        assertNull(power.crank());
-    }
-
-    @Test
-    public void parsePayload_boschCadenceOnly_returnsNull() {
-        BluetoothGattCharacteristic characteristic = new BluetoothGattCharacteristic(BoschEbikeParser.BOSCH_EBIKE.measurementUUID(), 0, 0);
-        // Bosch cadence-only frame: message 0x985A with value 0x01B8 => 220 / 2 = 110 rpm, so power parsing should ignore it.
-        characteristic.setValue(new byte[] { 0x30, 0x05, (byte) 0x98, 0x5A, 0x08, (byte) 0xB8, 0x01 });
-
-        CyclingPowerBluetooth.Data power = new CyclingPowerBluetooth().parsePayload(BoschEbikeParser.BOSCH_EBIKE, null, characteristic);
-
-        assertNull(power);
-    }
-
-}
+}

src/androidTest/java/de/dennisguse/opentracks/services/TrackRecordingServiceNotificationManagerTest.java

@@ -1,23 +1,24 @@
 package de.dennisguse.opentracks.services;
 
-import static org.junit.Assert.assertEquals;
+import static org.mockito.ArgumentMatchers.anyBoolean;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
 
-import android.app.NotificationChannel;
 import android.app.NotificationManager;
 import android.content.Context;
 
 import androidx.core.app.NotificationCompat;
 import androidx.test.core.app.ApplicationProvider;
 
-import org.junit.After;
 import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.junit.MockitoJUnitRunner;
 
 import java.time.ZoneOffset;
-import java.util.ArrayList;
-import java.util.List;
 import java.util.UUID;
 
-import de.dennisguse.opentracks.R;
 import de.dennisguse.opentracks.data.models.ActivityType;
 import de.dennisguse.opentracks.data.models.Altitude;
 import de.dennisguse.opentracks.data.models.Distance;
@@ -28,24 +29,32 @@ import de.dennisguse.opentracks.data.models.Track;
 import de.dennisguse.opentracks.data.models.TrackPoint;
 import de.dennisguse.opentracks.settings.UnitSystem;
 
+@RunWith(MockitoJUnitRunner.class)
 public class TrackRecordingServiceNotificationManagerTest {
 
-    private static final String CHANNEL_ID = "TrackRecordingServiceNotificationManagerTest";
-
     private final Context context = ApplicationProvider.getApplicationContext();
-    private final NotificationManager notificationManager = context.getSystemService(NotificationManager.class);
 
-    @After
-    public void tearDown() {
-        notificationManager.cancelAll();
-    }
+    @Mock
+    private NotificationCompat.Builder notificationCompatBuilder;
+
+    @Mock
+    private NotificationManager notificationManager;
 
     @Test
     public void updateLocation_triggersAlertOnlyOnFirstInaccurateLocation() {
-        notificationManager.createNotificationChannel(new NotificationChannel(CHANNEL_ID, CHANNEL_ID, NotificationManager.IMPORTANCE_DEFAULT));
+        TrackPoint trackPointMock = new TrackPoint(TrackPoint.Type.TRACKPOINT,
+                new Position(
+                        null,
+                        null, null, Distance.of(999f),
+                        Altitude.WGS84.of(10), null,
+                        null,
+                        Speed.ZERO)
+        );
 
-        TrackingNotificationBuilder notificationBuilder = new TrackingNotificationBuilder(context, CHANNEL_ID);
-        TrackRecordingServiceNotificationManager subject = new TrackRecordingServiceNotificationManager(notificationManager, notificationBuilder);
+        when(notificationCompatBuilder.setOnlyAlertOnce(anyBoolean()))
+                .thenReturn(notificationCompatBuilder);
+
+        TrackRecordingServiceNotificationManager subject = new TrackRecordingServiceNotificationManager(notificationManager, notificationCompatBuilder);
         subject.setUnitSystem(UnitSystem.METRIC);
 
         Track track = new Track(
@@ -59,42 +68,16 @@ public class TrackRecordingServiceNotificationManagerTest {
                 Statistics.DEFAULT
         );
 
-        subject.updateTrackPoint(context, createRecordingData(track, Distance.of(999f)), Distance.of(100));
-        subject.updateTrackPoint(context, createRecordingData(track, Distance.of(999f)), Distance.of(100));
-        subject.updateTrackPoint(context, createRecordingData(track, Distance.of(999f)), Distance.of(1000));
-        subject.updateTrackPoint(context, createRecordingData(track, Distance.of(999f)), Distance.of(100));
-        assertEquals(java.util.Arrays.asList(false, true, true, true, true, true, false, true), notificationBuilder.onlyAlertOnceValues);
+        RecordingData data = new RecordingData(track, trackPointMock, null, null);
+
+        // when
+        subject.updateTrackPoint(context, data, Distance.of(100));
+        subject.updateTrackPoint(context, data, Distance.of(100));
+        subject.updateTrackPoint(context, data, Distance.of(1000));
+        subject.updateTrackPoint(context, data, Distance.of(100));
+
+        // then
+        verify(notificationCompatBuilder, times(6)).setOnlyAlertOnce(true);
+        verify(notificationCompatBuilder, times(2)).setOnlyAlertOnce(false);
     }
-
-    private RecordingData createRecordingData(Track track, Distance horizontalAccuracy) {
-        TrackPoint trackPoint = new TrackPoint(
-                TrackPoint.Type.TRACKPOINT,
-                new Position(
-                        null,
-                        null,
-                        null,
-                        horizontalAccuracy,
-                        Altitude.WGS84.of(10),
-                        null,
-                        null,
-                        Speed.ZERO
-                )
-        );
-        return new RecordingData(track, trackPoint, null, null);
-    }
-
-    private static final class TrackingNotificationBuilder extends NotificationCompat.Builder {
-        private final List<Boolean> onlyAlertOnceValues = new ArrayList<>();
-
-        private TrackingNotificationBuilder(Context context, String channelId) {
-            super(context, channelId);
-            setSmallIcon(R.drawable.ic_logo_color_24dp);
-        }
-
-        @Override
-        public NotificationCompat.Builder setOnlyAlertOnce(boolean onlyAlertOnce) {
-            onlyAlertOnceValues.add(onlyAlertOnce);
-            return super.setOnlyAlertOnce(onlyAlertOnce);
-        }
-    }
-}
+}

src/androidTest/java/de/dennisguse/opentracks/services/TrackRecordingServiceStateMachineTest.java

@@ -15,7 +15,6 @@
  */
 package de.dennisguse.opentracks.services;
 
-import static de.dennisguse.opentracks.util.LiveDataTestUtils.waitForValue;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNotEquals;
@@ -42,7 +41,6 @@ import org.junit.Rule;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
-import java.time.Duration;
 import java.util.List;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.TimeoutException;
@@ -58,8 +56,6 @@ import de.dennisguse.opentracks.sensors.GpsStatusValue;
 @RunWith(AndroidJUnit4.class)
 public class TrackRecordingServiceStateMachineTest {
 
-    private static final Duration WAIT_TIMEOUT = Duration.ofSeconds(2);
-
     @Rule
     public final ServiceTestRule mServiceRule = ServiceTestRule.withTimeout(5, TimeUnit.SECONDS);
 
@@ -127,7 +123,6 @@ public class TrackRecordingServiceStateMachineTest {
 
         // when
         service.tryStartSensors();
-        waitUntilGpsStatusIs(GpsStatusValue.GPS_ENABLED);
 
         // then
         assertEquals(TrackRecordingService.STATUS_DEFAULT, service.getRecordingStatusObservable().getValue());
@@ -136,7 +131,6 @@ public class TrackRecordingServiceStateMachineTest {
 
         // when
         service.stopSensors();
-        waitUntilGpsStatusIs(GpsStatusValue.GPS_NONE);
 
         // then
         assertEquals(TrackRecordingService.STATUS_DEFAULT, service.getRecordingStatusObservable().getValue());
@@ -152,9 +146,6 @@ public class TrackRecordingServiceStateMachineTest {
 
         // when
         Track.Id trackId = service.startNewTrack();
-        waitUntilRecordingStatusIs(new RecordingStatus(trackId));
-        waitUntilRecordingDataIsNotDefault();
-        waitUntilGpsStatusIs(GpsStatusValue.GPS_ENABLED);
 
         // then
         assertTrue(service.isRecording());
@@ -163,13 +154,9 @@ public class TrackRecordingServiceStateMachineTest {
         assertEquals(GpsStatusValue.GPS_ENABLED, service.getGpsStatusObservable().getValue());
 
         service.endCurrentTrack();
-        waitUntilRecordingStatusIs(TrackRecordingService.STATUS_DEFAULT);
-        waitUntilGpsStatusIs(GpsStatusValue.GPS_NONE);
 
         // when
         service.resumeTrack(trackId);
-        waitUntilRecordingStatusIs(new RecordingStatus(trackId));
-        waitUntilGpsStatusIs(GpsStatusValue.GPS_ENABLED);
 
         // then
         assertTrue(service.isRecording());
@@ -180,8 +167,6 @@ public class TrackRecordingServiceStateMachineTest {
 
         // when
         service.endCurrentTrack();
-        waitUntilRecordingStatusIs(TrackRecordingService.STATUS_DEFAULT);
-        waitUntilGpsStatusIs(GpsStatusValue.GPS_NONE);
 
         // then
         assertFalse(service.isRecording());
@@ -192,8 +177,6 @@ public class TrackRecordingServiceStateMachineTest {
 
         // when
         service.resumeTrack(trackId);
-        waitUntilRecordingStatusIs(new RecordingStatus(trackId));
-        waitUntilGpsStatusIs(GpsStatusValue.GPS_ENABLED);
 
         // then
         assertTrue(service.isRecording());
@@ -271,25 +254,4 @@ public class TrackRecordingServiceStateMachineTest {
         assertNotNull(trackId);
         assertNull(newTrackId);
     }
-
-    private void waitUntilRecordingDataIsNotDefault() {
-        waitForValue(service.getRecordingDataObservable(),
-                recordingData -> !RecordingData.NOT_RECORDING.equals(recordingData),
-                WAIT_TIMEOUT,
-                "recording data to leave NOT_RECORDING");
-    }
-
-    private void waitUntilGpsStatusIs(GpsStatusValue expected) {
-        waitForValue(service.getGpsStatusObservable(),
-                expected::equals,
-                WAIT_TIMEOUT,
-                "gps status to become " + expected);
-    }
-
-    private void waitUntilRecordingStatusIs(RecordingStatus expected) {
-        waitForValue(service.getRecordingStatusObservable(),
-                expected::equals,
-                WAIT_TIMEOUT,
-                "recording status to become " + expected);
-    }
 }

src/androidTest/java/de/dennisguse/opentracks/services/TrackRecordingServiceUITest.java

@@ -2,12 +2,12 @@ package de.dennisguse.opentracks.services;
 
 import static org.junit.Assert.assertEquals;
 import static de.dennisguse.opentracks.services.TrackRecordingService.RECORDING_DATA_UPDATE_INTERVAL;
-import static de.dennisguse.opentracks.util.LiveDataTestUtils.waitForValue;
 
 import android.content.Context;
 import android.content.Intent;
 import android.os.Looper;
 
+import androidx.core.location.LocationManagerCompat;
 import androidx.test.core.app.ApplicationProvider;
 import androidx.test.ext.junit.runners.AndroidJUnit4;
 import androidx.test.rule.GrantPermissionRule;
@@ -30,7 +30,6 @@ import de.dennisguse.opentracks.data.models.Speed;
 import de.dennisguse.opentracks.data.models.TrackPoint;
 import de.dennisguse.opentracks.io.file.importer.ExportImportTest;
 import de.dennisguse.opentracks.io.file.importer.TrackPointAssert;
-import de.dennisguse.opentracks.sensors.GpsHandler;
 import de.dennisguse.opentracks.sensors.driver.GpsInternal;
 import de.dennisguse.opentracks.services.handlers.TrackPointCreator;
 
@@ -52,7 +51,7 @@ public class TrackRecordingServiceUITest {
     }
 
     @Test
-    public void getDataForUI_gps() throws TimeoutException {
+    public void getDataForUI_gps() throws TimeoutException, InterruptedException {
         TrackRecordingService service = ((TrackRecordingService.Binder) mServiceRule.bindService(new Intent(context, TrackRecordingService.class)))
                 .getService();
         RecordingData recordingData;
@@ -64,23 +63,34 @@ public class TrackRecordingServiceUITest {
 
         // when
         service.startNewTrack();
-        disconnectRealGps(trackPointCreator.getSensorManager().getGpsHandler());
-        trackPointCreator.getSensorManager().reset();
-        RecordingData initialRecordingData = waitUntilLatestTrackPointMatches(service, Instant.parse("2020-02-02T02:02:02Z"), false);
+        //We do not want the real GPS to interfere.
+        GpsInternal gpsInternal = (GpsInternal)trackPointCreator.getSensorManager().getGpsHandler().driver;
+        LocationManagerCompat.removeUpdates(gpsInternal.locationManager, gpsInternal.locationListenerCompat);
+        Thread.sleep(RECORDING_DATA_UPDATE_INTERVAL.toMillis());
 
         // then
-        TrackPoint initialTrackPoint = initialRecordingData.latestTrackPoint();
-        assertEquals(TrackPoint.Type.TRACKPOINT, initialTrackPoint.type());
-        assertEquals(Instant.parse("2020-02-02T02:02:02Z"), initialTrackPoint.getTime());
+        assertEquals(new TrackPoint(
+                        null,
+                        TrackPoint.Type.TRACKPOINT,
+                        Position.of( Instant.parse("2020-02-02T02:02:02Z")),
+                        null,
+                        null,
+                        null,
+                        null,
+                        null,
+                        null
+                ),
+                service.getRecordingDataObservable().getValue().latestTrackPoint());
 
 
         // when
         // In this step, the data is saved (and Aggregator.resetAggregated called), but data should still be shown in the UI.
         trackPointCreator.setClock("2020-02-02T02:02:03Z");
         ExportImportTest.sendLocation(trackPointCreator, "2020-02-02T02:02:03Z", 3.1234567, 14.0014567, 10, 13, 15, 1020.25, 1f);
-        recordingData = waitUntilLatestTrackPointMatches(service, Instant.parse("2020-02-02T02:02:03Z"), true);
 
         // then
+        Thread.sleep(RECORDING_DATA_UPDATE_INTERVAL.toMillis());
+        recordingData = service.getRecordingDataObservable().getValue();
         new TrackPointAssert().assertEquals(new TrackPoint(
                         null,
                         TrackPoint.Type.TRACKPOINT,
@@ -99,23 +109,4 @@ public class TrackRecordingServiceUITest {
                 ),
                 recordingData.latestTrackPoint());
     }
-
-    private void disconnectRealGps(GpsHandler gpsHandler) {
-        if (gpsHandler.driver != null) {
-            gpsHandler.driver.disconnect();
-        }
-        gpsHandler.onConnected(null, GpsInternal.LOCATION_PROVIDER);
-    }
-
-    private RecordingData waitUntilLatestTrackPointMatches(TrackRecordingService service, Instant expectedTime, boolean requiresLocation) {
-        return waitForValue(service.getRecordingDataObservable(),
-                recordingData -> {
-                    TrackPoint latestTrackPoint = recordingData != null ? recordingData.latestTrackPoint() : null;
-                    return latestTrackPoint != null
-                            && expectedTime.equals(latestTrackPoint.getTime())
-                            && (!requiresLocation || latestTrackPoint.position().hasLocation());
-                },
-                RECORDING_DATA_UPDATE_INTERVAL.multipliedBy(3),
-                "latest track point to reach " + expectedTime + (requiresLocation ? " with location" : ""));
-    }
-}
+}

src/androidTest/java/de/dennisguse/opentracks/services/announcement/VoiceAnnouncementUtilsTest.java

@@ -556,7 +556,6 @@ public class VoiceAnnouncementUtilsTest {
         PreferencesUtils.setVoiceAnnounceLapHeartRate(true);
 
         Pair<Track, Statistics> data = buildTrackWithTrackPoints();
-        int lapHeartRate = Math.round(data.second.avgHeartRate().getBPM());
 
         SensorStatistics sensorStatistics = new SensorStatistics(HeartRate.of(180f), HeartRate.of(180f), null, null, null, null);
 
@@ -574,7 +573,7 @@ public class VoiceAnnouncementUtilsTest {
         String announcement = VoiceAnnouncementUtils.createStatistics(context, data.first, dataSet, UnitSystem.METRIC, true, data.second, sensorStatistics).toString();
 
         // then
-        assertEquals("12:16 AM. Total distance 14.2 kilometers. 16 minutes 39 seconds. Average moving speed 51.2 kilometers per hour. Lap speed 51.2 kilometers per hour. Average heart rate 180 bpm. Lap heart rate " + lapHeartRate + " bpm.", announcement);
+        assertEquals("12:16 AM. Total distance 14.2 kilometers. 16 minutes 39 seconds. Average moving speed 51.2 kilometers per hour. Lap speed 51.2 kilometers per hour. Average heart rate 180 bpm. Lap heart rate 133 bpm.", announcement);
     }
 
     @Test
@@ -590,7 +589,6 @@ public class VoiceAnnouncementUtilsTest {
         PreferencesUtils.setVoiceAnnounceLapSpeedPace(false);
 
         Pair<Track, Statistics> data = buildTrackWithTrackPoints();
-        int lapHeartRate = Math.round(data.second.avgHeartRate().getBPM());
 
         SensorStatistics sensorStatistics = new SensorStatistics(HeartRate.of(180f), HeartRate.of(180f), null, null, null, null);
 
@@ -608,7 +606,7 @@ public class VoiceAnnouncementUtilsTest {
         String announcement = VoiceAnnouncementUtils.createStatistics(context, data.first, dataSet, UnitSystem.METRIC, true, data.second, sensorStatistics).toString();
 
         // then
-        assertEquals("12:16 AM.  Current heart rate 60 bpm. Average heart rate 180 bpm. Lap heart rate " + lapHeartRate + " bpm.", announcement);
+        assertEquals("12:16 AM.  Current heart rate 60 bpm. Average heart rate 180 bpm. Lap heart rate 133 bpm.", announcement);
     }
 
     @Test

src/androidTest/java/de/dennisguse/opentracks/settings/ImportExportSettingsIntentTest.java

@@ -1,51 +0,0 @@
-package de.dennisguse.opentracks.settings;
-
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
-
-import android.content.ComponentName;
-import android.content.Context;
-import android.content.Intent;
-import android.content.pm.ActivityInfo;
-import android.content.pm.PackageManager;
-import android.content.pm.ResolveInfo;
-
-import androidx.test.core.app.ApplicationProvider;
-import androidx.test.ext.junit.runners.AndroidJUnit4;
-
-import org.junit.Test;
-import org.junit.runner.RunWith;
-
-import de.dennisguse.opentracks.BuildConfig;
-import de.dennisguse.opentracks.R;
-
-@RunWith(AndroidJUnit4.class)
-public class ImportExportSettingsIntentTest {
-
-    private final Context context = ApplicationProvider.getApplicationContext();
-
-    @Test
-    public void applicationIdResource_matchesInstalledPackage() {
-        assertEquals(BuildConfig.APPLICATION_ID, context.getString(R.string.applicationId));
-        assertEquals(context.getPackageName(), context.getString(R.string.applicationId));
-    }
-
-    @Test
-    public void importExportPreferenceTargets_areResolvableInCurrentPackage() throws PackageManager.NameNotFoundException {
-        assertResolvable("de.dennisguse.opentracks.io.file.importer.DirectoryChooserActivity$ImportDirectoryChooserActivity");
-        assertResolvable("de.dennisguse.opentracks.io.file.importer.DirectoryChooserActivity$ExportDirectoryChooserActivity");
-        assertResolvable("de.dennisguse.opentracks.io.file.importer.DirectoryChooserActivity$ExportDirectoryChooserOneFileActivity");
-        assertResolvable("de.dennisguse.opentracks.io.file.importer.DirectoryChooserActivity$DefaultTrackExportDirectoryChooserActivity");
-    }
-
-    private void assertResolvable(String activityClassName) throws PackageManager.NameNotFoundException {
-        String applicationId = context.getString(R.string.applicationId);
-        ComponentName componentName = new ComponentName(applicationId, activityClassName);
-
-        ActivityInfo activityInfo = context.getPackageManager().getActivityInfo(componentName, 0);
-        assertEquals(applicationId, activityInfo.packageName);
-
-        ResolveInfo resolveInfo = context.getPackageManager().resolveActivity(new Intent().setComponent(componentName), 0);
-        assertNotNull(resolveInfo);
-    }
-}

src/androidTest/java/de/dennisguse/opentracks/ui/aggregatedStatistics/EspressoAggregatedFilterTest.java

@@ -1,41 +1,36 @@
 package de.dennisguse.opentracks.ui.aggregatedStatistics;
 
 import static androidx.test.espresso.Espresso.onView;
+import static androidx.test.espresso.action.ViewActions.click;
 import static androidx.test.espresso.assertion.ViewAssertions.matches;
-import static androidx.test.espresso.matcher.RootMatchers.isDialog;
 import static androidx.test.espresso.matcher.ViewMatchers.hasDescendant;
 import static androidx.test.espresso.matcher.ViewMatchers.isDisplayed;
 import static androidx.test.espresso.matcher.ViewMatchers.withId;
 import static androidx.test.espresso.matcher.ViewMatchers.withParent;
 import static androidx.test.espresso.matcher.ViewMatchers.withText;
-import static de.dennisguse.opentracks.util.EspressoUtils.performClick;
-import static de.dennisguse.opentracks.util.EspressoUtils.waitUntilDisplayed;
-import static de.dennisguse.opentracks.util.EspressoUtils.waitUntilRecyclerViewItemCount;
-import static de.dennisguse.opentracks.util.TestEnvironmentUtils.resetTrackRecordingServiceAndDeleteTracks;
-import static de.dennisguse.opentracks.util.TestEnvironmentUtils.stopTrackRecordingService;
 import static org.hamcrest.Matchers.allOf;
+import static de.dennisguse.opentracks.util.EspressoUtils.waitFor;
 
 import android.util.Pair;
-import android.view.View;
 
-import androidx.test.core.app.ActivityScenario;
+import androidx.test.core.app.ApplicationProvider;
+import androidx.test.espresso.matcher.ViewMatchers;
+import androidx.test.ext.junit.rules.ActivityScenarioRule;
 import androidx.test.ext.junit.runners.AndroidJUnit4;
 import androidx.test.filters.LargeTest;
 import androidx.test.rule.GrantPermissionRule;
 
 import org.hamcrest.core.IsInstanceOf;
-import org.hamcrest.Matcher;
-import org.junit.After;
 import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
-import java.time.Duration;
 import java.util.List;
 
 import de.dennisguse.opentracks.R;
 import de.dennisguse.opentracks.TestUtil;
+import de.dennisguse.opentracks.TrackListActivity;
 import de.dennisguse.opentracks.content.data.TestDataUtil;
 import de.dennisguse.opentracks.data.ContentProviderUtils;
 import de.dennisguse.opentracks.data.models.Track;
@@ -46,69 +41,53 @@ import de.dennisguse.opentracks.data.models.TrackPoint;
 @RunWith(AndroidJUnit4.class)
 public class EspressoAggregatedFilterTest {
 
-    private static final Duration UI_TIMEOUT = Duration.ofSeconds(10);
-
     private final String ACTIVITY_TYPE_LOCALIZED = "activityTypeLocalized";
 
+    @Rule
+    public ActivityScenarioRule<TrackListActivity> mActivityTestRule = new ActivityScenarioRule<>(TrackListActivity.class);
+
     @Rule
     public GrantPermissionRule mGrantPermissionRule = TestUtil.createGrantPermissionRule();
 
-    private ActivityScenario<AggregatedStatisticsActivity> scenario;
-
     @Before
     public void setUp() {
-        resetTrackRecordingServiceAndDeleteTracks();
-        ContentProviderUtils contentProviderUtils = new ContentProviderUtils(androidx.test.core.app.ApplicationProvider.getApplicationContext());
-
         Pair<Track, List<TrackPoint>> pair = TestDataUtil.createTrack(new Track.Id(System.currentTimeMillis()), 20);
         TrackBuilder trackBuilder = new TrackBuilder(pair.first);
         trackBuilder.setActivityTypeLocalized(ACTIVITY_TYPE_LOCALIZED);
-        TestDataUtil.insertTrackWithLocations(contentProviderUtils, trackBuilder.getTrack(), pair.second);
-
-        scenario = ActivityScenario.launch(AggregatedStatisticsActivity.class);
-    }
-
-    @After
-    public void tearDown() {
-        stopTrackRecordingService();
-        if (scenario != null) {
-            scenario.close();
-        }
+        TestDataUtil.insertTrackWithLocations(new ContentProviderUtils(ApplicationProvider.getApplicationContext()), trackBuilder.getTrack(), pair.second);
     }
 
     @Test
     public void espressoAggregatedFilterTest() {
-        waitUntilDisplayed(withId(R.id.bottom_app_bar), UI_TIMEOUT);
-        waitUntilDisplayed(withId(R.id.aggregated_statistics_filter), UI_TIMEOUT);
-        waitUntilRecyclerViewItemCount(withId(R.id.aggregated_stats_list), 1, UI_TIMEOUT);
-        waitUntilDisplayed(allOf(withId(R.id.aggregated_stats_type_label), withText(ACTIVITY_TYPE_LOCALIZED)), UI_TIMEOUT);
+        // open AggregatedStatisticsActivity through toolbar's menu item
+        onView(ViewMatchers.withId(R.id.bottom_app_bar))
+                .check(matches(isDisplayed()));
+        onView(withId(R.id.bottom_app_bar))
+                .check(matches(hasDescendant(withId(R.id.aggregated_stats_button))));
+        onView(withId(R.id.aggregated_stats_button))
+                .perform(click());
 
-        // open FilterDialogFragment through the current bottom app bar action item
+        // open FilterDialogFragment through toolbar's menu item
         onView(withId(R.id.bottom_app_bar))
                 .check(matches(isDisplayed()));
         onView(withId(R.id.bottom_app_bar))
                 .check(matches(hasDescendant(withId(R.id.aggregated_statistics_filter))));
         onView(withId(R.id.aggregated_statistics_filter))
-                .perform(performClick());
+                .perform(click());
 
         // check there's a checkbox with ACTIVITY_TYPE_LOCALIZED text
-        Matcher<View> activityTypeFilter = allOf(withId(R.id.filter_dialog_check_button), withText(ACTIVITY_TYPE_LOCALIZED),
+        onView(allOf(withId(R.id.filter_dialog_check_button), withText(ACTIVITY_TYPE_LOCALIZED),
                 withParent(allOf(withId(R.id.filter_items),
                         withParent(IsInstanceOf.instanceOf(android.view.ViewGroup.class)))),
-                isDisplayed());
-        onView(activityTypeFilter)
-                .inRoot(isDialog())
-                .check(matches(isDisplayed()));
+                isDisplayed()))
+                .perform(waitFor(2000));
 
         // check there's an edit text for "from date"
         onView(withId(R.id.filter_date_edit_text_from))
-                .inRoot(isDialog())
                 .check(matches(isDisplayed()));
 
         // check there's an edit text for "to date"
         onView(withId(R.id.filter_date_edit_text_to))
-                .inRoot(isDialog())
                 .check(matches(isDisplayed()));
     }
-
 }

src/androidTest/java/de/dennisguse/opentracks/ui/intervals/IntervalStatisticsUpdaterTest.java

@@ -35,10 +35,7 @@ public class IntervalStatisticsUpdaterTest {
         float distanceInterval = 1000f;
 
         // when and then
-        IntervalStatisticsComputation computation = computeIntervalStatistics(50, distanceInterval);
-        assertIntervalStatisticsComputation(computation, 50, distanceInterval);
-        assertEquals((int) Math.ceil(computation.track.statistics().totalDistance().toM() / distanceInterval), computation.intervalList.size());
-        assertEquals(computation.track.statistics().totalDistance().toM(), computation.totalDistance.toM(), 0.01);
+        whenAndThen(50, distanceInterval);
     }
 
     /**
@@ -52,10 +49,7 @@ public class IntervalStatisticsUpdaterTest {
         float distanceInterval = 1000f;
 
         // when and then
-        IntervalStatisticsComputation computation = computeIntervalStatistics(200, distanceInterval);
-        assertIntervalStatisticsComputation(computation, 200, distanceInterval);
-        assertEquals((int) Math.ceil(computation.track.statistics().totalDistance().toM() / distanceInterval), computation.intervalList.size());
-        assertEquals(computation.track.statistics().totalDistance().toM(), computation.totalDistance.toM(), 0.01);
+        whenAndThen(200, distanceInterval);
     }
 
     /**
@@ -69,10 +63,7 @@ public class IntervalStatisticsUpdaterTest {
         float distanceInterval = 3000f;
 
         // when and then
-        IntervalStatisticsComputation computation = computeIntervalStatistics(3000, distanceInterval);
-        assertIntervalStatisticsComputation(computation, 3000, distanceInterval);
-        assertEquals((int) Math.ceil(computation.track.statistics().totalDistance().toM() / distanceInterval), computation.intervalList.size());
-        assertEquals(computation.track.statistics().totalDistance().toM(), computation.totalDistance.toM(), 0.01);
+        whenAndThen(3000, distanceInterval);
     }
 
     /**
@@ -86,10 +77,7 @@ public class IntervalStatisticsUpdaterTest {
         float distanceInterval = 3000f;
 
         // when and then
-        IntervalStatisticsComputation computation = computeIntervalStatistics(1000, distanceInterval);
-        assertIntervalStatisticsComputation(computation, 1000, distanceInterval);
-        assertEquals((int) Math.ceil(computation.track.statistics().totalDistance().toM() / distanceInterval), computation.intervalList.size());
-        assertEquals(computation.track.statistics().totalDistance().toM(), computation.totalDistance.toM(), 0.01);
+        whenAndThen(1000, distanceInterval);
     }
 
     /**
@@ -103,10 +91,7 @@ public class IntervalStatisticsUpdaterTest {
         float distanceInterval = 1000f;
 
         // when and then
-        IntervalStatisticsComputation computation = computeIntervalStatistics(10000, distanceInterval);
-        assertIntervalStatisticsComputation(computation, 10000, distanceInterval);
-        assertEquals((int) Math.ceil(computation.track.statistics().totalDistance().toM() / distanceInterval), computation.intervalList.size());
-        assertEquals(computation.track.statistics().totalDistance().toM(), computation.totalDistance.toM(), 0.01);
+        whenAndThen(10000, distanceInterval);
     }
 
     @Test
@@ -137,18 +122,15 @@ public class IntervalStatisticsUpdaterTest {
         Pair<Track, List<TrackPoint>> trackWithStats = new Pair<>(dummyTrack, trackPoints);
 
         // when and then
-        IntervalStatisticsComputation computation = computeIntervalStatistics(trackWithStats.first, trackWithStats.second, distanceInterval);
-        assertIntervalStatisticsComputation(computation, numberOfPoints, distanceInterval);
-        assertEquals((int) Math.ceil(computation.track.statistics().totalDistance().toM() / distanceInterval), computation.intervalList.size());
-        assertEquals(computation.track.statistics().totalDistance().toM(), computation.totalDistance.toM(), 0.01);
+        whenAndThen(trackWithStats.first, trackWithStats.second, numberOfPoints, distanceInterval);
     }
 
-    private IntervalStatisticsComputation computeIntervalStatistics(int numberOfPoints, float distanceInterval) {
+    private void whenAndThen(int numberOfPoints, float distanceInterval) {
         Pair<Track, List<TrackPoint>> trackWithStats = buildTrackWithTrackPoints(numberOfPoints);
-        return computeIntervalStatistics(trackWithStats.first, trackWithStats.second, distanceInterval);
+        whenAndThen(trackWithStats.first, trackWithStats.second, numberOfPoints, distanceInterval);
     }
 
-    private IntervalStatisticsComputation computeIntervalStatistics(Track track, List<TrackPoint> trackPoints, float distanceInterval) {
+    private void whenAndThen(Track track, List<TrackPoint> trackPoints, int numberOfPoints, float distanceInterval) {
         IntervalStatisticsUpdater intervalStatistics = new IntervalStatisticsUpdater(Distance.of(distanceInterval));
 
         intervalStatistics.addTrackPoints(trackPoints.iterator());
@@ -175,27 +157,23 @@ public class IntervalStatisticsUpdaterTest {
             }
         }
 
-        return new IntervalStatisticsComputation(track, intervalList, totalDistance, totalTime, totalGain, totalLoss);
-    }
-
-    private void assertIntervalStatisticsComputation(IntervalStatisticsComputation computation, int numberOfPoints, float distanceInterval) {
-        assertEquals(computation.track.statistics().totalDuration().toSeconds(), computation.totalTime, 0.01);
-        assertEquals(computation.track.statistics().totalDistance().toM(), computation.totalDistance.toM(), 0.01);
-        assertEquals(computation.intervalList.size(), (int) Math.ceil(computation.track.statistics().totalDistance().toM() / distanceInterval));
-        if (computation.totalGain != null && computation.totalLoss != null) {
-            assertEquals(computation.totalGain, numberOfPoints * TestDataUtil.ALTITUDE_GAIN, 0.1);
-            assertEquals(computation.totalLoss, numberOfPoints * TestDataUtil.ALTITUDE_LOSS, 0.1);
+        // then
+        assertEquals(track.statistics().totalDuration().toSeconds(), totalTime, 0.01);
+        assertEquals(track.statistics().totalDistance().toM(), totalDistance.toM(), 0.01);
+        assertEquals(intervalList.size(), (int) Math.ceil(track.statistics().totalDistance().toM() / distanceInterval));
+        if (totalGain != null && totalLoss != null) {
+            assertEquals(totalGain, numberOfPoints * TestDataUtil.ALTITUDE_GAIN, 0.1);
+            assertEquals(totalLoss, numberOfPoints * TestDataUtil.ALTITUDE_LOSS, 0.1);
 
         } else {
-            assertTrue(computation.intervalList.stream().noneMatch(i -> i.altitudeGainLoss() != null));
+            assertTrue(intervalStatistics.getIntervalList().stream().noneMatch(i -> i.altitudeGainLoss() != null));
         }
 
-        Distance remainingDistance = computation.totalDistance;
-        for (int i = 0; i < computation.intervalList.size() - 1; i++) {
-            assertEquals(computation.intervalList.get(i).totalDistance().toM(), distanceInterval, 0.001);
-            remainingDistance = remainingDistance.minus(computation.intervalList.get(i).totalDistance());
+        for (int i = 0; i < intervalList.size() - 1; i++) {
+            assertEquals(intervalList.get(i).totalDistance().toM(), distanceInterval, 0.001);
+            totalDistance = totalDistance.minus(intervalList.get(i).totalDistance());
         }
-        assertEquals(computation.intervalList.get(computation.intervalList.size() - 1).totalDistance().toM(), remainingDistance.toM(), 0.01);
+        assertEquals(intervalList.get(intervalList.size() - 1).totalDistance().toM(), totalDistance.toM(), 0.01);
     }
 
     private static Pair<Track, List<TrackPoint>> buildTrackWithTrackPoints(int numberOfPoints) {
@@ -217,27 +195,4 @@ public class IntervalStatisticsUpdaterTest {
 
         return new Pair<>(track, trackPoints);
     }
-
-    private static final class IntervalStatisticsComputation {
-        private final Track track;
-        private final List<Statistics> intervalList;
-        private final Distance totalDistance;
-        private final float totalTime;
-        private final Float totalGain;
-        private final Float totalLoss;
-
-        private IntervalStatisticsComputation(Track track,
-                                              List<Statistics> intervalList,
-                                              Distance totalDistance,
-                                              float totalTime,
-                                              Float totalGain,
-                                              Float totalLoss) {
-            this.track = track;
-            this.intervalList = intervalList;
-            this.totalDistance = totalDistance;
-            this.totalTime = totalTime;
-            this.totalGain = totalGain;
-            this.totalLoss = totalLoss;
-        }
-    }
-}
+}

src/androidTest/java/de/dennisguse/opentracks/util/ActivityTestUtils.java

@@ -1,106 +0,0 @@
-package de.dennisguse.opentracks.util;
-
-import static org.junit.Assert.fail;
-
-import android.app.Activity;
-import android.app.Application;
-import android.os.Bundle;
-
-import androidx.test.core.app.ApplicationProvider;
-import androidx.test.platform.app.InstrumentationRegistry;
-import androidx.test.runner.lifecycle.ActivityLifecycleMonitorRegistry;
-import androidx.test.runner.lifecycle.Stage;
-
-import java.time.Duration;
-import java.util.concurrent.CountDownLatch;
-import java.util.concurrent.TimeUnit;
-import java.util.concurrent.atomic.AtomicReference;
-
-public final class ActivityTestUtils {
-
-    private ActivityTestUtils() {
-    }
-
-    public static <T extends Activity> T waitForResumedActivity(Class<T> activityClass, Duration timeout) {
-        T resumedActivity = getResumedActivity(activityClass);
-        if (resumedActivity != null) {
-            return resumedActivity;
-        }
-
-        Application application = ApplicationProvider.getApplicationContext();
-        CountDownLatch latch = new CountDownLatch(1);
-        AtomicReference<T> resumedActivityRef = new AtomicReference<>();
-
-        Application.ActivityLifecycleCallbacks callbacks = new Application.ActivityLifecycleCallbacks() {
-            @Override
-            public void onActivityResumed(Activity activity) {
-                if (activityClass.isInstance(activity)) {
-                    resumedActivityRef.set(activityClass.cast(activity));
-                    latch.countDown();
-                }
-            }
-
-            @Override
-            public void onActivityCreated(Activity activity, Bundle savedInstanceState) {
-            }
-
-            @Override
-            public void onActivityStarted(Activity activity) {
-            }
-
-            @Override
-            public void onActivityPaused(Activity activity) {
-            }
-
-            @Override
-            public void onActivityStopped(Activity activity) {
-            }
-
-            @Override
-            public void onActivitySaveInstanceState(Activity activity, Bundle outState) {
-            }
-
-            @Override
-            public void onActivityDestroyed(Activity activity) {
-            }
-        };
-
-        InstrumentationRegistry.getInstrumentation().runOnMainSync(() -> {
-            application.registerActivityLifecycleCallbacks(callbacks);
-
-            T currentResumedActivity = findResumedActivity(activityClass);
-            if (currentResumedActivity != null) {
-                resumedActivityRef.set(currentResumedActivity);
-                latch.countDown();
-            }
-        });
-
-        try {
-            if (!latch.await(timeout.toMillis(), TimeUnit.MILLISECONDS)) {
-                fail("Timed out waiting for resumed activity " + activityClass.getSimpleName());
-            }
-        } catch (InterruptedException e) {
-            Thread.currentThread().interrupt();
-            fail("Interrupted while waiting for resumed activity " + activityClass.getSimpleName());
-        } finally {
-            InstrumentationRegistry.getInstrumentation().runOnMainSync(() -> application.unregisterActivityLifecycleCallbacks(callbacks));
-        }
-
-        return resumedActivityRef.get();
-    }
-
-    private static <T extends Activity> T getResumedActivity(Class<T> activityClass) {
-        AtomicReference<T> resumedActivity = new AtomicReference<>();
-        InstrumentationRegistry.getInstrumentation().runOnMainSync(() -> resumedActivity.set(findResumedActivity(activityClass)));
-        return resumedActivity.get();
-    }
-
-    private static <T extends Activity> T findResumedActivity(Class<T> activityClass) {
-        for (Activity activity : ActivityLifecycleMonitorRegistry.getInstance().getActivitiesInStage(Stage.RESUMED)) {
-            if (activityClass.isInstance(activity)) {
-                return activityClass.cast(activity);
-            }
-        }
-        return null;
-    }
-}

src/androidTest/java/de/dennisguse/opentracks/util/EspressoUtils.java

@@ -1,25 +1,14 @@
 package de.dennisguse.opentracks.util;
 
-import static org.hamcrest.Matchers.allOf;
 import static androidx.test.espresso.matcher.ViewMatchers.isDisplayed;
-import static androidx.test.espresso.matcher.ViewMatchers.isAssignableFrom;
 
-import android.app.Activity;
-import android.os.SystemClock;
 import android.view.View;
+import android.view.ViewGroup;
 import android.view.ViewParent;
-import android.widget.AdapterView;
+import android.widget.ListView;
 
-import androidx.recyclerview.widget.RecyclerView;
-import androidx.test.espresso.PerformException;
 import androidx.test.espresso.UiController;
 import androidx.test.espresso.ViewAction;
-import androidx.test.platform.app.InstrumentationRegistry;
-import androidx.test.runner.lifecycle.ActivityLifecycleMonitorRegistry;
-import androidx.test.runner.lifecycle.Stage;
-import androidx.test.espresso.util.HumanReadables;
-import androidx.test.espresso.util.TreeIterables;
-import androidx.viewpager2.widget.ViewPager2;
 
 import com.google.android.material.tabs.TabLayout;
 
@@ -27,114 +16,61 @@ import org.hamcrest.Description;
 import org.hamcrest.Matcher;
 import org.hamcrest.TypeSafeMatcher;
 
-import java.time.Duration;
-import java.util.concurrent.atomic.AtomicBoolean;
-import java.util.function.Predicate;
-
 public class EspressoUtils {
 
-    private static final long VIEW_POLLING_INTERVAL_MS = 50;
+    public static Matcher<View> childAtPosition(
+            final Matcher<View> parentMatcher, final int position) {
 
-    public static Matcher<View> withRecyclerViewItemCount(final int count) {
         return new TypeSafeMatcher<>() {
             @Override
-            protected boolean matchesSafely(View view) {
-                if (!(view instanceof RecyclerView recyclerView)) {
-                    return false;
-                }
-
-                RecyclerView.Adapter<?> adapter = recyclerView.getAdapter();
-                return adapter != null && adapter.getItemCount() == count;
+            public void describeTo(Description description) {
+                description.appendText("Child at position " + position + " in parent ");
+                parentMatcher.describeTo(description);
             }
 
             @Override
-            public void describeTo(Description description) {
-                description.appendText("RecyclerView should have " + count + " items");
+            public boolean matchesSafely(View view) {
+                ViewParent parent = view.getParent();
+                return parent instanceof ViewGroup && parentMatcher.matches(parent)
+                        && view.equals(((ViewGroup) parent).getChildAt(position));
             }
         };
     }
 
-    public static Matcher<View> withSelectedTab(final int index) {
+    public static Matcher<View> withListSize (final int size) {
         return new TypeSafeMatcher<>() {
             @Override
-            protected boolean matchesSafely(View view) {
-                return view instanceof TabLayout tabLayout
-                        && tabLayout.getSelectedTabPosition() == index;
+            public boolean matchesSafely(final View view) {
+                return ((ListView) view).getCount() == size;
             }
 
             @Override
-            public void describeTo(Description description) {
-                description.appendText("TabLayout should have selected tab " + index);
+            public void describeTo(final Description description) {
+                description.appendText("ListView should have " + size + " items");
             }
         };
     }
 
-    public static Matcher<View> withViewPagerCurrentItem(final int index) {
-        return new TypeSafeMatcher<>() {
+    public static ViewAction waitFor(final long duration_ms) {
+        return new ViewAction() {
+
             @Override
-            protected boolean matchesSafely(View view) {
-                return view instanceof ViewPager2 viewPager2
-                        && viewPager2.getCurrentItem() == index
-                        && viewPager2.getScrollState() == ViewPager2.SCROLL_STATE_IDLE;
+            public String getDescription() {
+                return "Wait for milliseconds.";
             }
 
             @Override
-            public void describeTo(Description description) {
-                description.appendText("ViewPager2 should be idle on item " + index);
+            public Matcher<View> getConstraints() {
+                return isDisplayed();
+            }
+
+            @Override
+            public void perform(UiController uiController, final View view) {
+                uiController.loopMainThreadForAtLeast(duration_ms);
             }
         };
     }
 
-    public static void waitForResumedView(final Matcher<View> viewMatcher, final Duration timeout) {
-        waitForResumedViewCondition(viewMatcher, ignored -> true, "view to match " + viewMatcher, timeout);
-    }
-
-    public static void waitUntilDisplayed(final Matcher<View> viewMatcher, final Duration timeout) {
-        waitForResumedView(allOf(viewMatcher, isDisplayed()), timeout);
-    }
-
-    public static void waitUntilRecyclerViewItemCount(final Matcher<View> viewMatcher, final int expectedCount, final Duration timeout) {
-        waitForResumedViewCondition(
-                allOf(viewMatcher, isDisplayed()),
-                view -> withRecyclerViewItemCount(expectedCount).matches(view),
-                "RecyclerView item count to be " + expectedCount,
-                timeout);
-    }
-
-    public static void waitForResumedViewCondition(final Matcher<View> viewMatcher,
-                                                   final Predicate<View> condition,
-                                                   final String conditionDescription,
-                                                   final Duration timeout) {
-        long deadline = SystemClock.uptimeMillis() + timeout.toMillis();
-
-        do {
-            InstrumentationRegistry.getInstrumentation().waitForIdleSync();
-
-            AtomicBoolean matched = new AtomicBoolean(false);
-            InstrumentationRegistry.getInstrumentation().runOnMainSync(() -> {
-                for (Activity activity : ActivityLifecycleMonitorRegistry.getInstance().getActivitiesInStage(Stage.RESUMED)) {
-                    View decorView = activity.getWindow() != null ? activity.getWindow().getDecorView() : null;
-                    if (decorView == null) {
-                        continue;
-                    }
-
-                    for (View child : TreeIterables.breadthFirstViewTraversal(decorView)) {
-                        if (viewMatcher.matches(child) && condition.test(child)) {
-                            matched.set(true);
-                            return;
-                        }
-                    }
-                }
-            });
-
-            if (matched.get()) {
-                return;
-            }
-        } while (SystemClock.uptimeMillis() < deadline);
-
-        throw new AssertionError("Timed out waiting for " + conditionDescription);
-    }
-
     public static ViewAction selectTabAtIndex(final int index) {
         return new ViewAction() {
             @Override
@@ -155,135 +91,4 @@ public class EspressoUtils {
         };
     }
 
-    public static ViewAction performClick() {
-        return new ViewAction() {
-            @Override
-            public String getDescription() {
-                return "invoke View.performClick()";
-            }
-
-            @Override
-            public Matcher<View> getConstraints() {
-                return isDisplayed();
-            }
-
-            @Override
-            public void perform(UiController uiController, View view) {
-                if (!view.performClick()) {
-                    throw new PerformException.Builder()
-                            .withActionDescription(getDescription())
-                            .withViewDescription(HumanReadables.describe(view))
-                            .build();
-                }
-                uiController.loopMainThreadUntilIdle();
-            }
-        };
-    }
-
-    public static ViewAction performClickOnAncestor() {
-        return new ViewAction() {
-            @Override
-            public String getDescription() {
-                return "invoke performClick() on the matched view or its ancestor";
-            }
-
-            @Override
-            public Matcher<View> getConstraints() {
-                return isAssignableFrom(View.class);
-            }
-
-            @Override
-            public void perform(UiController uiController, View view) {
-                View current = view;
-                while (current != null) {
-                    if (current.performClick()) {
-                        uiController.loopMainThreadUntilIdle();
-                        return;
-                    }
-
-                    ViewParent parent = current.getParent();
-                    current = parent instanceof View ? (View) parent : null;
-                }
-
-                current = view;
-                while (current != null) {
-                    ViewParent parent = current.getParent();
-                    if (parent instanceof AdapterView<?> adapterView) {
-                        int position = adapterView.getPositionForView(current);
-                        if (position != AdapterView.INVALID_POSITION
-                                && adapterView.performItemClick(current, position, adapterView.getAdapter().getItemId(position))) {
-                            uiController.loopMainThreadUntilIdle();
-                            return;
-                        }
-                    }
-
-                    current = parent instanceof View ? (View) parent : null;
-                }
-
-                throw new PerformException.Builder()
-                        .withActionDescription(getDescription())
-                        .withViewDescription(HumanReadables.describe(view))
-                        .build();
-            }
-        };
-    }
-
-    public static ViewAction performLongClick() {
-        return new ViewAction() {
-            @Override
-            public String getDescription() {
-                return "invoke View.performLongClick()";
-            }
-
-            @Override
-            public Matcher<View> getConstraints() {
-                return isDisplayed();
-            }
-
-            @Override
-            public void perform(UiController uiController, View view) {
-                if (!view.performLongClick()) {
-                    throw new PerformException.Builder()
-                            .withActionDescription(getDescription())
-                            .withViewDescription(HumanReadables.describe(view))
-                            .build();
-                }
-                uiController.loopMainThreadUntilIdle();
-            }
-        };
-    }
-
-    public static ViewAction performLongClickOnAncestor() {
-        return new ViewAction() {
-            @Override
-            public String getDescription() {
-                return "invoke performLongClick() on the matched view or its ancestor";
-            }
-
-            @Override
-            public Matcher<View> getConstraints() {
-                return isDisplayed();
-            }
-
-            @Override
-            public void perform(UiController uiController, View view) {
-                View current = view;
-                while (current != null) {
-                    if (current.performLongClick()) {
-                        uiController.loopMainThreadUntilIdle();
-                        return;
-                    }
-
-                    ViewParent parent = current.getParent();
-                    current = parent instanceof View ? (View) parent : null;
-                }
-
-                throw new PerformException.Builder()
-                        .withActionDescription(getDescription())
-                        .withViewDescription(HumanReadables.describe(view))
-                        .build();
-            }
-        };
-    }
-
 }

src/androidTest/java/de/dennisguse/opentracks/util/LiveDataTestUtils.java

@@ -1,57 +0,0 @@
-package de.dennisguse.opentracks.util;
-
-import static org.junit.Assert.fail;
-
-import androidx.lifecycle.LiveData;
-import androidx.lifecycle.Observer;
-import androidx.test.platform.app.InstrumentationRegistry;
-
-import java.time.Duration;
-import java.util.concurrent.CountDownLatch;
-import java.util.concurrent.TimeUnit;
-import java.util.concurrent.atomic.AtomicReference;
-import java.util.function.Predicate;
-
-public final class LiveDataTestUtils {
-
-    private LiveDataTestUtils() {
-    }
-
-    public static <T> T waitForValue(LiveData<T> liveData,
-                                     Predicate<T> predicate,
-                                     Duration timeout,
-                                     String description) {
-        AtomicReference<T> lastValue = new AtomicReference<>(liveData.getValue());
-        CountDownLatch latch = new CountDownLatch(1);
-
-        Observer<T> observer = value -> {
-            lastValue.set(value);
-            if (predicate.test(value)) {
-                latch.countDown();
-            }
-        };
-
-        InstrumentationRegistry.getInstrumentation().runOnMainSync(() -> {
-            liveData.observeForever(observer);
-
-            T currentValue = liveData.getValue();
-            lastValue.set(currentValue);
-            if (predicate.test(currentValue)) {
-                latch.countDown();
-            }
-        });
-
-        try {
-            if (!latch.await(timeout.toMillis(), TimeUnit.MILLISECONDS)) {
-                fail("Timed out waiting for " + description + ". Last value: " + lastValue.get());
-            }
-        } catch (InterruptedException e) {
-            Thread.currentThread().interrupt();
-            fail("Interrupted while waiting for " + description);
-        } finally {
-            InstrumentationRegistry.getInstrumentation().runOnMainSync(() -> liveData.removeObserver(observer));
-        }
-
-        return lastValue.get();
-    }
-}

src/androidTest/java/de/dennisguse/opentracks/util/TestEnvironmentUtils.java

@@ -1,30 +0,0 @@
-package de.dennisguse.opentracks.util;
-
-import android.content.Context;
-import android.content.Intent;
-
-import androidx.test.core.app.ApplicationProvider;
-
-import de.dennisguse.opentracks.data.ContentProviderUtils;
-import de.dennisguse.opentracks.services.TrackRecordingService;
-
-public final class TestEnvironmentUtils {
-
-    private TestEnvironmentUtils() {
-    }
-
-    public static void stopTrackRecordingService() {
-        Context context = ApplicationProvider.getApplicationContext();
-        context.stopService(new Intent(context, TrackRecordingService.class));
-    }
-
-    public static void deleteAllTracks() {
-        Context context = ApplicationProvider.getApplicationContext();
-        new ContentProviderUtils(context).deleteAllTracks(context);
-    }
-
-    public static void resetTrackRecordingServiceAndDeleteTracks() {
-        stopTrackRecordingService();
-        deleteAllTracks();
-    }
-}

src/androidTest/java/de/dennisguse/opentracks/util/TrackRecordingServiceTestUtils.java

@@ -1,50 +0,0 @@
-package de.dennisguse.opentracks.util;
-
-import static org.junit.Assert.fail;
-
-import android.content.Context;
-
-import androidx.test.core.app.ApplicationProvider;
-import androidx.test.platform.app.InstrumentationRegistry;
-
-import java.time.Duration;
-import java.util.concurrent.CountDownLatch;
-import java.util.concurrent.TimeUnit;
-import java.util.concurrent.atomic.AtomicReference;
-
-import de.dennisguse.opentracks.services.TrackRecordingService;
-import de.dennisguse.opentracks.services.TrackRecordingServiceConnection;
-
-public final class TrackRecordingServiceTestUtils {
-
-    private TrackRecordingServiceTestUtils() {
-    }
-
-    public static void waitForRecordingState(boolean isRecording, Duration timeout) {
-        Context context = ApplicationProvider.getApplicationContext();
-        CountDownLatch connectedLatch = new CountDownLatch(1);
-        AtomicReference<TrackRecordingService> serviceRef = new AtomicReference<>();
-        TrackRecordingServiceConnection connection = new TrackRecordingServiceConnection((service, self) -> {
-            serviceRef.set(service);
-            connectedLatch.countDown();
-        });
-
-        InstrumentationRegistry.getInstrumentation().runOnMainSync(() -> connection.bind(context));
-
-        try {
-            if (!connectedLatch.await(timeout.toMillis(), TimeUnit.MILLISECONDS)) {
-                fail("Timed out waiting to bind TrackRecordingService");
-            }
-
-            LiveDataTestUtils.waitForValue(serviceRef.get().getRecordingStatusObservable(),
-                    status -> status != null && status.isRecording() == isRecording,
-                    timeout,
-                    "recording state to become " + isRecording);
-        } catch (InterruptedException e) {
-            Thread.currentThread().interrupt();
-            fail("Interrupted while waiting for recording state " + isRecording);
-        } finally {
-            InstrumentationRegistry.getInstrumentation().runOnMainSync(() -> connection.unbind(context));
-        }
-    }
-}

src/androidTest/java/de/dennisguse/opentracks/util/TrackUiTestUtils.java

@@ -1,70 +0,0 @@
-package de.dennisguse.opentracks.util;
-
-import static androidx.test.espresso.Espresso.onView;
-import static androidx.test.espresso.action.ViewActions.closeSoftKeyboard;
-import static androidx.test.espresso.action.ViewActions.replaceText;
-import static androidx.test.espresso.action.ViewActions.scrollTo;
-import static androidx.test.espresso.matcher.ViewMatchers.isClickable;
-import static androidx.test.espresso.matcher.ViewMatchers.withId;
-import static de.dennisguse.opentracks.util.ActivityTestUtils.waitForResumedActivity;
-import static de.dennisguse.opentracks.util.EspressoUtils.performClick;
-import static de.dennisguse.opentracks.util.EspressoUtils.performLongClick;
-import static de.dennisguse.opentracks.util.EspressoUtils.waitUntilDisplayed;
-import static de.dennisguse.opentracks.util.TrackRecordingServiceTestUtils.waitForRecordingState;
-import static org.hamcrest.Matchers.allOf;
-
-import androidx.annotation.IdRes;
-
-import java.time.Duration;
-
-import de.dennisguse.opentracks.R;
-import de.dennisguse.opentracks.TrackListActivity;
-import de.dennisguse.opentracks.TrackRecordingActivity;
-import de.dennisguse.opentracks.TrackStoppedActivity;
-
-public final class TrackUiTestUtils {
-
-    private TrackUiTestUtils() {
-    }
-
-    public static void startRecordingFromTrackList(Duration timeout) {
-        onView(withId(R.id.track_list_fab_action))
-                .perform(performClick());
-        waitForResumedActivity(TrackRecordingActivity.class, timeout);
-        waitForRecordingState(true, timeout);
-        waitUntilDisplayed(withId(R.id.track_recording_fab_action), timeout);
-    }
-
-    public static void stopRecordingToTrackStopped(Duration timeout, @IdRes int... expectedVisibleViewIds) {
-        onView(withId(R.id.track_recording_fab_action))
-                .perform(performLongClick());
-        waitForResumedActivity(TrackStoppedActivity.class, timeout);
-        waitUntilDisplayed(withId(R.id.track_edit_name), timeout);
-        for (int viewId : expectedVisibleViewIds) {
-            waitUntilDisplayed(withId(viewId), timeout);
-        }
-        onView(withId(R.id.track_edit_name))
-                .perform(closeSoftKeyboard());
-    }
-
-    public static void resumeStoppedTrack(Duration timeout) {
-        onView(allOf(withId(R.id.resume_button), isClickable()))
-                .perform(performClick());
-        waitForResumedActivity(TrackRecordingActivity.class, timeout);
-        waitForRecordingState(true, timeout);
-        waitUntilDisplayed(withId(R.id.track_recording_fab_action), timeout);
-    }
-
-    public static void finishStoppedTrack(Duration timeout) {
-        onView(withId(R.id.finish_button))
-                .perform(performClick());
-        waitForResumedActivity(TrackListActivity.class, timeout);
-        waitUntilDisplayed(withId(R.id.track_list), timeout);
-    }
-
-    public static void renameStoppedTrack(String name, Duration timeout) {
-        waitUntilDisplayed(withId(R.id.track_edit_name), timeout);
-        onView(withId(R.id.track_edit_name))
-                .perform(scrollTo(), replaceText(name), closeSoftKeyboard());
-    }
-}

src/androidTest/res/raw/csv_export.csv

@@ -4,10 +4,10 @@
 "2020-02-02T03:02:04+01:00","TRACKPOINT",,,,,,54,1,1,10,66,3,50
 "2020-02-02T03:02:15+01:00","TRACKPOINT",,,,,,,,,,68,3,50
 "2020-02-02T03:02:17+01:00","TRACKPOINT",3.123456,14.001456,1020.2,10,,18,0,0,2,69,3,50
-"2020-02-02T03:02:18+01:00","SEGMENT_END_MANUAL",3.123456,14.001456,1020.2,10,,18,0,0,0,69,3,50
+"2020-02-02T03:02:18+01:00","SEGMENT_END_MANUAL",,,,,,,,,,,,
 "2020-02-02T03:03:20+01:00","SEGMENT_START_MANUAL",,,,,,,,,,,,
 "2020-02-02T03:03:21+01:00","TRACKPOINT",3.123456,14.002456,999.1,10,,54,0,0,,,,
 "2020-02-02T03:03:22+01:00","SEGMENT_START_AUTOMATIC",3.123456,16,999.1,10,,54,0,0,,,,
 "2020-02-02T03:03:30+01:00","IDLE",,,,,,,0,0,,,,
 "2020-02-02T03:03:50+01:00","TRACKPOINT",3.123456,16.001,999.1,10,,54,0,0,,,,
-"2020-02-02T03:04:00+01:00","SEGMENT_END_MANUAL",,,,,,,0,0,,,,
+"2020-02-02T03:04:00+01:00","SEGMENT_END_MANUAL",,,,,,,,,,,,

src/debug/res/values/strings.xml

@@ -14,5 +14,5 @@ See the License for the specific language governing permissions and
 limitations under the License.
 -->
 <resources>
-    <string name="launcher_name" translatable="false">OpenTracks (Debug)</string>
+    <string name="app_name" translatable="false">OpenTracks (Debug)</string>
 </resources>

src/main/AndroidManifest.xml

@@ -78,7 +78,7 @@ limitations under the License.
         android:hardwareAccelerated="true"
         android:hasFragileUserData="false"
         android:icon="@drawable/ic_launcher"
-        android:label="@string/launcher_name"
+        android:label="@string/app_name"
         android:supportsRtl="true"
         android:theme="@style/DayNightDynamicTheme"> <!-- Default for AppCompatActivities -->
 

src/main/java/de/dennisguse/opentracks/data/ContentProviderUtils.java

@@ -36,6 +36,7 @@ import java.util.Collections;
 import java.util.List;
 import java.util.UUID;
 
+import de.dennisguse.opentracks.BuildConfig;
 import de.dennisguse.opentracks.data.models.ActivityType;
 import de.dennisguse.opentracks.data.models.Altitude;
 import de.dennisguse.opentracks.data.models.AltitudeExtremities;
@@ -68,10 +69,23 @@ public class ContentProviderUtils {
 
     private static final String TAG = ContentProviderUtils.class.getSimpleName();
 
+    //TODO Move to CustomContentProvider
+    // The authority (the first part of the URI) for the app's content provider.
+    static final String AUTHORITY_PACKAGE = BuildConfig.APPLICATION_ID + ".content";
+
+    //TODO Move to CustomContentProvider
+    // The base URI for the app's content provider.
+    public static final String CONTENT_BASE_URI = "content://" + AUTHORITY_PACKAGE;
+
     private static final String ID_SEPARATOR = ",";
 
     private final ContentResolver contentResolver;
 
+    //TODO Check if this can be used in more than one place. If not remove.
+    public interface ContentProviderSelectionInterface {
+        SelectionData buildSelection();
+    }
+
     public ContentProviderUtils(Context context) {
         contentResolver = context.getContentResolver();
     }
@@ -741,7 +755,7 @@ public class ContentProviderUtils {
     }
 
     @NonNull
-    public List<AggregatedStatistic> getAggregatedStatisticsForTracks(TrackSelection selection) {
+    public List<AggregatedStatistic> getAggregatedStatisticsForTracks(ContentProviderSelectionInterface selection) {
         SelectionData data = selection.buildSelection();
         try (Cursor cursor = contentResolver.query(TracksColumns.CONTENT_URI_AGGREGATED_STATISTICS, null, data.selection(), data.getSelectionArgs(), null)) {
             ArrayList<AggregatedStatistic> aggregatedStatistics = new ArrayList<>(cursor.getCount());

src/main/java/de/dennisguse/opentracks/data/CustomContentProvider.java

@@ -34,7 +34,6 @@ import androidx.annotation.NonNull;
 
 import java.util.Arrays;
 
-import de.dennisguse.opentracks.BuildConfig;
 import de.dennisguse.opentracks.data.models.TrackPoint;
 import de.dennisguse.opentracks.data.tables.MarkerColumns;
 import de.dennisguse.opentracks.data.tables.TrackPointsColumns;
@@ -51,11 +50,6 @@ import de.dennisguse.opentracks.settings.PreferencesUtils;
  */
 public class CustomContentProvider extends ContentProvider {
 
-    // The authority (the first part of the URI) for the app's content provider.
-    static final String AUTHORITY_PACKAGE = BuildConfig.APPLICATION_ID + ".content";
-
-    // The base URI for the app's content provider.
-    public static final String CONTENT_BASE_URI = "content://" + AUTHORITY_PACKAGE;
     private static final String TAG = CustomContentProvider.class.getSimpleName();
 
     private static final String SQL_LIST_DELIMITER = ",";
@@ -102,22 +96,22 @@ public class CustomContentProvider extends ContentProvider {
 
     public CustomContentProvider() {
         uriMatcher = new UriMatcher(UriMatcher.NO_MATCH);
-        uriMatcher.addURI(AUTHORITY_PACKAGE, TrackPointsColumns.CONTENT_URI_BY_ID.getPath(), UrlType.TRACKPOINTS.ordinal());
-        uriMatcher.addURI(AUTHORITY_PACKAGE, TrackPointsColumns.CONTENT_URI_BY_ID.getPath() + "/#", UrlType.TRACKPOINTS_BY_ID.ordinal());
-        uriMatcher.addURI(AUTHORITY_PACKAGE, TrackPointsColumns.CONTENT_URI_BY_TRACKID.getPath() + "/*", UrlType.TRACKPOINTS_BY_TRACKID.ordinal());
+        uriMatcher.addURI(ContentProviderUtils.AUTHORITY_PACKAGE, TrackPointsColumns.CONTENT_URI_BY_ID.getPath(), UrlType.TRACKPOINTS.ordinal());
+        uriMatcher.addURI(ContentProviderUtils.AUTHORITY_PACKAGE, TrackPointsColumns.CONTENT_URI_BY_ID.getPath() + "/#", UrlType.TRACKPOINTS_BY_ID.ordinal());
+        uriMatcher.addURI(ContentProviderUtils.AUTHORITY_PACKAGE, TrackPointsColumns.CONTENT_URI_BY_TRACKID.getPath() + "/*", UrlType.TRACKPOINTS_BY_TRACKID.ordinal());
 
-        uriMatcher.addURI(AUTHORITY_PACKAGE, TracksColumns.CONTENT_URI.getPath(), UrlType.TRACKS.ordinal());
-        uriMatcher.addURI(AUTHORITY_PACKAGE, TracksColumns.CONTENT_URI_SENSOR_STATS.getPath() + "/#", UrlType.TRACKS_SENSOR_STATS.ordinal());
-        uriMatcher.addURI(AUTHORITY_PACKAGE, TracksColumns.CONTENT_URI_AGGREGATED_STATISTICS.getPath(), UrlType.TRACKS_AGGREGATED_STATISTICS.ordinal());
-        uriMatcher.addURI(AUTHORITY_PACKAGE, TracksColumns.CONTENT_URI.getPath() + "/*", UrlType.TRACKS_BY_ID.ordinal());
+        uriMatcher.addURI(ContentProviderUtils.AUTHORITY_PACKAGE, TracksColumns.CONTENT_URI.getPath(), UrlType.TRACKS.ordinal());
+        uriMatcher.addURI(ContentProviderUtils.AUTHORITY_PACKAGE, TracksColumns.CONTENT_URI_SENSOR_STATS.getPath() + "/#", UrlType.TRACKS_SENSOR_STATS.ordinal());
+        uriMatcher.addURI(ContentProviderUtils.AUTHORITY_PACKAGE, TracksColumns.CONTENT_URI_AGGREGATED_STATISTICS.getPath(), UrlType.TRACKS_AGGREGATED_STATISTICS.ordinal());
+        uriMatcher.addURI(ContentProviderUtils.AUTHORITY_PACKAGE, TracksColumns.CONTENT_URI.getPath() + "/*", UrlType.TRACKS_BY_ID.ordinal());
 
-        uriMatcher.addURI(AUTHORITY_PACKAGE, MarkerColumns.CONTENT_URI.getPath(), UrlType.MARKERS.ordinal());
-        uriMatcher.addURI(AUTHORITY_PACKAGE, MarkerColumns.CONTENT_URI.getPath() + "/#", UrlType.MARKERS_BY_ID.ordinal());
-        uriMatcher.addURI(AUTHORITY_PACKAGE, MarkerColumns.CONTENT_URI_BY_TRACKID.getPath() + "/*", UrlType.MARKERS_BY_TRACKID.ordinal());
+        uriMatcher.addURI(ContentProviderUtils.AUTHORITY_PACKAGE, MarkerColumns.CONTENT_URI.getPath(), UrlType.MARKERS.ordinal());
+        uriMatcher.addURI(ContentProviderUtils.AUTHORITY_PACKAGE, MarkerColumns.CONTENT_URI.getPath() + "/#", UrlType.MARKERS_BY_ID.ordinal());
+        uriMatcher.addURI(ContentProviderUtils.AUTHORITY_PACKAGE, MarkerColumns.CONTENT_URI_BY_TRACKID.getPath() + "/*", UrlType.MARKERS_BY_TRACKID.ordinal());
 
-        uriMatcher.addURI(AUTHORITY_PACKAGE, UrlType.DASHBOARD_TRACKS_BY_IDS.getPath() + "*", UrlType.DASHBOARD_TRACKS_BY_IDS.ordinal());
-        uriMatcher.addURI(AUTHORITY_PACKAGE, UrlType.DASHBOARD_TRACKPOINTS_BY_TRACKIDS.getPath() + "*", UrlType.DASHBOARD_TRACKPOINTS_BY_TRACKIDS.ordinal());
-        uriMatcher.addURI(AUTHORITY_PACKAGE, UrlType.DASHBOARD_MARKERS_BY_TRACKIDS.getPath() + "*", UrlType.DASHBOARD_MARKERS_BY_TRACKIDS.ordinal());
+        uriMatcher.addURI(ContentProviderUtils.AUTHORITY_PACKAGE, UrlType.DASHBOARD_TRACKS_BY_IDS.getPath() + "*", UrlType.DASHBOARD_TRACKS_BY_IDS.ordinal());
+        uriMatcher.addURI(ContentProviderUtils.AUTHORITY_PACKAGE, UrlType.DASHBOARD_TRACKPOINTS_BY_TRACKIDS.getPath() + "*", UrlType.DASHBOARD_TRACKPOINTS_BY_TRACKIDS.ordinal());
+        uriMatcher.addURI(ContentProviderUtils.AUTHORITY_PACKAGE, UrlType.DASHBOARD_MARKERS_BY_TRACKIDS.getPath() + "*", UrlType.DASHBOARD_MARKERS_BY_TRACKIDS.ordinal());
     }
 
     @Override
@@ -153,7 +147,7 @@ public class CustomContentProvider extends ContentProvider {
         } finally {
             db.endTransaction();
         }
-        notifyChanges(url);
+        getContext().getContentResolver().notifyChange(url, null, false);
 
         int totalChanges = getTotalChanges() - totalChangesBefore;
         Log.i(TAG, "Deleted " + totalChanges + " total rows from database");
@@ -212,8 +206,7 @@ public class CustomContentProvider extends ContentProvider {
         } finally {
             db.endTransaction();
         }
-        notifyChanges(url);
-
+        getContext().getContentResolver().notifyChange(url, null, false);
         return result;
     }
 
@@ -236,8 +229,7 @@ public class CustomContentProvider extends ContentProvider {
         } finally {
             db.endTransaction();
         }
-        notifyChanges(url);
-
+        getContext().getContentResolver().notifyChange(url, null, false);
         return numInserted;
     }
 
@@ -350,36 +342,10 @@ public class CustomContentProvider extends ContentProvider {
             }
         }
 
-        notifyChanges(url);
-
+        getContext().getContentResolver().notifyChange(url, null, false);
         return count;
     }
 
-    private void notifyChanges(@NonNull Uri uri) {
-        getContext().getContentResolver().notifyChange(uri, null, false);
-        // Also notify dashboard URIs for compatibility
-        Uri dashboardUri = getDashboardUri(uri);
-        if (dashboardUri != null) {
-            getContext().getContentResolver().notifyChange(dashboardUri, null, false);
-        }
-    }
-
-    private Uri getDashboardUri(Uri uri) {
-        String path = uri.getPath();
-        if (path == null) return null;
-        String dashboardPath;
-        if (path.startsWith("/tracks")) {
-            dashboardPath = path.replaceFirst("/tracks", "/dashboard/tracks");
-        } else if (path.startsWith("/markers")) {
-            dashboardPath = path.replaceFirst("/markers", "/dashboard/markers");
-        } else if (path.startsWith("/trackpoints")) {
-            dashboardPath = path.replaceFirst("/trackpoints", "/dashboard/trackpoints");
-        } else {
-            return null;
-        }
-        return Uri.parse(CONTENT_BASE_URI + dashboardPath);
-    }
-
     @NonNull
     private UrlType getUrlType(Uri url) {
         UrlType[] urlTypes = UrlType.values();
@@ -450,9 +416,9 @@ public class CustomContentProvider extends ContentProvider {
         @Deprecated //TODO Should not be used anymore
         MARKERS_BY_TRACKID,
 
-        DASHBOARD_TRACKS_BY_IDS(Uri.parse(CONTENT_BASE_URI + "/dashboard/tracks/"), TracksColumns.CONTENT_TYPE),
-        DASHBOARD_TRACKPOINTS_BY_TRACKIDS(Uri.parse(CONTENT_BASE_URI + "/dashboard/trackpoints/"), TrackPointsColumns.CONTENT_TYPE),
-        DASHBOARD_MARKERS_BY_TRACKIDS(Uri.parse(CONTENT_BASE_URI + "/dashboard/markers/"), MarkerColumns.CONTENT_TYPE);
+        DASHBOARD_TRACKS_BY_IDS(Uri.parse(ContentProviderUtils.CONTENT_BASE_URI + "/dashboard/tracks/"), TracksColumns.CONTENT_TYPE),
+        DASHBOARD_TRACKPOINTS_BY_TRACKIDS(Uri.parse(ContentProviderUtils.CONTENT_BASE_URI + "/dashboard/trackpoints/"), TrackPointsColumns.CONTENT_TYPE),
+        DASHBOARD_MARKERS_BY_TRACKIDS(Uri.parse(ContentProviderUtils.CONTENT_BASE_URI + "/dashboard/markers/"), MarkerColumns.CONTENT_TYPE);
 
         private final Uri uri;
 

src/main/java/de/dennisguse/opentracks/data/ShareContentProvider.java

@@ -59,12 +59,12 @@ public class ShareContentProvider extends CustomContentProvider {
     private static final String TRACKID_DELIMITER = "_";
 
     static {
-        uriMatcher.addURI(CustomContentProvider.AUTHORITY_PACKAGE, TracksColumns.TABLE_NAME + "/" + TrackFileFormat.GPX.getPreferenceId() + "/*/*", URI_GPX);
+        uriMatcher.addURI(ContentProviderUtils.AUTHORITY_PACKAGE, TracksColumns.TABLE_NAME + "/" + TrackFileFormat.GPX.getPreferenceId() + "/*/*", URI_GPX);
 
-        uriMatcher.addURI(CustomContentProvider.AUTHORITY_PACKAGE, TracksColumns.TABLE_NAME + "/" + TrackFileFormat.KML_WITH_TRACKDETAIL_AND_SENSORDATA.getPreferenceId() + "/*/*", URI_KML_WITH_TRACKDETAIL_SENSORDATA);
+        uriMatcher.addURI(ContentProviderUtils.AUTHORITY_PACKAGE, TracksColumns.TABLE_NAME + "/" + TrackFileFormat.KML_WITH_TRACKDETAIL_AND_SENSORDATA.getPreferenceId() + "/*/*", URI_KML_WITH_TRACKDETAIL_SENSORDATA);
 
-        uriMatcher.addURI(CustomContentProvider.AUTHORITY_PACKAGE, TracksColumns.TABLE_NAME + "/" + TrackFileFormat.KMZ_WITH_TRACKDETAIL_AND_SENSORDATA_AND_PICTURES.getPreferenceId() + "/*/*", URI_KMZ_WITH_TRACKDETAIL_SENSORDATA_AND_PICTURES);
-        uriMatcher.addURI(CustomContentProvider.AUTHORITY_PACKAGE, TracksColumns.TABLE_NAME + "/" + TrackFileFormat.CSV.getPreferenceId() + "/*/*", URI_CSV);
+        uriMatcher.addURI(ContentProviderUtils.AUTHORITY_PACKAGE, TracksColumns.TABLE_NAME + "/" + TrackFileFormat.KMZ_WITH_TRACKDETAIL_AND_SENSORDATA_AND_PICTURES.getPreferenceId() + "/*/*", URI_KMZ_WITH_TRACKDETAIL_SENSORDATA_AND_PICTURES);
+        uriMatcher.addURI(ContentProviderUtils.AUTHORITY_PACKAGE, TracksColumns.TABLE_NAME + "/" + TrackFileFormat.CSV.getPreferenceId() + "/*/*", URI_CSV);
     }
 
     /**

src/main/java/de/dennisguse/opentracks/data/TrackSelection.java

@@ -10,7 +10,7 @@ import java.util.List;
 import de.dennisguse.opentracks.data.models.Track;
 import de.dennisguse.opentracks.data.tables.TracksColumns;
 
-public class TrackSelection {
+public class TrackSelection implements ContentProviderUtils.ContentProviderSelectionInterface {
     private final List<Track.Id> trackIds = new ArrayList<>();
     private final List<String> categories = new ArrayList<>();
     private Instant from;
@@ -40,6 +40,7 @@ public class TrackSelection {
         return trackIds.isEmpty() && categories.isEmpty() && from == null && to == null;
     }
 
+    @Override
     public ContentProviderUtils.SelectionData buildSelection() {
         String selection = "";
         List<String> selectionArgs = new ArrayList<>();

src/main/java/de/dennisguse/opentracks/data/models/MarkerBuilder.java

@@ -28,6 +28,7 @@ import androidx.annotation.VisibleForTesting;
  * @author Leif Hendrik Wilden
  * @author Rodrigo Damazio
  */
+//TODO All data should be final; no default values.
 public final class MarkerBuilder {
 
     private Marker.Id id;
@@ -56,6 +57,14 @@ public final class MarkerBuilder {
         this.position = trackPoint.position();
     }
 
+    public MarkerBuilder(@Nullable Track.Id trackId, @NonNull TrackPoint trackPoint, String name, String description, String typeLocalized, Uri photoUrl) {
+        this(trackId, trackPoint);
+        this.name = name;
+        this.description = description;
+        this.typeLocalized = typeLocalized;
+        this.photoUrl = photoUrl;
+    }
+
     public MarkerBuilder(Marker marker) {
         this.id = marker.id();
         this.trackId = marker.trackId();

src/main/java/de/dennisguse/opentracks/data/models/TrackPoint.java

@@ -20,7 +20,6 @@ import android.os.Parcelable;
 
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
-import androidx.annotation.VisibleForTesting;
 
 import java.time.Instant;
 
@@ -64,7 +63,7 @@ public record TrackPoint(
         );
     }
 
-    @VisibleForTesting
+    @Deprecated //TOOD Private?
     public TrackPoint(Type type, Instant now) {
         this(
                 null,

src/main/java/de/dennisguse/opentracks/data/tables/MarkerColumns.java

@@ -22,7 +22,7 @@ import android.provider.BaseColumns;
 import android.widget.ArrayAdapter;
 
 import de.dennisguse.opentracks.R;
-import de.dennisguse.opentracks.data.CustomContentProvider;
+import de.dennisguse.opentracks.data.ContentProviderUtils;
 
 /**
  * Constants for markers table.
@@ -32,8 +32,8 @@ import de.dennisguse.opentracks.data.CustomContentProvider;
 public interface MarkerColumns extends BaseColumns {
 
     String TABLE_NAME = "markers";
-    Uri CONTENT_URI = Uri.parse(CustomContentProvider.CONTENT_BASE_URI + "/" + TABLE_NAME);
-    Uri CONTENT_URI_BY_TRACKID = Uri.parse(CustomContentProvider.CONTENT_BASE_URI + "/" + TABLE_NAME + "/trackid");
+    Uri CONTENT_URI = Uri.parse(ContentProviderUtils.CONTENT_BASE_URI + "/" + TABLE_NAME);
+    Uri CONTENT_URI_BY_TRACKID = Uri.parse(ContentProviderUtils.CONTENT_BASE_URI + "/" + TABLE_NAME + "/trackid");
     String CONTENT_TYPE = "vnd.android.cursor.dir/vnd.de.dennisguse.waypoint";
     String CONTENT_ITEMTYPE = "vnd.android.cursor.item/vnd.de.dennisguse.waypoint";
     String DEFAULT_SORT_ORDER = _ID;

src/main/java/de/dennisguse/opentracks/data/tables/TrackPointsColumns.java

@@ -19,7 +19,7 @@ package de.dennisguse.opentracks.data.tables;
 import android.net.Uri;
 import android.provider.BaseColumns;
 
-import de.dennisguse.opentracks.data.CustomContentProvider;
+import de.dennisguse.opentracks.data.ContentProviderUtils;
 
 /**
  * Constants for the track points table.
@@ -29,8 +29,8 @@ import de.dennisguse.opentracks.data.CustomContentProvider;
 public interface TrackPointsColumns extends BaseColumns {
 
     String TABLE_NAME = "trackpoints";
-    Uri CONTENT_URI_BY_ID = Uri.parse(CustomContentProvider.CONTENT_BASE_URI + "/" + TABLE_NAME);
-    Uri CONTENT_URI_BY_TRACKID = Uri.parse(CustomContentProvider.CONTENT_BASE_URI + "/" + TABLE_NAME + "/trackid");
+    Uri CONTENT_URI_BY_ID = Uri.parse(ContentProviderUtils.CONTENT_BASE_URI + "/" + TABLE_NAME);
+    Uri CONTENT_URI_BY_TRACKID = Uri.parse(ContentProviderUtils.CONTENT_BASE_URI + "/" + TABLE_NAME + "/trackid");
     String CONTENT_TYPE = "vnd.android.cursor.dir/vnd.de.dennisguse.trackpoint";
     String CONTENT_ITEMTYPE = "vnd.android.cursor.item/vnd.de.dennisguse.trackpoint";
     String DEFAULT_SORT_ORDER = _ID;

src/main/java/de/dennisguse/opentracks/data/tables/TracksColumns.java

@@ -19,7 +19,7 @@ package de.dennisguse.opentracks.data.tables;
 import android.net.Uri;
 import android.provider.BaseColumns;
 
-import de.dennisguse.opentracks.data.CustomContentProvider;
+import de.dennisguse.opentracks.data.ContentProviderUtils;
 
 /**
  * Constants for the tracks table.
@@ -29,9 +29,9 @@ import de.dennisguse.opentracks.data.CustomContentProvider;
 public interface TracksColumns extends BaseColumns {
 
     String TABLE_NAME = "tracks";
-    Uri CONTENT_URI = Uri.parse(CustomContentProvider.CONTENT_BASE_URI + "/" + TABLE_NAME);
-    Uri CONTENT_URI_SENSOR_STATS = Uri.parse(CustomContentProvider.CONTENT_BASE_URI + "/" + TABLE_NAME + "/sensorstats");
-    Uri CONTENT_URI_AGGREGATED_STATISTICS = Uri.parse(CustomContentProvider.CONTENT_BASE_URI + "/" + TABLE_NAME + "/aggregated/");
+    Uri CONTENT_URI = Uri.parse(ContentProviderUtils.CONTENT_BASE_URI + "/" + TABLE_NAME);
+    Uri CONTENT_URI_SENSOR_STATS = Uri.parse(ContentProviderUtils.CONTENT_BASE_URI + "/" + TABLE_NAME + "/sensorstats");
+    Uri CONTENT_URI_AGGREGATED_STATISTICS = Uri.parse(ContentProviderUtils.CONTENT_BASE_URI + "/" + TABLE_NAME + "/aggregated/");
     String CONTENT_TYPE = "vnd.android.cursor.dir/vnd.de.dennisguse.track";
     String CONTENT_ITEMTYPE = "vnd.android.cursor.item/vnd.de.dennisguse.track";
     String DEFAULT_SORT_ORDER = _ID;

src/main/java/de/dennisguse/opentracks/io/file/importer/GPXTrackImporter.java

@@ -297,17 +297,7 @@ public class GPXTrackImporter extends DefaultHandler implements XMLImporter.Trac
         }
 
         if (latitude == null || longitude == null) {
-            return new TrackPoint(
-                    null,
-                    TrackPoint.Type.TRACKPOINT,
-                    Position.of(parsedTime.toInstant()),
-                    null,
-                    null,
-                    null,
-                    null,
-                    null,
-                    null
-            );
+            return new TrackPoint(TrackPoint.Type.TRACKPOINT, parsedTime.toInstant());
         }
 
         double latitudeParsed;

src/main/java/de/dennisguse/opentracks/sensors/GpsHandler.java

@@ -110,7 +110,7 @@ public class GpsHandler extends SensorHandler<Location, Position> {
 
     @Override
     protected int getSensorPreferenceKey() {
-        return R.string.settings_sensor_gps_key;
+        return R.string.settings_sensor_bluetooth_gps_key;
     }
 
     @Override

src/main/java/de/dennisguse/opentracks/sensors/SensorManager.java

@@ -164,7 +164,7 @@ public class SensorManager implements SharedPreferences.OnSharedPreferenceChange
             cyclingDistanceSpeedHandler.connect();
         }
 
-        if (PreferencesUtils.isKey(cyclingPowerHandler.getSensorPreferenceKey(), key)) {
+        if (PreferencesUtils.isKey(cyclingCadenceHandler.getSensorPreferenceKey(), key)) {
             cyclingPowerHandler.connect();
         }
 
@@ -259,6 +259,37 @@ public class SensorManager implements SharedPreferences.OnSharedPreferenceChange
         );
     }
 
+    @VisibleForTesting
+    public void clear() {
+        Log.i(TAG, "Removing all aggregators");
+
+        //TODO This is to ExportImportTest alive; refactor test.
+        if (this.altitudeChangeHandler != null) {
+            this.altitudeChangeHandler.setAggregator(null);
+        }
+        if (this.heartRateHandler != null) {
+            this.heartRateHandler.setAggregator(null);
+        }
+        if (this.temperatureHandler != null) {
+            this.temperatureHandler.setAggregator(null);
+        }
+        if (this.cyclingCadenceHandler != null) {
+            this.cyclingCadenceHandler.setAggregator(null);
+        }
+        if (cyclingDistanceSpeedHandler != null) {
+            cyclingDistanceSpeedHandler.setAggregator(null);
+        }
+        if (cyclingPowerHandler != null) {
+            cyclingPowerHandler.setAggregator(null);
+        }
+        if (runningSpeedCadenceDistanceHandler != null) {
+            runningSpeedCadenceDistanceHandler.setAggregator(null);
+        }
+        if (this.gpsHandler != null) {
+            this.gpsHandler.setAggregator(null);
+        }
+    }
+
     private boolean isStarted() {
         return wakeLock != null;
     }

src/main/java/de/dennisguse/opentracks/sensors/driver/BarometerInternal.java

@@ -9,8 +9,6 @@ import android.util.Log;
 
 import androidx.annotation.NonNull;
 
-import java.time.Duration;
-import java.time.Instant;
 import java.util.concurrent.TimeUnit;
 
 import de.dennisguse.opentracks.data.models.AtmosphericPressure;
@@ -19,14 +17,12 @@ public class BarometerInternal implements Driver {
 
     private static final String TAG = BarometerInternal.class.getSimpleName();
 
-    private static final Duration SAMPLING_PERIOD = Duration.ofSeconds(5);
+    private static final int SAMPLING_PERIOD = (int) TimeUnit.SECONDS.toMicros(5);
 
     private final DriverObserver<AtmosphericPressure> observer;
 
     private android.hardware.SensorManager sensorService;
 
-    private Instant lastEventTime = Instant.EPOCH;
-
     private final SensorEventListener sensorEventListener = new SensorEventListener() {
         @Override
         public void onSensorChanged(SensorEvent event) {
@@ -35,13 +31,6 @@ public class BarometerInternal implements Driver {
                 return;
             }
 
-            Instant currentTime = Instant.now();
-
-            if (lastEventTime.plus(SAMPLING_PERIOD).isAfter(currentTime)) {
-                return;
-            }
-
-            lastEventTime = currentTime;
             observer.onDataReceived(AtmosphericPressure.ofHPA(event.values[0]));
         }
 
@@ -59,9 +48,8 @@ public class BarometerInternal implements Driver {
     public void connect(Context context, Handler handler, String addressIgnored) {
         sensorService = (android.hardware.SensorManager) context.getSystemService(Context.SENSOR_SERVICE);
         Sensor pressureSensor = sensorService.getDefaultSensor(Sensor.TYPE_PRESSURE);
-        int samplingPeriodUs = (int) TimeUnit.MICROSECONDS.convert(SAMPLING_PERIOD);
 
-        if (pressureSensor != null && sensorService.registerListener(sensorEventListener, pressureSensor, samplingPeriodUs, handler)) {
+        if (pressureSensor != null && sensorService.registerListener(sensorEventListener, pressureSensor, SAMPLING_PERIOD, handler)) {
             observer.onConnected(null, null);
             return;
         }

src/main/java/de/dennisguse/opentracks/sensors/driver/BoschEbikeParser.java

@@ -1,217 +0,0 @@
-package de.dennisguse.opentracks.sensors.driver;
-
-import android.util.Log;
-
-import androidx.annotation.Nullable;
-
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.List;
-import java.util.UUID;
-
-import de.dennisguse.opentracks.data.models.Cadence;
-import de.dennisguse.opentracks.data.models.Power;
-import de.dennisguse.opentracks.data.models.Speed;
-import de.dennisguse.opentracks.sensors.ServiceMeasurementUUID;
-
-// Implementation of metrics from a Bosch Smart System eBike via BLE.
-// as described and implemented here: https://github.com/RobbyPee/Bosch-Smart-System-Ebike-Garmin-Android
-//
-// The bike exposes a single custom BLE service with one notification characteristic onto
-// which all measurements are multiplexed as concatenated frames.
-//
-// ```
-// 30  <length>  <id-hi>  <id-lo>  [08  <varint...>]
-// ```
-//
-// Frame format
-//
-// - `30` : start byte
-// - `<length>` - number of payload bytes following (min 2, which means value = 0)
-// - two-byte big-endian message ID
-// - `08` : varint type tag (absent when value is 0)
-// - varint : strip MSB from each byte, 7-bit groups, little-endian concatenation
-//
-// Multiple frames may be packed into a single characteristic notification.
-//
-
-public final class BoschEbikeParser {
-
-    private static final String TAG = BoschEbikeParser.class.getSimpleName();
-
-    private static final int MESSAGE_ID_CADENCE = 0x985A;
-    private static final int MESSAGE_ID_HUMAN_POWER = 0x985B;
-    private static final int MESSAGE_ID_SPEED = 0x982D;
-    private static final int MESSAGE_ID_MOTOR_POWER = 0x985D;
-    private static final int MESSAGE_ID_BATTERY = 0x8088;
-    private static final int MESSAGE_ID_ASSIST_MODE = 0x9809;
-
-    private static final int START_BYTE = 0x30;
-    private static final int VARINT_TAG = 0x08;
-    private static final int MAX_VARINT_32_BIT_BYTES = 5;
-
-    public static final ServiceMeasurementUUID BOSCH_EBIKE = new ServiceMeasurementUUID(
-            UUID.fromString("00000010-eaa2-11e9-81b4-2a2ae2dbcce4"),
-            UUID.fromString("00000011-eaa2-11e9-81b4-2a2ae2dbcce4"));
-
-    private BoschEbikeParser() {
-    }
-
-    /**
-     * Decodes a single varint from {@code data}. Uses little-endian 7-bit groups; MSB=1 means another byte follows.
-     */
-    private static Integer decodeVarint(byte[] data) {
-        if (data == null || data.length == 0) {
-            Log.d(TAG, "Malformed varint: empty payload");
-            return null;
-        }
-
-        int result = 0;
-
-        for (int i = 0; i < data.length; i++) {
-            if (i >= MAX_VARINT_32_BIT_BYTES) {
-                Log.d(TAG, "Malformed varint: exceeds 32-bit limit after " + i + " bytes");
-                return null;
-            }
-
-            int byteValue = data[i] & 0x7F;
-            result |= byteValue << (7 * i);
-
-            if ((data[i] & 0x80) == 0) {
-                return result;
-            }
-        }
-
-        Log.d(TAG, "Malformed varint: truncated after " + data.length + " bytes");
-        return null;
-    }
-
-    /**
-     * Parses one Bosch notification payload, which may contain multiple concatenated frames, and returns the measurements recognized in that payload.
-     */
-    static Data parse(byte[] raw) {
-        if (raw == null || raw.length == 0) {
-            return null;
-        }
-
-        Data data = splitFrames(raw).stream()
-                .filter(BoschEbikeParser::isValidFrame)
-                .filter(BoschEbikeParser::isSupportedFrame)
-                .map(BoschEbikeParser::decodeFrame)
-                .filter(decodedFrame -> decodedFrame != null)
-                .reduce(null,
-                        BoschEbikeParser::processMessage,
-                        (left, right) -> right);
-        Log.d(TAG, "Parsed Bosch data: " + data);
-        return data;
-    }
-
-    private static List<byte[]> splitFrames(byte[] raw) {
-        List<byte[]> frames = new ArrayList<>();
-
-        int i = 0;
-        while (i < raw.length) {
-            if (raw[i] != START_BYTE) {
-                i++;
-                continue;
-            }
-
-            if (i + 1 >= raw.length) {
-                Log.d(TAG, "Malformed frame at offset " + i + ": missing length byte (raw length=" + raw.length + ")");
-                i++;
-                continue;
-            }
-
-            int length = raw[i + 1] & 0xFF;
-            int frameEnd = i + length + 2;
-            frames.add(Arrays.copyOfRange(raw, i, Math.min(frameEnd, raw.length)));
-            i = frameEnd;
-        }
-
-        return frames;
-    }
-
-    private static boolean isValidFrame(byte[] frame) {
-        int length = getFrameLength(frame);
-        if (length < 2) {
-            Log.d(TAG, "Malformed frame: payload length " + length + " is shorter than minimum 2 bytes");
-            return false;
-        }
-
-        if (frame.length != length + 2) {
-            Log.d(TAG, "Malformed frame: expected " + (length + 2) + " bytes, got " + frame.length);
-            return false;
-        }
-
-        return true;
-    }
-
-    private static boolean isSupportedFrame(byte[] frame) {
-        boolean supported = getFrameLength(frame) == 2 || (frame[4] & 0xFF) == VARINT_TAG;
-        if (!supported) {
-            Log.d(TAG, "Unsupported frame: tag 0x" + String.format("%02X", frame[4] & 0xFF));
-        }
-        return supported;
-    }
-
-    @Nullable
-    private static DecodedFrame decodeFrame(byte[] frame) {
-        if (getFrameLength(frame) == 2) {
-            return new DecodedFrame(getMessageId(frame), 0);
-        }
-
-        Integer varintResult = decodeVarint(Arrays.copyOfRange(frame, 5, frame.length));
-        if (varintResult == null) {
-            return null;
-        }
-
-        return new DecodedFrame(getMessageId(frame), varintResult);
-    }
-
-    private static int getFrameLength(byte[] frame) {
-        return frame[1] & 0xFF;
-    }
-
-    private static int getMessageId(byte[] frame) {
-        return (frame[2] & 0xFF) << 8 | (frame[3] & 0xFF);
-    }
-
-    /**
-     * Processes a message ID and value, updating the data with any measurements.
-     */
-    @Nullable
-    private static Data processMessage(@Nullable Data data, DecodedFrame decodedFrame) {
-        switch (decodedFrame.messageId()) {
-            case MESSAGE_ID_CADENCE:
-                return new Data(null, Cadence.of(decodedFrame.value() / 2.0f), null, data);
-            case MESSAGE_ID_HUMAN_POWER:
-                return new Data(null, null, Power.of((float) decodedFrame.value()), data);
-            case MESSAGE_ID_SPEED:
-                double speed_kmh = decodedFrame.value() / 100.0;
-                return new Data(Speed.ofKMH(speed_kmh), null, null, data);
-            case MESSAGE_ID_MOTOR_POWER:
-            case MESSAGE_ID_BATTERY:
-            case MESSAGE_ID_ASSIST_MODE:
-                Log.d(TAG, "Ignoring unimplemented message: raw=" + decodedFrame.value());
-                return data;
-        }
-        Log.d(TAG, "Ignoring unknown message: raw=" + decodedFrame.value());
-        return data;
-    }
-
-    public record Data(
-            @Nullable Speed speed,
-            @Nullable Cadence cadence,
-            @Nullable Power humanPower) {
-
-        public Data(@Nullable Speed speed, @Nullable Cadence cadence, @Nullable Power humanPower, @Nullable Data oldData) {
-            this(
-                    speed != null ? speed : oldData != null ? oldData.speed() : null,
-                    cadence != null ? cadence : oldData != null ? oldData.cadence() : null,
-                    humanPower != null ? humanPower : oldData != null ? oldData.humanPower() : null);
-        }
-    }
-
-    private record DecodedFrame(int messageId, int value) {
-    }
-}

src/main/java/de/dennisguse/opentracks/sensors/driver/CyclingPowerBluetooth.java

@@ -18,28 +18,14 @@ public class CyclingPowerBluetooth implements BluetoothDriver.BluetoothParser<Cy
             new UUID(0x2A6300001000L, 0x800000805f9b34fbL)
     );
 
-    public static final List<ServiceMeasurementUUID> SUPPORTED_SERVICES = List.of(
-            CYCLING_POWER,
-            BoschEbikeParser.BOSCH_EBIKE
-    );
-
     @Override
     public List<ServiceMeasurementUUID> getServices() {
-        return SUPPORTED_SERVICES;
+        return List.of(CYCLING_POWER);
     }
 
     @Override
     public CyclingPowerBluetooth.Data parsePayload(@NonNull ServiceMeasurementUUID serviceMeasurementUUID, String sensorName, BluetoothGattCharacteristic characteristic) {
-        if (serviceMeasurementUUID.equals(CYCLING_POWER)) {
-            return parseCyclingPower(characteristic);
-        }
-        if (serviceMeasurementUUID.equals(BoschEbikeParser.BOSCH_EBIKE)) {
-            BoschEbikeParser.Data boschData = BoschEbikeParser.parse(characteristic.getValue());
-            if (boschData != null && boschData.humanPower() != null) {
-                return new Data(boschData.humanPower(), null);
-            }
-        }
-        return null;
+        return parseCyclingPower(characteristic);
     }
 
 

src/main/java/de/dennisguse/opentracks/settings/bluetooth/BluetoothLeCyclingPowerPreference.java

@@ -4,6 +4,9 @@ import android.content.Context;
 import android.util.AttributeSet;
 
 import androidx.preference.PreferenceDialogFragmentCompat;
+
+import java.util.List;
+
 import de.dennisguse.opentracks.sensors.driver.CyclingPowerBluetooth;
 
 public class BluetoothLeCyclingPowerPreference extends BluetoothLeSensorPreference {
@@ -26,8 +29,6 @@ public class BluetoothLeCyclingPowerPreference extends BluetoothLeSensorPreferen
 
     @Override
     public PreferenceDialogFragmentCompat createInstance() {
-        return BluetoothLeSensorPreference.BluetoothLeSensorPreferenceDialog.newInstance(
-                getKey(),
-                CyclingPowerBluetooth.SUPPORTED_SERVICES);
+        return BluetoothLeSensorPreference.BluetoothLeSensorPreferenceDialog.newInstance(getKey(), List.of(CyclingPowerBluetooth.CYCLING_POWER));
     }
-}
+}

src/main/java/de/dennisguse/opentracks/settings/bluetooth/BluetoothLeGpsPreference.java

@@ -0,0 +1,41 @@
+package de.dennisguse.opentracks.settings.bluetooth;
+
+import android.content.Context;
+import android.location.LocationManager;
+import android.util.AttributeSet;
+
+import androidx.core.location.LocationManagerCompat;
+import androidx.preference.PreferenceDialogFragmentCompat;
+
+import java.util.List;
+
+import de.dennisguse.opentracks.sensors.driver.GpsInternal;
+
+public class BluetoothLeGpsPreference extends BluetoothLeSensorPreference {
+
+    public BluetoothLeGpsPreference(Context context, AttributeSet attrs, int defStyleAttr, int defStyleRes) {
+        super(context, attrs, defStyleAttr, defStyleRes);
+    }
+
+    public BluetoothLeGpsPreference(Context context, AttributeSet attrs, int defStyleAttr) {
+        super(context, attrs, defStyleAttr);
+    }
+
+    public BluetoothLeGpsPreference(Context context, AttributeSet attrs) {
+        super(context, attrs);
+    }
+
+    public BluetoothLeGpsPreference(Context context) {
+        super(context);
+    }
+
+    @Override
+    public PreferenceDialogFragmentCompat createInstance() {
+        boolean hasInternalSensor = LocationManagerCompat.hasProvider((LocationManager) getContext().getSystemService(Context.LOCATION_SERVICE), GpsInternal.LOCATION_PROVIDER);
+
+        return BluetoothLeSensorPreferenceDialog
+                .newInstance(getKey(), List.of(), hasInternalSensor);
+    }
+
+
+}

src/main/java/de/dennisguse/opentracks/settings/bluetooth/BluetoothLeSensorPreference.java

@@ -191,6 +191,26 @@ public abstract class BluetoothLeSensorPreference extends DialogPreference {
             List<ParcelUuid> serviceUUIDs = getArguments().getParcelableArrayList(ARG_BLE_SERVICE_UUIDS);
             boolean includeInternalSensor = getArguments().getBoolean(ARG_INCLUDE_INTERNAL);
 
+            BluetoothAdapter bluetoothAdapter = BluetoothUtils.getAdapter(getContext());
+            if (bluetoothAdapter == null || !bluetoothAdapter.isEnabled()) {
+                Log.w(TAG, "Bluetooth adapter is present or not enabled.");
+                Toast.makeText(getContext(), R.string.bluetooth_disabled, Toast.LENGTH_SHORT).show();
+                dismiss();
+                return;
+            }
+
+            if (bluetoothAdapter.isDiscovering()) {
+                Log.i(TAG, "Cancelling ongoing Bluetooth discovery.");
+                bluetoothAdapter.cancelDiscovery();
+            }
+
+            scanner = bluetoothAdapter.getBluetoothLeScanner();
+            if (scanner == null) {
+                Log.e(TAG, "BluetoothLeScanner is null.");
+                dismiss();
+                return;
+            }
+
             listAdapter.add(SensorType.NONE.getPreferenceValue(), getContext().getString(DEVICE_NONE_RESOURCEID));
             selectedEntryIndex = 0;
 
@@ -208,37 +228,8 @@ public abstract class BluetoothLeSensorPreference extends DialogPreference {
                 selectedEntryIndex = !includeInternalSensor ? 1 : 2;
             }
 
-            BluetoothAdapter bluetoothAdapter = BluetoothUtils.getAdapter(getContext());
-            if (bluetoothAdapter == null || !bluetoothAdapter.isEnabled()) {
-                Log.w(TAG, "Bluetooth adapter is present or not enabled. Skipping BLE scan.");
-                Toast.makeText(getContext(), R.string.bluetooth_disabled, Toast.LENGTH_SHORT).show();
-                if (!includeInternalSensor) {
-                    dismiss();
-                }
-                return;
-            }
-
-            if (bluetoothAdapter.isDiscovering()) {
-                Log.i(TAG, "Cancelling ongoing Bluetooth discovery.");
-                bluetoothAdapter.cancelDiscovery();
-            }
-
-            scanner = bluetoothAdapter.getBluetoothLeScanner();
-            if (scanner == null) {
-                Log.e(TAG, "BluetoothLeScanner is null.");
-                dismiss();
-                return;
-            }
-
-            // Pre-populate with already-bonded BLE devices so that devices that are paired but not actively advertising (e.g. Bosch eBike) are still shown. In case we dont have any cached UUIDs for a device, we just add it to the list and let the user decide
-            boolean filterEnabled = PreferencesUtils.getBluetoothFilterEnabled();
-            bluetoothAdapter.getBondedDevices().stream()
-                    .filter(bonded -> bonded.getType() == BluetoothDevice.DEVICE_TYPE_LE || bonded.getType() == BluetoothDevice.DEVICE_TYPE_DUAL)
-                    .filter(bonded -> !filterEnabled || bonded.getUuids() == null || java.util.Arrays.stream(bonded.getUuids()).anyMatch(serviceUUIDs::contains))
-                    .forEach(bonded -> listAdapter.add(bonded.getAddress(), bonded.getName()));
-
             List<ScanFilter> scanFilter = null;
-            if (filterEnabled) {
+            if (PreferencesUtils.getBluetoothFilterEnabled()) {
                 scanFilter = serviceUUIDs.stream()
                         .map(it -> new ScanFilter.Builder().setServiceUuid(it).build())
                         .toList();

src/main/java/de/dennisguse/opentracks/viewmodels/GenericStatisticsViewHolder.java

@@ -244,6 +244,22 @@ public abstract class GenericStatisticsViewHolder extends StatisticViewHolder<St
         }
     }
 
+    public static class Altitude extends GenericStatisticsViewHolder {
+
+        @Override
+        public void onChanged(UnitSystem unitSystem, RecordingData data) {
+            TrackPoint latestTrackPoint = data.latestTrackPoint();
+            Float altitude = latestTrackPoint != null && latestTrackPoint.position().hasAltitude() ? (float) latestTrackPoint.position().altitude().toM() : null;
+            String altitudeReference = latestTrackPoint != null && latestTrackPoint.position().hasAltitude() ? getContext().getString(latestTrackPoint.position().altitude().getLabelId()) : null;
+            Pair<String, String> valueAndUnit = StringUtils.getAltitudeParts(getContext(), altitude, unitSystem);
+
+            getBinding().statsValue.setText(valueAndUnit.first);
+            getBinding().statsUnit.setText(valueAndUnit.second);
+            getBinding().statsDescriptionMain.setText(R.string.stats_altitude);
+            getBinding().statsDescriptionSecondary.setText(altitudeReference);
+        }
+    }
+
     public static class Gain extends GenericStatisticsViewHolder {
 
         @Override

src/main/java/de/dennisguse/opentracks/viewmodels/Mapping.java

@@ -28,7 +28,7 @@ public class Mapping {
         m.put(context.getString(R.string.stats_custom_layout_elapsed_segment_time_key), GenericStatisticsViewHolder.ElapsedSegmentTime::new);
         m.put(context.getString(R.string.stats_custom_layout_fastest_pace_key), GenericStatisticsViewHolder.FastestPace::new);
 
-        m.put(context.getString(R.string.stats_custom_layout_altitude_key), SensorStatisticsViewHolder.Altitude::new);
+        m.put(context.getString(R.string.stats_custom_layout_altitude_key), GenericStatisticsViewHolder.Altitude::new);
         m.put(context.getString(R.string.stats_custom_layout_gain_key), GenericStatisticsViewHolder.Gain::new);
         m.put(context.getString(R.string.stats_custom_layout_loss_key), GenericStatisticsViewHolder.Loss::new);
         m.put(context.getString(R.string.stats_custom_layout_coordinates_key), GenericStatisticsViewHolder.Coordinates::new);

src/main/java/de/dennisguse/opentracks/viewmodels/SensorStatisticsViewHolder.java

@@ -5,7 +5,6 @@ import android.view.LayoutInflater;
 
 import de.dennisguse.opentracks.R;
 import de.dennisguse.opentracks.data.models.HeartRateZones;
-import de.dennisguse.opentracks.data.models.TrackPoint;
 import de.dennisguse.opentracks.databinding.StatsSensorItemBinding;
 import de.dennisguse.opentracks.sensors.sensorData.SensorDataSet;
 import de.dennisguse.opentracks.services.RecordingData;
@@ -129,20 +128,4 @@ public abstract class SensorStatisticsViewHolder extends StatisticViewHolder<Sta
             getBinding().statsDescriptionSecondary.setText(sensorName);
         }
     }
-
-    public static class Altitude extends SensorStatisticsViewHolder {
-
-        @Override
-        public void onChanged(UnitSystem unitSystem, RecordingData data) {
-            TrackPoint latestTrackPoint = data.latestTrackPoint();
-            Float altitude = latestTrackPoint != null && latestTrackPoint.position().hasAltitude() ? (float) latestTrackPoint.position().altitude().toM() : null;
-            String altitudeReference = latestTrackPoint != null && latestTrackPoint.position().hasAltitude() ? getContext().getString(latestTrackPoint.position().altitude().getLabelId()) : null;
-            Pair<String, String> valueAndUnit = StringUtils.getAltitudeParts(getContext(), altitude, unitSystem);
-
-            getBinding().statsValue.setText(valueAndUnit.first);
-            getBinding().statsUnit.setText(valueAndUnit.second);
-            getBinding().statsDescriptionMain.setText(R.string.stats_altitude);
-            getBinding().statsDescriptionSecondary.setText(altitudeReference);
-        }
-    }
 }

src/main/res/values-da/strings.xml

@@ -130,7 +130,7 @@ limitations under the License.
     <!-- Description -->
     <string name="description_activity_type">Aktivitetstype: %1$s</string>
     <string name="description_average_moving_pace_in_minute">Gennemsnitstempo i bevægelse: %1$s min./km (%2$s min./mil)</string>
-    <string name="description_average_moving_speed">Gennemsnitlig bevægelseshastighed: %1$.2f km/t (%2$.1f mil/t)</string>
+    <string name="description_average_moving_speed">Gennemsnitshastighed i bevægelse: %1$.2f km/t (%2$.1f mil/t)</string>
     <string name="description_average_pace_in_minute">Gennemsnitstempo: %1$s min./km (%2$s min./mil)</string>
     <string name="description_average_speed">Gennemsnitshastighed: %1$.2f km/t (%2$.1f mil/t)</string>
     <string name="description_altitude_gain">Stigning: %1$d m (%2$d fod)</string>
@@ -220,7 +220,7 @@ limitations under the License.
     <!-- Search -->
     <!-- Sensor State -->
     <string name="sensor_state_heart_rate">Puls</string>
-    <string name="sensor_state_heart_rate_value">%1$d slag/min.</string>
+    <string name="sensor_state_heart_rate_value">%1$d slag per minut</string>
     <string name="sensor_state_power">Effekt</string>
     <string name="sensor_could_not_scan">Kunne ikke scanne efter Bluetooth-enheder (fejl %1$i).</string>
     <string name="bluetooth_disabled">Aktivér venligst Bluetooth.</string>
@@ -544,7 +544,7 @@ limitations under the License.
     <string name="settings_announcements_idle_title">Stillestående</string>
     <string name="unit_knots">knob</string>
     <string name="settings_recording_idle_timeout_title">Tid før stilstand aktiveres</string>
-    <string name="settings_announcements_average_speed_pace">Gennemsnitshastighed/tempo</string>
+    <string name="settings_announcements_average_speed_pace">Gennemsnitlig hastighed/tempo</string>
     <string name="value_float_knots_recommended">%1$.1f knob (anbefalet)</string>
     <string name="activity_type_swimming">svømning</string>
     <string name="settings_recording_min_required_accuracy_summary">Placering ignoreres hvis nøjagtigheden er større end %1$s</string>
@@ -603,12 +603,4 @@ limitations under the License.
     <string name="settings_announcements_lap_power">Omgangseffekt</string>
     <string name="power_x_watt">Power {x, plural, =1 {1 watt} other {# watt} }</string>
     <string name="power">Effekt</string>
-    <string name="marker_detail_title">%1$d af %2$d: %3$s</string>
-    <string name="sensor_state_temperature">Termometer</string>
-    <string name="stats_sensors_temperature">Temperatur</string>
-    <string name="sensor_state_cadence_unit">o/m</string>
-    <string name="sensor_state_heart_rate_unit">slag/min.</string>
-    <string name="settings_announcements_segment_average_speed_pace">Gennemsnitshastighed/tempo (segment)</string>
-    <string name="stats_average_segment_pace">Gns. segment-tempo</string>
-    <string name="stats_elapsed_segment_time">Forløbet segmentid</string>
 </resources>

src/main/res/values-de/strings.xml

@@ -654,9 +654,4 @@ Meldet das GPS-Gerät ungenaue Daten (z.B. Standort, Geschwindigkeit, Höhe), ka
     <string name="settings_night_mode_option_day_dynamic">Tag (DynamicColor)</string>
     <string name="settings_night_mode_option_night_dynamic">Nacht (DynamicColor)</string>
     <string name="settings_night_mode_option_night_oled_dynamic">OLED-freundlich (DynamicColor)</string>
-    <string name="stats_sensors_temperature">Temperatur</string>
-    <string name="sensor_state_temperature">Thermometer</string>
-    <string name="settings_announcements_segment_average_speed_pace">Durchschnittsgeschwindigkeit/pace (Segment)</string>
-    <string name="stats_average_segment_pace">Durchschnittliche Segment Geschwindigkeit</string>
-    <string name="stats_elapsed_segment_time">Verstrichene Segment Zeit</string>
 </resources>

src/main/res/values-it/strings.xml

@@ -622,7 +622,4 @@ Infatti, un\'applicazione deve supportare <i>ACTION_VIEW</i> con MIME <i>applica
     <string name="settings_announcements_segment_average_speed_pace">Velocità/Ritmo medi (segmento)</string>
     <string name="stats_average_segment_pace">Ritmo medio nel segmento</string>
     <string name="stats_elapsed_segment_time">Tempo trascorso nel segmento</string>
-    <string name="stats_sensors_temperature">Temperatura</string>
-    <string name="description_sensor_temperature">Temperatura (Celsius)</string>
-    <string name="sensor_state_temperature">Termometro</string>
 </resources>

src/main/res/values-iw/strings.xml

@@ -254,6 +254,4 @@
     <string name="waypoint_type_waterfall">מפל</string>
     <string name="waypoint_type_water_fountain">מזרקת מים</string>
     <string name="waypoint_type_waypoint">ציון דרך</string>
-    <string name="about_preference_title">על אודות</string>
-    <string name="about_libraries">ספריות</string>
-</resources>
+</resources>

src/main/res/values-ja/strings.xml

@@ -304,13 +304,4 @@ limitations under the License.
     <string name="waypoint_type_waypoint">地点</string>
     <string name="help_feature_content">"* GPS トラックを作成します\n\n\n\n  * 心拍センサーを使用します (Bluetooth LE のみ)\n\n\n\n  * 音声アナウンス（時間または距離）\n\n\n\n  * マーカーの作成 (写真を含む)\n\n\n\n  * 完全にオフラインで動作します\n\n\n\n  * 地図上にトラックを表示します (下記を参照)"</string>
     <string name="help_data_google_play_services_content">いいえ</string>
-    <string name="about_history">OpenTracksは<a href="https://code.google.com/archive/p/mytracks/"><i>GoogleのMyTracks</i></a> (2016に開発停止)のフォークです。</string>
-    <string name="help_feature_title">OpenTracks には以下の機能があります:</string>
-    <string name="activity_type_escooter">電動スクーター</string>
-    <string name="activity_type_kickscooter">スクーター</string>
-    <string name="generic_overwrite">上書き</string>
-    <string name="generic_skip">スキップ</string>
-    <string name="import_progress_summary_ok_msg">インポート完了</string>
-    <string name="import_progress_summary_exists_msg">既に存在しています</string>
-    <string name="help_track_map_content">小さな地図のアイコンを使います.\n a) (live updates) <a href="https://codeberg.org/OpenTracksApp/OSMDashboard">OSMDashboard</a>をインストールして下さい。 <a href="https://www.openstreetmap.org">OpenStreetMap</a> を利用したオンラインまたはオフラインの地図を使用できるようになります。\n実際、OSMDashbordは (一時的に保存された) 表示するトラッキングデータにだけアクセスする独立したアプリケーションです。\n b) 一般的な地図アプリケーションを使用 (e.g., <a href="http://osmand.net/">OsmAnd</a> and <a href="https://maps.me/">MAPS.ME</a>) 。 KMZフォーマットをサポートしている必要があります (位置及びタイムスタンプのみを含む)。 加えて、 MIME <i>application/vnd.google-earth.kmz</i> の <i>ACTION_VIEW</i> をサポートしている必要もあります。</string>
-</resources>
+</resources>

src/main/res/values/do_not_translate.xml

@@ -16,7 +16,6 @@ limitations under the License.
 <resources>
     <string name="app_web_url" translatable="false">https://codeberg.org/OpenTracksApp/OpenTracks</string>
     <string name="app_name" translatable="false">OpenTracks</string>
-    <string name="launcher_name" translatable="false">OpenTracks</string>
 
     <string name="egm2008" translatable="false">EGM2008</string>
     <string name="wgs84" translatable="false">WGS84</string>

src/main/res/values/settings.xml

@@ -26,17 +26,9 @@
     <string name="settings_sensor_bluetooth_cycling_power_key" translatable="false">bluetoothCyclingPowerSensor</string>
     <string name="settings_sensor_bluetooth_running_speed_and_cadence_key" translatable="false">bluetoothRunningSpeedAndCadenceSensor</string>
     <string name="settings_sensor_bluetooth_pressure_key" translatable="false">bluetoothPressureSensor</string>
-    <string name="settings_sensor_gps_key" translatable="false">bluetoothGPSSensor</string>
+    <string name="settings_sensor_bluetooth_gps_key" translatable="false">bluetoothGPSSensor</string>
     <string name="sensor_type_value_none" translatable="false">NONE</string>
     <string name="sensor_type_value_internal" translatable="false">INTERNAL</string>
-    <string-array name="sensor_type_no_bluetooth_entryValues">
-        <item>@string/sensor_type_value_none</item>
-        <item>@string/sensor_type_value_internal</item>
-    </string-array>
-    <string-array name="sensor_type_no_bluetooth_entries">
-        <item>@string/value_none</item>
-        <item>@string/value_internal_sensor</item>
-    </string-array>
 
     <string name="settings_sensor_bluetooth_cycling_speed_wheel_circumference_key" translatable="false">bluetoothCyclingSpeedWheelCircumference</string>
     <string name="settings_sensor_bluetooth_cycling_speed_wheel_circumference_default" translatable="false">2135</string>

src/main/res/xml/settings_sensors.xml

@@ -5,13 +5,10 @@
     android:title="@string/settings_sensors_title">
 
     <PreferenceCategory android:title="@string/settings_gps_sensor">
-        <ListPreference
+        <de.dennisguse.opentracks.settings.bluetooth.BluetoothLeGpsPreference
             android:defaultValue="@string/sensor_type_value_internal"
-            android:entryValues="@array/sensor_type_no_bluetooth_entryValues"
-            android:entries="@array/sensor_type_no_bluetooth_entries"
-            android:key="@string/settings_sensor_gps_key"
-            android:title="@string/settings_gps_sensor"
-            app:useSimpleSummaryProvider="true" />
+            android:key="@string/settings_sensor_bluetooth_gps_key"
+            android:title="@string/settings_gps_sensor" />
         <ListPreference
             android:defaultValue="@string/min_sampling_interval_default"
             android:entryValues="@array/min_sampling_interval_values"

src/nightly/res/values/strings.xml

@@ -1,4 +1,4 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
-    <string name="launcher_name" translatable="false">OpenTracks (Nightly)</string>
+    <string name="app_name" translatable="false">OpenTracks (Nightly)</string>
 </resources>